github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-10-17 21:05:04 -04:00
Code Issues Projects Releases Packages Wiki Activity
22922 commits 3 branches 7 tags 201 MiB
Commit graph

233 commits

Author SHA1 Message Date
David
4b708613b6 Merge pull request #19381 from overleaf/dp--review-panel-css-clean-up 
Clean up some old review panel css

GitOrigin-RevId: eb88bfbfa6679787d06f6c2a7d28b9fafb846195
 2024-07-15 09:32:50 +00:00
David
0c7a32b4f2 Merge pull request #19346 from overleaf/dp-review-panel-empty-state 
Add empty state to review panel

GitOrigin-RevId: 47d7b676e9868942567fc02db234b0827ac86ba3
 2024-07-15 09:04:27 +00:00
roo hutton
bf90932f40 Merge pull request #18936 from overleaf/rh-viewer-no-comment 
[web] Remove access to commenting/chat for collaborators with Viewer permission

GitOrigin-RevId: 03957cb8c04866318a4b94bdb72843e7d7a5a003
 2024-06-26 08:04:38 +00:00
Mathias Jakobsen
23a7e19e8e Merge pull request #18991 from overleaf/mj-table-generator-promotion-teardown 
[web] Tear down table generator promotion

GitOrigin-RevId: 361215bdd792042ae68762fa20ae60286db5bab3
 2024-06-24 12:05:18 +00:00
David
c342dc70a5 Merge pull request #18927 from overleaf/dp-remove-grammarly-promo 
Remove Grammarly advert

GitOrigin-RevId: 6652cfafc47f8a42efc9acc1745a50e4ab8cc208
 2024-06-19 08:04:46 +00:00
David
7722c44414 Merge pull request #18918 from overleaf/dp-swap-search-arrows 
Swap order of next/previous arrows in editor search

GitOrigin-RevId: 2c402e177fcd679ebff8e96812faf09d493e9726
 2024-06-19 08:04:26 +00:00
Jakob Ackermann
aa480a2663 Merge pull request #18898 from overleaf/jpa-no-window 
[web] migrate from window attributes to getMeta

GitOrigin-RevId: 3dcf1ab6b01155e5e4abeb3e78d0fa9053e055bc
 2024-06-19 08:04:21 +00:00
Alf Eaton
c24ace801b Remove Angular (#17534) 
GitOrigin-RevId: 7a0d45e17d9905fa75569e2d19ca59caa4a41565
 2024-06-06 08:04:09 +00:00
Jimmy Domagala-Tang
81903bb79d Merge pull request #18175 from overleaf/jdt-new-bib-file-prompt 
[Web] Add opportunistic prompts for third party references

GitOrigin-RevId: d794df16781d0db707423f23ab12f40a13604907
 2024-05-27 10:23:41 +00:00
Alf Eaton
e7827fbd57 Validate URL protocol before opening from Visual Editor tooltip (#18393) 
GitOrigin-RevId: 1da255d3e8ccd91e8c8774d140ec663906be948f
 2024-05-21 08:04:26 +00:00
Alf Eaton
c1c098e2f9 Allow files to be dragged from the file tree into the editor (#15028) 
GitOrigin-RevId: f926666c032d1398a0e3f72a298116a3c7a9cd75
 2024-05-09 08:04:46 +00:00
Jimmy Domagala-Tang
72b53fe8db Merge pull request #18173 from overleaf/jdt-container-utils 
[Web] Add container based hide utils to our util css

GitOrigin-RevId: 193abf1242ec4a816299fabf486754b3bcbae147
 2024-05-08 08:03:51 +00:00
Antoine Clausse
2f99e3ccf1 Add autoComplete="off" to React-controlled checkboxes (#18212) 
Fixes https://github.com/overleaf/internal/issues/18144

Browsers use a [bfcache](https://web.dev/articles/bfcache) (Back/forward cache) which restores form data on navigation. Unfortunately, it causes checkbox appearances not to respect our React states.

Setting `autoComplete="off"` on checkboxes mitigates this problem. (From https://stackoverflow.com/questions/299811/why-does-the-checkbox-stay-checked-when-reloading-the-page)

Another solution could be to set a `Cache-Control: no-store` header, but this might additionnal undesired consequences.

GitOrigin-RevId: 7d3cceb1c818ad70de7e806ea6d714ffc8bffb4a
 2024-05-06 08:04:39 +00:00
David
0c20c86878 Merge pull request #18178 from overleaf/dp-insert-figure-translations 
Add translations for insert figure dropdown

GitOrigin-RevId: 6ffbf0229f7ac222619271688517bc50339c10f6
 2024-05-06 08:04:16 +00:00
Antoine Clausse
6a6f155029 [web] Use React hooks to get split-test variants instead of getSplitTestVariant (getMeta) (#18133) 
* Fix split-tests loading in React component: use `useSplitTestContext` instead of `getSplitTestVariant`

* Replace use of `isSplitTestEnabled` by `useSplitTestContext`

* Add SplitTestProvider to roots, and fix tests

* Create `useFeatureFlag` hook

* Use `useFeatureFlag` where applicable

GitOrigin-RevId: 9ff7bb3975d50bc4d07d74d93c482d56dc96f615
 2024-05-01 08:04:55 +00:00
Alf Eaton
9d4340e24a Reapply "Avoid vertical border between editor switch and empty space (#18029)" (#18072) 
This reverts commit 9a071e1d02f27bbcaf1d61a9cca577cc6c889abc.

GitOrigin-RevId: 72380a15ccbc4e8d7fddcfdf0a9a48209152b8b9
 2024-04-24 08:04:22 +00:00
Jimmy Domagala-Tang
e1ec856650 Merge pull request #18066 from overleaf/ae-revert-toolbar 
Revert "Avoid vertical border between editor switch and empty space"

GitOrigin-RevId: eda4deba8eb384cddf2ea9c90edee080ceb6330c
 2024-04-23 08:05:45 +00:00
Alf Eaton
92d6966f69 Only display bulk actions for tracked changes when permitted (#18038) 
GitOrigin-RevId: a2f4df9c26866aab3eea62c92ce6e1a211e08294
 2024-04-23 08:05:31 +00:00
Alf Eaton
315b511666 Avoid vertical border between editor switch and empty space (#18029) 
GitOrigin-RevId: 516098061a4d329daf55bb42bcf47a5a412595c1
 2024-04-23 08:05:26 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540) 
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
 2024-04-10 08:04:08 +00:00
Andrew Rumble
9fda813e20 Merge pull request #17786 from overleaf/ar-select-caption-in-inserted-figures 
Select caption text when new figure inserted

GitOrigin-RevId: 443594ff03c5a5cd316623e60b231a6af4390d3c
 2024-04-09 08:04:36 +00:00
Miguel Serrano
d7d63e0f51 Merge pull request #17693 from overleaf/msm-hide-grammarly-sp 
Prevent grammarly ad from rendering in CE/SP

GitOrigin-RevId: 3ef191f282f2ce682236710df9ca32a087271c4c
 2024-04-09 08:03:59 +00:00
Antoine Clausse
92a58c8f3b [web] Paywall CTA split-test (#17555) 
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
 2024-04-03 08:04:16 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier 
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
 2024-03-26 09:04:05 +00:00
Alf Eaton
aeb20340c8 Reduce review panel calls to Trans (#17385) 
GitOrigin-RevId: fdc7b3c2cd2506c810a785462fcd120a3a05da78
 2024-03-07 16:30:36 +00:00
Alf Eaton
5df35093ea Remove hidden comment button from editor toolbar (#17386) 
GitOrigin-RevId: 61b3725a7b2112c6e5abca0349b1be910e97266a
 2024-03-07 16:30:28 +00:00
Alf Eaton
749660e168 Refactor review panel context (#17383) 
GitOrigin-RevId: 23e7ff8632172ebd0bc544a2297d1d4179010832
 2024-03-07 16:30:25 +00:00
Miguel Serrano
ac48d81987 Merge pull request #17373 from overleaf/jpa-figure-modal-options 
[web] hide figure modal import options as configured server side

GitOrigin-RevId: f8907a33d413fcac238b00328eaba14d64f2f31b
 2024-03-06 17:27:32 +00:00
roo hutton
790fc5513b Merge pull request #17392 from overleaf/rh-friendly-readonly 
Don't show 'add comment' button if isRestrictedTokenMember

GitOrigin-RevId: da236a4f2fbe0e66a7e5999bd70f7145fd60df20
 2024-03-06 09:03:13 +00:00
Tim Down
3a88a60e23 Merge pull request #16700 from overleaf/td-scroll-comment-input-into-view 
Scroll comment textarea into view after autofocus

GitOrigin-RevId: c8542f40d25772a14e7511702c0e47b7001be275
 2024-02-05 09:04:21 +00:00
Alf Eaton
0cde5be165 Merge pull request #14709 from overleaf/ae-context-typescript 
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
 2024-01-29 09:03:04 +00:00
ilkin-overleaf
fa314fe5b0 Merge pull request #16509 from overleaf/ii-rp-update-entry-positions 
[web] Review panel entry positions and long user names

GitOrigin-RevId: 3a596bd90bab2c87b2efae5eb812ffc5e5a1580f
 2024-01-19 09:05:28 +00:00
Alf Eaton
612c7c28b0 Merge pull request #16511 from overleaf/ae-upgrade-uppy 
Upgrade Uppy to v3

GitOrigin-RevId: ca3e366a20ac651a98aafe12bf319b1968ac6ec1
 2024-01-19 09:05:05 +00:00
Alf Eaton
22b5828b3d Move Writefull toolbar loading/initialisation into a React component (#16546) 
GitOrigin-RevId: 1cb6efa7cab2babb33800fef9469fca3addbdaf5
 2024-01-19 09:04:52 +00:00
Mathias Jakobsen
7c3c3047fe Merge pull request #16588 from overleaf/mj-usepackage-fix 
[web] Copy single backslash in column width modal

GitOrigin-RevId: ee3e3eadac067dac1d955adc04709e8ab3121a59
 2024-01-19 09:04:37 +00:00
Mathias Jakobsen
8d7fbf5a47 Merge pull request #16522 from overleaf/mj-table-generator-cypress-tests 
[web] Add cypress tests for table generator

GitOrigin-RevId: c77454763cfc83e4869e75ba247369e6255a0553
 2024-01-19 09:04:33 +00:00
Mathias Jakobsen
80a6424343 Merge pull request #16048 from overleaf/mj-table-column-width 
[visual] Allow setting column widths in table generator

GitOrigin-RevId: 3bd4bb05dd3b29d0bd62fbc41da45eda282fecf4
 2024-01-19 09:04:28 +00:00
Thomas
e1c58c2aaf Merge pull request #15710 from overleaf/tm-no-constant-binary-expressions 
Add no-constant-binary-expression, fix existing expressions that have no effect

GitOrigin-RevId: 6691e87181331ecbb5dabfda0be89839a0a4884b
 2024-01-16 09:04:09 +00:00
David
a2da947a1f Merge pull request #16437 from overleaf/dp-remove-visual-editor-feedback-icon 
Remove visual editor feedback badge

GitOrigin-RevId: c84cc7b6630642853848fad46695bff6ae2a990a
 2024-01-12 09:03:19 +00:00
Alf Eaton
fc8892e4fb Expose ScopeValueStore via window.overleaf.unstable.store (#16404) 
GitOrigin-RevId: 4b251639296405c0a9487f063e8b049687860004
 2024-01-09 09:03:46 +00:00
Jimmy Domagala-Tang
3617196760 Merge pull request #16419 from overleaf/jdt-fix-grammarly-offer-link 
fix the grammarly offer id

GitOrigin-RevId: 996501ebb50b64bd8f9bd46305ba47baa37fee88
 2024-01-08 09:05:45 +00:00
Jimmy Domagala-Tang
5f38a930a5 Merge pull request #16319 from overleaf/jdt-grammarly-ad-redesign 
Grammarly Ad redesign

GitOrigin-RevId: 28d0ae871b6303b31aadb59abc80b625d529cc9b
 2024-01-08 09:05:40 +00:00
Alf Eaton
cf0e260a36 Recalculate toolbar overflow when buttons change (#16350) 
GitOrigin-RevId: 70ab356172bc57630b6032a6400fb08e8fd33464
 2024-01-08 09:05:17 +00:00
Alf Eaton
84898dca5d Remove margin from table grid popover (#16337) 
Co-authored-by: Mathias Jakobsen <mathias.jakobsen@overleaf.com>
GitOrigin-RevId: 71673d7d9a18baf44027e82cc34058e3db052591
 2024-01-08 09:05:12 +00:00
Jimmy Domagala-Tang
21dd23d0e4 Merge pull request #16318 from overleaf/jdt-fix-multiple-popups 
Show only one editor notification at a time

GitOrigin-RevId: 88a0309da121e9545136cd718ed24710a9d25363
 2024-01-04 09:03:40 +00:00
Alf Eaton
4f5ca6624e Move responsibility for parsing and validating table data out of the tabular widget (#15152) 
GitOrigin-RevId: bba823ca036501a527f08746cffb155641d3becf
 2024-01-04 09:03:29 +00:00
Alf Eaton
dc962832f0 Ensure that only one toolbar dropdown is open at a time (#16344) 
GitOrigin-RevId: db06091ec35886f38de2a320eba9126b35d33064
 2024-01-04 09:03:17 +00:00
ilkin-overleaf
20485b886f Merge pull request #16278 from overleaf/ii-ide-page-prototype-review-panel-entry-hover 
[web] Remove entry hover from review panel

GitOrigin-RevId: 6bcfb28e20d7a8826301c34499340b6a7d2745db
 2024-01-04 09:03:14 +00:00
Jimmy Domagala-Tang
0ac514f81b Merge pull request #16293 from overleaf/jdt-grammarly-perm-advert 
Grammarly Permanent Collaboration

GitOrigin-RevId: 0ef47cb7dcb4b175c4d5f3a3c2dbe2e6590a69de
 2023-12-18 09:05:12 +00:00
ilkin-overleaf
fbed0cb943 Merge pull request #16268 from overleaf/ii-ide-page-prototype-review-panel-layout-to-left 
[web] Review panel popovers

GitOrigin-RevId: 4424abab97b197013063679bd8efcac001f458ad
 2023-12-18 09:04:18 +00:00