Commit graph

23764 commits

Author SHA1 Message Date
Alf Eaton
5c8daedf72 Increase the timeout for spell-check tests (#21385)
GitOrigin-RevId: 31013f9663a0464cfd22f32164e22f8d45e4c0d9
2024-10-28 09:04:46 +00:00
CloudBuild
f822161b14 auto update translation
GitOrigin-RevId: cc87ce010583724e100b4f64d70598119dc6ce43
2024-10-25 08:07:03 +00:00
M Fahru
6c83f85d5d Merge pull request #21232 from overleaf/mf-remove-use-advanced-search
[web] Remove advance gallery search

GitOrigin-RevId: af39f63ac0483fe2540ba737f0239d0b503f87fe
2024-10-25 08:06:58 +00:00
Jessica Lawshe
5182e9a883 Merge pull request #21337 from overleaf/as-gallery-badge-underline
Remove underline on hover on gallery badges

GitOrigin-RevId: c83dc2f9e29650d11686a5e15b289391dc032e56
2024-10-25 08:06:50 +00:00
Jessica Lawshe
775ab9a8d1 Merge pull request #21352 from overleaf/as-gallery-tags-min-height
Set a minimum height on expanded tags container

GitOrigin-RevId: f8f537815a3b9b3e641b5e9d359964efa88f7808
2024-10-25 08:06:46 +00:00
Jessica Lawshe
4eef05a980 Merge pull request #21291 from overleaf/mf-change-caption-description-html-element
[web] Change gallery caption-description html element from div to p

GitOrigin-RevId: e9d5b699c0ada270a775223126d8c90cdc5992af
2024-10-25 08:06:41 +00:00
Jessica Lawshe
81663a1531 Merge pull request #21313 from overleaf/mf-spacing-featured-section
[web] Add correct spacing between popular-tags section, recent-docs section, and featured-docs section

GitOrigin-RevId: c04d2b09d85ac383efd8b3da2c53d5bd86a069f7
2024-10-25 08:06:37 +00:00
Jessica Lawshe
7a7533f794 Merge pull request #21116 from overleaf/mf-new-gallery-search-result-mobile
[web] Adjust search result styling for smaller screen width

GitOrigin-RevId: 6a16b0ca05358c6c83cc626c6103a6bffc98c33f
2024-10-25 08:06:32 +00:00
Jessica Lawshe
fd778822f9 Merge pull request #21364 from overleaf/jel-gallery-list-img
[web] Remove image container on gallery items

GitOrigin-RevId: 2cd310df1ed99cc559286a5d8d9405eed2c440c3
2024-10-25 08:06:28 +00:00
Jessica Lawshe
0e607a95ee Merge pull request #21338 from overleaf/jel-image-drop-shadow-gallery
[web] Use larger drop shadow on gallery images

GitOrigin-RevId: 3a8a94def86cd1f77785326becb32d21a0804c0c
2024-10-25 08:06:23 +00:00
Liangjun Song
8293771f58 Merge pull request #21290 from overleaf/ls-scripts-to-esm-translations
Migrate scripts/translation to esm

GitOrigin-RevId: 475ec949f0ba238791df91de109169584e68c701
2024-10-25 08:06:12 +00:00
Jakob Ackermann
52edad6f12 Merge pull request #21322 from overleaf/jpa-skip-converted-cleanup
[filestore] remove unnecessary cleanup of converted files

GitOrigin-RevId: a46aaee473938209dc56d9fea90f96d09952ce47
2024-10-25 08:06:07 +00:00
Jakob Ackermann
29381cf054 Merge pull request #21321 from overleaf/jpa-reconfigure-filestore
[filestore] refactor acceptance tests

GitOrigin-RevId: a6bb1527220b1c062d980c79d2ccb62973b99d2c
2024-10-25 08:06:02 +00:00
Jakob Ackermann
d1d65e65ad Merge pull request #21320 from overleaf/jpa-filestore-controller
[filestore] only call handler from controller

GitOrigin-RevId: 1d1bbe4e961b300a919ae79e3c760322304783bc
2024-10-25 08:05:57 +00:00
Jakob Ackermann
e56e5442fd Merge pull request #21295 from overleaf/jpa-fix-filestore-tests
[filestore] fix conditional tests following sharing changes

GitOrigin-RevId: 7d804acb14942fb6d06ee38f782fc78796e9182e
2024-10-25 08:05:53 +00:00
Liangjun Song
14cd8f5479 Merge pull request #21282 from overleaf/ls-scripts-to-esm-5
Migrate rest of the scripts to esm

GitOrigin-RevId: 421f3ccd15342d34113be8d22e343d08533177ea
2024-10-25 08:05:41 +00:00
Liangjun Song
e3b93f0a22 Merge pull request #21284 from overleaf/ls-scripts-to-esm-6
Migrate scripts/ukamf to esm

GitOrigin-RevId: e7318d9fb112304153912303649fc597ef7a19db
2024-10-25 08:05:37 +00:00
Tim Down
30eb5416f3 Merge pull request #21353 from overleaf/td-search-panel-focus
Pass main-field attribute through to form control in BS3

GitOrigin-RevId: 58ac2f4a18e098b35e4d4b14aa18eb013e4898e4
2024-10-25 08:05:32 +00:00
ilkin-overleaf
ed8fc2747a Merge pull request #21281 from overleaf/ii-bs5-toolbar-items-border-radius
[web] BS5 toolbar buttons border radius

GitOrigin-RevId: b07a7bb16ab7a933dfa714a128f88f2ee006cf04
2024-10-25 08:05:27 +00:00
Mathias Jakobsen
4bc5a0f1d9 Merge pull request #21319 from overleaf/mj-select-controlled-null
[web] Allow Select to be controlled with no selection

GitOrigin-RevId: 15e5b643e30205124f8e807379ab7e540e2145d1
2024-10-25 08:05:23 +00:00
Tim Down
792c9774a5 Merge pull request #21347 from overleaf/td-document-diff-viewer-full-width
Make document diff viewer always take up the full width of its container

GitOrigin-RevId: cdb593700c403564bdf297ea838b279e7e73bba2
2024-10-25 08:05:18 +00:00
Alf Eaton
4bbde479a5 Avoid creating duplicate spell check marks on the edited line (#21331)
GitOrigin-RevId: 12726b47450be23f5a412a4c50cc2420af6f425f
2024-10-25 08:05:10 +00:00
Alf Eaton
5ec52e2e5b Avoid calling destroy on the PDF.js loading task (#21277)
GitOrigin-RevId: b315e78ff739d301583f2139109f3244abceade8
2024-10-25 08:05:05 +00:00
CloudBuild
aa0fe5aeb3 auto update translation
GitOrigin-RevId: b8104bbfa04a27dd76db1b15d3e479807dc528a2
2024-10-24 08:06:38 +00:00
Jessica Lawshe
19e6ba98f0 Merge pull request #21228 from overleaf/as-gallery-related-tags
[web] Update gallery related tags styling and introduce Show More behaviour

GitOrigin-RevId: 7caef881c9a6f70437486e2bb080135d84f6742f
2024-10-24 08:06:34 +00:00
Eric Mc Sween
13ecddaef1 Merge pull request #20898 from overleaf/em-ai-add-on-setup-recurly
Script for setting up the Assistant add-on in Recurly

GitOrigin-RevId: 25a94961e4068456795b6be6b5e047efc65363fa
2024-10-24 08:06:29 +00:00
M Fahru
60cf8885b0 Merge pull request #21312 from overleaf/mf-gallery-search-author
[web] Add author of the template in search result on gallery redesign

GitOrigin-RevId: 6c5dfc039a31a22650f36bd264f0cb7133238ca2
2024-10-24 08:06:25 +00:00
M Fahru
9a142dd5ec Merge pull request #21306 from overleaf/mf-limit-gallery-summary-max-width-to-tagged-page
[web] Limit 828px max-width on gallery-summary to tagged pages only

GitOrigin-RevId: 48a0e342d403eff34cf47e71208b13af6e3f1cbd
2024-10-24 08:06:20 +00:00
M Fahru
b12236576b Merge pull request #21286 from overleaf/mf-fix-layout-search-margin-top
[web] Remove margin-top on template gallery page without search

GitOrigin-RevId: 91335298b15f403e268f8e506ff373345922188b
2024-10-24 08:06:16 +00:00
Jessica Lawshe
4a10779064 Merge pull request #21311 from overleaf/jel-gallery-images
[web] Fix gallery placeholder not expanding full width while images download

GitOrigin-RevId: 5a943799d87bff967bd635b4dc98158d44569d9c
2024-10-24 08:06:12 +00:00
Jessica Lawshe
91d011e1f2 Merge pull request #21308 from overleaf/jel-back-links
[web] Use standard black link CSS for back links

GitOrigin-RevId: 7b26a9a4635ecbd722920407cd8cf900fc394172
2024-10-24 08:06:07 +00:00
Jessica Lawshe
74a475322e Merge pull request #21273 from overleaf/jel-tag-names
[web] Update popular tag names on dash to reflect new names

GitOrigin-RevId: 76e40103102934c260bca3728af66f28bfcba568
2024-10-24 08:06:03 +00:00
Tim Down
1b2385dfce Merge pull request #21259 from overleaf/td-bs5-editor-search
[BS5] Migrate Editor search panel

GitOrigin-RevId: 37605845d4efc27d6c0c3a11de12387e8e3262f4
2024-10-24 08:05:58 +00:00
ilkin-overleaf
2646fefce4 Merge pull request #21289 from overleaf/ii-bs5-figure-modal-improvements
[web] BS5 fix form text colour

GitOrigin-RevId: 8ff03f41cc3490eff0ea4c65a376ac572003fb9c
2024-10-24 08:05:54 +00:00
ilkin-overleaf
5791563ef0 Merge pull request #21263 from overleaf/ii-bs5-code-color
[web] Fix code tag colour in BS5

GitOrigin-RevId: 694640f33c8a614f470887f16f40f236cc7f9104
2024-10-24 08:05:50 +00:00
ilkin-overleaf
7f35ec9b6a Merge pull request #21260 from overleaf/ii-share-modal-role-dropdown
[web] BS5 share modal role dropdown click

GitOrigin-RevId: bb235564a42e737b0fafb4b6b3f47816440a5402
2024-10-24 08:05:45 +00:00
ilkin-overleaf
5c3d9117c5 Merge pull request #21240 from overleaf/ii-bs5-review-panel-old
[web] BS5 review panel old

GitOrigin-RevId: da018b8f2946afb21ab63da0003453e20781f04c
2024-10-24 08:05:41 +00:00
Davinder Singh
92a23b7e9d Gallery redesign - Making the changes on tagged page to match figma design (#21256)
* Adding max width for gallery-summary

* changin card background color

* removing row from within the card

* matching the padding of gray card with figma design

* removing row and spaced row to avoid extra padding and adding doc-rows-container

* adding grid for templates and removing some old styling

* adding .recent-templates-container to add the padding and margins

* deleting a comment and adding img border radius for the thumbnail

* adding margin-bottom on recent-templates-container

* adding .gallery-tagged-title-container to match the figma padding and then a fix was needed for the width of the filters

* renaming gallery-tagged-title-container to gallery-tagged-container-spacing and re-using it for Related tags container

* making recent heading as heading-xl to match figma

* adding badge styling and its container styling via .gallery-tagged-template-tags-container

* making two classes out of this class .gallery-tagged-container-spacing to add the styling for the h2 heading

* adding margin-bottom to match figma style

* making class generic and using it at multiple places

* removing some extra code

* removing grid styling because after rebase the layout was fixed with col classes

* adding rows back

* adding h2 instead of h3 and making them heading-xl

* adapting some changes after merge conflicts

* removing duplicate classname after rebase

GitOrigin-RevId: d02a0b1e2784fd96d2af2326700829879dacc464
2024-10-24 08:05:26 +00:00
Davinder Singh
11cb7dc24c Gallery redesign - Gallery item page redesign (#21034)
* adding .gallery at top level

* adding styling for heading and buttons

* removing padding under cta-links

* removing find more templates text

* adding field title styling

* adding .details-container for spacing between the content

* adding a colon after field-title

* moving tags styling into badge.scss file to make it more generic to use

* moving section tag one level below to use it as a flex containe for adding gap property

* adding field-description class

* fixing the image width

* adding some padding between the content

* renaming  a file to a more descriptive name

* adding .gallery-abstract class in the scss file

* adding colons in pug file

* adding previous-page-link and its container class

* moving paddings to larger screens only and adding a top margin for mobile screens]

* adding some spacing above tags on mobile view when heading and tags are vertically aligned

* adding styling to the badge and removing extra padding from h1 to match figma

* lint:fix

* swapping position of top-pick and official badges

* adding path and itemPlural

* removing unused top margin

GitOrigin-RevId: a5c9b731b69ecfe2b752015c410e10a0fec2c704
2024-10-24 08:05:21 +00:00
David
d74981775c Merge pull request #21283 from overleaf/dp-keyboard-shortcuts
Add missing keyboard shortcuts to new review panel

GitOrigin-RevId: 78e3a63284b62c90e8a3803bd81fdf273f1a2ec9
2024-10-24 08:05:17 +00:00
David
c872d97295 Merge pull request #21250 from overleaf/dp-resolved-comments-ui
UI tweaks for resolved comments menu

GitOrigin-RevId: 23df6f9f0374277c315d2fb9c9940dd92ec19f4e
2024-10-24 08:05:12 +00:00
David
1c5f5950fa Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
Add options to accept/reject all changes to review tooltip

GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
Domagoj Kriskovic
c4b23b4d39 Add "usingNewReviewPanel" flag in store (#21279)
* Revert "Add isUsingNewReviewPanel flag for writefull (#21111)"

This reverts commit 3491e93ca70fa1db0c751872e233dfebdbe81423.

* add usingNewReviewPanel in store

* fix lint error

GitOrigin-RevId: 56d90a428a2cc45708b8b483dc60a62aae233a85
2024-10-24 08:05:03 +00:00
Antoine Clausse
b2e7477467 [web] Migrate AI Error Assistant to BS5 (#21129)
* [storybook] Rerender story when switching BS3/BS5

* [storybook] Add SCSS loader to storybook

* [storybook] Add some AI error assistant stories

* Rename ai-error-assistant.less to .scss

* Update less variables to sass

* Remove duplicated selector

* Replace react-bootstrap components by `OL...`

* Update Checkboxes after BS5 update

* Add IDs so clicking on labels work
* Add BS5 class name in SCSS

Note: `answer-not-detailed` is used twice in the Radios. I think it's a mistake: there should be another name for the "ai_feedback_the_suggestion_wasnt_the_best_fix_available" radio

* Rename ID `answer-not-detailed` -> `answer-not-best-fix`

* Pass name and value to BS3Radio/BS3Checkbox

* [storybook] Add delay before AI suggestion (shows the animation)

* Add a number after the checkbox/radio IDs, to allow multiple forms to be displayed

Without this, clicks on second form are updating the first form!

Another solution could be to wrap the input in the label, but it comes with other problems. See https://css-tricks.com/html-inputs-and-labels-a-love-story/

* [storybook] Update `LabsAiPromoBanner`

* Use CSS variables instead of hardcoded values

* Make radio input flex

* Replace `blue-10` by `bg-info-03`

* Fix `SuggestFixButton`

* Fix `AiErrorAssistantCopyCode`

* Fix button loading in BS5

* Use OLBadge

* Fix Button variants

* Update `suggestFixAction`

* Migrate Tooltip and Button to BS5 in LabsExperimentWidget

* Update BS3/BS5 button classname in AiErrorAssistantCopyCode

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [storybook] Allow to choose props of `LabsExperimentWidget`

* Fixup `OLTooltip`: Display the tooltip on disabled button in BS5

* Update Tooltips to BS5

---------

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 08d594e772c0a3b6db1c6081337cc2d079f478a5
2024-10-23 08:06:36 +00:00
Antoine Clausse
30860ae9f9 [web] Migrate PDF Logs to BS5 (#21062)
* [web] Migrate Logs components JSX to Bootstrap 5

* [web] Migrate logs.less to logs.scss

* [web] Remove unused class names

* [storybook] Define default Bootstrap version in Storybook

This prevents some warning in the console

* [storybook] Update pdf-preview.stories.jsx

* [storybook] Add pdf-log-entry.stories.tsx

* [storybook] Force re-renders when switching BS version

* [web] Keep files dropdown menu in bounds

* [web] Make files dropdown items not bold in BS5

* [web] Revert unrelated change

* [web] Fixup PreviewLogsPaneMaxEntries

* [web] Add style for log-entry-content-link

* [web] Replace log-entry by OLNotification in `PdfCodeCheckFailedNotice`

* [web] Use `BootstrapVersionSwitcher` instead of `isBootstrap5`

* [web] Rename `DropdownBS3` to `BS3Dropdown`

* [web] Reuse variables for `toolbar-height` and `toolbar-small-height`

* [web] Set `id` on `DropdownToggle` not `Dropdown`

* [web] Set `log-entry-btn-expand-collapse` in BS3 only

* [web] Remove `block: true` from StartFreeTrialButton in BS3

* [web] Remove unnecessary CSS in `.log-entry-header-link`

* [web] Use semantic color names

* Migrate the downloadable pdf file list to Bootstrap 5

* Remove nested BootstrapVersionSwitcher, fix "key" prop

* Update roles to: `<li role="menuitem">` `<a role="link">`

* Update `log-entry-header-link`: variant ghost and fix colors

---------

Co-authored-by: Rebeka <o.dekany@gmail.com>
GitOrigin-RevId: 89848970ab5d8a8c135335386caf24363f69a34c
2024-10-23 08:06:32 +00:00
Antoine Clausse
d77ca18b0b [web] Remove dead code: history-content & history-root (#20959)
They are duplicated by:
* services/web/frontend/js/features/ide-react/components/history.tsx
* services/web/frontend/js/features/ide-react/components/history-root.tsx

GitOrigin-RevId: c3f13ea9016530182ae623b06e91a9fdb2be7a87
2024-10-23 08:06:27 +00:00
CloudBuild
388f16169e auto update translation
GitOrigin-RevId: a7a23972ddc8c18eff2e2833ea06572cbce676fc
2024-10-23 08:06:23 +00:00
M Fahru
a0ea00b692 Merge pull request #21108 from overleaf/mf-only-one-container-gallery-redesign
[web] Make sure gallery (tagged and non-tagged) page only have a single `.container` on each page

GitOrigin-RevId: df5272082a7f74dcc4051560692eaf715b49dc37
2024-10-23 08:06:19 +00:00
Andrew Rumble
e75e9c4818 Revert "Send subscription -> salesforce/v1 links to analytics"
This reverts commit 52c02138f9ef8141850e2f8ce16f2bab1e7463b0.

GitOrigin-RevId: 022e828a8e41cc73c4087b94d51fa75dbe6cfdb5
2024-10-23 08:06:11 +00:00
Andrew Rumble
6f3c371435 Revert "Add an endpoint for rails to record salesforce mappings"
This reverts commit fcca974a69217dc885c458543a82b4dcc338d98b.

GitOrigin-RevId: cc7e2561a5f6b4866e5f69f4fb41ffb1bad07bb1
2024-10-23 08:06:06 +00:00