Commit graph

23650 commits

Author SHA1 Message Date
David
438192fc11 Open review panel current file view when clicking add comment tooltip (#20891)
* Remove need for custom set-review-panel-open event

* Open current file view when clicking add comment tooltip

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 2b21061193f4270030d73174014aabbd017fd38e
2024-10-14 11:08:56 +00:00
Domagoj Kriskovic
4a3eed35d6 Fix accept changes request for new review panel (#20956)
* Fix accept changes request for new review panel

* Implement pessimistic UI updates for new review panel (#20986)

* Implement pessimistic UI updates for new review panel

* deleteThread, reopenThread handlers

* use finally

* handleSubmit in useCallback

GitOrigin-RevId: 358181a6b5601ad1b3579e001564dfa4da67a81d
2024-10-14 11:08:44 +00:00
David
42a199043a Skip ReviewPanelEntry focus event if target is anchor element (#20928)
GitOrigin-RevId: e6ad0ca7c03de2ef176b6328c27dd0afa10bd102
2024-10-14 11:08:39 +00:00
David
def2f7f4fd Move divider into overview-file component so that they don't render if file doesn't (#20882)
GitOrigin-RevId: fef584609fa06e6313323c27bc6f9ab9b9a6c815
2024-10-14 11:08:30 +00:00
David
b1d1432183 Update add comment tooltip to match new designs (#20913)
* Update add comment tooltip to match new designs

* Rename AddCommentTooltip to ReviewTooltipMenu

* Split off add-comment-button specific padding

GitOrigin-RevId: 12a69b13b52b007eb97ba7ad6f290e3a98d741cd
2024-10-14 11:08:26 +00:00
Alf Eaton
9ba6a6a042 Update modified tracked changes in the React state (#20877)
GitOrigin-RevId: d3b17908aa43d99b6e46550f2de77186f9d7b86d
2024-10-14 11:08:21 +00:00
Mathias Jakobsen
ee2e95ec01 Merge pull request #20987 from overleaf/mj-write-and-cite-settings-icons
[web] Add setting icons to Write and Cite section headers

GitOrigin-RevId: 18e5eefeb1271d17812b83f152e4d464a66185f8
2024-10-14 11:08:09 +00:00
Jakob Ackermann
7f6c2afc92 Merge pull request #20980 from overleaf/jpa-extend-create-project
[web] scripts/create_project: fix and extend

GitOrigin-RevId: 4df41d02138a2214c83e7237794995d534e3c603
2024-10-14 11:08:04 +00:00
roo hutton
7d53b3e4a8 Merge pull request #20561 from overleaf/rh-duplicate-invite
[web] Revoke invite after joining project via link sharing

GitOrigin-RevId: 5071c9fbb226e5eef8c3e5c82991da73529d7396
2024-10-14 11:08:00 +00:00
Antoine Clausse
d6de6da781 [web] Migrate the file view to Bootstrap 5 (#20765)
* [web] Remove unnecessary divs around `fileInfo`

* [web] Add file-view SCSS style

* [web] Simplify `TPRFileViewInfo`

* [web] Add div for action buttons

* [web] Misc. simplifications

* [web] Add Overleaf logo in bg when selecting multiple files

* [web] Add message when multiple files are selected

* [web] Add .full-size class

* [web] Import styles from LESS file

* [web] Update icons, use MaterialIcon

* [web] Use OLButton

* [web] Add missing space between icons and text

* [web] Adjust margins

* [web] Fix alert button

* [web] Update Alerts

* [web] Update `FileViewLoadingIndicator`

* [web] Fix test "shows a loading indicator..."

This was failing because `LoadingSpinner` is shown after a setTimeout.
Maybe we can skip this setTimeout when delay==0 ?

* [web] Remove Row/Col around error notifications

* [web] Replace `!!` by `Boolean`

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* [web] Use `alert` class in BS3 only

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Update "Go to settings" to OLButton

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Use `BootstrapVersionSwitcher` instead of `isBootstrap5`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Align Alert content to the left in BS5

* [web] Remove `leadingIcon` on Refresh buttons

* [web] Make the download link be an OLButton

* [web] Set `tpr-refresh-error` in BS3 only

Co-authored-by: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>

* [web] Use `var(--white);` instead of `white`

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [web] Update OLButton size (small -> sm)

---------

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
Co-authored-by: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>
Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 04f369c0f1a53d47619a1570648ee58de5050751
2024-10-14 11:07:55 +00:00
Antoine Clausse
2e080a3a34 [web] Migrate IDE page loading screen to BS5 (#20896)
* [web] Add `.loading-screen` style

* [web] Add `.loading-screen-error` style

* [web] Nest styles in `.loading-screen`

* [web] Simplify code, make a more valuable Storybook

* [web] Add a reusable bootstrap-switcher argument to loading.stories.tsx

* [web] Make `isBootstrap5()` work in storybook

* [web] Revert unrelated changes around `ConnectionError` type

* [web] Remove comment about unhandled error codes

https://github.com/overleaf/internal/pull/20896/files#r1790572314

* [web] Don't repeat the `errorCode` prop type

* [web] Remove unused CSS and magic padding

* [web] Fixup SCSS division

* [storybook] Revert Storybook changes (moved to another branch)

* [web] Fixup SCSS division again (lint)

* [web] Render with `Boolean(errorCode) && ...` instead of `errorCode && ...`

* [web] Remove importants; use spacing var

Addresses Tim's comments

GitOrigin-RevId: e8b5623f4bb9aa72a255851f46b45b652a0dbb16
2024-10-14 11:07:50 +00:00
Antoine Clausse
b054342ddb [web] Update bsVersion to return its arguments types (#20963)
* [web] Update `bsVersion` to return its arguments types

* [web] Remove `as string` after `bsVersion` calls

GitOrigin-RevId: 604ce87aaccd709299124a986e98cf45874484bb
2024-10-14 11:07:45 +00:00
Antoine Clausse
4a8b79080b [storybook] Update Storybook and add a control for BS3/BS5 (#20948)
* [storybook] Update Storybook to version 8.3.5

* [storybook] Run storybook with `--no-open`. Fixes xdg-utils issue

* [storybook] Create decorator for BS3/BS5

* [storybook] Add `bsVersionDecorator` to stories

* [storybook] Fix bugs in stories

* [storybook] Fixup `useMeta` type. Use `DeepPartial`

* [storybook] Fix types

GitOrigin-RevId: 48c0f0fefb1ab2d4863ab59051b900b1908a613c
2024-10-14 11:07:40 +00:00
ilkin-overleaf
4f838ccacf Merge pull request #20824 from overleaf/ii-bs5-share-modal
[web] BS5 share modal

GitOrigin-RevId: 40a33e06eab720b568d31aefa021682535b6934e
2024-10-14 11:07:31 +00:00
ilkin-overleaf
6c7ee8f778 Merge pull request #20715 from overleaf/ii-bs5-chat-pane
[web] BS5 chat pane

GitOrigin-RevId: 8587aca1372b4d2087863d492e702f04a31c23e2
2024-10-14 11:07:26 +00:00
Andrew Rumble
e05c181af4 Ignore test settings file
GitOrigin-RevId: 5f9e901f4358bb631299ec165b72305ea814e343
2024-10-14 11:07:18 +00:00
Brian Gough
4a32f49b3d add an option to remove chat from server pro (#20445)
* add option to remove chat from backend

* make chat default to enabled

* Check chat is enabled in chat context

---------

Co-authored-by: mserranom <mserranom@gmail.com>
GitOrigin-RevId: 7dda09df4bb74007eb4b1272d4918155b5cddaf6
2024-10-14 11:07:02 +00:00
Miguel Serrano
ce130a8bc5 Merge pull request #20909 from overleaf/msm-check-esm-test
[scripts] lookup `test` dirs on `esm-check-migration.js`

GitOrigin-RevId: 79a0961e3b018b440cdb15980a194b63b2211aec
2024-10-14 11:06:50 +00:00
Alf Eaton
53d6b4dfd0 Set workerPublicPath in webpack config (#20629)
GitOrigin-RevId: 3fba33a6b52bf2a91f3126efc9d76f6f1dfbc1c4
2024-10-14 11:06:45 +00:00
Alf Eaton
d9a4c5b2bc Only use sentry-cli sourcemaps upload (#20852)
GitOrigin-RevId: d7effc1ca24a987079811acc0476cc55c9b1b4af
2024-10-14 11:06:41 +00:00
Domagoj Kriskovic
0998cc04df [project-history] fix diff view on file revert (#20769)
GitOrigin-RevId: 6c95dab9328ecab636272ad507505f5342ec8709
2024-10-14 11:06:36 +00:00
CloudBuild
27dd10258e auto update translation
GitOrigin-RevId: 9c3e46cc8d5c56e4cef9c5607c7f6e0a6f38fa4b
2024-10-14 11:06:31 +00:00
Jimmy Domagala-Tang
c6aec5c5c0 Merge pull request #20598 from overleaf/jdt-ae-dropbox-limit-notif
Add go to project for 2000 file limit notification

GitOrigin-RevId: dfd69773ebd5c2160dfce75f56b8fa1e93792c23
2024-10-14 11:06:26 +00:00
ilkin-overleaf
874c0211d7 Merge pull request #20926 from overleaf/ae-storybook-wasm
Add Storybook webpack config for wasm files

GitOrigin-RevId: a5e0e3b6af7865c3f8285c9b7bef8a4efae3a55b
2024-10-14 11:06:22 +00:00
ilkin-overleaf
92eade7502 Merge pull request #20708 from overleaf/ii-bs5-pdf-toolbar
[web] BS5 pdf toolbar

GitOrigin-RevId: a04091c9e936e52f47c3977b3149ffe613d43bb9
2024-10-14 11:06:17 +00:00
Jessica Lawshe
9ce7d4ec44 Merge pull request #20797 from overleaf/jel-checkmark-green
[web] CMS BS5 - Update greens in checkmark

GitOrigin-RevId: 7a98c0173c9aa580257c964847368ef5efbe0c8d
2024-10-14 11:05:57 +00:00
David
037529f243 Merge pull request #20886 from overleaf/dp-overview-file-counts
Check that thread has messages in overview comment count

GitOrigin-RevId: 8499f837a016256c5ca615172b5c53a7f2e7c6b5
2024-10-14 11:05:53 +00:00
David
d9211998de Merge pull request #20887 from overleaf/dp-rp-entry-buttons
Don't focus entry if clicking on a button/link

GitOrigin-RevId: 0c37ce76134358ef7d3fd5b0c897ffab8e4d7db1
2024-10-14 11:05:48 +00:00
David
43bb8c0ab2 Merge pull request #20803 from overleaf/dp-resolved-comments-scroll
Add a max-height and scroll to tracked changes menu

GitOrigin-RevId: 93d4be0f057f4785a8d383f718078619467f3e2a
2024-10-14 11:05:43 +00:00
Mathias Jakobsen
58b52db56d Merge pull request #20903 from overleaf/mj-load-write-and-cite-with-autocomplete
[web] Load Write and Cite with AutoComplete

GitOrigin-RevId: b496874447b00723410df01a96ea66aa8ec4da3c
2024-10-14 11:05:39 +00:00
Eric Mc Sween
16d3d59bc1 Merge pull request #20869 from overleaf/em-ranges-tracker-duplicate-ids
Fix handling of duplicate change ids in RangesTracker

GitOrigin-RevId: 1a75d1dc7e7931c459d2d004973f34d931100d33
2024-10-14 11:05:30 +00:00
Alf Eaton
139fde750a Add feedback link in spelling suggestion footer (#20867)
GitOrigin-RevId: 3bef428f810b88f56a76e3645cebcf22dd5ad9e3
2024-10-14 11:05:21 +00:00
Alf Eaton
e99ae3a459 Add Hunspell README (#20872)
GitOrigin-RevId: 0b02a1a03e467d0857766e70e3a3862f939c773c
2024-10-14 11:05:17 +00:00
Alf Eaton
a1ea50ded3 Load hunspell.wasm from the CDN (#20856)
GitOrigin-RevId: 0fcbc2102e280222ab4b9279f02c820a3b904496
2024-10-14 11:05:12 +00:00
andrew rumble
50c74c3168 Add esmock for tests
GitOrigin-RevId: 42be4094f8551a1588de5048b4876557e16888f1
2024-10-14 11:05:07 +00:00
Eric Mc Sween
731ba80b47 Merge pull request #20888 from overleaf/revert-20834-em-validate-tracked-deletes
Revert "Sanity check for tracked changes in document-updater"

GitOrigin-RevId: 1b7592b1f2d60374ce9ba54d9db5e34c9636ea9a
2024-10-14 11:05:01 +00:00
andrew rumble
4919172d52 Load settingsCheckModule regardless of module type
GitOrigin-RevId: 7afeb6d5bbe6b5db33c8d1a547009980e6e75c53
2024-10-14 11:04:50 +00:00
andrew rumble
46317a9b9c Make apply module function async
This will allow us to support async module loading required for ES
modules support.

GitOrigin-RevId: bfd925c94ca3b6df8f75f704e21164a546973f5f
2024-10-14 11:04:41 +00:00
andrew rumble
2f96ef11f9 Allow ESM OL modules to be loaded
Lots of changes to async/await required to allow this. We have to make
some changes to handle the fact that modules are loaded async in stages
rather than sync (so we can't control when top-level functionality is
run in a fine grained way)

GitOrigin-RevId: 0127b15bfc4f228a267df3af8519c675e900654e
2024-10-14 11:04:32 +00:00
andrew rumble
5a5995f43c Convert server and router files to ES modules
GitOrigin-RevId: dab330dd89afb156db6586d8c28b146216548477
2024-10-14 11:04:28 +00:00
andrew rumble
e128e8ea32 Convert app.js to ES modules
GitOrigin-RevId: 7819cc8c8235b93b985c1c07c7dec778c93d9134
2024-10-14 11:04:23 +00:00
M Fahru
209a3670ce Merge pull request #20827 from overleaf/mf-bs5-previous-page-link-hover
[web] Add hover effect to `.previous-page-link` class

GitOrigin-RevId: ccba4cb22274695a2a3b63abcf86d7bc0c6dec61
2024-10-14 11:04:18 +00:00
M Fahru
2a99415c69 Merge pull request #20829 from overleaf/mf-blog-list-title-link-size
[web] Reduce blog title link size on bootstrap 5 blog list page

GitOrigin-RevId: cd22fef67488c5b8d291c358e812e0d94cb303ef
2024-10-14 11:04:13 +00:00
M Fahru
5d2eac5694 Merge pull request #20851 from overleaf/mf-bs5-pagination
[web] Bootstrap 5 pagination

GitOrigin-RevId: b3709a3f016423e7df12d6dfdf2cb4e47efbffe2
2024-10-14 11:04:09 +00:00
Eric Mc Sween
dc445121fe Merge pull request #20834 from overleaf/em-validate-tracked-deletes
Sanity check for tracked changes in document-updater

GitOrigin-RevId: 5f4c5cb931a6dae5257fed2f21e40777cb466309
2024-10-14 11:04:04 +00:00
Liangjun Song
7258ddcf02 Merge pull request #20770 from overleaf/ls-drop-unused-collections
drop unused collections

GitOrigin-RevId: 4b079f15dca349ef6a5aed8d9dcb35478819c2ce
2024-10-14 11:03:59 +00:00
Andrew Rumble
ee8c13ec7e Ensure gov banner defined before use
GitOrigin-RevId: 1db97fd4882600f8e6764273bbcbec503b68f01e
2024-10-14 11:03:55 +00:00
Davinder Singh
f2c167a026 CMS BS5 migration - Adding the left spacing to the labels next to checkbox (#20780)
* adding left-margin for the checkbox-label

* moving the styling to appropriate file and making it more generic

GitOrigin-RevId: 66484344891c77f6d31147ef7d0e0d55987a8445
2024-10-14 11:03:50 +00:00
Davinder Singh
d61997373f BS5 Migrations CMS - Adding the pattern card at the end of the blog page (#20739)
* adding existing pattern card content and styling with commented code to avoid breaking the compiler

* removing extra styling that is not needed

* using variables

* removing event segmentation and adding URLs

* adding a translation for tthe ext

* adding a translation for explore_all_plans

* adding translation sign_up_for_free

* adding the card on blog post page

* adding card-body to match BS5 and removing extra padding from .cta-card

* adding p and removing margin from .font-size-display-xs

* removing cta-card-text class

* removing margin-top from responsive-button-container and adding the usage of .p-no-text-nodes with p

* removing gap and margin responsive-button-container

* removing extra padding

* adding font-size and line-height to match figma design

* changing the breakpoint to lg

* removing important keyword

* making explore plans button as primary and hiding signup button when user is logged in

* removing responsive-button-container

* adding count variable in the translation

* moving font-size-display-xs one level lower

* adding span under p

GitOrigin-RevId: a1a16d46a725b547bda6e452ff1c7bef05964690
2024-10-14 11:03:45 +00:00
andrew rumble
8a31146d02 Promisify LinkedFilesController
GitOrigin-RevId: b81ed1615939671839cbeabc36308fe8b81647cf
2024-10-14 11:03:19 +00:00