github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-14 20:40:17 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #20887 from overleaf/dp-rp-entry-buttons

Browse source 
Don't focus entry if clicking on a button/link

GitOrigin-RevId: 0c37ce76134358ef7d3fd5b0c897ffab8e4d7db1
This commit is contained in:
David 2024-10-08 13:23:30 +01:00 committed by Copybot
parent 43bb8c0ab2
commit d9211998de
1 changed files with 19 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
services/web/frontend/js/features/review-panel-new/components/review-panel-entry.tsx
View file

@ -43,12 +43,25 @@ export const ReviewPanelEntry: FC<{
setReviewPanelOpen(true)
}, [setReviewPanelOpen])
const focusHandler = useCallback(() => {
if (selectLineOnFocus) {
openDocId(docId, { gotoOffset: position, keepCurrentView: true })
}
setFocused(true)
}, [selectLineOnFocus, docId, openDocId, position])
const focusHandler = useCallback(
event => {
if (
event.target instanceof HTMLButtonElement ||
event.target instanceof HTMLLinkElement ||
event.target instanceof HTMLTextAreaElement
) {
// Don't focus if the click was on a button/link/textarea as we don't want
// affect the behaviour of the button/link/textarea
return
}
if (selectLineOnFocus) {
openDocId(docId, { gotoOffset: position, keepCurrentView: true })
}
setFocused(true)
},
[selectLineOnFocus, docId, openDocId, position]
)
// Clear op highlight on dismount
useEffect(() => {