Commit graph

32 commits

Author SHA1 Message Date
David
1c5f5950fa Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
Add options to accept/reject all changes to review tooltip

GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
Mathias Jakobsen
58b52db56d Merge pull request #20903 from overleaf/mj-load-write-and-cite-with-autocomplete
[web] Load Write and Cite with AutoComplete

GitOrigin-RevId: b496874447b00723410df01a96ea66aa8ec4da3c
2024-10-14 11:05:39 +00:00
David
46198cd780 Merge pull request #20688 from overleaf/dk-fix-wrong-rangesdata
Fix "RangeError" when switching files using new review panel

GitOrigin-RevId: 399c8722584053c62acf5c413572fbbcdd1896cc
2024-10-14 10:59:33 +00:00
Mathias Jakobsen
aba4694377 [web] Move ARS Write and Cite behind separate feature flag (#20631)
* [web] Move ARS Write and Cite behind separate feature flag

* [web] Use isSplitTestEnabled function

* [web] Only load Write and Cite if project has ARS access

* [web] Enable Write and Cite ARS by default

* [web] Fix condition for loading write and cite ref sources

* [web] Remove references settings button in free projects

GitOrigin-RevId: c4f3b7c60da9864409c788dcf34bdc77347441a8
2024-10-14 10:59:11 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
Domagoj Kriskovic
be47b27d98 remove clearChanges and buildChanges effects from ranges extension
GitOrigin-RevId: 4782725bfaf50153007bbd9ae5c8146cca769cde
2024-08-26 08:05:01 +00:00
Domagoj Kriskovic
dc70054caf trackDetachedComments as separate extension
GitOrigin-RevId: 8039de3f9766b072e9bb2170b50e683073105748
2024-08-26 08:04:56 +00:00
Domagoj Kriskovic
ec6b17eb01 revert trackChanges extension to a version before redesign
GitOrigin-RevId: fc12968a3971cfee7594720076bb4dc271178e73
2024-08-26 08:04:52 +00:00
Alf Eaton
6ec26060e4 Move updateListener out of sourceOnly wrapper (#19573)
GitOrigin-RevId: 3633b7c9763eac05793c2099124bd78369f90a73
2024-08-07 08:05:50 +00:00
David
c07d2f3fa2 Merge pull request #19528 from overleaf/dp-equation-preview
Equation Preview

GitOrigin-RevId: 98e71e5d2c1a83d6c9fa685eeee1f4b93a5a3da1
2024-07-25 08:05:04 +00:00
Alf Eaton
c1c098e2f9 Allow files to be dragged from the file tree into the editor (#15028)
GitOrigin-RevId: f926666c032d1398a0e3f72a298116a3c7a9cd75
2024-05-09 08:04:46 +00:00
Alf Eaton
cac1ab1259 Add tags to Sentry error reports (#16465)
GitOrigin-RevId: 1d014e8cc9f87d249a285b247c35f12465ecb93a
2024-02-02 09:03:23 +00:00
Alf Eaton
4a7a24b44d Update the CodeMirror language when the current file is renamed (#16342)
GitOrigin-RevId: 8b51df0d1acfeeb8b0323cebf6de78572c8cb95c
2024-01-15 09:04:27 +00:00
Alf Eaton
d40de2018c Remove Angular/Pug review panel code (#15935)
GitOrigin-RevId: de782d4b47d987f6434a34bea487568b269e8d85
2023-11-29 09:04:13 +00:00
Alf Eaton
54c55360c4 Remove completion and shortcut event logging (#15633)
GitOrigin-RevId: 35eedb7b18200badef8226eecc58b3c35344f256
2023-11-07 12:34:56 +00:00
Alf Eaton
6dbb2df5b8 Remove editor split tests (#14985)
* Remove source-editor-toolbar split test
* Remove editor-left-menu split test
* Remove paste-html split test
* Remove figure-modal split test
* Remove rich-text split test
* Remove table-generator split test

GitOrigin-RevId: e3fe415b81ff0135d8764cd3f3c91b1dd4a77cf0
2023-10-04 08:04:34 +00:00
Alf Eaton
fbb0ab210e [cm6] Configure "4 spaces" as the indent unit for all files (#14366)
GitOrigin-RevId: 5aed6bc5abfd194c11830bdedcbba65ef1ed0522
2023-08-18 08:05:04 +00:00
Alf Eaton
e86c5dc137 [cm6] Add analytics for bold and italic shortcuts (#13785)
GitOrigin-RevId: 62f2f9976778083b7ca6566f79e3d055585e7bb7
2023-07-17 11:04:01 +00:00
Alf Eaton
48e758a5fe Record each completion selection for analytics (#13665)
GitOrigin-RevId: bc8e92ceca51f6365c4311204a35fc85914969b0
2023-07-17 11:03:43 +00:00
Alf Eaton
87013d20f8 Revert "[cm6] Show "move" cursor when the selection is ready to be dragged (#13532)" (#13673)
This reverts commit 1a89abceeadb6e1c53b4bc779df19b6723eab738.

GitOrigin-RevId: 05025068f75f1012626359230952e252e941d675
2023-07-17 10:50:49 +00:00
Alf Eaton
1cfc1eb269 [cm6] Show "move" cursor when the selection is ready to be dragged (#13532)
GitOrigin-RevId: 1a89abceeadb6e1c53b4bc779df19b6723eab738
2023-07-17 10:50:40 +00:00
Domagoj Kriskovic
17452b51d7 [cm6] Add toolbar to Source Mode for Beta users (#13429)
* [cm6] toolbar for source mode

* top:0 for new toolbar

* empty div for extensions

* fix legacy css top pos

* show source toolbar split test

* prettier

* show beta icon in source editor

* dropdown toolbar wip

* fix wrong conflict resolve

* math dropdown, chrome extension fixes

* math dropdown cleanup

* sort en.json

* fix sort en.json

* using isVisual

* getMeta in component, pug update

* using flex grow

* toolbar beta badge

* remove extra whitespace

* has-legacy-toolbar class

* Increase container size

* fix tests

* prettier

* styling fixes, using SplitTestBadge

* only show source toolbar if flag is set

* fix typo

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 34b01a9421f4a0d6defc40925c5092901575946e
2023-07-17 10:46:26 +00:00
ilkin-overleaf
15db0ce4e3 Merge pull request #13492 from overleaf/td-review-panel-sync-height
Add hook for synchronizing review panel height with editor content height

GitOrigin-RevId: ef0a96ef4e77e7858b28f6f65254a4b0c1e778ea
2023-07-17 10:39:29 +00:00
Alf Eaton
e025088065 Merge pull request #13241 from overleaf/ae-extensions-documentation
Add documentation for CodeMirror extensions

GitOrigin-RevId: e5f07084173f201919272f9d46dcdaef4b817874
2023-07-17 10:28:53 +00:00
Mathias Jakobsen
480672bf7a Merge pull request #13133 from overleaf/mj-wait-upload
[cm6] Wait for file to be ready before inserting code from figure modal

GitOrigin-RevId: 5c4e8f243518bacc7b6ef4272eaf44995192efbc
2023-05-22 08:04:10 +00:00
Alf Eaton
60370d5227 [cm6] Consolidate loose extensions (#13086)
GitOrigin-RevId: ff937418be5092b2b5197435e9cd60bc61f41b2c
2023-05-17 08:04:40 +00:00
Domagoj Kriskovic
27ffe1c814 [cm6] Display non-standard spaces as special chars (#12927)
* [cm6] Display non-standard spaces as special chars

* specialChar background color

* removed Ideographic Space

* fix: lint error

* added Ideographic Space

* display only for source editor

GitOrigin-RevId: d94942cdc6a0aa17045b1783ac95de601f6ae15a
2023-05-08 08:04:18 +00:00
Mathias Jakobsen
c2292a8567 Merge pull request #12677 from overleaf/ae-codemirror-view-upgrade
[cm6] Upgrade CodeMirror dependencies

GitOrigin-RevId: cc973b1c5b23eca0fc93a9b3a970c832212e47af
2023-04-21 08:02:53 +00:00
Mathias Jakobsen
4b2cc907e2 [cm6] Change Emacs commands to visual-line-mode (#12523)
* [cm6] Change Emacs commands to visual-line-mode
* [cm6] Change line deletion commands to visual line mode

GitOrigin-RevId: 7a4f3d66bec611de410b6c1fbafbfe33b974e37b
2023-04-17 08:05:08 +00:00
Alf Eaton
ab10fd99f5 Add CodeMirror dev tools extension (#12142)
GitOrigin-RevId: 148a0fba5faf6dc8f638fcb4666e2fda6c5c6c40
2023-04-17 08:04:09 +00:00
Alf Eaton
161decd67d Upgrade @codemirror/view (#12574)
* Upgrade @codemirror/view
* Disable emptyLineFiller extension

GitOrigin-RevId: 57ce4194ece0ea448e24184f0b3a3e13352cb014
2023-04-17 08:04:00 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457)
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00