Commit graph

692 commits

Author SHA1 Message Date
Paulo Reis
f012a6fe32 Scroll patcher for Safari. 2016-07-29 17:24:45 +01:00
Brian Gough
208798ebe3 add a log hint for mismatched brackets 2016-07-29 14:59:48 +01:00
Brian Gough
4d3b743e4d display validation errors only when doing validation 2016-07-29 14:59:48 +01:00
Brian Gough
a3c8202d0e support jumping to position with line and column from log entries 2016-07-29 14:59:48 +01:00
Brian Gough
5da1b90418 use validate as keyword for syntax checks 2016-07-29 14:59:48 +01:00
Brian Gough
14a0499b56 allow HumanReadableLogs to rewrite messages with regex
also allow an explicit hintId for each rule
2016-07-29 14:59:48 +01:00
Brian Gough
d4c5028350 allow HumanReadableLogs to accept an already parsed log 2016-07-29 14:59:48 +01:00
Brian Gough
ef85f1014c add menu option for checking with chktex 2016-07-29 14:59:48 +01:00
Brian Gough
e0d5075fdb include check option when compiling 2016-07-29 14:59:48 +01:00
Shane Kilkelly
7b18f88145 Merge branch 'master' into pr-email-tokens 2016-07-28 14:53:36 +01:00
Shane Kilkelly
254705c3f1 Tidy up, and fall back to handling data.users. 2016-07-28 13:47:19 +01:00
Paulo Reis
4c2f69692e Namespace events which are sent only once. 2016-07-27 16:56:14 +01:00
Paulo Reis
64654257a1 Track a few high-frequency events only once. 2016-07-27 15:53:28 +01:00
Shane Kilkelly
46ec17f2c4 Add redir query string to login link 2016-07-27 13:51:52 +01:00
Shane Kilkelly
72c9c3f020 If there are no completions matching, detach the completer.
This prevents an invisible completer from swallowing keystrokes such as up/down
2016-07-26 15:54:33 +01:00
Paulo Reis
bfe3e160c9 Integrate with UI. 2016-07-26 11:37:51 +01:00
Paulo Reis
32b57f228c Integrate feedback UI with wufoo service. 2016-07-25 16:12:56 +01:00
Shane Kilkelly
16dcbe2cd4 WIP: wire up share-modal frontend to invite system 2016-07-25 15:07:14 +01:00
Shane Kilkelly
b3add65de1 Start integrating invites into share frontend 2016-07-25 14:27:02 +01:00
Shane Kilkelly
8dea179b01 Whitespace 2016-07-25 10:33:43 +01:00
Henry Oswald
a3e40adbaf Merge pull request #283 from sharelatex/ho-cdn
Ho cdn
2016-07-20 14:19:37 +01:00
Henry Oswald
6c78ab4ace got requirejs working nicely with cdn 2016-07-20 12:58:32 +01:00
Brian Gough
fcfdabd279 clean up pdfcontroller query string logic 2016-07-20 09:58:47 +01:00
Brian Gough
4e252976c7 add missing cache bust on log file 2016-07-20 09:58:47 +01:00
Brian Gough
a3c97533ae Merge pull request #281 from sharelatex/stop-compile
add support for stopping compile
2016-07-18 15:01:26 +01:00
Brian Gough
5a02e8c656 add support for stopping compile 2016-07-15 16:28:52 +01:00
Paulo Jorge Reis
0b21f8f4f1 Merge pull request #279 from sharelatex/pr-track-trial-start
Track trial start and subscription
2016-07-14 10:14:49 +01:00
Brian Gough
d53fa5de47 avoid exception in pdf viewer when no visible pages 2016-07-13 14:14:51 +01:00
Brian Gough
d8c11a0824 fix scope for pdf page load error handler 2016-07-13 14:04:58 +01:00
Paulo Reis
688eebf469 Merge branch 'pr-track-trial-start' of github.com:sharelatex/web-sharelatex into pr-track-trial-start 2016-07-13 09:49:57 +01:00
Paulo Reis
0542d9e05d Track trials starts, with source. 2016-07-12 17:33:00 +01:00
Paulo Reis
b2da63f532 Track trials starts, with source. 2016-07-12 16:41:22 +01:00
Brian Gough
2e646729d1 avoid clobbering file urls in download dropdown 2016-07-12 14:37:08 +01:00
Brian Gough
8c9fcfdd60 remove sentry downsampling on pdf errors
load errors should be less frequent now
2016-07-12 11:51:30 +01:00
Brian Gough
7555382e33 remove the render timeout
pdfjs uses requestAnimationFrame to schedule the rendering, and this
does not fire if the tab is inactive. That causes an unwanted error if
switching tabs for more than the one minute timeout.
2016-07-12 11:51:30 +01:00
Brian Gough
0ae639f1c3 enable per-page pdf downloads by default 2016-07-12 11:51:30 +01:00
Brian Gough
b546c5eee9 cleanup, remove comments 2016-07-11 15:07:06 +01:00
Brian Gough
4b1ec24bc0 cancel existing load/render tasks correctly 2016-07-11 15:01:58 +01:00
Brian Gough
f68ab1e508 improve loading indicators 2016-07-11 15:01:24 +01:00
Brian Gough
379e6d2f90 nullify highlight timeout after clearing it 2016-07-11 12:17:49 +01:00
Brian Gough
ad83784a81 remove the renderTimer
only display the page when it is fully rendered
2016-07-11 12:17:49 +01:00
Brian Gough
70a82c10ce cleanup pdfJs 2016-07-11 12:17:49 +01:00
Brian Gough
41b0309e6e show progress bar when loading starts 2016-07-11 12:17:49 +01:00
Brian Gough
a4cd5c90c3 only process the render queue after we stop moving 2016-07-11 12:17:49 +01:00
Brian Gough
eaca616dd3 use progress bar for initial loading 2016-07-11 12:17:49 +01:00
Brian Gough
b8f677ac7c replace canvas with rendered page after 1 second 2016-07-11 12:17:49 +01:00
Brian Gough
0e550ac012 add spinner for loading, initially static 2016-07-11 12:17:49 +01:00
Brian Gough
c657a02db5 render offscreen pages 2016-07-11 12:17:49 +01:00
Brian Gough
83ea771aef include start method for spinner 2016-07-11 12:17:49 +01:00
Brian Gough
8c81f0a9ff prerender offscreen pages 2016-07-11 12:17:49 +01:00
Paulo Reis
e1fb4a51c6 Identify sampled events. 2016-07-08 11:17:18 +01:00
Paulo Jorge Reis
c5cf151add Merge pull request #275 from sharelatex/pr-separate-events-log-hints-feedback
Track positive and negative feedback as different events
2016-07-08 10:54:02 +01:00
Paulo Reis
c67ad84be8 Track positive and negative feedback as different events. 2016-07-08 10:26:40 +01:00
Paulo Reis
dfe9e05abe Use sampled tracking in editor recompiles. 2016-07-08 10:07:45 +01:00
Paulo Reis
07cce99c17 Add sampled tracking method. 2016-07-08 10:06:46 +01:00
Paulo Jorge Reis
3a24c4bff9 Merge pull request #272 from MCribbin/patch-2
Update HumanReadableLogsRules.coffee
2016-07-07 13:39:44 +01:00
MCribbin
b62fbd4d3f Update HumanReadableLogsRules.coffee 2016-07-06 16:18:27 +01:00
MCribbin
dadee03ca3 Update HumanReadableLogsRules.coffee
Added new linke for LaTeX Error: Unknown float option `q'.
Changed hint for "No positions in optional float specifier" to include quick fix (will probably need some clearer way of saying which square brackets need to be removed)
2016-07-06 15:57:56 +01:00
Paulo Reis
b867c37d49 Merge branch 'master' into pr-log-dropdown 2016-07-06 15:35:28 +01:00
Paulo Reis
8e2475afdc Track hints feedback in both GA and Countly; clean-up. 2016-07-06 14:24:50 +01:00
MCribbin
95f1435920 Update HumanReadableLogsRules.coffee 2016-07-06 14:16:21 +01:00
Paulo Reis
0dd3a70b4b Use Countly tracking method where appropriate. 2016-07-06 12:32:33 +01:00
Paulo Reis
909f7c15b5 Track log-related actions. 2016-07-05 16:27:14 +01:00
Paulo Reis
d5efe81a46 Track recompiles. 2016-07-05 16:02:46 +01:00
Paulo Reis
96f6603bd3 Track settings changes. 2016-07-05 15:37:13 +01:00
Paulo Reis
304529754d Track editor modals. 2016-07-05 15:16:55 +01:00
Paulo Reis
a40cbdd84e Track share modal opening. 2016-07-05 14:32:56 +01:00
Brian Gough
ea942fe255 Merge pull request #269 from sharelatex/remove-migration-to-per-user-containers
remove scaffolding for per-user compiles so that it is always by default
2016-06-30 15:16:28 +01:00
Brian Gough
c04e00026b remove scaffolding for per-user compiles so that it is always by default 2016-06-30 14:43:03 +01:00
Paulo Reis
d93c96d43c Improve log hints ids. 2016-06-30 11:30:43 +01:00
Paulo Reis
c5f53ef431 Track log hints feedback. 2016-06-30 11:30:30 +01:00
Paulo Reis
536c1ac65e Merge branch 'pr-project-filepath-regex' 2016-06-29 14:19:37 +01:00
Paulo Reis
36e09e3b0c Make the user id portion of the path optional. 2016-06-29 14:19:16 +01:00
Brian Gough
16b58a9420 Merge pull request #268 from sharelatex/per-user-containers-part-3
add support for on-demand viewing of pdfs for per-user compiles
2016-06-29 14:16:24 +01:00
Paulo Reis
5ad0c06770 Regex now matches new folder nomenclature. 2016-06-28 17:19:02 +01:00
Paulo Reis
88564ea126 Dynamically determine if the files dropdown should drop up or drop down. 2016-06-28 15:48:11 +01:00
Paulo Reis
86a8a180a8 Merge branch 'master' into pr-toggle-comment-keybinding-windows 2016-06-28 11:37:46 +01:00
Paulo Reis
d6067b86ac Merge branch 'master' into pr-ui-feedback-error-nav 2016-06-28 10:49:55 +01:00
James Allen
883a9b512a Merge pull request #265 from MCribbin/patch-1
Update HumanReadableLogsRules.coffee
2016-06-28 10:33:24 +01:00
Brian Gough
8d32fa1e87 enable per-user containers by default 2016-06-28 08:40:30 +01:00
Paulo Reis
6a8499f515 Merge branch 'master' into pr-toggle-comment-keybinding-windows 2016-06-27 15:39:35 +01:00
Brian Gough
8b15d40f8b add word count to per-user container 2016-06-27 12:41:50 +01:00
Paulo Reis
81b93ab5a9 Disable links to the docs when the wiki is not available. 2016-06-27 11:34:24 +01:00
Henry Oswald
6526b29f96 add another null check on file inside fetchLogs 2016-06-25 13:56:45 +01:00
MCribbin
9a399ebd15 Update HumanReadableLogsRules.coffee
Space added after URL. '...' changed to '\u2026'
2016-06-24 15:50:23 +01:00
MCribbin
883ae307a9 Update HumanReadableLogsRules.coffee
Changed extraInfoURL links from /Errors:... to /Errors/...
Added math mode description to "Missing $ inserted." (humanReadableHint might be too long with this extra description)
2016-06-24 15:37:39 +01:00
Paulo Reis
91cbf2b321 Links within hint content also open in a new tab. 2016-06-24 11:56:31 +01:00
Paulo Reis
2da9cdb0db Hints as HTML. 2016-06-24 10:15:51 +01:00
Paulo Reis
9b25af3c8c Consolidate rules related to too-strict float specifiers. 2016-06-23 16:57:05 +01:00
James Allen
da41e64e97 Update HumanReadableLogsRules.coffee 2016-06-23 16:52:02 +01:00
Paulo Reis
5a890d0d8b Add log matching rules. 2016-06-23 16:39:05 +01:00
Paulo Reis
d6c966934d Set the key binding which is reported on Windows. 2016-06-21 16:53:50 +01:00
Paulo Reis
e607de0b91 Safety checks for non-existing values; avoid rendering the hint template when there is no hint. 2016-06-21 12:07:47 +01:00
Paulo Reis
d8e0026bc6 Add class to enable per-hint feedback tracking. 2016-06-20 17:32:57 +01:00
Paulo Reis
a8976fd4dc Use plain links instead of buttons. 2016-06-20 14:42:36 +01:00
Paulo Reis
ada018263a Merge branch 'master' into pr-human-readable-logs 2016-06-20 11:54:56 +01:00
Paulo Reis
605bb07ba3 Hint card styling. 2016-06-20 09:45:14 +01:00
Paulo Reis
54d48ce0ea Support extra info URL in human readable hints. 2016-06-17 11:42:32 +01:00
Paulo Reis
40fda6e361 Support HTML in human readable log messages. 2016-06-16 16:29:19 +01:00
Paulo Reis
9b8d695e43 Match logs against ruleset; show human readable message when appropriate. 2016-06-16 15:53:39 +01:00
Paulo Reis
f167aacc08 Add sample rules file. 2016-06-16 15:29:00 +01:00
Brian Gough
5e30310aae restore popupDownloads=true for pdf downloads 2016-06-16 15:20:57 +01:00
Brian Gough
02e3f7a02b change download links so they do not rely on build id
prefer the top level files, because the build directories are more
ephemeral.  In a shared project they can expire if there are multiple
compiles.
2016-06-16 14:05:21 +01:00
Brian Gough
f045eb65d3 add query string utility function 2016-06-16 14:03:42 +01:00
Paulo Reis
c54f3dae20 Create human readable logs module on top of LatexLogParser; use it in the PDF controller. 2016-06-16 11:14:45 +01:00
Paulo Reis
e28e959941 Quick fix require statements. 2016-06-15 13:46:40 +01:00
Paulo Reis
a9e0185098 Added tooltip with keyboard shortcut in the recompile button. 2016-06-14 17:02:22 +01:00
Brian Gough
d6964feb2f Revert "enable per-user containers by default"
This reverts commit e80b8cd907605d9a7aad16496d49efff4bb08810.
2016-06-14 16:30:06 +01:00
Brian Gough
d0a273fac1 Merge pull request #257 from sharelatex/fix-synctex-position-calculation
Fix synctex position calculation
2016-06-14 15:07:48 +01:00
Brian Gough
77de4dd432 Merge pull request #258 from sharelatex/enable-per-user-container
enable per-user containers by default
2016-06-14 15:07:37 +01:00
Brian Gough
ed6c384b68 fix urls of downloaded files to those provided by clsi 2016-06-14 14:51:33 +01:00
Brian Gough
ecd9bed1c2 enable per-user containers by default 2016-06-14 14:21:56 +01:00
Brian Gough
991d3c7aa1 avoid exception when switching between full and split pdf view 2016-06-14 12:49:06 +01:00
Brian Gough
2840a7757f fix bug in synctex position calculation for syncToCode 2016-06-14 12:32:54 +01:00
Brian Gough
830d15136d fix missing variables in pdf sync 2016-06-14 08:49:08 +01:00
Brian Gough
49a7c3c27b Merge branch 'per-user-containers-part-2'
Conflicts:
	app/coffee/Features/Compile/ClsiManager.coffee
	app/coffee/Features/Compile/CompileController.coffee
	app/coffee/Features/Compile/CompileManager.coffee
2016-06-13 12:24:48 +01:00
Brian Gough
3c31988e9a enable on-demand viewing of pdfs for per-user compiles 2016-06-10 16:06:02 +01:00
Brian Gough
6c244eb2f4 Merge pull request #251 from sharelatex/fix-download-urls
fix filename of downloaded pdf files
2016-06-08 14:33:12 +01:00
Henry Oswald
a297c07bbb added null check into response.outputFiles? 2016-06-06 14:56:34 +01:00
Henry Oswald
79929eae73 Merge branch 'clsichecks' 2016-06-06 14:34:22 +01:00
Brian Gough
ce1524cd07 remove unnecessary build id in query string
this is now in the url
2016-06-02 15:48:13 +01:00
Brian Gough
272625fbcc add per-user compilation in client
enabled only when query string includes isolated=true
2016-06-02 15:48:13 +01:00
Henry Oswald
c284465ba5 added clsiformat checker, wired in 2016-06-02 13:09:32 +01:00
Brian Gough
b8e31dfc71 fix filename of downloaded pdf files 2016-06-01 16:47:55 +01:00
James Allen
daf8f6f3cf Refresh the page if the user is not logged in when joining a project 2016-05-31 11:47:48 +01:00
James Allen
345d38c28d Don't clean up a documents event listener until after the socket has disconnected on error 2016-05-27 14:39:33 +01:00
James Allen
36c8c197e1 Add more debug log lines 2016-05-27 14:14:08 +01:00
James Allen
fec3266726 Don't remove new instance of Document from openDocs when cleaning up old instance 2016-05-27 14:13:53 +01:00
James Allen
a605dae7ba Don't show saving just because of pending ops
When typing continuously, there is always a pending op present.
The only time we're not saving is if the inflight op isn't changing.
So long as this has changed, it means the previous one has been processed.
2016-05-27 14:08:46 +01:00
James Allen
4bc31ae2b9 Don't throw an error if we get an ack for our update more than once, since we may try sending it more than once 2016-05-27 10:46:14 +01:00
James Allen
6ea58d4d6c Don't try to resend an update if the editor is not joined to the project 2016-05-27 10:46:14 +01:00
James Allen
39e57a9886 Throw fatal error if document update actually returns an error from the real-time service 2016-05-27 10:46:14 +01:00
James Allen
0175a86d4c Add in debugging console.logs which only display if ?debug=true is in URL 2016-05-27 10:46:14 +01:00
James Allen
f937f0bc5c Remove missed debugging console.log 2016-05-25 10:38:40 +01:00
James Allen
a196531a58 Move spinner add logic into same code pathway as spinner remove logic 2016-05-24 15:13:08 +01:00
James Allen
3452a9870e Show logs when compile fails correctly 2016-05-24 15:10:55 +01:00
Shane Kilkelly
0c454f5ddd Merge branch 'master' of github.com:sharelatex/web-sharelatex 2016-05-20 14:34:55 +01:00
Shane Kilkelly
2441930fe9 Add a spinner when waiting for image preview to load. 2016-05-20 14:28:51 +01:00
Henry Oswald
11724fce13 Merge branch 'master' into clsi-dynamic-load 2016-05-20 12:34:42 +01:00
Brian Gough
eaa41e4361 support displaying output files using .url parameter from clsi 2016-05-20 11:34:22 +01:00
Shane Kilkelly
939c7a8c72 Force reload BinaryFile view when a new object is selected. 2016-05-20 11:20:00 +01:00
Shane Kilkelly
2e2354c574 Merge branch 'master' of github.com:sharelatex/web-sharelatex 2016-05-20 09:17:35 +01:00
Shane Kilkelly
9a6876d237 Toggle the dots at the end of bib preview, based on size of payload. 2016-05-20 09:17:25 +01:00
Henry Oswald
04e70735d2 Merge branch 'master' into clsi-dynamic-load 2016-05-19 16:26:54 +01:00
Henry Oswald
f03a076669 make cash bust add onto object not recreate it 2016-05-19 16:23:56 +01:00
Brian Gough
5497eb86d1 Merge pull request #245 from sharelatex/clean-up-log-requests-in-pdf-controller
clean up log requests, avoid requesting blg file when not present
2016-05-19 16:13:21 +01:00
Shane Kilkelly
0ea16f0bcc Index '.bib' file objects. 2016-05-19 14:58:12 +01:00
Henry Oswald
036b179ffe put the clsiserverid onto qs object for correct server allocation 2016-05-19 13:28:20 +01:00
Henry Oswald
2abebd850c Merge branch 'project_url_query' into clsi-dynamic-load 2016-05-19 13:08:20 +01:00
Shane Kilkelly
b649c13c17 Eliminate weird flicker when loading bibtex 2016-05-19 11:25:24 +01:00