James Allen
6d7f4e9e6a
Add basic comment replying
2016-11-09 15:25:41 +00:00
James Allen
707ed43a7d
Very crude adding of comments
2016-11-09 14:50:58 +00:00
James Allen
446ca7212a
Track timestamps of changes
2016-11-09 12:19:48 +00:00
James Allen
cd494f7866
Update ChangesTracker to handle delete edge case
2016-11-08 17:57:23 +00:00
James Allen
f68c615f61
Remove markers correctly
2016-11-08 17:47:54 +00:00
James Allen
084838926d
Add in dashed line callouts for changes and comments
2016-11-08 17:31:08 +00:00
James Allen
4f8055d998
make sure line 1 changes don't hide under toolbar
2016-11-08 16:51:20 +00:00
James Allen
064ae1945a
Toggle review panel and track changes with ui elements
2016-11-08 16:43:01 +00:00
James Allen
a907ec04fc
Don't complain about comment markers when checking
2016-11-08 15:17:20 +00:00
James Allen
8c65cb5835
Track and highlight comment ranges
2016-11-08 15:12:25 +00:00
Shane Kilkelly
2ff211ce2c
Make sure the $scope.canAddCollaborators
var is initialised at least once, outside of angular $watch
.
2016-11-07 14:36:04 +00:00
James Allen
0b50623d51
Escape \
2016-11-05 11:07:58 +00:00
James Allen
26f9ee7fd3
Escape \
2016-11-05 11:07:07 +00:00
Brian Gough
307f08e6bb
Merge pull request #363 from sharelatex/bg-lock-editor-when-connection-down
...
lock editor when connection down
2016-11-04 11:04:30 +00:00
Brian Gough
476de0118c
Merge pull request #362 from sharelatex/bg-fix-saving-indicator
...
fix saving indicator
2016-11-04 11:02:32 +00:00
Brian Gough
d2ba575d85
note that acks are for our own ops
2016-11-04 10:55:46 +00:00
Brian Gough
c25395d80b
fix links to wiki
2016-11-04 10:25:08 +00:00
Brian Gough
e1b54322ee
fix whitespace
2016-11-04 10:18:33 +00:00
Brian Gough
49a06f8489
modal for lost connection
2016-11-03 12:37:44 +00:00
Brian Gough
91a590ad0e
update links from tender to wiki
2016-11-03 12:28:19 +00:00
Brian Gough
2a8efea29a
use browser 'online' event to trigger reconnect
2016-11-03 12:28:19 +00:00
Brian Gough
87d8192d29
decrease reconnect ratelimit for user activity
2016-11-03 12:28:19 +00:00
Brian Gough
62b8c30d0b
make pollSavedStatus more robust against failure
...
check last ack timestamp and size of pending op
provide method to compute sharejs op size so we can check if pending
ops get too big
2016-11-03 11:28:23 +00:00
James Allen
8763e444e9
Include aceDelta in error message
2016-11-03 11:23:27 +00:00
James Allen
091eb7e462
Merge branch 'master' into ja-review-panel
...
Conflicts:
public/coffee/ide.coffee
public/stylesheets/app/editor.less
2016-11-03 10:07:37 +00:00
Paulo Jorge Reis
74d8fb103b
Merge pull request #358 from sharelatex/pr-latex-linter-onboarding
...
Code-checker onboarding
2016-11-02 13:58:06 +00:00
Paulo Reis
c88cb4574e
Support dismissing the dialog just with Enter.
2016-11-01 16:17:42 +00:00
Brian Gough
b907620fc1
clean up whitespace
2016-11-01 12:19:29 +00:00
Brian Gough
2461c1b7be
add more sl_console debugging to ConnectionManager
2016-11-01 12:19:29 +00:00
Brian Gough
e2c66e8d56
keep track of reconnect timer
2016-11-01 12:19:29 +00:00
Brian Gough
4da9008300
rate limit on reconnection attempts (cursor/click)
2016-11-01 12:19:29 +00:00
Brian Gough
f894048292
fix lastUpdate in ConnectionManager
2016-11-01 12:19:29 +00:00
Brian Gough
d57e191ad0
use socket.io connect method instead of reconnect
...
the reconnect method tries 10 times by default, but we want to manage
reconnections ourselves
2016-11-01 12:06:41 +00:00
Brian Gough
69e957419d
Merge pull request #355 from sharelatex/bg-handle-reconnects
...
wait for confirmation before sending joinProject
2016-11-01 11:50:44 +00:00
Paulo Reis
2c78b5967f
Fix settings logic.
2016-11-01 11:36:05 +00:00
Brian Gough
35259bf9b7
send joinProject after connectionAccepted
2016-11-01 11:17:36 +00:00
Paulo Reis
aa58b70d43
Improve visibility logic.
2016-10-31 20:18:08 +00:00
James Allen
11c24377cb
fix JSONstringifyWithCycles
2016-10-31 16:57:29 +00:00
James Allen
c2eb49845f
Revert "Make very simple shallow copy of aceDelta when there's an undo error"
...
This reverts commit 1d77a95f17dde6f8792bca1989d65952474b144c.
2016-10-31 16:56:49 +00:00
James Allen
26410690da
Make very simple shallow copy of aceDelta when there's an undo error
2016-10-31 16:47:13 +00:00
James Allen
8368577867
Merge branch 'master' into ja-review-panel
...
Conflicts:
app/views/project/editor/editor.jade
public/coffee/ide.coffee
public/coffee/ide/editor/directives/aceEditor.coffee
2016-10-31 16:42:55 +00:00
Paulo Reis
97b92928dc
Merge branch 'master' into pr-latex-linter-onboarding
2016-10-28 16:36:10 +01:00
Brian Gough
8887ab78c0
improve ace mode recognition
2016-10-27 15:42:19 +01:00
Shane Kilkelly
2029ec2535
Merge branch 'sk-plans-tidy'
2016-10-27 10:42:29 +01:00
Brian Gough
cb4380fa78
fix problem with setting syntax validation option
2016-10-26 15:08:29 +01:00
Shane Kilkelly
d912c3b487
Merge branch 'master' into sk-plans-tidy
2016-10-26 13:47:26 +01:00
James Allen
c9925a3590
Handle reporting of cyclic objects to Sentry
2016-10-26 11:34:05 +01:00
Paulo Reis
70c7880639
Style adjustments.
2016-10-26 11:12:34 +01:00
James Allen
032165c930
Merge pull request #349 from sharelatex/ja-real-time-reconnects
...
Reconnect gracefully when asked to by real-time
2016-10-26 10:04:25 +01:00
Paulo Reis
b913118e07
Save the syntax validation setting in the onboarding view.
2016-10-25 15:01:30 +01:00
Paulo Reis
f4849201aa
Merge branch 'master' into pr-latex-linter-onboarding
2016-10-25 15:00:26 +01:00
Paulo Reis
238e07ddde
Save syntax checking as a user setting.
2016-10-25 14:59:20 +01:00
James Allen
43aeb5a21d
Clear SERVERID cookie when reconnecting gracefully
2016-10-25 14:09:36 +01:00
Shane Kilkelly
6069d4dba3
Merge branch 'master' into sk-plans-tidy
2016-10-25 13:14:44 +01:00
James Allen
52754e038a
Reconnect gracefully when asked to by real-time
2016-10-24 16:36:40 +01:00
Paulo Reis
32d59b6212
Add setting saving logic.
2016-10-24 12:20:08 +01:00
Shane Kilkelly
d5a7514923
Add AB test for plans (+15 squashed commits)
...
Squashed commits:
[45c2237] Add a `subscription-form-switch-to-student` event
[1ad9b8f] change experiment name, and re-enable switch-to-student workflow
[f7cdb78] Remove debug
[4b9778a] Incorporate collaborator alternative plans
[701e80b] Add collaborator plans for heron and ibis
[287aa0f] AB test plans from editor page
[c74052e] Fix change-plan view for default plans
[1a947d6] Use correct plan codes
[1eecda7] Adjust prices
[69c4c7b] Introduce two plans
[8b8d5f8] Rename sixpack experiment
[c332002] Fix up the change-plan page
[c7af52d] Overhaul change-plan page, show only plans from current generation
[33d86bf] update plan
[5bbd946] Add a basic plans AB test
2016-10-21 16:17:37 +01:00
Paulo Reis
4d33b11ce5
Restrict the appearance of the onboarding view.
2016-10-21 15:00:52 +01:00
Paulo Reis
777b28b443
Add animation and other styling items. Small refactor with Less vars.
2016-10-21 12:02:53 +01:00
James Allen
2ac405e58c
Allow track changes to be toggled on and off
2016-10-20 16:59:58 +01:00
Paulo Reis
ac07ba035b
Navigation in onboarding UI.
2016-10-20 16:39:43 +01:00
Brian Gough
e9b5fc056d
fold aceEditor resetSession into session set up
...
it is not used elsewhere, and mode setting is now done during the
initialisation.
2016-10-20 16:03:55 +01:00
Brian Gough
7258e947a8
use ace modelist extension to auto-detect mode
2016-10-20 16:03:19 +01:00
James Allen
60a81beb11
Try out different styling for highlights
2016-10-20 15:18:45 +01:00
James Allen
8f9a4882c8
Don't let widgets in review panel overlap
2016-10-20 15:04:10 +01:00
Brian Gough
84f986058a
enable pdfjs cmaps in pdfRenderer
2016-10-20 12:55:58 +01:00
James Allen
2b94c69795
Don't use the trackChanges engine in the history editor panel
2016-10-20 12:19:57 +01:00
James Allen
52f3fe7303
Show different users changes in different colours
2016-10-20 12:15:22 +01:00
Brian Gough
3a07b785db
disable auto insert of brackets and quotes in ace
2016-10-20 11:33:12 +01:00
James Allen
193766b437
Don't switch back to editor view when selecting a file in the history view
2016-10-19 10:43:53 +01:00
James Allen
c88624bf4c
Pass through the data needed to trackChangesManager to determine if a remote was local or remote
2016-10-18 18:01:52 +01:00
James Allen
e717caab7f
Merge branch 'master' into ja-review-panel
2016-10-18 16:52:41 +01:00
James Allen
05cd6e69a7
Add in extra sentry logging for undefined start in aceDelta
2016-10-18 16:37:40 +01:00
Brian Gough
29080bafb2
use PDFJS text layer renderer instead of our own
2016-10-14 12:00:47 +01:00
Brian Gough
c98f40b90b
use a single pdfjs worker, rotated to avoid leaks
2016-10-13 16:10:02 +01:00
Brian Gough
85d8c2ed2e
pass in PDFJS as a module, not global
2016-10-13 16:10:01 +01:00
Brian Gough
71275efebe
remove unused pdf dependency
2016-10-13 16:10:01 +01:00
Brian Gough
27a8dc1dfd
upgrade pdfjs to 1.6.210p1
2016-10-13 16:10:01 +01:00
Brian Gough
f31e3260ee
remove pdfjs special case disableFontFace for MSIE
2016-10-13 16:10:01 +01:00
Brian Gough
4ca918a3b8
render canvas on-screen to avoid bad fonts in MSIE
2016-10-13 14:40:57 +01:00
James Allen
7a4bebd785
Allow review panel to be toggled
2016-10-13 14:22:23 +01:00
James Allen
42ab2e8165
Init review panel with ace editor height
2016-10-13 12:21:49 +01:00
James Allen
77c02042f8
Recalculate change offsets on editor resize
2016-10-13 12:09:18 +01:00
James Allen
8d968f6865
Tidy up ReviewPanelController
2016-10-13 10:09:59 +01:00
James Allen
fc782581ea
Change review panel to feel like part of ace
2016-10-12 17:27:20 +01:00
James Allen
c689937297
Merge pull request #338 from sharelatex/ja-track-changes
...
Ja track changes
2016-10-12 09:21:46 +01:00
James Allen
4ac55c7671
Merge branch 'ja-track-changes' into ja-review-panel
2016-10-11 14:24:51 +01:00
Brian Gough
452f6117cd
remove console.log
2016-10-11 13:56:17 +01:00
James Allen
65bc8a84db
Merge pull request #332 from MCribbin/patch-4
...
Update HumanReadableLogsRules.coffee
2016-10-11 11:11:10 +01:00
James Allen
32d7bb16e5
Be more explicit with query string to turn on track changes
2016-10-11 09:40:15 +01:00
James Allen
9682af3981
Merge branch 'master' into ja-track-changes
...
Conflicts:
public/coffee/ide/history/HistoryManager.coffee
2016-10-10 17:10:10 +01:00
James Allen
0995ba5ee6
Add basic change tracking into editor behind a feature flag
2016-10-10 17:06:46 +01:00
James Allen
1c9abd35f8
Rename track-changes -> history on the client
...
Conflicts:
app/views/project/editor/history.jade
2016-10-10 16:59:25 +01:00
MCribbin
0d5e6e2abf
Update HumanReadableLogsRules.coffee
2016-10-10 13:31:38 +01:00
James Allen
220759ee7a
Merge pull request #330 from sharelatex/ja-non-english-spell-check
...
Use comprehensive unicode letter regex for spell check matching
2016-10-10 08:54:56 +01:00
Brian Gough
2d1a0b34d5
Merge pull request #333 from sharelatex/support-package-versions
...
Support package versions
2016-10-07 15:04:59 +01:00
MCribbin
fba22dc11f
Update HumanReadableLogsRules.coffee
2016-10-06 12:29:42 +01:00
Brian Gough
9177544ed9
add left menu for syntax validator
2016-10-06 11:51:24 +01:00
Brian Gough
837151a395
include moment in package versions
2016-10-05 14:54:42 +01:00
MCribbin
1ce8901c2a
Update HumanReadableLogsRules.coffee
2016-10-05 14:12:49 +01:00
James Allen
201012a131
Use comprehensive unicode letter regex for spell check matching
2016-10-04 11:24:48 +01:00
James Allen
1e1c4ec570
Disable font face in PDFs for IE 11 as well
2016-09-30 15:12:27 +01:00
Brian Gough
0eaa359f6c
use syntax validator for beta programme users only
2016-09-23 15:19:40 +01:00
Brian Gough
d152095920
destroy ace sessions when no longer in use
...
also set mode to "latex" when session is created, to avoid setting mode
to "text" (default) and then to "latex" which causes the text worker to
be unnecessarily created and destroyed.
2016-09-23 15:19:40 +01:00
Brian Gough
0a350c8e3f
infrastructure for using ace syntax checking
2016-09-23 15:19:40 +01:00
James Allen
2b317cab6c
Merge pull request #320 from sharelatex/ja-validate-filenames
...
Don't allow files to be created with / or * characters
2016-09-23 09:42:48 +01:00
Paulo Jorge Reis
f4ff72a2e4
Merge pull request #318 from sharelatex/ja-invite-emails-once
...
Ja invite emails once
2016-09-22 17:36:10 +01:00
James Allen
21f88bb20e
Use ide.validFileRegex, not hard coded regex
2016-09-22 14:57:59 +01:00
James Allen
4386ab1225
Don't allow files to be created with / or * characters
...
Requires the following translations:
"files_cannot_include_invalid_characters": "Files cannot include '*' or '/' characters",
"invalid_file_name": "Invalid File Name"
2016-09-21 16:31:55 +01:00
Brian Gough
de2e0478c6
disable pdfjs fontface on Microsoft Edge
2016-09-21 13:58:14 +01:00
James Allen
bb7985208b
Lower case email before considering if it's duplciated when sharing
2016-09-21 10:48:04 +01:00
Brian Gough
afa910c32d
turn on syntax check for all users
2016-09-06 11:19:32 +01:00
Shane Kilkelly
c8ee803570
fix limits on sharing, account for both members and invites.
2016-09-06 09:37:53 +01:00
Brian Gough
7bf3b9daf9
add event tracking for syntax check
2016-08-26 15:54:01 +01:00
Brian Gough
092d7da479
use Syntax error for consistency in file check
2016-08-25 16:56:06 +01:00
Brian Gough
588be16255
handle try/turn off options for syntax check
2016-08-25 15:52:37 +01:00
Brian Gough
7f20415048
only set compileExited on compile errors
2016-08-24 16:48:45 +01:00
Brian Gough
74bc157e7c
added force recompile option
2016-08-24 16:48:37 +01:00
Brian Gough
4b50505ec9
suppress all cascading chktex environment errors
2016-08-23 11:27:27 +01:00
Brian Gough
6f11c2d7cc
Merge changes to HumanReadableLogsRules
2016-08-23 10:50:01 +01:00
Brian Gough
f26ed03e7d
Merge pull request #299 from sharelatex/roll-out-chktex
...
Roll out chktex
2016-08-23 10:28:58 +01:00
MCribbin
290b1ad134
Update HumanReadableLogsRules.coffee
...
Added corrections to new hints:
-Double subscript
-Double superscript
-LaTeX Error: Something's wrong--perhaps a missing \item
-Misplaced \noalign
2016-08-22 16:33:07 +01:00
Brian Gough
133250c150
extend log hints for more chktex errors
2016-08-18 13:28:47 +01:00
Brian Gough
109e79db99
track cascading errors in Human Readable Log Hints
2016-08-18 13:21:27 +01:00
Brian Gough
090f10e3be
add log hints for new chktex messages
2016-08-18 09:47:57 +01:00
Shane Kilkelly
4805c96584
Merge branch 'master' into pr-email-tokens
2016-08-17 08:52:24 +01:00
Brian Gough
cb4f6391a2
updated comments
2016-08-16 10:59:27 +01:00
Brian Gough
93f69ca0a2
run chktex silently for all users
2016-08-15 16:48:48 +01:00
Brian Gough
7bec656bc2
sort latex output files into order in dropdown
2016-08-15 16:45:33 +01:00
Shane Kilkelly
d40cf6568d
Set invites to empty array
2016-08-15 15:40:16 +01:00
Shane Kilkelly
40cb7e4590
defend against undefined property
2016-08-15 15:19:16 +01:00
Shane Kilkelly
492853f284
Defend against undefined invites and members
2016-08-15 14:56:02 +01:00
Shane Kilkelly
158afbb157
Merge branch 'master' into pr-email-tokens
...
Conflicts:
app/coffee/Features/Notifications/NotificationsBuilder.coffee
public/coffee/ide/share/controllers/ShareController.coffee
2016-08-15 10:29:21 +01:00
Shane Kilkelly
d547bff4e5
Blur the resend
button after response
2016-08-12 11:25:03 +01:00
Brian Gough
7863b7cab6
when calling gotoLine also scrollToLine to put line in view
2016-08-11 16:46:30 +01:00
Brian Gough
daa1d80865
add extra delay to gotoLine event
2016-08-11 16:46:12 +01:00
Paulo Reis
6a3372fcbf
Use new event tracking methods.
2016-08-10 17:33:56 +01:00
Brian Gough
abcfb2dd16
Merge pull request #290 from sharelatex/enable-chktex
...
Enable chktex
2016-08-10 11:49:31 +01:00
Shane Kilkelly
d59b51aacd
Add error handlers.
2016-08-05 14:09:37 +01:00
Shane Kilkelly
eafd61a90e
Refresh members and invites in client when status changes
2016-08-05 14:01:08 +01:00
Shane Kilkelly
8f7603c324
Add an endpoint to access project members
2016-08-04 16:47:48 +01:00
Paulo Jorge Reis
60f8e577a8
Merge pull request #293 from sharelatex/pr-wrap-long-words-chat
...
Wrap long words chat
2016-08-03 16:32:36 +01:00
Shane Kilkelly
721ea88bd0
If email is already invited, resend the invite
2016-08-03 16:30:34 +01:00
Paulo Reis
cf5c8e27e1
UI fix - do not allow multiple clicks to restore a deleted file.
2016-08-03 16:05:19 +01:00
Shane Kilkelly
a5ddcc3df7
Allow resending of invites
2016-08-03 15:42:19 +01:00
Paulo Reis
216779fafe
Track-changes usage.
2016-08-03 12:36:42 +01:00
Paulo Reis
e6898d64c9
Track hovering of header features.
2016-08-03 12:17:19 +01:00
Shane Kilkelly
8cb93511df
Update UI of share modal
2016-08-03 11:55:24 +01:00
Shane Kilkelly
dca1c9be5d
Load invites on project load, rather than asynchronously.
2016-08-01 17:05:37 +01:00
Paulo Reis
ff62e50530
Integrate word wrapping filter in the chat component.
2016-08-01 16:42:54 +01:00