github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-10-31 21:21:03 -04:00
Code Issues Projects Releases Packages Wiki Activity
17798 commits 3 branches 7 tags 199 MiB
Commit graph

17798 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jakob Ackermann
f80a92ce46 [misc] migrate the app to the native mongo driver 
acceptance tests to follow in a separate commit
 2020-08-28 15:12:30 +01:00
Jakob Ackermann
4960bdd6fe [misc] re-level log: 404 from web -> WARN and emit 'project not found' 
A stale browser tab tried to join a deleted project.
Emitting 'project not found'/'ProjectNotFound' will trigger a page
 reload in the frontend, upon web can render a 404.
See frontend: ConnectionManager.joinProject callback
 2020-08-27 11:51:57 +01:00
Jakob Ackermann
55d938ba14 [misc] add tests for web replying with a 404 for joinProject 2020-08-27 11:51:56 +01:00
Jakob Ackermann
884b340c75 [misc] re-level log: 403 from web goes to WARN and emit 'not authorized' 
Users will get redirected to the login page and will see a 'restricted'
 page after logging in again.
See frontend: ConnectionManager.reportConnectionError
 2020-08-27 11:51:56 +01:00
Jakob Ackermann
d2a2b9d46e [misc] add tests for web replying with a 403 for joinProject 2020-08-27 11:51:56 +01:00
Jakob Ackermann
1ff9c1e71b [misc] add the rpc-method into the log context in Router._handleError 2020-08-27 11:51:55 +01:00
Jakob Ackermann
0647abf433 [misc] drop info-log in WebApiManager for joinProject being rate-limited 
The CodedError is logged at warn-level in Router._handleError.
 2020-08-27 11:51:09 +01:00
Jakob Ackermann
2ce7b36c95 [misc] drop duplicate log line for unauthorized applyOtUpdate calls 
The violation is logged in Router._handleError.
 2020-08-27 10:22:31 +01:00
Jakob Ackermann
dee4749e6d [misc] re-level log: properly silence unauthorized updateClientPosition 2020-08-27 10:11:40 +01:00
Simon Detheridge
4415f77b18 Merge pull request #3140 from overleaf/ho-swallow-deactive-project-err 
if deactivateProject errors, continue the deactivateOldProjects jobs

GitOrigin-RevId: b3c2584e0a042cb3c78e609314c320a9b657640c
 2020-08-27 02:04:13 +00:00
Simon Detheridge
38cc0488b1 Merge pull request #65 from overleaf/spd-migration-script 
Add script to migrate data from S3
 2020-08-26 12:58:50 +01:00
Simon Detheridge
f9862081b7 Add script to migrate data from S3 2020-08-26 11:46:40 +01:00
Hugh O'Brien
b48b937f26 Merge pull request #3133 from overleaf/hb-fix-bibtex-error-crash 
Stop bib log parser after 500 iterations per parser

GitOrigin-RevId: 415624c20154b4fd4054f166179cd455a7cc2d4d
 2020-08-26 02:04:45 +00:00
Miguel Serrano
7f5ac7a932 Merge pull request #3139 from overleaf/revert-3116-msm-pdfjs-2-4 
Revert "Update pdf.js to 2.4.456"

GitOrigin-RevId: 73c9d3fc7b7d746a36ac90c1bf85e2b6d9ca1ec9
 2020-08-26 02:04:40 +00:00
Hugh O'Brien
3aaab7270c Merge pull request #3116 from overleaf/msm-pdfjs-2-4 
Update pdf.js to 2.4.456

GitOrigin-RevId: 29ce64acd44914b2f890f7b05c77ef890c315d01
 2020-08-26 02:04:35 +00:00
Hugh O'Brien
3825475aea Merge pull request #3132 from overleaf/hb-update-leaving-email 
Update cancel subscription email

GitOrigin-RevId: c3226a760e5e71483788bdb99fc355e3e8c829eb
 2020-08-26 02:04:29 +00:00
Jakob Ackermann
425052ff91 Merge pull request #187 from overleaf/jpa-o-error-tagging 
[misc] migrate to OError tagging/wrapping
 2020-08-25 11:46:28 +02:00
Jakob Ackermann
64e659bf43 Merge pull request #186 from overleaf/jpa-fix-join-project-error-context 
[misc] fix join project error context
 2020-08-25 11:46:18 +02:00
Jakob Ackermann
849a1cf416 Merge pull request #185 from overleaf/jpa-doc-id-in-error-context 
[misc] add/bring back doc_id in error context
 2020-08-25 11:42:41 +02:00
Jakob Ackermann
735027a2b7 Merge pull request #184 from overleaf/jpa-custom-errors 
[misc] migrate to custom OErrors
 2020-08-25 11:42:19 +02:00
Jakob Ackermann
6df23a9712 Merge pull request #183 from overleaf/jpa-increase-unit-test-timeout 
[misc] increase the timeout for unit tests -- CI boxes are too slow
 2020-08-25 11:41:53 +02:00
Jakob Ackermann
ed0426478c Merge pull request #66 from overleaf/jpa-mongodb-native 
[misc] migrate to the native mongo driver
 2020-08-25 11:00:34 +02:00
Jakob Ackermann
2fa09928ee [misc] migrate acceptance tests to the native mongo driver, drop mongojs 2020-08-25 09:41:23 +01:00
Jakob Ackermann
df0747ec48 [misc] migrate the app to the native mongo driver 
acceptance tests to follow in a separate commit
 2020-08-25 09:40:59 +01:00
Jakob Ackermann
b5e770daff Merge pull request #56 from overleaf/jpa-wait-for-db 
[misc] simplify the naming around waiting for a mongo connection
 2020-08-25 10:20:37 +02:00
Jessica Lawshe
bde7ef600f Merge pull request #3138 from overleaf/jel-csrf-fix 
Fix validateToken signature

GitOrigin-RevId: fbedaa76ec0fa2134a08aa43c28c3756f8a2afe6
 2020-08-25 02:04:34 +00:00
CloudBuild
2cd5bcca60 auto update translation 
GitOrigin-RevId: cea732cc8dd7106771beecc5d30cd4bffe276698
 2020-08-25 02:04:28 +00:00
Timothée Alby
cc218c98c2 Merge pull request #3098 from overleaf/jel-dropbox-tidy 
Tidy DropboxUserController and DropboxHandler

GitOrigin-RevId: f492b35af06d02b6401b99467e887a92d5335b56
 2020-08-25 02:04:23 +00:00
Timothée Alby
1ff2c6ce00 Merge pull request #3117 from overleaf/sk-block-tpds-update-on-archived-project 
Block TPDS update on archived/trashed project

GitOrigin-RevId: 7db41a313b03721b93cbb601add6f91ae31f3f2a
 2020-08-25 02:04:17 +00:00
Timothée Alby
750a20491d Merge pull request #3131 from overleaf/pr-fix-context-menu-placement-folders 
Fix ellipsis icon placement in folders

GitOrigin-RevId: 4004ed43c8dd138e8f774d660e712bc7076e8b62
 2020-08-25 02:04:12 +00:00
Timothée Alby
bc90ffb1e8 Merge pull request #3105 from overleaf/ta-outline-go-to-pdf 
[Outline] Go To PDF on Double-Click

GitOrigin-RevId: 0be4207eb26d0712814097b71906b3c9c37d4790
 2020-08-25 02:04:05 +00:00
Jakob Ackermann
39ea30355e [misc] simplify the naming around waiting for a mongo connection 
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com>
Co-Authored-By: Miguel Serrano <mserranom@gmail.com>
Co-Authored-By: Simon Detheridge <s@sd.ai>
 2020-08-24 17:41:03 +01:00
Jakob Ackermann
ee3d3b09ed [misc] wrap redis errors as tagging does not work with them 
ioredis may reuse the error instance for multiple callbacks. E.g. when
 the connection to redis fails, the queue is flushed with the same
 MaxRetriesPerRequestError instance.
 2020-08-24 10:12:20 +01:00
Jakob Ackermann
537e97be73 [misc] OError.tag all the errors in async contexts 
See the docs of OError.tag:
https://github.com/overleaf/o-error#long-stack-traces-with-oerrortag
(currently at 221dd902e7bfa0ee92de1ea5a3cbf3152c3ceeb4)

I am tagging all errors at each async hop. Most of the controller code
 will only ever see already tagged errors -- or new errors created in
 our app code. They should have enough info that we do not need to tag
 them again.
 2020-08-24 10:12:06 +01:00
Jakob Ackermann
8e31cc5c23 [Router] _handleError: joinProject error-context may not have project_id 
The ol_context patch changed the priority of client context and rpc
 context.
This lead to the (possibly missing) project_id of the client context
 overwriting the project_id of the rpc context.
REF: f1d55c0a5437a518e9f4617473caed9ba928e648
 2020-08-21 13:29:28 +01:00
Jakob Ackermann
f935b1881a [Router] leaveDoc: pass the doc_id into the error-context 2020-08-21 12:47:42 +01:00
Jakob Ackermann
fd88819eec [Router] _handleError: ol_context.doc_id does not exist, drop overwrite 2020-08-21 12:47:42 +01:00
Jakob Ackermann
880056d397 [Router] use a new UnexpectedArgumentsError 2020-08-21 12:47:08 +01:00
Jakob Ackermann
50140f785a [WebsocketController] use a new JoinLeaveEpochMismatchError 2020-08-21 12:47:08 +01:00
Jakob Ackermann
0462e3e437 [WebsocketController] use a new NotJoinedError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
4cb8cc4a85 [DocumentUpdaterManager] use a new ClientRequestedMissingOpsError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
8abfdb87ff [DocumentUpdaterManager] use a new DocumentUpdaterRequestFailedError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
02a2382264 [WebApiManager] use a new CorruptedJoinProjectResponseError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
68bc9d0d23 [WebApiManager] use a new WebApiRequestFailedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
59c4c884a5 [WebsocketController] use the new NotAuthorizedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
a8c51de510 [AuthorizationManager] use a new NotAuthorizedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
de518ea4eb [SessionSockets] use a new MissingSessionError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
6828becb46 [DocumentUpdaterManager] use a new NullBytesInOpError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
af50f9b02c [DocumentUpdaterManager] use a new UpdateTooLargeError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
5950b26a42 [SafeJsonParse] migrate to OError and use a new DataTooLargeToParseError 2020-08-21 12:47:05 +01:00