Commit graph

3460 commits

Author SHA1 Message Date
Antoine Clausse
d6de6da781 [web] Migrate the file view to Bootstrap 5 (#20765)
* [web] Remove unnecessary divs around `fileInfo`

* [web] Add file-view SCSS style

* [web] Simplify `TPRFileViewInfo`

* [web] Add div for action buttons

* [web] Misc. simplifications

* [web] Add Overleaf logo in bg when selecting multiple files

* [web] Add message when multiple files are selected

* [web] Add .full-size class

* [web] Import styles from LESS file

* [web] Update icons, use MaterialIcon

* [web] Use OLButton

* [web] Add missing space between icons and text

* [web] Adjust margins

* [web] Fix alert button

* [web] Update Alerts

* [web] Update `FileViewLoadingIndicator`

* [web] Fix test "shows a loading indicator..."

This was failing because `LoadingSpinner` is shown after a setTimeout.
Maybe we can skip this setTimeout when delay==0 ?

* [web] Remove Row/Col around error notifications

* [web] Replace `!!` by `Boolean`

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* [web] Use `alert` class in BS3 only

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Update "Go to settings" to OLButton

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Use `BootstrapVersionSwitcher` instead of `isBootstrap5`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Align Alert content to the left in BS5

* [web] Remove `leadingIcon` on Refresh buttons

* [web] Make the download link be an OLButton

* [web] Set `tpr-refresh-error` in BS3 only

Co-authored-by: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>

* [web] Use `var(--white);` instead of `white`

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [web] Update OLButton size (small -> sm)

---------

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
Co-authored-by: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>
Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 04f369c0f1a53d47619a1570648ee58de5050751
2024-10-14 11:07:55 +00:00
Antoine Clausse
2e080a3a34 [web] Migrate IDE page loading screen to BS5 (#20896)
* [web] Add `.loading-screen` style

* [web] Add `.loading-screen-error` style

* [web] Nest styles in `.loading-screen`

* [web] Simplify code, make a more valuable Storybook

* [web] Add a reusable bootstrap-switcher argument to loading.stories.tsx

* [web] Make `isBootstrap5()` work in storybook

* [web] Revert unrelated changes around `ConnectionError` type

* [web] Remove comment about unhandled error codes

https://github.com/overleaf/internal/pull/20896/files#r1790572314

* [web] Don't repeat the `errorCode` prop type

* [web] Remove unused CSS and magic padding

* [web] Fixup SCSS division

* [storybook] Revert Storybook changes (moved to another branch)

* [web] Fixup SCSS division again (lint)

* [web] Render with `Boolean(errorCode) && ...` instead of `errorCode && ...`

* [web] Remove importants; use spacing var

Addresses Tim's comments

GitOrigin-RevId: e8b5623f4bb9aa72a255851f46b45b652a0dbb16
2024-10-14 11:07:50 +00:00
Antoine Clausse
b054342ddb [web] Update bsVersion to return its arguments types (#20963)
* [web] Update `bsVersion` to return its arguments types

* [web] Remove `as string` after `bsVersion` calls

GitOrigin-RevId: 604ce87aaccd709299124a986e98cf45874484bb
2024-10-14 11:07:45 +00:00
Antoine Clausse
4a8b79080b [storybook] Update Storybook and add a control for BS3/BS5 (#20948)
* [storybook] Update Storybook to version 8.3.5

* [storybook] Run storybook with `--no-open`. Fixes xdg-utils issue

* [storybook] Create decorator for BS3/BS5

* [storybook] Add `bsVersionDecorator` to stories

* [storybook] Fix bugs in stories

* [storybook] Fixup `useMeta` type. Use `DeepPartial`

* [storybook] Fix types

GitOrigin-RevId: 48c0f0fefb1ab2d4863ab59051b900b1908a613c
2024-10-14 11:07:40 +00:00
ilkin-overleaf
4f838ccacf Merge pull request #20824 from overleaf/ii-bs5-share-modal
[web] BS5 share modal

GitOrigin-RevId: 40a33e06eab720b568d31aefa021682535b6934e
2024-10-14 11:07:31 +00:00
ilkin-overleaf
6c7ee8f778 Merge pull request #20715 from overleaf/ii-bs5-chat-pane
[web] BS5 chat pane

GitOrigin-RevId: 8587aca1372b4d2087863d492e702f04a31c23e2
2024-10-14 11:07:26 +00:00
Brian Gough
4a32f49b3d add an option to remove chat from server pro (#20445)
* add option to remove chat from backend

* make chat default to enabled

* Check chat is enabled in chat context

---------

Co-authored-by: mserranom <mserranom@gmail.com>
GitOrigin-RevId: 7dda09df4bb74007eb4b1272d4918155b5cddaf6
2024-10-14 11:07:02 +00:00
Alf Eaton
53d6b4dfd0 Set workerPublicPath in webpack config (#20629)
GitOrigin-RevId: 3fba33a6b52bf2a91f3126efc9d76f6f1dfbc1c4
2024-10-14 11:06:45 +00:00
Jimmy Domagala-Tang
c6aec5c5c0 Merge pull request #20598 from overleaf/jdt-ae-dropbox-limit-notif
Add go to project for 2000 file limit notification

GitOrigin-RevId: dfd69773ebd5c2160dfce75f56b8fa1e93792c23
2024-10-14 11:06:26 +00:00
ilkin-overleaf
92eade7502 Merge pull request #20708 from overleaf/ii-bs5-pdf-toolbar
[web] BS5 pdf toolbar

GitOrigin-RevId: a04091c9e936e52f47c3977b3149ffe613d43bb9
2024-10-14 11:06:17 +00:00
David
037529f243 Merge pull request #20886 from overleaf/dp-overview-file-counts
Check that thread has messages in overview comment count

GitOrigin-RevId: 8499f837a016256c5ca615172b5c53a7f2e7c6b5
2024-10-14 11:05:53 +00:00
David
d9211998de Merge pull request #20887 from overleaf/dp-rp-entry-buttons
Don't focus entry if clicking on a button/link

GitOrigin-RevId: 0c37ce76134358ef7d3fd5b0c897ffab8e4d7db1
2024-10-14 11:05:48 +00:00
David
43bb8c0ab2 Merge pull request #20803 from overleaf/dp-resolved-comments-scroll
Add a max-height and scroll to tracked changes menu

GitOrigin-RevId: 93d4be0f057f4785a8d383f718078619467f3e2a
2024-10-14 11:05:43 +00:00
Mathias Jakobsen
58b52db56d Merge pull request #20903 from overleaf/mj-load-write-and-cite-with-autocomplete
[web] Load Write and Cite with AutoComplete

GitOrigin-RevId: b496874447b00723410df01a96ea66aa8ec4da3c
2024-10-14 11:05:39 +00:00
Alf Eaton
139fde750a Add feedback link in spelling suggestion footer (#20867)
GitOrigin-RevId: 3bef428f810b88f56a76e3645cebcf22dd5ad9e3
2024-10-14 11:05:21 +00:00
Alf Eaton
e99ae3a459 Add Hunspell README (#20872)
GitOrigin-RevId: 0b02a1a03e467d0857766e70e3a3862f939c773c
2024-10-14 11:05:17 +00:00
Alf Eaton
a1ea50ded3 Load hunspell.wasm from the CDN (#20856)
GitOrigin-RevId: 0fcbc2102e280222ab4b9279f02c820a3b904496
2024-10-14 11:05:12 +00:00
M Fahru
209a3670ce Merge pull request #20827 from overleaf/mf-bs5-previous-page-link-hover
[web] Add hover effect to `.previous-page-link` class

GitOrigin-RevId: ccba4cb22274695a2a3b63abcf86d7bc0c6dec61
2024-10-14 11:04:18 +00:00
M Fahru
2a99415c69 Merge pull request #20829 from overleaf/mf-blog-list-title-link-size
[web] Reduce blog title link size on bootstrap 5 blog list page

GitOrigin-RevId: cd22fef67488c5b8d291c358e812e0d94cb303ef
2024-10-14 11:04:13 +00:00
M Fahru
5d2eac5694 Merge pull request #20851 from overleaf/mf-bs5-pagination
[web] Bootstrap 5 pagination

GitOrigin-RevId: b3709a3f016423e7df12d6dfdf2cb4e47efbffe2
2024-10-14 11:04:09 +00:00
Andrew Rumble
ee8c13ec7e Ensure gov banner defined before use
GitOrigin-RevId: 1db97fd4882600f8e6764273bbcbec503b68f01e
2024-10-14 11:03:55 +00:00
Davinder Singh
f2c167a026 CMS BS5 migration - Adding the left spacing to the labels next to checkbox (#20780)
* adding left-margin for the checkbox-label

* moving the styling to appropriate file and making it more generic

GitOrigin-RevId: 66484344891c77f6d31147ef7d0e0d55987a8445
2024-10-14 11:03:50 +00:00
Davinder Singh
d61997373f BS5 Migrations CMS - Adding the pattern card at the end of the blog page (#20739)
* adding existing pattern card content and styling with commented code to avoid breaking the compiler

* removing extra styling that is not needed

* using variables

* removing event segmentation and adding URLs

* adding a translation for tthe ext

* adding a translation for explore_all_plans

* adding translation sign_up_for_free

* adding the card on blog post page

* adding card-body to match BS5 and removing extra padding from .cta-card

* adding p and removing margin from .font-size-display-xs

* removing cta-card-text class

* removing margin-top from responsive-button-container and adding the usage of .p-no-text-nodes with p

* removing gap and margin responsive-button-container

* removing extra padding

* adding font-size and line-height to match figma design

* changing the breakpoint to lg

* removing important keyword

* making explore plans button as primary and hiding signup button when user is logged in

* removing responsive-button-container

* adding count variable in the translation

* moving font-size-display-xs one level lower

* adding span under p

GitOrigin-RevId: a1a16d46a725b547bda6e452ff1c7bef05964690
2024-10-14 11:03:45 +00:00
David
50723d0f8f Merge pull request #20840 from overleaf/dp-review-panel-split-test-badge
Add split test badge to new review panel for beta release

GitOrigin-RevId: 863b7614fc6b68aebc15dbc9bfec5014499af817
2024-10-14 11:03:05 +00:00
David
5fd2b63258 Merge pull request #20811 from overleaf/dp-more-comments-mini
Hide more comments button in mini review panel

GitOrigin-RevId: c41b303e36dfb2fbb0decaecd0e3d63f49568d6b
2024-10-14 11:03:00 +00:00
David
175a4d024d Merge pull request #20805 from overleaf/dk-fix-focus-highlight
Fix focus highlight decoration for new review panel

GitOrigin-RevId: c69ba8dd8527b6c3797b1e986cfd87c1ca87da6d
2024-10-14 11:02:55 +00:00
David
fac379b3a8 Merge pull request #20733 from overleaf/dp-align-change-icon
Align change icon with first line of change

GitOrigin-RevId: 319ed7ba7984fae52f31bd37a6d718ca07aa9009
2024-10-14 11:02:50 +00:00
David
a40fb42fed Merge pull request #20712 from overleaf/dp-click-mini-panel
Clicking on an entry in the mini review panel opens the full panel

GitOrigin-RevId: 4c925435a09f56ae5b02c53951185c67eb0413a2
2024-10-14 11:02:44 +00:00
David
b2dab4b1c0 Merge pull request #20709 from overleaf/dp-search-wrapping
Wrap search controls on small editor widths

GitOrigin-RevId: 513d046ba2951daf13385f48b73704e6feccd7d0
2024-10-14 11:02:40 +00:00
David
4480a986a3 Merge pull request #20785 from overleaf/dp-sticky-highlights
Clear op highlight on review-panel-entry dismount

GitOrigin-RevId: 9892df75f35fcb0440bd19bcfbaa276a3db033a1
2024-10-14 11:02:35 +00:00
roo hutton
551de499d5 Merge pull request #20802 from overleaf/rh-change-personal-plan
[web] Remove personal plans from 'change plans' table

GitOrigin-RevId: 284573cf3d5d38b1964d10fe6451b1468c90ff84
2024-10-14 11:02:24 +00:00
M Fahru
16ba4b0ddf Merge pull request #20371 from overleaf/mf-us-gov-banner
[web] Add US gov banner based on inclusion and exclusion criteria

GitOrigin-RevId: c45ed280c8ef2dbdf9f3b84488e767c06fcc1ae1
2024-10-14 11:02:15 +00:00
M Fahru
f3cb79c12f Merge pull request #20777 from overleaf/as-cms-mobile-grid
Add support for specifying a mobile grid

GitOrigin-RevId: 1e9c30873d51a6cdd0b802bf6a9caf6207f07d72
2024-10-14 11:02:07 +00:00
M Fahru
20846a89a1 Merge pull request #20793 from overleaf/jel-cms-card-top-margin
[web] Apply vertical spacing between cards on CMS pages

GitOrigin-RevId: c03ae91d1de081013e8318dd80b90ef508cb5b4f
2024-10-14 11:01:59 +00:00
M Fahru
2d070ec901 Merge pull request #20796 from overleaf/jel-cms-container-width
[web] Switch to class instead of inline style for `max-width` on CMS rows

GitOrigin-RevId: 26517f7c3e6b09078d133920c380da1283e38736
2024-10-14 11:01:51 +00:00
M Fahru
04de9f28a2 Merge pull request #20754 from overleaf/mf-bs5-blog-list-style
[web] Implement Bootstrap 5 blog list style

GitOrigin-RevId: 1a343fa844cd8b22483097a470f5108ec9bcd914
2024-10-14 11:01:46 +00:00
M Fahru
163966bbb6 Merge pull request #20722 from overleaf/mf-bs5-blog-post-style
[web] Implement boostrap-5 blog post style

GitOrigin-RevId: b9dbe4952726e4260a0fcb95c8e54d7bd2db0415
2024-10-14 11:01:42 +00:00
Mathias Jakobsen
1c39f0d795 [web] Add survey link to ARS Write and cite (#20639)
GitOrigin-RevId: 97786a2ae4e80c4493981eabe948a4eb54e9943f
2024-10-14 11:01:37 +00:00
Alf Eaton
a9fac2370b Upgrade Sentry SDK (#20806)
GitOrigin-RevId: 70cfbfd7f2ae61bbc865d32c576aa8f195837fb5
2024-10-14 11:01:28 +00:00
Alf Eaton
17e8c70069 Use non-legacy build of PDF.js
GitOrigin-RevId: 473dc8657bac01fc4fc7b94565b10ff939e7fcdd
2024-10-14 11:01:04 +00:00
Alf Eaton
df6147bb4d Convert PDF.js code to TypeScript
GitOrigin-RevId: 840bc48816d78497131b927522b4f6f7940bb0c4
2024-10-14 11:00:45 +00:00
Alf Eaton
5e7f4feeb8 Remove pdfjs-dist split test
GitOrigin-RevId: 39c8a54921c2b541a5bbe3670e1baa6fd9d5f745
2024-10-14 11:00:36 +00:00
Tim Down
90904e876c Merge pull request #20718 from overleaf/td-bs5-update-foundations
Update BS5 Foundations Sass to match Figma

GitOrigin-RevId: 23712486ea497f4bfac643e47171baf076ca77af
2024-10-14 11:00:24 +00:00
Jessica Lawshe
76b9058acb Merge pull request #20535 from overleaf/as-cms-large-black-link
[web] CMS - Add styles for large black link with angled arrow

GitOrigin-RevId: d33f6b121d51619cd373c4ede2266f7ef4da2754
2024-10-14 11:00:20 +00:00
Jessica Lawshe
fd5e1df2e1 Merge pull request #20759 from overleaf/jel-cms-col-gap
[web] Replace margin on `Style | Group` with gap on `Layout | Grid`

GitOrigin-RevId: 297a5c9f6953a22818de31062f8ad5258db4691b
2024-10-14 11:00:15 +00:00
David
2117bfe29d Merge pull request #20541 from overleaf/dk-delete-widgets
Handle highlight/focus effects for track deletes in new review panel

GitOrigin-RevId: 102eed9e8af04599823c1bcf0598a0328901bdba
2024-10-14 10:59:47 +00:00
David
4c334b4b45 Merge pull request #20776 from overleaf/dp-resolve-lint
Provide empty decoration set to useMoreComments when addCommentRanges is undefined

GitOrigin-RevId: 40b7ae41ef783586d4304f2896397d8e84628e18
2024-10-14 10:59:42 +00:00
David
56d396a6cf Merge pull request #20617 from overleaf/dk-review-indicator-hover
Improve "mini" view popovers for new review panel

GitOrigin-RevId: ff5fc0af70bd9660d5cc17437b25824ef4c9a704
2024-10-14 10:59:38 +00:00
David
46198cd780 Merge pull request #20688 from overleaf/dk-fix-wrong-rangesdata
Fix "RangeError" when switching files using new review panel

GitOrigin-RevId: 399c8722584053c62acf5c413572fbbcdd1896cc
2024-10-14 10:59:33 +00:00
David
a331ac6116 Merge pull request #19796 from overleaf/dp-more-comments-2
Add More Comments buttons

GitOrigin-RevId: 3cd6539683cbc53ceb63488ab9e9b0ffe53e079c
2024-10-14 10:59:29 +00:00