James Allen
31ae2e7124
Update RangesTracker
2017-02-17 09:24:25 +01:00
James Allen
c8a6555cb1
Update RangesTracker
2017-02-16 17:07:56 +01:00
James Allen
04b9f8d249
Merge branch 'master' into ja-track-changes
2017-02-16 17:07:12 +01:00
Paulo Reis
a639f13cb6
Bootstrap collapsing behavior in files list. Store state.
2017-02-16 15:48:58 +00:00
Paulo Reis
36e5ac74dc
Give the scrollbar a background-color, so that Safari knows that it should paint it.
2017-02-15 15:11:01 +00:00
Henry Oswald
bb7ededaaf
announcementClicked -> logAnnouncementClick
2017-02-15 12:43:13 +00:00
Henry Oswald
8cd3d21792
track read more clicks in announcements
2017-02-15 12:17:10 +00:00
James Allen
d01d6a35cf
Only create Controller when showing onboarding
2017-02-15 09:47:37 +01:00
James Allen
bdee15128b
Remove click handler on dismiss
2017-02-14 22:31:49 +01:00
Paulo Reis
badc4ecb7a
Show add comment tooltip to the left when appropriate.
2017-02-14 14:40:21 +00:00
James Allen
4dbc2c3066
Merge pull request #418 from sharelatex/pr-review-panel-onboarding
...
Pr review panel onboarding
2017-02-14 15:00:39 +01:00
James Allen
b48f57c2cb
Submit comment on blur or selection change
2017-02-14 13:41:04 +01:00
Paulo Reis
594f2024d1
Style the onboarding prompt as a modal; close it when clicked outside.
2017-02-14 12:09:05 +00:00
James Allen
cc0986b4da
List track changes in beta program
2017-02-14 12:22:53 +01:00
Paulo Reis
12730caa63
Make the dismiss option more obvious.
2017-02-14 11:22:53 +00:00
Paulo Reis
1eed10b4e7
Add keyboard navigation
2017-02-14 10:21:45 +00:00
James Allen
c08c8e09ff
Only show onboarding for users with track changes enabled
2017-02-14 11:09:37 +01:00
James Allen
03ecf4b4ae
Only show track changes onboarding once based on analytics API events
2017-02-14 10:25:46 +01:00
James Allen
61ef158f76
Don't show review panel if user doesn't have track changes
2017-02-14 09:38:58 +01:00
James Allen
c8baae84da
Merge branch 'pr-review-panel-onboarding' of github.com:sharelatex/web-sharelatex into pr-review-panel-onboarding
2017-02-13 16:51:16 +01:00
Paulo Reis
7dd9a3fa44
Add a dismiss button.
2017-02-13 15:49:58 +00:00
James Allen
6a4f0ace3b
Merge branch 'master' into pr-review-panel-onboarding
2017-02-13 16:19:56 +01:00
James Allen
bf5f5f832d
Use correct flag for determining mini panel visibility
2017-02-13 14:39:43 +01:00
James Allen
f840a20f5c
Merge pull request #417 from sharelatex/pr-track-changes-upgrade-prompt
...
Turn on track changes for beta users with upgrade prompt
2017-02-13 12:44:04 +01:00
James Allen
3334078fe6
Merge pull request #415 from sharelatex/ja-track-changes
...
Don't animate review panel entries on toggle and resize
2017-02-13 12:17:45 +01:00
James Allen
e99c9a2065
Enable track changes for beta users
2017-02-13 12:09:47 +01:00
James Allen
47a66eed50
Merge branch 'ja-include-track-changes-feature' into pr-track-changes-upgrade-prompt
2017-02-13 11:50:56 +01:00
James Allen
a9c89635bd
Also scroll long deletes and insertions if would overflow
2017-02-13 10:16:16 +01:00
James Allen
f590b9c97a
Scroll when long words would overflow comment entry
2017-02-13 10:09:35 +01:00
James Allen
85c2910738
Don't animate review panel entries on toggle and resize
2017-02-13 09:49:51 +01:00
Paulo Reis
52c601965b
Improve button styling and paragraph width.
2017-02-10 15:28:57 +00:00
Paulo Reis
481f9bbadc
Add re-encoded videos (all forced to have the same size).
2017-02-10 15:28:22 +00:00
Paulo Reis
a8a7589973
More style adjustments.
2017-02-09 17:13:23 +00:00
Paulo Reis
dd15cc06a0
Integrate playback state directive in tutorial videos; style adjustments.
2017-02-09 15:44:38 +00:00
Paulo Reis
1263532271
Add a directive to control the playback state of media elements.
2017-02-09 15:44:15 +00:00
Paulo Reis
d137b00822
Relayout the onboarding, making a video slideshow.
2017-02-08 17:19:29 +00:00
Paulo Reis
1ef5cc97fc
Rename stuff to refer to the new onboarding feature.
2017-02-08 17:19:13 +00:00
James Allen
51b76d2cf9
Merge pull request #413 from sharelatex/ja-abort-in-progress-spell-checks
...
Abort any inprogress spell checks when switching document
2017-02-08 11:38:05 +01:00
James Allen
87aea41bed
Abort any inprogress spell checks when switching document
2017-02-08 11:32:19 +01:00
James Allen
d44a0ece97
Merge pull request #411 from sharelatex/ja-fix-cursor-on-resize
...
Ja fix cursor on resize
2017-02-08 11:30:37 +01:00
James Allen
123300cdfb
Clear highlighted word manager on session change
2017-02-08 11:08:26 +01:00
James Allen
f6743b839f
Reflow review panel as editor pane changes size
2017-02-07 16:45:45 +01:00
Paulo Reis
6d35703963
Add clip showing review panel toggling.
2017-02-07 15:28:50 +00:00
Paulo Reis
d792230bf0
Basic onboarding tutorial for track-changes.
2017-02-07 15:07:26 +00:00
James Allen
11a104ef96
Move spelling marker to back marker layer where it is updated properly by Ace
2017-02-07 15:55:00 +01:00
James Allen
c1a2779d9e
Merge branch 'master' into ja-fix-cursor-on-resize
2017-02-07 15:27:01 +01:00
James Allen
d00619ff3d
Keep the cursor in the same position on screen when the editor resizes
2017-02-07 15:23:44 +01:00
Paulo Reis
73835f004d
Add onboarding-related assets.
2017-02-07 14:13:25 +00:00
James Allen
1b06af766d
Merge pull request #406 from sharelatex/pr-expandable-text-area-fixes
...
Expandable text area fixes
2017-02-07 09:04:10 +01:00
James Allen
c97ded201f
Merge pull request #408 from sharelatex/ja-track-changes
...
Clear selection after creating a comment
2017-02-07 08:55:39 +01:00
Paulo Reis
38e1b66fdc
Use slightly slower video.
2017-02-06 14:06:08 +00:00
Joe Green
a32ec78a54
added about image for jg
2017-02-06 11:59:32 +00:00
Paulo Reis
d19cb2a31b
Fix border-radius in entries.
2017-02-03 15:20:50 +00:00
James Allen
4a80f0de5a
Clear selection after creating a comment
2017-02-03 15:09:40 +00:00
James Allen
343abfde23
Use user feature flags to determine track changes state
2017-02-03 14:36:11 +01:00
James Allen
27c48f3790
Clear selection after creating a comment
2017-02-03 14:17:09 +01:00
Paulo Reis
6ef8d2d46d
Merge branch 'master' into pr-expandable-text-area-fixes
2017-02-02 14:38:09 +00:00
Paulo Reis
9d1d2df977
Disable mocked feature flag behaviour.
2017-02-02 12:19:44 +00:00
Paulo Reis
8f9e43f339
Handle track changles toggling when the feature is not enabled.
2017-02-02 12:12:14 +00:00
Paulo Reis
f50967295d
Support disabling the review-panel toggle, like a standard checkbox.
2017-02-02 12:08:17 +00:00
Paulo Reis
fe33fa1f65
Add modal controller.
2017-02-02 10:19:00 +00:00
Paulo Reis
98b98005a6
Create and integrate track changes upgrade prompt.
2017-02-01 16:52:18 +00:00
Paulo Reis
ad3a30b1b3
Add track changes teaser assets.
2017-02-01 16:51:37 +00:00
Shane Kilkelly
83d0f26011
Merge branch 'master' into sk-pug
2017-01-31 10:18:53 +00:00
James Allen
ca11f5fa18
Merge pull request #400 from sharelatex/ja-goto-code-from-rp
...
Jump to code when clicking on review panel entries
2017-01-31 10:49:13 +01:00
James Allen
9663df3457
Jump to text when clicking change icon as well
2017-01-30 16:00:32 +01:00
Shane Kilkelly
4e9426e6bf
Merge branch 'master' into sk-pug
2017-01-30 14:36:10 +00:00
James Allen
30618d33db
Add in extra check to set ui state
2017-01-27 17:13:11 +01:00
James Allen
d9b774bb9b
Sycn track changes based on doc state, not editor state
2017-01-27 17:12:17 +01:00
James Allen
ff7c5a0954
Merge branch 'master' into ja-track-changes
2017-01-27 17:11:49 +01:00
Paulo Reis
15ad3f4769
Avoid stopping propagation, check event target instead.
2017-01-26 16:11:02 +00:00
James Allen
68aab6e05c
Don't use code check on .bib files
2017-01-26 16:13:21 +01:00
Paulo Reis
ce89714a48
Emit event when textarea resizes; capture it in the review panel and trigger reflow.
2017-01-26 14:35:01 +00:00
James Allen
76328ff93f
Tell other clients when threads are deleted
2017-01-26 15:12:59 +01:00
James Allen
abb4ef14d8
Streamline the update/rendering process to not do extra work
2017-01-26 15:08:30 +01:00
Paulo Reis
6304c213bd
Add a min-height to the review panel text areas.
2017-01-26 12:00:11 +00:00
Paulo Reis
1a1320b561
Avoid shrinking the expandable text area.
2017-01-26 11:59:55 +00:00
James Allen
32b0c6a4fb
Merge pull request #398 from sharelatex/ja-track-changes
...
Fix style issues in IE 10
2017-01-25 15:55:15 +01:00
James Allen
757c7002eb
Merge pull request #397 from sharelatex/ja-modify-threads
...
Allow editing/deleting of comments and threads
2017-01-25 15:50:00 +01:00
James Allen
406181b05d
Remove a console.log
2017-01-25 15:49:38 +01:00
Paulo Reis
a924794a5a
Add expandable text area directive; apply it to review panel text areas.
2017-01-25 13:51:33 +00:00
Paulo Reis
f11926d0a9
Make sure layout math is done on load.
2017-01-25 10:31:02 +00:00
Henry Oswald
02e6eb4dd1
Merge pull request #399 from sharelatex/ho-promote-case-study
...
promote domain alerts
2017-01-25 09:41:50 +00:00
Henry Oswald
13d21b881f
use new annoncments feature for case study info
2017-01-24 16:03:05 +00:00
James Allen
f9ba7392e9
Allow editing/deleting of comments and threads
2017-01-24 16:21:14 +01:00
Paulo Reis
1de8b3bce7
Disable text selection with right click on file tree.
2017-01-24 15:19:48 +00:00
Henry Oswald
2341a8481a
Merge branch 'master' into ho-promote-case-study
2017-01-24 14:49:35 +00:00
James Allen
2813b16ebf
Use thread id for comment id
2017-01-23 09:45:37 +01:00
Henry Oswald
6f2c7ba6c6
Merge branch 'master' of https://github.com/sharelatex/web-sharelatex
2017-01-20 14:51:23 +00:00
Henry Oswald
03555f0339
added chris and removed geri from pics
2017-01-20 14:50:38 +00:00
Shane Kilkelly
cfa2777d62
Merge branch 'sk-launchpad'
2017-01-20 13:58:16 +00:00
Shane Kilkelly
36eb453aed
Clarify logic of asyncform onsuccess and onerror handlers
2017-01-20 13:52:31 +00:00
Shane Kilkelly
57cd54bf55
WIP: migrate from jade to pug
2017-01-20 12:03:02 +00:00
Paulo Reis
73c1016f4a
Avoid using 0px, because minifiers might convert the value to 0, which will still cause issues on IE.
2017-01-19 16:58:16 +00:00
Paulo Reis
1970ab4e63
Ensure that the change text fits the entry UI in IE.
2017-01-19 16:55:21 +00:00
Paulo Reis
a4ca7e2ca9
Fix padding in the review panel toolbar for IE.
2017-01-19 16:54:34 +00:00
Paulo Reis
cd975c6190
Make resolved comments dropdown scrollable in IE.
2017-01-19 15:43:26 +00:00
Paulo Reis
76ea469970
Reposition the track-changes indicator element to avoid issues with IE positioning.
2017-01-19 12:12:34 +00:00
Paulo Reis
3b9a599276
Fix entries z-index issues on IE10.
2017-01-19 11:57:49 +00:00
Paulo Reis
5489514d7a
Add some compatibility style rules for IE10.
2017-01-18 15:38:34 +00:00
Paulo Reis
2589ac7d58
Remove unneeded review panel layout event.
2017-01-18 10:55:51 +00:00
Paulo Reis
49fe8ef3a3
Update entry truncating logic while typing.
2017-01-18 10:53:59 +00:00
Paulo Reis
329c6af168
Add a track-changes indicator in the editor, for when the review panel is closed.
2017-01-17 17:20:51 +00:00
Paulo Reis
f27118084c
Make review header icon behave like font-awesome icons.
2017-01-17 16:03:41 +00:00
James Allen
318313d66c
Merge branch 'ja-track-changes' of github.com:sharelatex/web-sharelatex into ja-track-changes
2017-01-17 16:55:25 +01:00
James Allen
4d15fc30ba
Don't flash resolved comments when editor is loading
2017-01-17 16:55:18 +01:00
James Allen
5a34d17947
Toggle track changes in a project based on the owner's feature switch
2017-01-17 15:59:18 +01:00
Paulo Reis
2f119e5787
Track review features usage.
2017-01-17 14:39:31 +00:00
James Allen
e15d01874d
Remove comment from dropdown when it is reopened
2017-01-17 15:13:50 +01:00
James Allen
dec9b5bf1e
Use email if name is blank
2017-01-17 15:10:44 +01:00
James Allen
960d1e8b2f
Only call /project/.../threads if we need the threads
2017-01-17 15:04:49 +01:00
James Allen
4a47d135c7
Reapply ops to track changes as current user when reconnecting
2017-01-17 14:54:22 +01:00
James Allen
eb8e801dea
Merge branch 'ja-track-changes' of github.com:sharelatex/web-sharelatex into ja-track-changes
2017-01-17 11:51:11 +01:00
James Allen
1b63db91d0
Add in a null check
2017-01-17 11:51:02 +01:00
Paulo Reis
d66f2033bb
Ensure that review panel elements are above, z-index-wise, Ace elements.
2017-01-17 10:16:10 +00:00
Shane Kilkelly
06bba062a4
Merge branch 'master' into sk-launchpad
2017-01-17 09:29:37 +00:00
James Allen
9c0bf885be
Merge branch 'master' into ja-track-changes
2017-01-17 10:16:41 +01:00
Paulo Reis
36f15ff56e
Avoid empty comment submission.
2017-01-16 17:14:06 +00:00
Paulo Reis
121629426e
Avoid empty comment replies.
2017-01-16 17:06:57 +00:00
Paulo Reis
1c8942c5c6
Merge branch 'ja-track-changes' of github.com:sharelatex/web-sharelatex into ja-track-changes
2017-01-16 16:28:27 +00:00
Paulo Reis
65e257ca37
Change text marker colors on Ace dark themes.
2017-01-16 16:25:38 +00:00
James Allen
f12aeedb35
Tweak padding around track changes toggle loading indicator
2017-01-16 16:57:20 +01:00
James Allen
5fb54d8447
Don't refresh resolved comments every times an entry changes
2017-01-16 16:55:14 +01:00
James Allen
d4f60977fd
Add loading indicator while submitting new comments
2017-01-16 15:25:10 +01:00
James Allen
e5c96eb619
Focus on text area when adding a comment
2017-01-16 15:17:56 +01:00
Brian Gough
962a4d5039
roll out math mode linter for all users
...
from our ace commit 953ff92c3283f03da94559d50a933fe685b05631
2017-01-16 09:17:38 +00:00
Paulo Reis
1ed0ccf854
Improve hovering behaviour for entries in mini mode.
2017-01-13 16:07:08 +00:00
Paulo Reis
3968761ac8
Add collapsing behaviour to resolved comments.
2017-01-13 15:37:24 +00:00
Paulo Reis
5eece9f5d9
Add collapsing behaviour to long entries.
2017-01-13 15:30:31 +00:00
James Allen
b6ea338ff8
Separate resolved comments so they don't affect review panel
2017-01-13 15:27:45 +01:00
James Allen
bf7038f506
Adapt review panel line height to editor
2017-01-13 14:52:08 +01:00
James Allen
718f3dc388
Fix slightly broken callout positioning behaviour
2017-01-13 14:30:04 +01:00
James Allen
6c49b95538
Don't allow overlapping comments
...
Note that this is only a 'soft' don't allow. You could resolve a comment, comment in the same area,
and get them to overlap. It's not a problem if they overlap, just a bit ugly UI wise
2017-01-13 14:17:47 +01:00
James Allen
aab4dea8ae
Merge branch 'master' into ja-track-changes
2017-01-13 13:46:01 +01:00
Paulo Reis
823c2c854a
Add styling to have left-based layout when there is no space on the right.
2017-01-12 17:06:08 +00:00
Paulo Reis
3d5691ddaf
Merge branch 'ja-track-changes' of github.com:sharelatex/web-sharelatex into ja-track-changes
2017-01-12 16:49:56 +00:00
Paulo Reis
e3e8541a63
Add class when review panel should layout to the left.
2017-01-12 16:49:47 +00:00
Paulo Reis
9f008318cc
Emit event after linking the layout directive.
2017-01-12 16:49:29 +00:00
James Allen
b31d086330
Merge branch 'ja-track-changes' of github.com:sharelatex/web-sharelatex into ja-track-changes
2017-01-12 17:22:18 +01:00
James Allen
2052ee63a3
Recover tracked changes after a disconnect
2017-01-12 17:19:19 +01:00
Paulo Reis
b97ce52c6f
Handle z-index issues with mini review panel.
2017-01-12 14:20:41 +00:00
Brian Gough
a153375688
Merge pull request #391 from sharelatex/bg-syntax-checker-mathmode
...
math mode syntax checking improvements
2017-01-12 14:18:11 +00:00
Brian Gough
df4b5c1b37
math mode syntax checking improvements
...
for beta users
from our ace commit 442a1c522c58b1e511d2fd2c6f03909488d41e60
2017-01-12 13:25:19 +00:00
James Allen
a42cc48be8
Fix doc names and sort order in resolved comments dropdown
2017-01-12 13:44:54 +01:00
James Allen
8e0c2ff0b3
Adjust resolved comments buttons and add tooltip
2017-01-12 13:37:44 +01:00
James Allen
f9b8ada215
track changes for anonymous users
2017-01-12 13:29:57 +01:00
James Allen
0d02b860d9
Merge branch 'ja-track-changes' of github.com:sharelatex/web-sharelatex into ja-track-changes
2017-01-12 13:08:57 +01:00
Paulo Reis
0b57cc650b
Fix merge mistake; adjust animation timings.
2017-01-12 11:56:04 +00:00
James Allen
64b9fe52dd
Handle deleted users in comments gracefully
2017-01-12 12:31:01 +01:00
Paulo Reis
88b694f894
Animate comment resolving.
2017-01-12 11:25:36 +00:00