github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-01-23 05:52:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't refresh resolved comments every times an entry changes

Browse source
This commit is contained in:
James Allen 2017-01-16 16:55:14 +01:00
parent bf56952f88
commit 5fb54d8447
2 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee
View file

@ -163,11 +163,12 @@ define [
$scope.refreshResolvedCommentsDropdown = () ->
$scope.reviewPanel.dropdown.loading = true
refreshRanges()
.then () ->
$scope.reviewPanel.dropdown.loading = false
.catch () ->
$scope.reviewPanel.dropdown.loading = false
q = refreshRanges()
q.then () ->
$scope.reviewPanel.dropdown.loading = false
q.catch () ->
$scope.reviewPanel.dropdown.loading = false
return q
updateEntries = (doc_id) ->
rangesTracker = getChangeTracker(doc_id)

3
services/web/public/coffee/ide/review-panel/directives/resolvedCommentsDropdown.coffee
View file

@ -23,6 +23,7 @@ define [
scope.state.isOpen = !scope.state.isOpen
if (scope.state.isOpen)
scope.onOpen()
.then () -> filterResolvedComments()
scope.resolvedComments = []
@ -54,5 +55,3 @@ define [
resolvedComment.docName = getDocNameById(docId)
scope.resolvedComments.push(resolvedComment)
scope.$on "entries:changed", filterResolvedComments