Commit graph

785 commits

Author SHA1 Message Date
Rebeka Dekany
5b6bbcb73c Merge pull request #21008 from overleaf/rd-editor-errors
[web] Migrate notifications and error boundaries on the editor page

GitOrigin-RevId: c195ecf0dd9e38ec8326c823174e559e1f192ce1
2024-10-14 11:09:36 +00:00
Domagoj Kriskovic
4a3eed35d6 Fix accept changes request for new review panel (#20956)
* Fix accept changes request for new review panel

* Implement pessimistic UI updates for new review panel (#20986)

* Implement pessimistic UI updates for new review panel

* deleteThread, reopenThread handlers

* use finally

* handleSubmit in useCallback

GitOrigin-RevId: 358181a6b5601ad1b3579e001564dfa4da67a81d
2024-10-14 11:08:44 +00:00
David
b1d1432183 Update add comment tooltip to match new designs (#20913)
* Update add comment tooltip to match new designs

* Rename AddCommentTooltip to ReviewTooltipMenu

* Split off add-comment-button specific padding

GitOrigin-RevId: 12a69b13b52b007eb97ba7ad6f290e3a98d741cd
2024-10-14 11:08:26 +00:00
Antoine Clausse
d6de6da781 [web] Migrate the file view to Bootstrap 5 (#20765)
* [web] Remove unnecessary divs around `fileInfo`

* [web] Add file-view SCSS style

* [web] Simplify `TPRFileViewInfo`

* [web] Add div for action buttons

* [web] Misc. simplifications

* [web] Add Overleaf logo in bg when selecting multiple files

* [web] Add message when multiple files are selected

* [web] Add .full-size class

* [web] Import styles from LESS file

* [web] Update icons, use MaterialIcon

* [web] Use OLButton

* [web] Add missing space between icons and text

* [web] Adjust margins

* [web] Fix alert button

* [web] Update Alerts

* [web] Update `FileViewLoadingIndicator`

* [web] Fix test "shows a loading indicator..."

This was failing because `LoadingSpinner` is shown after a setTimeout.
Maybe we can skip this setTimeout when delay==0 ?

* [web] Remove Row/Col around error notifications

* [web] Replace `!!` by `Boolean`

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* [web] Use `alert` class in BS3 only

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Update "Go to settings" to OLButton

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Use `BootstrapVersionSwitcher` instead of `isBootstrap5`

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>

* [web] Align Alert content to the left in BS5

* [web] Remove `leadingIcon` on Refresh buttons

* [web] Make the download link be an OLButton

* [web] Set `tpr-refresh-error` in BS3 only

Co-authored-by: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>

* [web] Use `var(--white);` instead of `white`

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [web] Update OLButton size (small -> sm)

---------

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
Co-authored-by: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>
Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 04f369c0f1a53d47619a1570648ee58de5050751
2024-10-14 11:07:55 +00:00
ilkin-overleaf
4f838ccacf Merge pull request #20824 from overleaf/ii-bs5-share-modal
[web] BS5 share modal

GitOrigin-RevId: 40a33e06eab720b568d31aefa021682535b6934e
2024-10-14 11:07:31 +00:00
ilkin-overleaf
6c7ee8f778 Merge pull request #20715 from overleaf/ii-bs5-chat-pane
[web] BS5 chat pane

GitOrigin-RevId: 8587aca1372b4d2087863d492e702f04a31c23e2
2024-10-14 11:07:26 +00:00
ilkin-overleaf
92eade7502 Merge pull request #20708 from overleaf/ii-bs5-pdf-toolbar
[web] BS5 pdf toolbar

GitOrigin-RevId: a04091c9e936e52f47c3977b3149ffe613d43bb9
2024-10-14 11:06:17 +00:00
David
43bb8c0ab2 Merge pull request #20803 from overleaf/dp-resolved-comments-scroll
Add a max-height and scroll to tracked changes menu

GitOrigin-RevId: 93d4be0f057f4785a8d383f718078619467f3e2a
2024-10-14 11:05:43 +00:00
David
50723d0f8f Merge pull request #20840 from overleaf/dp-review-panel-split-test-badge
Add split test badge to new review panel for beta release

GitOrigin-RevId: 863b7614fc6b68aebc15dbc9bfec5014499af817
2024-10-14 11:03:05 +00:00
David
5fd2b63258 Merge pull request #20811 from overleaf/dp-more-comments-mini
Hide more comments button in mini review panel

GitOrigin-RevId: c41b303e36dfb2fbb0decaecd0e3d63f49568d6b
2024-10-14 11:03:00 +00:00
David
fac379b3a8 Merge pull request #20733 from overleaf/dp-align-change-icon
Align change icon with first line of change

GitOrigin-RevId: 319ed7ba7984fae52f31bd37a6d718ca07aa9009
2024-10-14 11:02:50 +00:00
David
56d396a6cf Merge pull request #20617 from overleaf/dk-review-indicator-hover
Improve "mini" view popovers for new review panel

GitOrigin-RevId: ff5fc0af70bd9660d5cc17437b25824ef4c9a704
2024-10-14 10:59:38 +00:00
David
a331ac6116 Merge pull request #19796 from overleaf/dp-more-comments-2
Add More Comments buttons

GitOrigin-RevId: 3cd6539683cbc53ceb63488ab9e9b0ffe53e079c
2024-10-14 10:59:29 +00:00
David
70535f9baa Merge pull request #20713 from overleaf/dp-fix-dark-mode-styles
Set default review panel color so that it renders correctly in a dark editor theme

GitOrigin-RevId: a3bbaef35dca294822d76eef2e18ca3f03f11857
2024-10-14 10:59:20 +00:00
Antoine Clausse
9997c4874f [web] Migrate /user/subscription to BS5 (#20513)
* [web] Initialize BS5 in subscription page

* [web] Update subscription-dashboard.tsx for BS5

* [web] Update row-link.tsx for BS5

* [web] Update modals

* [web] Add `btn` to `btn-inline-link` classes

* [web] Update circle change-to-group circle price element

* [web] Replace `list-item-with-margin-bottom` with `mb-3`

* [web] Update form elements to BS5

* [web] Use `useContactUsModal`

* [web] Adjust tables margin/padding, and more

* [web] Update change-to-group-modal.tsx

* [web] Add gap to subscription buttons

* [web] Remove subscription page colspan for md and above

* [web] Use Notification component

* [web] Update "leave group" buttons

* [web] Fix tests: add `ol-user` meta tag

* [web] Nest .hover-highlight in #subscription-dashboard-root

* [web] Update to OLRow/OLCol

* [web] Update to OLButtons

* [web] Update to OLFormGroup

* [web] Naming: use BSversion prefix

* [web] Set CancelSubscriptionButton as ghost directly in component

* [web] Set "Plan" font size

* [web] Simplify cancel-subscription buttons

* [web] Remove `--neutral-10` ModalFooter background

* [web] Simplify circle styles

* [web] Center discount badge

* [web] Update fieldset label

* [web] Add `<ul>` around RowLink

* [web] Define SCSS for row-link component

* [web] Remove some use of utility classes

* [web] Revert and update `fieldset` changes (fixes tests)

* [web] Fixup some more OLButtons

* [web] Fixup use of OLRow/OLCol

* [web] Reduce spacing below "legend-as-label"

* [web] Use h5 instead of small in OLModalTitle

* [web] Revert OLCol removal on lg screens

I had removed them by mistake because I wasn't using the proper breakpoints

* [web] Add backdrop to nested modal ContactUsModal

* [web] Don't prefill project URL in ContactUsModal

* [web] Fix lint

* [web] Share `className` prop in BS5 and BS3 modals

* [web] Set sub-title font sans serif (BS3)

* [web] Update remaining Alerts to OLNotification

GitOrigin-RevId: 7fd975ae3e992cebfaf71d4e182f8e13ec886d09
2024-10-01 08:05:14 +00:00
ilkin-overleaf
35728d7681 Merge pull request #20436 from overleaf/ii-bs5-editor-toolbar
[web] BS5 editor toolbar

GitOrigin-RevId: a517fd52d648d165e89231d6f5551c026a951c43
2024-10-01 08:04:42 +00:00
David
8c09b5866a Merge pull request #20635 from overleaf/dk-fix-review-footer
Fix review panel footer and header positioning

GitOrigin-RevId: 6da19c26fa844d0bf673cbcb113d3c47a6d04936
2024-09-27 08:04:43 +00:00
David
e253b48bc0 Merge pull request #20634 from overleaf/dp-resolved-comments-font
Add explicit font-size to review-panel-entry-content

GitOrigin-RevId: 7c0dd2a441ad011bd9d706f1f6a1f965d3b80b51
2024-09-27 08:04:30 +00:00
Rebeka Dekany
abb59e4603 Merge pull request #20298 from overleaf/rd-ide-filetree
[web] Migrate the file tree on the editor page to Bootstrap 5

GitOrigin-RevId: e2efec26242c8cdab37a54bc182b83bfb0f1eb3c
2024-09-26 08:05:43 +00:00
Antoine Clausse
d480faf60b [web] Make the welcome page cards all have the same widths (implementation 2) (#20570)
* welcome page adjusted columns in BS5

* [web] Fix card color

* [web] Fixup card width in BS3

* [web] Fix lint

* [web] Fix cards text color in BS3

* [web] Fix cards positioning in BS3

* [web] Prevent cards from becoming too large on big screens

---------

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: 9b91c073a62dae7cad4402908a34f9880ecdb0ac
2024-09-26 08:04:55 +00:00
David
7002d1e4bf Merge pull request #20511 from overleaf/dp-review-panel-footer
Update UI for new review panel footer

GitOrigin-RevId: 8beb554f78fa5876d5349981d96b44a16ab5567c
2024-09-25 08:05:07 +00:00
David
ab43a44b76 Merge pull request #20526 from overleaf/dp-mini-review-panel
Styling updates for mini review panel

GitOrigin-RevId: 1bbf7f1d2e02f5d6f3f50937d2b7b9cdc5a0878f
2024-09-25 08:05:02 +00:00
David
08a6caab80 Merge pull request #20405 from overleaf/dp-fix-empty-state-position
Fix positioning of review panel empty state

GitOrigin-RevId: d1c93e1a8bef59ad68e9f3e62106a949b7f9efdd
2024-09-20 08:04:57 +00:00
Jessica Lawshe
e3c9017a85 Merge pull request #20328 from overleaf/jel-plans-tooltip
[web] Fix opacity on tooltip on light touch redesign plans page

GitOrigin-RevId: 3254fec50356815e223dec8e13e1c6351d642a1e
2024-09-17 08:05:53 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
ilkin-overleaf
8b3ffe58fa Merge pull request #20231 from overleaf/ii-bs5-ide-header-light
[web] BS5 IDE light header

GitOrigin-RevId: 39403afae76f267228fb286492ad50e8e88e31be
2024-09-09 08:05:10 +00:00
Mathias Jakobsen
7d80d22e96 Merge pull request #20233 from overleaf/mj-restore-promo
[web] Add promotion for file/project reverting

GitOrigin-RevId: 9f8e66ab2ad945274576800253d288bca5986562
2024-09-09 08:05:01 +00:00
Mathias Jakobsen
abc1aff3a1 Merge pull request #20300 from overleaf/mj-synctex-button-cursor
[web] Fix synctex buttons cursor

GitOrigin-RevId: 87fc77801fa1bf09652823225974567bee5cd2bc
2024-09-06 08:05:39 +00:00
Mathias Jakobsen
663e2304f6 Merge pull request #20272 from overleaf/revert-20268-revert-19885-mj-resizeable-panels
[web] Upgrade react-resizable-panels (2nd attempt)

GitOrigin-RevId: 643a90044dac0daf39245fa29267b16550fd6e69
2024-09-06 08:05:28 +00:00
M Fahru
eb75c6e627 Fix sticky header is terminated earlier than it should because of the margin in the header element (#20275)
GitOrigin-RevId: 35e9e9c5a0212019b27d5090627c20cec1e7575a
2024-09-06 08:05:20 +00:00
Davinder Singh
88c8e2bdfa Plans page - Fixes the accessibility issues on the plans page (#20258)
* adding the li within ul to fix the accessibility issue from axe dev tools

* adding aria-label on the button

* adding a translation

GitOrigin-RevId: de46c7f1a71d7921b7ab88299441c50ef666cae2
2024-09-06 08:04:56 +00:00
M Fahru
9ed8b82acc Reduce font-size and line-height for interstitial page mobile table price (for light-design variant)
GitOrigin-RevId: f227346c6a45bb7352caa9aa15d16788bc115df0
2024-09-05 08:06:07 +00:00
Davinder Singh
56b69a743b Plans page redesign - [light-design] Use the new "request overleaf common" UI on the student tab (#20199)
* making the university info section in students tab to follow the new design.

* adding the left alignment of the button

* adding light keyword for the classes that are being used in the light design version for this university info card

* removing text-capitalize class

* deleting the comment

GitOrigin-RevId: 641613cf6ab73edef57b917b58ebf10b698572d3
2024-09-05 08:05:52 +00:00
Davinder Singh
f8f111d023 Merge pull request #20154 from overleaf/ds-plans-annual-monthly-toggle-switch-gap
Plans page - Annual/Monthly toggle switch gap removal

GitOrigin-RevId: e14b1a595b127e7b22dc3fa6f5d679629ead3e0b
2024-09-05 08:05:48 +00:00
ilkin-overleaf
86689a6269 Merge pull request #20205 from overleaf/ii-bs5-ide-header
[web] BS5 ide page header

GitOrigin-RevId: b7aad221d458d8403d60ff9950129394c74af856
2024-09-04 08:06:00 +00:00
Rebeka Dekany
39b6b8baed Merge pull request #20172 from overleaf/rd-ide-fileoutline
[web] Migrate the file outline styling from LESS to SCSS

GitOrigin-RevId: 5e485b13a7358e5dcab2c75ee7d36a07e1401e26
2024-09-04 08:05:12 +00:00
Alf Eaton
27e558b484 Fix image upload modal dropzone overflow (#20102)
GitOrigin-RevId: 8caf4e631056ed00b167cff8a6cccea0e0ff8ae7
2024-09-04 08:05:02 +00:00
Alf Eaton
284a8256d4 Fix tag name overflow in projects list (#20120)
GitOrigin-RevId: 9fc317dbebd8115ab8af97f4753350f5ee79c1cd
2024-09-04 08:04:57 +00:00
roo hutton
31bb5939a1 Merge pull request #20156 from overleaf/rh-share-modal-dropdown-fix
[web] Add explicit width to share modal permission dropdown

GitOrigin-RevId: df20cedfffffb2ba8291dcae128845a03b2897ba
2024-09-04 08:04:39 +00:00
Jessica Lawshe
feddc2158f Merge pull request #20186 from overleaf/jel-discount-color
[web] Increase color contrast on new plans page discount badge

GitOrigin-RevId: 3230a2debdf1c23a0b18b32b8062d5108f7e32ce
2024-09-02 08:05:35 +00:00
Jessica Lawshe
f8b10a41dc Merge pull request #20183 from overleaf/jel-plans-discount-line-height
[web] Fix line height on new plans discount badge

GitOrigin-RevId: e253c6f3fc66988d4eb978fc46002f1b9ad31ed1
2024-09-02 08:05:30 +00:00
Jessica Lawshe
27b4dfbd79 Merge pull request #20174 from overleaf/jel-plans-page-query-param-part-3
[web] New plans page elements that are dependent on plan period type

GitOrigin-RevId: 677d4df1544aa901dd5c57d61c395f3045c1c024
2024-08-30 08:04:55 +00:00
Jessica Lawshe
3b864d4345 Merge pull request #20155 from overleaf/jel-plans-page-query-param-part-2
[web] Render initial plans tab on server

GitOrigin-RevId: cb4d59274c0fd2a40fd35b5301d0bd387e738a98
2024-08-30 08:04:50 +00:00
Jessica Lawshe
3c86912f61 Merge pull request #20072 from overleaf/jel-plans-period-toggle
[web] Put plans period toggle within tabs that use it

GitOrigin-RevId: ccc2594467b3b31dd3fda82dd23e058911d0ec82
2024-08-30 08:04:34 +00:00
M Fahru
250514b28e Merge pull request #20143 from overleaf/mf-fix-plan-features-mobile-header-text
[web] Change "Collaborator" text to "Standard" in individual tab plans (plans page and interstitial page new design)

GitOrigin-RevId: 064bb59b3fb84f1fb413035acc40e7f6b368b1f8
2024-08-29 08:04:56 +00:00
roo hutton
2dcf87e3f6 [web] Share modal shows downgraded editors (#20015)
* add hasBeenDowngraded prop for EditMember

* reduce padding on share modal collab row, add prompt to hasBeenDowngraded Select

* share modal select styling tweaks to allow for inline warning icon

* always show editor limit subtitle when in downgraded state

* add AccessLevelsChanged warning, tweak owner row styling

* conditionally set hasBeenDowngraded prop. make invited member row styling more consistent between warning/enforcement

* add an info state for access level changed notification

* add notification for lost edit access on collaborator share modal, TSify SendInvitesNotice

* fix member privilege alignment in collaborator share modal

* show blue upgrade CTA when some pending editors have been resolved

* automatically show share modal to owners when has pending editors or is over collab limit

* only show lost edit access warning in read-only share modal to pending editors

---------

Co-authored-by: Thomas <thomas-@users.noreply.github.com>
GitOrigin-RevId: e3b88052a48b8f598299ffc55b7c24cb793da151
2024-08-27 08:04:49 +00:00
Davinder Singh
e19e5ae29a Interstitial Page - Adding geo banners for India and latin america (#20046)
* adding geo banners on interstitial page

* adding a new class .interstitial-new-design-content-spacing to match the spacing of 13

GitOrigin-RevId: 0b72f321356a899f02efcf4bd2719d7762e7b524
2024-08-26 08:04:22 +00:00
ilkin-overleaf
0e71084600 Merge pull request #19840 from overleaf/ii-bs5-project-tools
[web] BS5 project tools

GitOrigin-RevId: 3181c62985b6db4051292b484f53178a0736fa75
2024-08-22 14:01:43 +00:00
Alf Eaton
e61eb1b220 Merge pull request #20008 from overleaf/ae-review-panel-empty-state
Improve calculations of empty state, mini state and sizes variables in review panel

GitOrigin-RevId: 41bcb3b67c9f0019c11b4de0e4590b0407e04e66
2024-08-22 14:01:16 +00:00
Jessica Lawshe
493bdc92d5 Merge pull request #20048 from overleaf/jel-plans-light-touch
[web] Plans page light touch redesign updates

GitOrigin-RevId: 71bb1a594e1767fe406bb63334534fd73b3d368a
2024-08-22 08:05:53 +00:00