Commit graph

22485 commits

Author SHA1 Message Date
Jakob Ackermann
cfe37dcbb5 Merge pull request #152 from overleaf/jpa-vendor-cookie
[misc] vendor a patched session.socket.io middleware
2020-06-10 11:27:58 +02:00
Jakob Ackermann
5b85e0154d Merge pull request #151 from overleaf/jpa-perf-parser
[perf] add a few short cuts to the packet decoding
2020-06-10 11:27:50 +02:00
Jakob Ackermann
ef04d252f3 Merge pull request #150 from overleaf/jpa-tests-for-141-147
[misc] add test cases for the validation of the callback argument
2020-06-10 11:27:44 +02:00
Jakob Ackermann
b2e4448992 [misc] test/acceptance: ReceiveUpdateTests: test remotely sent update 2020-06-10 09:53:48 +01:00
Jakob Ackermann
83e3ff0ed7 [misc] test/acceptance: ReceiveUpdateTests: add 2nd project/3rd client
...and check for cross project leakage.
2020-06-10 09:53:29 +01:00
Jakob Ackermann
56fda1f9b0 [misc] test/acceptance: use the correct redis instances 2020-06-10 09:43:15 +01:00
Jakob Ackermann
bc44494466 [HttpController] return 404 in case of a missing client and add tests
Add acceptance tests for the client view.
2020-06-10 09:41:36 +01:00
Hugh O'Brien
f024483aa0 Merge pull request #2889 from overleaf/jpa-ns-disable-spell-check-at-runtime
[misc] disable spellcheck for unsupported languages at runtime

GitOrigin-RevId: 4214981930992abac054e78ce138adacaa99b801
2020-06-10 02:12:46 +00:00
Hugh O'Brien
cedb075b34 Merge pull request #2893 from overleaf/jel-plans-test
Add hidden plans cards at bottom of page for A/B test

GitOrigin-RevId: a44ca8f3ee60a583187126af32dcdfedba4ee41d
2020-06-10 02:12:41 +00:00
Jakob Ackermann
eabff1d6b2 [perf] test/acceptance: DrainManagerTests: cleanup previous clients
...before starting to drain.
2020-06-09 18:02:38 +01:00
Jakob Ackermann
de35fc5ecf [HttpApiController] implement the disconnection of a single client
The http route returns as soon as the client has fully disconnected.
2020-06-09 18:01:08 +01:00
Jakob Ackermann
91e296533f [misc] test/acceptance: add tests for the draining of connections 2020-06-09 18:00:44 +01:00
Simon Detheridge
59551fc140 Merge pull request #121 from overleaf/spd-gcs-byte-range
Fix Filestore returning one-too-many bytes when given a range
2020-06-09 16:32:42 +01:00
Jakob Ackermann
acb7d7df5a [misc] add test cases for the validation of the callback argument
When the user provides a function as last argument for socket.emit,
 socket.io will flag this as an RPC and add a cb as the last argument
 to the client.on('event', ...) handler on the server side.
Without a function as last argument for socket.emit, the callback
 argument on the server side is undefined, leading to invalid function
 calls (`undefined()`) and an unhandled exception.
The user can also provide lots of other arguments, so the 2nd/3rd ...
 argument is of arbitrary type, again leading to invalid function calls
 -- e.g. `1()`.
2020-06-09 16:30:03 +01:00
Jakob Ackermann
853ee994a6 [perf] add a few short cuts to the packet decoding 2020-06-09 15:26:17 +01:00
Jakob Ackermann
dc553c4150 [misc] vendor a patched session.socket.io middleware 2020-06-09 15:21:33 +01:00
Simon Detheridge
7b6299e05a Update GcsPersistor range unit test 2020-06-09 13:55:03 +01:00
Jakob Ackermann
1c9eaf574a Merge pull request #147 from overleaf/jpa-backport-141
[backport] 141: Router: validate the callback argument
2020-06-09 14:41:24 +02:00
Jakob Ackermann
5238e6ad36 Merge pull request #145 from overleaf/jpa-backport-140
[backport] 140: stop processing requests as we detect a client disconnect
2020-06-09 14:41:12 +02:00
Jakob Ackermann
589bedc3dd Merge pull request #146 from overleaf/jpa-downgrade-logging
[misc] downgrade logging when running tests
2020-06-09 14:40:59 +02:00
Brian Gough
54d1cf7eeb add missing setting for optimiseInDocker 2020-06-09 11:22:28 +01:00
Simon Detheridge
5d9f78322d Don't increment range end when passing to GCS backend 2020-06-09 10:01:47 +01:00
Simon Detheridge
0027d27473 Use latest version of gcs server for tests 2020-06-09 10:01:20 +01:00
Jakob Ackermann
9eaa1f9677 Merge pull request #2890 from overleaf/jpa-socket-io-secondary-id
[misc] socket.io: use a secondary publicId for public facing usages

GitOrigin-RevId: f472c90ce0706aaf409e63c4199e71899b1aefa3
2020-06-09 02:10:34 +00:00
Eric Mc Sween
ac6e70d064 Merge pull request #59 from overleaf/msm-update-oerror-v3
Update OError to v3
2020-06-08 09:10:26 -04:00
Eric Mc Sween
256e7375ff Upgrade logger-sharelatex to 2.0.0 2020-06-08 08:58:25 -04:00
Jakob Ackermann
6dce45bf2f Merge pull request #148 from overleaf/jpa-secondary-id
[misc] socket.io: use a secondary publicId for public facing usages
2020-06-08 14:51:01 +02:00
Eric Mc Sween
510ad04d66 Merge pull request #19 from overleaf/msm-update-oerror-v3
Update OError dependency to v3
2020-06-08 08:34:19 -04:00
Jakob Ackermann
32af7001fc [misc] Router: prefix the publicId with 'P.' for easy differentiation 2020-06-08 11:29:40 +01:00
Brian Gough
8464ce33a1 Merge pull request #173 from overleaf/bg-openout-any
add setting TEXLIVE_OPENOUT_ANY
2020-06-08 09:03:05 +01:00
Chrystal Maria Griffiths
6c614a6adc Merge pull request #2885 from overleaf/as-remove-transforms
Remove transforms after being run

GitOrigin-RevId: a998e9ce9c58a501d366f6b288277bd604f9f39e
2020-06-06 02:10:05 +00:00
Chrystal Maria Griffiths
c89b1912ca Merge pull request #2877 from overleaf/as-upgrade-react-dom-testing-library
Upgrade React & DOM testing library

GitOrigin-RevId: b3ee2e726a549d7ddb55fe74497e8787237708eb
2020-06-06 02:10:00 +00:00
Chrystal Maria Griffiths
50585a22b3 Merge pull request #2881 from overleaf/jpa-socket-io-retry-handshake
[misc] socket.io: retry the initial connection attempt

GitOrigin-RevId: e7f7e8eb233015f41b2b8c67e46c4661b8fad3c9
2020-06-06 02:09:55 +00:00
Chrystal Maria Griffiths
d536e57ed8 Merge pull request #2884 from overleaf/as-remove-dead-code
Remove some dead code

GitOrigin-RevId: f861b0a4071f5f66a1f1052caa681799bad17153
2020-06-06 02:09:50 +00:00
Chrystal Maria Griffiths
1e4b7aeace Merge pull request #2887 from overleaf/cmg-plans-covid-notification
Add WFH notification to plans page

GitOrigin-RevId: 49597e4fdaa8fb047639105cb83e9aed8c30a260
2020-06-06 02:09:45 +00:00
Jakob Ackermann
f40241a037 [misc] downgrade logging when running tests 2020-06-05 11:38:09 +01:00
Jakob Ackermann
0b2cccf1e0 [misc] apply review feedback: adjust metric names
Co-Authored-By: Brian Gough <brian.gough@overleaf.com>

(cherry-picked from commit 67674b83efb452ece05cdc39525ee3a5eeb8a4d7)
2020-06-05 11:33:00 +01:00
Jakob Ackermann
ddcb9cf8c8 [misc] downgrade a warning message from clients leaving non-joined rooms
This can now happen all the time, as we skip the join for clients that
 disconnect before joinProject/joinDoc completed.

(cherry-picked from commit f357931de74e088800f3cced3898cce4f251dad0)
2020-06-05 11:32:43 +01:00
Jakob Ackermann
7fa9061015 [misc] stop processing requests as we detect a client disconnect
v2 expose `client.connected`; v0 exposes `client.disconnected`

(cherry-picked from commit a9d70484343ca9be367d45bf7bb949e4be449647)
2020-06-05 11:32:13 +01:00
Jakob Ackermann
0840700ffd [Router] validate the callback argument 2020-06-05 10:59:01 +01:00
Shane Kilkelly
f4950c21bf Merge pull request #2870 from overleaf/sk-restrict-chat
Block restricted users from Chat endpoints

GitOrigin-RevId: caec8fe2bc93d567dd57f32dc765bd74ba53e933
2020-06-05 02:09:58 +00:00
Shane Kilkelly
74313e4b82 Merge pull request #2883 from overleaf/ta-email-remove-features-refresh
Refresh User's Features After Removing Email

GitOrigin-RevId: 0085a5341a806d1d22f4a1fb5bb98c93675e242e
2020-06-05 02:09:52 +00:00
Jakob Ackermann
c6d08647c7 [misc] socket.io: use a secondary publicId for public facing usages 2020-06-04 17:18:07 +01:00
Brian Gough
3d6b911295 add setting TEXLIVE_OPENOUT_ANY 2020-06-04 11:47:22 +01:00
Tim Alby
472d65d15c Revert "[misc] make: ignore a lint/format task failure"
This reverts commit 85f3dc661b17f8b99aa073c376aa2aa5af8998af.
2020-06-04 10:39:35 +02:00
Tim Alby
8335f31d6c fix linting 2020-06-04 10:37:43 +02:00
Tim Alby
d3a7ffd1a9 fix formatting 2020-06-04 10:24:21 +02:00
Tim Alby
361f8ff123 Revert "[misc] make: ignore a lint/format task failure"
This reverts commit 26e27b0ff22d694ce58b0e721416c2b775f7ae6a.
2020-06-04 10:21:50 +02:00
Tim Alby
85d8b04a6c Revert "[misc] make: ignore a lint/format task failure"
This reverts commit 6daa8ff2467557f710adcddbf7277b1ce135991d.
2020-06-04 10:19:52 +02:00
Tim Alby
311d7cefa1 fix linting 2020-06-04 10:17:40 +02:00