David
d74981775c
Merge pull request #21283 from overleaf/dp-keyboard-shortcuts
...
Add missing keyboard shortcuts to new review panel
GitOrigin-RevId: 78e3a63284b62c90e8a3803bd81fdf273f1a2ec9
2024-10-24 08:05:17 +00:00
David
c872d97295
Merge pull request #21250 from overleaf/dp-resolved-comments-ui
...
UI tweaks for resolved comments menu
GitOrigin-RevId: 23df6f9f0374277c315d2fb9c9940dd92ec19f4e
2024-10-24 08:05:12 +00:00
David
1c5f5950fa
Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
...
Add options to accept/reject all changes to review tooltip
GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
David
c7eafd69c2
Merge pull request #21014 from overleaf/dk-review-panel-tc-widget
...
Add "Track changes is On" button when review panel is closed
GitOrigin-RevId: a165201f611860ba531f2eeb3d89f83a695cd017
2024-10-22 08:05:50 +00:00
Domagoj Kriskovic
64460681b8
Fix delete comment/thread in the new review panel ( #21199 )
...
GitOrigin-RevId: 95d4db64d2f837322d84a81cbd129ec02ee135a2
2024-10-22 08:05:46 +00:00
Domagoj Kriskovic
c606f04cce
Sort track changes and comments in overview mode ( #21099 )
...
GitOrigin-RevId: 795d30b56e57970363512170f504ab51bd104c93
2024-10-22 08:05:37 +00:00
Domagoj Kriskovic
332e2a38c9
Fix review panel entry focus handler ( #21075 )
...
* Fix review panel entry focus handler
* dont check position
* remove event.target checks
* Revert "remove event.target checks"
This reverts commit 3f511e47b6922260666c6952b692f6f0a29d5912.
GitOrigin-RevId: 9271df9cdb36a040d59a97c88f21d6e923ac0404
2024-10-22 08:05:33 +00:00
David
87f714f7c3
Merge pull request #21164 from overleaf/dp-add-comment-keyboard-shortcut
...
Add keyboard shortcut (cmd+shift+c) for adding a new comment
GitOrigin-RevId: 20359426f45e90b09cbc887bac3096adf1b3141a
2024-10-22 08:05:15 +00:00
David
31154bb9f5
Merge pull request #21065 from overleaf/dp-limit-track-change
...
Truncate text in a tracked change
GitOrigin-RevId: a3c070f0ca2f51545151934d25a26a10c99b7465
2024-10-22 08:05:11 +00:00
David
efa376f4f4
Merge pull request #21120 from overleaf/dp-overview-entry-gap
...
Adjust size of gap between review panel entries to 4px
GitOrigin-RevId: a09a6fde0e8eb15e0c753e436a1c09434581d6d8
2024-10-22 08:05:07 +00:00
David
af7e388c41
Merge pull request #21122 from overleaf/dp-rp-hide-edit
...
Hide edit option for other user's comments
GitOrigin-RevId: 317fa57402dfbe2e949fa7b196cbbe246f88257d
2024-10-22 08:05:02 +00:00
ilkin-overleaf
8bc374c916
Merge pull request #21115 from overleaf/ii-bs5-review-panel
...
[web] BS5 review panel new
GitOrigin-RevId: c65d17d0053858bd74984ba746a620b89d900606
2024-10-21 08:04:37 +00:00
Domagoj Kriskovic
e00831761a
Fix "update in progress" error when removing highlight ranges ( #21024 )
...
GitOrigin-RevId: 025e69f10b6010fe978ac57838ae17c113358633
2024-10-14 11:10:09 +00:00
David
438192fc11
Open review panel current file view when clicking add comment tooltip ( #20891 )
...
* Remove need for custom set-review-panel-open event
* Open current file view when clicking add comment tooltip
---------
Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 2b21061193f4270030d73174014aabbd017fd38e
2024-10-14 11:08:56 +00:00
Domagoj Kriskovic
4a3eed35d6
Fix accept changes request for new review panel ( #20956 )
...
* Fix accept changes request for new review panel
* Implement pessimistic UI updates for new review panel (#20986 )
* Implement pessimistic UI updates for new review panel
* deleteThread, reopenThread handlers
* use finally
* handleSubmit in useCallback
GitOrigin-RevId: 358181a6b5601ad1b3579e001564dfa4da67a81d
2024-10-14 11:08:44 +00:00
David
42a199043a
Skip ReviewPanelEntry focus event if target is anchor element ( #20928 )
...
GitOrigin-RevId: e6ad0ca7c03de2ef176b6328c27dd0afa10bd102
2024-10-14 11:08:39 +00:00
David
def2f7f4fd
Move divider into overview-file component so that they don't render if file doesn't ( #20882 )
...
GitOrigin-RevId: fef584609fa06e6313323c27bc6f9ab9b9a6c815
2024-10-14 11:08:30 +00:00
David
b1d1432183
Update add comment tooltip to match new designs ( #20913 )
...
* Update add comment tooltip to match new designs
* Rename AddCommentTooltip to ReviewTooltipMenu
* Split off add-comment-button specific padding
GitOrigin-RevId: 12a69b13b52b007eb97ba7ad6f290e3a98d741cd
2024-10-14 11:08:26 +00:00
Alf Eaton
9ba6a6a042
Update modified tracked changes in the React state ( #20877 )
...
GitOrigin-RevId: d3b17908aa43d99b6e46550f2de77186f9d7b86d
2024-10-14 11:08:21 +00:00
David
037529f243
Merge pull request #20886 from overleaf/dp-overview-file-counts
...
Check that thread has messages in overview comment count
GitOrigin-RevId: 8499f837a016256c5ca615172b5c53a7f2e7c6b5
2024-10-14 11:05:53 +00:00
David
d9211998de
Merge pull request #20887 from overleaf/dp-rp-entry-buttons
...
Don't focus entry if clicking on a button/link
GitOrigin-RevId: 0c37ce76134358ef7d3fd5b0c897ffab8e4d7db1
2024-10-14 11:05:48 +00:00
David
50723d0f8f
Merge pull request #20840 from overleaf/dp-review-panel-split-test-badge
...
Add split test badge to new review panel for beta release
GitOrigin-RevId: 863b7614fc6b68aebc15dbc9bfec5014499af817
2024-10-14 11:03:05 +00:00
David
5fd2b63258
Merge pull request #20811 from overleaf/dp-more-comments-mini
...
Hide more comments button in mini review panel
GitOrigin-RevId: c41b303e36dfb2fbb0decaecd0e3d63f49568d6b
2024-10-14 11:03:00 +00:00
David
fac379b3a8
Merge pull request #20733 from overleaf/dp-align-change-icon
...
Align change icon with first line of change
GitOrigin-RevId: 319ed7ba7984fae52f31bd37a6d718ca07aa9009
2024-10-14 11:02:50 +00:00
David
a40fb42fed
Merge pull request #20712 from overleaf/dp-click-mini-panel
...
Clicking on an entry in the mini review panel opens the full panel
GitOrigin-RevId: 4c925435a09f56ae5b02c53951185c67eb0413a2
2024-10-14 11:02:44 +00:00
David
4480a986a3
Merge pull request #20785 from overleaf/dp-sticky-highlights
...
Clear op highlight on review-panel-entry dismount
GitOrigin-RevId: 9892df75f35fcb0440bd19bcfbaa276a3db033a1
2024-10-14 11:02:35 +00:00
David
2117bfe29d
Merge pull request #20541 from overleaf/dk-delete-widgets
...
Handle highlight/focus effects for track deletes in new review panel
GitOrigin-RevId: 102eed9e8af04599823c1bcf0598a0328901bdba
2024-10-14 10:59:47 +00:00
David
4c334b4b45
Merge pull request #20776 from overleaf/dp-resolve-lint
...
Provide empty decoration set to useMoreComments when addCommentRanges is undefined
GitOrigin-RevId: 40b7ae41ef783586d4304f2896397d8e84628e18
2024-10-14 10:59:42 +00:00
David
56d396a6cf
Merge pull request #20617 from overleaf/dk-review-indicator-hover
...
Improve "mini" view popovers for new review panel
GitOrigin-RevId: ff5fc0af70bd9660d5cc17437b25824ef4c9a704
2024-10-14 10:59:38 +00:00
David
a331ac6116
Merge pull request #19796 from overleaf/dp-more-comments-2
...
Add More Comments buttons
GitOrigin-RevId: 3cd6539683cbc53ceb63488ab9e9b0ffe53e079c
2024-10-14 10:59:29 +00:00
David
df2e3c1119
Merge pull request #20728 from overleaf/dp-state-field-error
...
Safeguard against addCommentStateField not existing
GitOrigin-RevId: 06f5f72bc12552b9668892a50d9789d6dfc45a9e
2024-10-14 10:59:16 +00:00
Alf Eaton
c6633632d6
Move CodeMirror contexts into a separate file ( #20643 )
...
GitOrigin-RevId: 8425454a75ff8160a03fda1be5bda2242b41f6cd
2024-09-30 08:04:48 +00:00
David
dae40941ee
Merge pull request #20638 from overleaf/dk-review-subview-mini
...
Always use current file sub view when review panel is collapsed
GitOrigin-RevId: 536476a11a9e54c79c2fe930d74639c6e676870e
2024-09-27 08:04:47 +00:00
David
2801b3baad
Merge pull request #20583 from overleaf/dk-review-gotoposition
...
Goto position when clicking on review entry in Overview tab
GitOrigin-RevId: 17c9cefed339537afa994778ffbc01cfb294bf46
2024-09-27 08:04:34 +00:00
David
2a051700b5
Merge pull request #20586 from overleaf/dp-resoled-comments-tooltip
...
Add tooltips for resolved comments toggle and reopen/delete thread buttons
GitOrigin-RevId: 6e043d0ca83418f4362ec1b49994c4ceed24742b
2024-09-27 08:04:26 +00:00
David
7002d1e4bf
Merge pull request #20511 from overleaf/dp-review-panel-footer
...
Update UI for new review panel footer
GitOrigin-RevId: 8beb554f78fa5876d5349981d96b44a16ab5567c
2024-09-25 08:05:07 +00:00
David
ab43a44b76
Merge pull request #20526 from overleaf/dp-mini-review-panel
...
Styling updates for mini review panel
GitOrigin-RevId: 1bbf7f1d2e02f5d6f3f50937d2b7b9cdc5a0878f
2024-09-25 08:05:02 +00:00
David
9d3841a46d
Merge pull request #20517 from overleaf/dp-overview-edit-actions
...
Don't allow tracked changes to be edited in the overview tab in new review panel
GitOrigin-RevId: 132771c4105096034bf58bc3d4a7ba23c3d088b7
2024-09-25 08:04:57 +00:00
David
af6ffdcf7c
Merge pull request #20409 from overleaf/dk-selectLineOnFocus-fix
...
Fix scroll issue when focusing a change in new review panel
GitOrigin-RevId: 55784de415f65935ad9b1a8cd3ad82ea3ddac3c1
2024-09-20 08:05:17 +00:00
David
22e4c2de2c
Merge pull request #20411 from overleaf/dk-highlight-focus-ranges
...
Highlight and focus ranges in editor for new review panel
GitOrigin-RevId: 4fef31a8c9e6dc974519d925c7478665e0c8cc29
2024-09-20 08:05:13 +00:00
David
8a0bed71e1
Merge pull request #20475 from overleaf/dk-fix-positionItems
...
Change focused item index to be per docId in new review panel
GitOrigin-RevId: af4b91cdc7128302a75f25d11c2afc5a2861abdd
2024-09-20 08:05:08 +00:00
David
8685d87920
Merge pull request #20494 from overleaf/dp-zero-message-thread
...
Don't show comment threads with zero messages
GitOrigin-RevId: e9efdf4fc1119b8fdafdd8a93c7cd9caed91a276
2024-09-20 08:05:03 +00:00
David
08a6caab80
Merge pull request #20405 from overleaf/dp-fix-empty-state-position
...
Fix positioning of review panel empty state
GitOrigin-RevId: d1c93e1a8bef59ad68e9f3e62106a949b7f9efdd
2024-09-20 08:04:57 +00:00
David
a323f3af75
Implement a floating "Add comment" button for the redesigned review panel ( #19891 )
...
* Implement floating Add comment button
* Fix comment typo
* Remove unused imports
* Make tooltip always appear above cursor
Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
* Refactor how new comment form is positioned
* Add missing file
* Create new map when rendering positions
* Use codemirror state to manage ranges and allow for mutliple in-progress comments
* Memoise sorting
* Create new ranges map each time it is changed
* Add back mutation observer
* Only allow single tooltip
* Fix typo
* Convert state field to store a single tooltip
* Make add comment tooltip content a react component
* Refactor to remove usages of !important
* Use RangeSet to keep track of new comment ranges
* Fix logic broken in rebase
* Map ranges through document changes
* Add decorations for in-progress comments
* Use set-review-panel-open rather than an editor event to open review panel
* Implement new designs for add comment form
* Add padding to textarea
* Fix bug where comment was being submitted for incorrect range
* Add missing key to ReviewPanelAddComment
* Store new comment ranges as a DecorationSet
* Small refactor to how ReviewPanelAddCommens are rendered
* Make op prop to ReviewPanelEntry required
* Add handling for disabling of add comemnt form buttons
* Move viewer check inside AddCommentTooltip
* Ensure that add comment button doesn't reshow when collaborators edit the document
* Remove unneeded op check in ReviewPanelEntry
* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx
Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
---------
Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
Domagoj Kriskovic
cab58d87dd
extracted rejectChanges to a separate file
...
GitOrigin-RevId: 83c55c4823f6e18f22dbd6bc1fa7ec010c509e30
2024-08-26 08:05:10 +00:00
Domagoj Kriskovic
6547ce6aa1
remove updateRangesEffect and rejectChanges from trackChanges extension
...
GitOrigin-RevId: b93751421d235fd61a80ce64f47aec7998e4f6cf
2024-08-26 08:04:47 +00:00
Alf Eaton
e61eb1b220
Merge pull request #20008 from overleaf/ae-review-panel-empty-state
...
Improve calculations of empty state, mini state and sizes variables in review panel
GitOrigin-RevId: 41bcb3b67c9f0019c11b4de0e4590b0407e04e66
2024-08-22 14:01:16 +00:00
Alf Eaton
ee8b8d0692
Merge pull request #20007 from overleaf/ae-review-panel-container-ref
...
Fix event listener attachment to review panel container
GitOrigin-RevId: ceb1023d7be48d9b88e725963124cd04e98127bd
2024-08-20 08:04:59 +00:00
David
9416e69647
Merge pull request #19985 from overleaf/dp-resolved-threads
...
Implement redesigned resolved threads popover
GitOrigin-RevId: 4e462eb26a2f2f3194fca89c39d5f9d08ea2e33c
2024-08-20 08:04:35 +00:00
Alf Eaton
acba1b8956
Rebuild review panel entries when the editor viewport changes ( #19962 )
...
GitOrigin-RevId: af144a278a3338bffb58e40a91ddbeb204959dee
2024-08-16 08:04:27 +00:00
