Paulo Reis
15980d5427
Merge branch 'master' into pr-hide-review-panel
2017-05-19 15:31:14 +01:00
Paulo Reis
957b201fc1
Add commenting and track-changes keyboard shortcuts.
2017-05-19 15:28:49 +01:00
Paulo Reis
e532f543a3
Merge branch 'master' into pr-bulk-actions
2017-05-18 14:38:16 +01:00
Paulo Reis
832764dd3d
Add key shortcut to toggle the review panel.
2017-05-18 11:02:50 +01:00
Paulo Reis
7f3c0ed5ac
Refactor accept and reject methods to support multiple changes; support bulk actions events.
2017-05-16 14:27:06 +01:00
Paulo Reis
36b4a8e6c2
Update ranges tracker.
2017-05-16 14:04:13 +01:00
Paulo Reis
ac99422c26
Update ranges tracker.
2017-05-16 14:04:06 +01:00
Paulo Reis
a3c529d23f
Update range tracker with new bulk method.
2017-05-16 14:03:52 +01:00
Shane Kilkelly
ada614cc69
Check response exists before calling method
2017-05-16 09:20:12 +01:00
Paulo Reis
f4e46bb2f9
Use new ranges tracker method to get N changes at once; small refactor.
2017-05-15 11:24:40 +01:00
Paulo Reis
7bb5d65b52
Update ranges tracker.
2017-05-15 11:11:28 +01:00
Paulo Reis
82a19444b3
Merge branch 'master' into pr-bulk-actions
2017-05-15 10:29:15 +01:00
Paulo Reis
dd85c2fab2
Remove debug line.
2017-05-12 15:44:49 +01:00
Paulo Reis
658e70a772
Update ranges tracker.
2017-05-11 11:32:12 +01:00
Paulo Reis
f2dac28a65
Consolidate some watchers.
2017-05-11 10:23:41 +01:00
Paulo Reis
a3ab994ab3
Use the same watcher to control miniRP visibility and trigger Ace resizing.
2017-05-11 10:17:25 +01:00
Paulo Reis
8aee0edfe8
Integrate bulk actions dialog with controller actions.
2017-05-09 16:06:34 +01:00
Paulo Reis
f3e020df7e
Add dialog to confirm bulk actions.
2017-05-09 16:06:19 +01:00
Paulo Reis
499272cbb5
Use new range-tracker method.
2017-05-08 16:12:21 +01:00
Paulo Reis
03b8b72520
Update range tracker with new bulk method.
2017-05-08 16:10:08 +01:00
Paulo Reis
3ced808411
Use a single accept changes method.
2017-05-05 15:19:31 +01:00
Paulo Reis
f25db3ff64
Reflect accepted changes on the UI layer.
2017-05-04 15:47:25 +01:00
Paulo Reis
19828d3c5b
Basic bulk accept support.
2017-05-04 15:33:47 +01:00
Paulo Reis
8f6d11632b
Add bulk rejection support.
2017-05-03 17:16:41 +01:00
Paulo Reis
dae66d5edf
Add bulk methods in controller.
2017-05-03 17:16:29 +01:00
Paulo Reis
05d9bf47d1
Use entry ids instead.
2017-05-03 16:53:04 +01:00
Paulo Reis
bf7bf701ed
Store selected entries; improve visibility logic.
2017-05-03 16:35:58 +01:00
Paulo Reis
722d75f6ef
Correctly check if deletions are within selection.
2017-05-02 17:08:41 +01:00
Paulo Reis
3f441ff38c
Count entries within selection; only show bulk actions if there are selected entries.
2017-05-02 17:02:30 +01:00
Paulo Reis
e2eaf6619e
Bulk actions directive; include it in the review panel.
2017-05-02 16:15:40 +01:00
Paulo Reis
76ea497b33
Use a single entry for bulk actions.
2017-05-02 15:43:45 +01:00
Paulo Reis
d874eb70f8
Add and remove bulk accept and reject entries with selections.
2017-05-02 15:34:05 +01:00
Paulo Reis
d71296da9f
Add row clicking in the projects list.
2017-05-01 17:11:03 +01:00
Paulo Reis
208f021bd0
Actually remove project from tag, inline.
2017-05-01 16:00:25 +01:00
Paulo Reis
6e40284099
Add untagged projects counter.
2017-04-28 16:57:37 +01:00
Paulo Reis
84a2658259
Add an untagged filter in the projects list.
2017-04-28 12:11:51 +01:00
Paulo Reis
877cd8e018
Apply stored filtering options.
2017-04-27 16:18:16 +01:00
Paulo Reis
884a89893d
Save and read filtering options from local storage.
2017-04-27 16:17:28 +01:00
Henry Oswald
f5267ac6ee
Merge pull request #481 from sharelatex/ja-encode-project-names
...
Error if no project returned from joinProject
2017-04-25 09:17:59 +01:00
Henry Oswald
79bc4c1d3e
= != == ;)
2017-04-24 16:16:02 +01:00
Henry Oswald
c733925a26
show rate limit message when compiled too much
2017-04-24 15:56:09 +01:00
James Allen
f6bd949f01
Error if no project returned from joinProject
...
socket.io seems to choke on the unicode project name and just return
undefined when it fails to parse the JSON. I've improved the escaping
of the user data on HTML load, but reporting an error is the best we
can easily do on joinProject via websockets.
2017-04-10 12:03:39 +01:00
James Allen
477278eea5
Merge pull request #476 from sharelatex/ja-use-new-comment-button
...
Fix on the new comment button variation
2017-04-05 11:08:59 +01:00
James Allen
ce59307c91
Merge pull request #475 from sharelatex/ja-scroll-overflow-in-review-panel
...
Allow scrolling in the review panel to extend outside of top of text …
2017-04-05 11:08:49 +01:00
Shane Kilkelly
0555154a24
Merge branch 'sk-fix-folder-creation'
2017-04-04 11:01:07 +01:00
Paulo Reis
7855afa0cd
Remove unused scope binding.
2017-04-04 10:48:31 +01:00
Paulo Reis
15de552c2c
Make new add comment button styles as the default; removed old add comment button code.
2017-04-04 10:40:53 +01:00
James Allen
567edbfb31
Fix on the new comment button variation
2017-04-03 17:11:33 +01:00
James Allen
2fa909c707
Allow scrolling in the review panel to extend outside of top of text like Ace
2017-04-03 16:46:36 +01:00
James Allen
efac6b70f4
Merge pull request #468 from sharelatex/ja-allow-overlapping-comments
...
Allo overlapping comments
2017-04-03 14:04:14 +01:00
James Allen
1675185f37
Merge pull request #474 from sharelatex/pr-project-name-tooltip
...
Project name tooltip
2017-04-03 14:04:02 +01:00
Paulo Reis
6b9b8480a8
Only show the tooltip if the project name is truncated.
2017-03-31 16:36:58 +01:00
Paulo Reis
855d37289b
Use ISO strings instead of of date type in locally resolved comments.
2017-03-31 14:29:28 +01:00
Shane Kilkelly
15d0a40f85
When error occurs, unset state.inflight
2017-03-31 10:30:28 +01:00
Shane Kilkelly
49446afb82
Remove duplicate line
2017-03-31 10:30:10 +01:00
James Allen
4c8ce65ce7
Allo overlapping comments
2017-03-28 16:50:30 +01:00
Paulo Jorge Reis
67943a8906
Merge pull request #463 from sharelatex/pr-ab-test-add-comments
...
PR AB test "add comment" button
2017-03-27 09:32:49 +01:00
Paulo Reis
93934b9c8f
Use deploy date.
2017-03-27 09:32:02 +01:00
Henry Oswald
aa4f768513
Merge pull request #455 from sharelatex/ho-bug-fix
...
multiple small bug fixes
2017-03-27 09:28:28 +01:00
Paulo Reis
c72ee95177
Refactor AB test participation code; add conversion code.
2017-03-23 15:00:43 +00:00
Paulo Reis
254e4953cb
Wire-up AB test for adding comments.
2017-03-23 12:26:21 +00:00
James Allen
b22ef30876
Merge pull request #456 from sharelatex/ja-show-too-many-track-changes-error
...
Show an explanation error message on too many track changes error
2017-03-21 13:15:14 +00:00
James Allen
e705118dfe
Merge pull request #457 from sharelatex/pr-new-add-comment-btn
...
New "add comment" button
2017-03-21 13:15:03 +00:00
Paulo Reis
a35f2585c7
Remove unused flag.
2017-03-20 14:02:25 +00:00
Paulo Reis
0e24d7118d
Hide new UI behind query string parameter.
2017-03-20 13:56:36 +00:00
Paulo Reis
8951e91e31
Remove add comment button from the mini review panel.
2017-03-20 11:35:35 +00:00
Paulo Reis
2c2abc3cae
Wire up new button with existing UI for adding comments.
2017-03-20 11:18:29 +00:00
Paulo Reis
beac43741c
New add comment button.
2017-03-17 17:05:38 +00:00
Paulo Reis
c74449b2e3
Don't show the mini review panel when the only visible entry is the add comment one.
2017-03-17 16:28:21 +00:00
James Allen
3c2f5525a1
Show an explanation error message on too many track changes error
2017-03-17 14:49:32 +00:00
Henry Oswald
9a8ee112a5
null check path.split
...
https://sentry.io/sharelatex-1/sl-web-client-prod/issues/202702369/
2017-03-17 10:35:07 +00:00
James Allen
aa36768d8a
Remove debugging line
2017-03-16 16:01:03 +00:00
James Allen
6c1a15a698
Move comments when cutting and pasting
2017-03-16 15:48:57 +00:00
James Allen
fb91219661
Don't submit comment on clicking cancel
2017-03-08 11:38:28 +00:00
James Allen
a6679a1aeb
Stop local and remote ops being batched together in the undo manager if they happen in the same flush
2017-03-01 16:33:04 +00:00
James Allen
e1cf6229f7
Merge branch 'master' into ja-use-dirty-state
2017-03-01 10:03:00 +00:00
Paulo Reis
1646496f19
Patch overflow behaviour so that z-index is always higher by 1.
2017-02-24 14:38:46 +00:00
Paulo Reis
3bdbe7e538
Set synctex controls z-index to the minimum working value.
2017-02-24 14:36:08 +00:00
James Allen
dd0271e799
Only cancel deletes with inserts on undo and reject
2017-02-24 14:20:26 +01:00
James Allen
7418d12bf8
Defer updates of remote ops until Ace has been updated
2017-02-23 11:34:58 +01:00
James Allen
f4bbd8ea10
Use dirty state rather events to avoid O(N^2) behaviour
2017-02-23 11:27:19 +01:00
Paulo Reis
96c44eec38
Support values other than objects in the numKeys filter, returning zero if so.
2017-02-21 14:48:21 +00:00
Paulo Reis
7f6941677d
Check local storage on load; use explicit condition syntax.
2017-02-21 14:43:05 +00:00
Paulo Reis
2e8f917318
Support initial closed state.
2017-02-21 14:27:57 +00:00
Paulo Reis
5c7fc66964
Merge branch 'pr-collapse-overview-entries' of github.com:sharelatex/web-sharelatex into pr-collapse-overview-entries
2017-02-21 14:21:10 +00:00
Paulo Reis
33c8bc8684
Support saving state to local storage.
2017-02-21 14:20:51 +00:00
James Allen
00fce4d2da
Merge branch 'master' into pr-collapse-overview-entries
2017-02-21 14:25:45 +01:00
James Allen
f1baa1b8ad
Merge pull request #432 from sharelatex/ja-hide-offscreen-review-panel-entries
...
Only render the entries that are visible in the text
2017-02-21 10:28:45 +01:00
James Allen
f466be96dd
Make sure first change isn't hidden under toolbar
2017-02-21 09:58:49 +01:00
James Allen
3af7cdf0a9
Merge branch 'ja-scroll-review-panel-past-ace' into ja-hide-offscreen-review-panel-entries
2017-02-20 16:24:26 +01:00
James Allen
6c21d19894
Increase offscreen lines considered for visibility
2017-02-20 16:24:19 +01:00
James Allen
ad05cc288c
Do DOM reads first to prevent thrashing
2017-02-20 16:22:18 +01:00
James Allen
8c5800ceaf
Only render the entries that are visible in the text
2017-02-20 16:03:02 +01:00
James Allen
b52e4a5d1c
Reset scroll margins when changing document
2017-02-20 15:46:53 +01:00
James Allen
995fa6122b
Scroll the review panel past the limits of Ace
2017-02-20 12:56:26 +01:00
Paulo Reis
1e66c46ca7
Add filter to retrieve number of keys in objects.
2017-02-17 14:31:50 +00:00
Paulo Reis
cd2c8e7199
Add directive based on jQuery animation API.
2017-02-17 11:54:33 +00:00
Paulo Reis
0841ab8278
Add directive to collapse elements via height.
2017-02-17 11:24:21 +00:00
James Allen
31ae2e7124
Update RangesTracker
2017-02-17 09:24:25 +01:00
James Allen
c8a6555cb1
Update RangesTracker
2017-02-16 17:07:56 +01:00