Commit graph

7642 commits

Author SHA1 Message Date
David
635aae7b1f Merge pull request #18320 from overleaf/dp-add-secondary-prompt-ui
Add secondary email form V2 (with Captcha this time)

GitOrigin-RevId: b06216a2c9cb5b3b09305a17992eca506a0047f5
2024-05-27 10:22:40 +00:00
Eric Mc Sween
a22319fe46 Merge pull request #18453 from overleaf/em-fix-floating-promise
Fix no-floating-promises lint rule

GitOrigin-RevId: 58f89e0078abf72be65552f9468cb225e5758e3e
2024-05-27 10:22:24 +00:00
Eric Mc Sween
876ee4d967 Merge pull request #18225 from overleaf/em-typescript-eslint
Add typescript-eslint rule: no-floating-promises

GitOrigin-RevId: 8c3decdff537c885f5bfeb5250b7805480bc6602
2024-05-27 10:22:20 +00:00
Antoine Clausse
3300811d3a [web] Simplify removeSessionsFromRedis signature (#18440)
* Simplify `removeSessionsFromRedis` signature

* Update usage of `removeSessionsFromRedis`

* Fix tests around `removeSessionsFromRedis`

* Add comments "remove all sessions except the current session"

GitOrigin-RevId: 03bf99c14faf2c8e403bc4bcc16463a70e031284
2024-05-27 10:21:30 +00:00
Antoine Clausse
78a0bc2b05 [web] Convert RecurlyWrapper functions to async (#18384)
* Rename `RecurlyWrapper` to `promises`, as it will only contain the promises soon

* Update `apiRequest`

* Update `_parseXml`

* Update `_parseXmlAndGetAttribute`

* Update `_parse*Xml`

* Update `updateAccountEmailAddress`

* Update `checkAccountExists`

* Update `createAccount`

* Update `createBillingInfo`

* Update `setAddressAndCompanyBillingInfo`

* Update `createSubscription`

* Update `_createPaypalSubscription`

* Update `_handle422Response`

* Update `_createCreditCardSubscription`

* Update `createSubscription`

* Update `getSubscriptions`

* Update `getSubscription`

* Update `getPaginatedEndpoint`

* Update `getAccount`

* Update `getAccountActiveCoupons`

* Update `getCoupon`

* Update `getBillingInfo`

* Update `getAccountPastDueInvoices`

* Update `attemptInvoiceCollection`

* Update `updateSubscription`

* Update `createFixedAmmountCoupon`

* Update `lookupCoupon`

* Update `redeemCoupon`

* Update `extendTrial`

* Update `listAccountActiveSubscriptions`

* To find which functions to add as callbackified, I used this Regex:
`RecurlyWrapper\.(?!promises)[^.\s]*`

And after adding callbackified functions, we're left with no results with the Regex:
`RecurlyWrapper\.(?!promises|apiUrl|_buildXml|_parseXml|attemptInvoiceCollection|createFixedAmmountCoupon|getAccountActiveCoupons|getBillingInfo|getPaginatedEndpoint|getSubscription|updateAccountEmailAddress)[^.\s]*`

* Update unit tests

* Test `getSubscription` both as "promise" and as "callback"

I'm not sure if we want to generalize this.

* Fix: add missing `await`s (!!)

* Change `apiRequest` to reject errors instead of resolving it in an object

* Fixup for CollectPayPalPastDueInvoice test

* Fix: callbackify `getSubscriptions` (!!)

* Replace `.then(...)` chain by multiple `await`

* Fixup `attemptInvoicesCollection`: prevent reading length of undefined

* Use `return await` when returning promises

Per https://github.com/overleaf/internal/pull/18384#pullrequestreview-2065738771

GitOrigin-RevId: ceda755b24fd29f97a27e60ac5db9bc7e369f932
2024-05-27 10:21:26 +00:00
ilkin-overleaf
7ca9a5b61b Merge pull request #18415 from overleaf/ii-delete-with-body
[web] Replace delete with post requests when having body

GitOrigin-RevId: b580cfa3bd53c21f46de72f3a36b647fda143b04
2024-05-21 08:04:44 +00:00
Rebeka Dekany
1aa5ee7b21 Merge pull request #18404 from overleaf/rd-bs5-dropdown-fix
[web] Fix footer layout on the smallest viewport Bootstrap 5

GitOrigin-RevId: 741540ff5e25fe36021d0a2ef2d433dc63ee3650
2024-05-20 08:04:27 +00:00
Eric Mc Sween
dfd1652c35 Merge pull request #18375 from overleaf/em-promisify-chat-api-handler
Promisify ChatApiHandler

GitOrigin-RevId: 83cedb14b5e2b187fb2cb02fcbf888ada5a599b1
2024-05-20 08:04:22 +00:00
Antoine Clausse
25d8e053be [web] Update revokeAllUserSessions and rename it to removeSessionsFromRedis (#18360)
* Fix `revokeAllUserSessions` call in `_cleanupUser`

The user object should be passed, not the _id

* Change `revokeAllUserSessions` signature, take `req` and `stayLoggedIn` arguments

* Update uses of `revokeAllUserSessions`

* Fix promisified `revokeAllUserSessions` args

* Update tests

* Destroy or Regenerate the session in the end of `revokeAllUserSessions`

Per https://github.com/overleaf/internal/issues/17036#issuecomment-1938398570

* Revert "Destroy or Regenerate the session in the end of `revokeAllUserSessions`"

This reverts commit fe30734dbe45b27d2931d2e43a711d591bb85787.

* Rename `revokeAllUserSessions` to `removeSessionsFromRedis`

* Fixup tests

* Fix: add optional chaining in `req.sessionID` (!!)

GitOrigin-RevId: d41676bf00f463230af495e09c65fb9ee521f49f
2024-05-20 08:04:12 +00:00
Christopher Hoskin
3342d672c2 Merge pull request #18397 from overleaf/em-revert-download-all-link
Revert "Merge pull request #18190 from overleaf/ar-add-download-all-l…

GitOrigin-RevId: 681eb2734636d76558e682dc85083bfcaa6b7d2d
2024-05-17 08:05:10 +00:00
Rebeka Dekany
f652c49713 Merge pull request #18386 from overleaf/rd-footer-pug
[web] Migrate the language dropdown in footer to Bootstrap 5

GitOrigin-RevId: 07a37f59914c543ae8d33312aa313451145cd220
2024-05-17 08:05:02 +00:00
Tim Down
97add91248 Merge pull request #18377 from overleaf/td-metrics-page-fix
Move Bootstrap and jQuery imports into metricsApp

GitOrigin-RevId: 3ec1690ca60928e983211792f6c6b63548dfe62c
2024-05-16 08:05:35 +00:00
Jakob Ackermann
dfe587f297 Merge pull request #18294 from overleaf/jpa-td-invite-details
[web] avoid content reflection via query parameter on register page

GitOrigin-RevId: 43e7ba6069e0d9f3f12e5e9e680b5960b0673782
2024-05-16 08:05:09 +00:00
Andrew Rumble
105d67bd04 Merge pull request #18190 from overleaf/ar-add-download-all-link
[web] Add download all link for output files

GitOrigin-RevId: a275f17b6acf3130250d91462ba01588b93b62f5
2024-05-16 08:05:04 +00:00
Tim Down
0886104862 Merge pull request #18276 from overleaf/td-bs5-load-js
Load correct JS for the active Bootstrap version, second attempt

GitOrigin-RevId: ad8748a941691d745db5cd3e986e9c7b188b3ecb
2024-05-16 08:04:59 +00:00
M Fahru
5c44fb8e9d Merge pull request #18281 from overleaf/mf-decaffeinate-server-admin-controller
[web][admin panel] Decaf cleanup of AdminController

GitOrigin-RevId: fca50565e140435b833c303d2a0dfac7449c3e17
2024-05-15 08:05:24 +00:00
M Fahru
ec1ab82789 Merge pull request #17479 from overleaf/mf-clean-up-plans-styling
[web] Clean up plans page styling

GitOrigin-RevId: fe05e9a1fd6c29c62941c878fe5e676d062c37de
2024-05-15 08:05:20 +00:00
Antoine Clausse
9419cc3b37 [web] Add tests to collect_paypal_past_due_invoice.js + update logging (#18310)
* Fix: Invoices collected array length comparison

Update the code with the correct condition to respect the intent of the previous implementation ("exit with non zero code when no invoicess were processed").
See 5476f39984

However, I'm not sure if erroring when no invoices are collected is actually what we want to do.

* Wrap `collect_paypal_past_due_invoice` script and export the function

* Fixup typo `accoutns`

* Log invoices collection data before throwing

* Add note: `handleAPIError` is silencing the errors

* Create a test on `collect_paypal_past_due_invoice`

* Replace `console.log` by `@overleaf/logger` (bunyan)

Our `console.warn` show up as Errors (in red) in GCP. For example the following is an error in GCP:
```
Errors in attemptInvoiceCollection with id=2693634 OError: Recurly API returned with status code: 400
```
https://github.com/overleaf/internal/blob/5476f39/services/web/scripts/recurly/collect_paypal_past_due_invoice.js#L9

---

Does it correctly set the levels as warnings if we use `@overleaf/logger`

GitOrigin-RevId: 37c8bdf4afd8cef4706700aafb44480ec8966a74
2024-05-15 08:04:46 +00:00
David
6718729087 Merge pull request #18318 from overleaf/dp-revert-secondary-email
Revert "Merge pull request #18139 from overleaf/dp-add-secondary-prompt-ui"

GitOrigin-RevId: d8af37a5c332ac21ddd4c85679553df0bda326f9
2024-05-14 08:04:11 +00:00
David
0630e96d49 Merge pull request #18139 from overleaf/dp-add-secondary-prompt-ui
Add UI for secondary email prompt

GitOrigin-RevId: 887b2c7f0047f19b605f03745f7dda83926ec70b
2024-05-14 08:04:01 +00:00
Brian Gough
41cb0859db Merge pull request #18283 from overleaf/bg-session-secret-use-session-secret-in-web
replace SECURITY_SESSION_SECRET with SESSION_SECRET in web

GitOrigin-RevId: f6ff5f13cf04e1b59fe44a394a0888af55ae140f
2024-05-14 08:03:57 +00:00
Jakob Ackermann
9ea6b2f8b1 Merge pull request #18252 from overleaf/jpa-refactor-for-flaky-test
[web] refactor background job for setting root doc automatically

GitOrigin-RevId: 719c010eb3e5b692908b7a6fea9d8522b9fc01b9
2024-05-09 08:05:23 +00:00
Copybot
9ee7c86b41 Merge pull request #1208 from tgotowik:hotfix-user-create-mail
GitOrigin-RevId: 8e4c159513533598b1ad3eb223a4a7033a2ef736
2024-05-09 08:05:19 +00:00
Jessica Lawshe
c6b88085d5 Merge pull request #18188 from overleaf/jel-react-group-invite
[web] Migrate team invite to React

GitOrigin-RevId: 32e968c3b512020aef9a396808c73a7b4859e6d1
2024-05-09 08:05:03 +00:00
Antoine Clausse
eca84b9370 Reintroduce compile sampling for analysis (#18217)
* Revert "Merge pull request #14143 from overleaf/jlm-unsampled-compiles"

This reverts commit 2457977d61756be52db506d7c84531b22a26abe0, reversing
changes made to 3c452b3943c453707aac90d38e7b5b2ea9df0df4.

* Re-add export of `getPercentile` in SplitTestHandler.js

Was previously removed in aa8c0aadec

GitOrigin-RevId: 42c48829e7246a6bdb9dbb2d075638c1eafdf2f0
2024-05-06 08:04:45 +00:00
Jakob Ackermann
9981be0cc1 Merge pull request #18199 from overleaf/jpa-cleanup-redirects
[web] cleanup redirects in session when reaching project dashboard

GitOrigin-RevId: aff131ebf68dda059d7d6949563e72834decd894
2024-05-06 08:04:10 +00:00
Alf Eaton
9729befe59 Merge pull request #18170 from overleaf/ae-token-access-page
Convert token access page to React

GitOrigin-RevId: d7434f0de395c47a95d00767727fbe9d43f9abca
2024-05-03 08:05:01 +00:00
Jakob Ackermann
4c49841637 Merge pull request #18153 from overleaf/jpa-validate-session-in-store
[web] check for redis connection being out of sync in session store

GitOrigin-RevId: c271e88d4e1fbcb0f7a57f4775e8ef88b70b16a8
2024-05-03 08:04:25 +00:00
Jakob Ackermann
0576e02127 Merge pull request #18152 from overleaf/jpa-stricter-session-validation
[web] stricter session validation

GitOrigin-RevId: 3ef916318fde7f31e3e3fd0f7082dde7a2975a27
2024-05-03 08:04:20 +00:00
Tim Down
a452e1e8cd Merge pull request #18195 from overleaf/revert-18120-td-bs5-load-js
Revert "Load correct JS for the active Bootstrap version"

GitOrigin-RevId: 7f6e846b5461cfbacec874ed55bba577e414f3a6
2024-05-03 08:04:16 +00:00
Tim Down
56150d9dbc Load correct JS for the active Bootstrap version (#18120)
* Load correct JS for the active Bootstrap version

* Tidy up bootstrapVersion declaration

* Add Bootstrap JS to website redesign layout

* FIx error on interstitial subscriptions page

* Remove unnecessary import of jQuery and Bootstrap

* Use global entrypointScripts in bootstrap-js mixin

GitOrigin-RevId: 6b1977354a72dc69008fc0d2e3baec2f28d97f6b
2024-05-03 08:04:07 +00:00
Jessica Lawshe
ae0abd6445 Merge pull request #18159 from overleaf/jel-group-invite-header
[web] Break word on group invite header

GitOrigin-RevId: 790c24e8291f1dbdfa9231e4c9e3d4e531bf2b8f
2024-05-02 08:03:52 +00:00
Rebeka Dekany
62c2937dac Merge pull request #18164 from overleaf/rd-remove-endpoints
[web] Remove publicly accessible endpoints

GitOrigin-RevId: c8e57faf6418274cac36b6e721c97a4ca70a1193
2024-05-01 08:04:46 +00:00
Andrew Rumble
9c3d9ef590 Merge pull request #17935 from overleaf/ar-refactor-compile-async
[web] make CompileManager async

GitOrigin-RevId: 617bde1f429fa9aafc7d4bf4ec628b2a22386b19
2024-04-30 08:04:43 +00:00
Brian Gough
29105911c5 Merge pull request #17732 from overleaf/bg-session-mitigation-initial-protoype
anonymous cookie-based sessions module

GitOrigin-RevId: 75fe2d48fa384ba8d07c0b478a9a5a907a2b3b67
2024-04-26 08:04:54 +00:00
Jakob Ackermann
90a02ebc2f Merge pull request #17949 from overleaf/jpa-set-nx-xx
[web] stricter writes to redis when creating and updating sessions

GitOrigin-RevId: 79723e0d38884bf723c7a2ba32993e4daa2612a0
2024-04-26 08:04:35 +00:00
Antoine Clausse
ede03daafd Rename test to local-ccy-format-v2 to restart with clean data (#18115)
GitOrigin-RevId: 610495f41d69f8cac1a427ef7b8d64886bc5cdba
2024-04-26 08:04:26 +00:00
Antoine Clausse
e32b4f0db1 [web] Handle error cause by currencyDisplay: 'narrowSymbol' in old browsers (#18060)
* Handle error cause by `currencyDisplay: 'narrowSymbol'` in old browsers

RangeError
Value narrowSymbol out of range for Number.prototype.toLocaleString options property currencyDisplay

* Make `formatCurrencyLocalized` bulletproof

GitOrigin-RevId: 26e8abc6f9fb7c06c2d14b9d86af2d84fb9f32e3
2024-04-26 08:04:22 +00:00
David
c2448ff3d2 Merge pull request #17947 from overleaf/dp-secondary-email-confirmation-code
Add endpoints for secondary email confirmation by code

GitOrigin-RevId: c2829672fd9aeca457f76958d4922b9c95086f26
2024-04-26 08:04:00 +00:00
Jessica Lawshe
8d1885cd50 Merge pull request #18073 from overleaf/jel-sso-disabled-email-alert
[web] Send SSO disabled email to non-managed and linked users

GitOrigin-RevId: d5e6739efd432b396dcd7fa3dd37e18d2b9dc933
2024-04-25 08:05:30 +00:00
Jessica Lawshe
0b86bc04ad Merge pull request #18045 from overleaf/jel-user-settings-sso-groups
[web] Use `getUserGroupsSSOEnrollmentStatus` helper

GitOrigin-RevId: 4846d513964a63afb620ee2dbb5b810dd0aa4e60
2024-04-25 08:05:22 +00:00
Jessica Lawshe
7e3dfded2d Merge pull request #17821 from overleaf/jel-subscription-populate
[web] Only populate the required admin data for the subscription

GitOrigin-RevId: 4c2de85ce9f26b337deeff491b40d74756f21702
2024-04-25 08:05:03 +00:00
Jessica Lawshe
94e9456a4b Merge pull request #17793 from overleaf/jel-password-token-when-managed-linked
[web] Check permissions when using password reset token

GitOrigin-RevId: b5339d5ad5322fcae7beaa99fb40a87ffb938b52
2024-04-25 08:04:58 +00:00
David
2a725b3a26 Merge pull request #18077 from overleaf/dp-teardown-share-modal-paywall-split-test
Tear down project-share-modal-paywall split test

GitOrigin-RevId: b85e6cdf2243a76d071607e55a33f9909f704b76
2024-04-25 08:04:21 +00:00
Jimmy Domagala-Tang
2c11ad84e0 Merge pull request #18071 from overleaf/jdt-bib-events
Bibliography events for 3rd party integrations

GitOrigin-RevId: d8d7f4378d75166481d5265d2e8bef72d75968c3
2024-04-24 08:05:11 +00:00
Antoine Clausse
0c4ca15003 [web] Add #main-content to some pug pages (fix skip-to-content links) (#18050)
* Add `#main-content` to some pug pages

This fixes our `skip-to-content` accessibility anchor links. Alternatively or additionally, we can set `suppressSkipToContent = true` in some pages: that will remove the anchor link in the page.

While working on this, I noticed that sometimes we still have a bit of extra nesting or components that should maybe be out of `<main>` or `#main-content`. In a future PR we can maybe update these elements to target the "real core content" of the page.

* Add `suppressSkipToContent` in confirm-email page

GitOrigin-RevId: 6cbf4112f2d1a2d8eff06f142d0c2b4f3a5d9cff
2024-04-24 08:04:43 +00:00
Antoine Clausse
2a5dca0897 [web] Fix thousands separators in plan page for LATAM currencies (#18068)
Use function from https://github.com/overleaf/internal/blob/e486f2fc/services/web/scripts/plan-prices/plans.js#L123-L135

GitOrigin-RevId: e83ea429112c92e07857ee4d3e5fd43c81fcb871
2024-04-24 08:04:39 +00:00
Mathias Jakobsen
5aee58c6f4 Merge pull request #17956 from overleaf/mj-web-promisify-restore-manager
[web] Promisify RestoreManager

GitOrigin-RevId: cd3395f8cb7b90e19828297e1c89c1d3850877a6
2024-04-24 08:04:26 +00:00
David
ce00af7838 Merge pull request #18011 from overleaf/dp-make-_getRedirectFromSession-public
Make _getRedirectFromSession a public method

GitOrigin-RevId: 6538e4ec25e607d32beb944370d151d4f1a3709c
2024-04-24 08:04:13 +00:00
Alf Eaton
98cefaa5bd Remove "upgrade to annual" page (#18014)
GitOrigin-RevId: b9f92ad038adab7fc7eb5e2a7175461bfefee379
2024-04-24 08:04:04 +00:00
Alexandre Bourdin
1336b2daeb Merge pull request #18058 from overleaf/ab-split-test-convert-race-cond-fix
[web] Prevent failure due to race condition where converting anon assignments

GitOrigin-RevId: 81eb16689724b9ddc2ec7e23df2c3ea55837b83c
2024-04-23 08:05:54 +00:00
Jimmy Domagala-Tang
4fcade16cb Merge pull request #17888 from overleaf/jdt-async-tpr
Async Await the third party references module

GitOrigin-RevId: 58bbc4160cf00bf26b2cd2ea81659ba213f95294
2024-04-23 08:05:50 +00:00
Alf Eaton
1f14746111 Remove latex-log-parser split test (#17999)
GitOrigin-RevId: 5accb0e5fc4c1ecce563f1d6f991de8c8633308b
2024-04-23 08:05:16 +00:00
Alexandre Bourdin
9fc6fa9b77 Merge pull request #18017 from overleaf/ab-convert-assigned-at-date
[web] Transform assignedAt back to date for conversion

GitOrigin-RevId: bd0213b337f765d8512386f9f5d3fc6d03572e33
2024-04-23 08:04:52 +00:00
Alexandre Bourdin
3022f573e9 Merge pull request #18022 from overleaf/revert-18018-revert-17906-ab-split-test-assignments-optim-pt2
Revert "Revert "[web] Store anonymous users split test assignments in new format in session""

GitOrigin-RevId: bd48a21c17df91eda1536378d8d999a1933e83a2
2024-04-23 08:04:47 +00:00
Davinder Singh
a179751986 Merge pull request #17866 from overleaf/ds-banner-labels
Geo Pricing- Update Banner message on Latam america

GitOrigin-RevId: 7a8adf8e31e7ba4bc1b415a26c492bf6e5867328
2024-04-23 08:04:19 +00:00
roo hutton
06cac44d84 Merge pull request #18021 from overleaf/rh-mailchimp-api
[web] Replace node-mailchimp with own MailChimpClient

GitOrigin-RevId: 10207620c48f30ad29f4f0e7ea5193c11d256902
2024-04-22 08:04:33 +00:00
roo hutton
9601fd097a Merge pull request #17946 from overleaf/rh-promisify-third-party-identity-
[web] Promisify ThirdPartyIdentityManager and ThirdPartyIdentityManagerTests

GitOrigin-RevId: f7d24f73213fb0a43eb453aa21749b21ba60b83d
2024-04-22 08:04:28 +00:00
Christopher Hoskin
2100cd14fc Merge pull request #18012 from overleaf/bg-mongo-upgrade-remove-sort-from-project-deactivation-query
Simplify query for old projects in InactiveProjectManager

GitOrigin-RevId: 6c712c3b095abec9c777332a07ed888178947b40
2024-04-22 08:03:55 +00:00
Alexandre Bourdin
14bbc65e99 Merge pull request #18018 from overleaf/revert-17906-ab-split-test-assignments-optim-pt2
Revert "[web] Store anonymous users split test assignments in new format in session"

GitOrigin-RevId: 2c1a95031a9d1d99b9dfef54eb4b80264a32ba0d
2024-04-19 08:04:27 +00:00
Alexandre Bourdin
bfe75c7d31 Merge pull request #17906 from overleaf/ab-split-test-assignments-optim-pt2
[web] Store anonymous users split test assignments in new format in session

GitOrigin-RevId: a5f71f7dcad7e7b11fc6a391bd5182525b3bdf03
2024-04-19 08:04:23 +00:00
Alexandre Bourdin
e4e054e8bb Merge pull request #18008 from overleaf/ab-fix-anon-assignment-append
[web] Fix anonymous assignment append to session

GitOrigin-RevId: 402cd94ec6250e15f0e35cb69af3977c78ec5a7d
2024-04-19 08:04:19 +00:00
Alexandre Bourdin
cdf4f98c87 Merge pull request #17957 from overleaf/ab-archive-test-slack-notif-date
[web] Send correct date for Slack notification when archiving a split test

GitOrigin-RevId: acf39915e3362f90b431b6c973e1191428acd9c9
2024-04-19 08:04:15 +00:00
Alexandre Bourdin
bee4c95c28 Merge pull request #17907 from overleaf/ab-split-test-assignments-optim-pt1
[web] Read anonymous split test assignments in session from both old&new fields

GitOrigin-RevId: 5235bb3e7d72d5ff9e89c6543b70fb80e9f1213c
2024-04-19 08:04:11 +00:00
Domagoj Kriskovic
945e51b8ed [web] add Revert File button behind a feature flag (#17975)
* [web] add Revert File button behind a feature flag

* improve error message

* use constant for timeout

GitOrigin-RevId: 047c35d22e948351c52d469e48b869719f44ec4f
2024-04-19 08:04:06 +00:00
David
0cf17478fe Merge pull request #17810 from overleaf/dp-compormised-password-prompt
Add compromised password prompt

GitOrigin-RevId: 7910a220943fcb3aa191da6d514d5bc3ae20f5a3
2024-04-19 08:03:58 +00:00
Antoine Clausse
b2ef7a935f [web] Use localized number formatting for currencies (#17622)
* Add a unit test on `SubscriptionFormatters.formatPrice`

* Add JSDoc to `formatPrice`

Also: Name the functions before exporting:
This fixes my IDE (WebStorm) navigation

* Make `'USD'` the default param instead of reassigning

* Create `formatCurrency` function

* Use `formatCurrency` in SubscriptionFormatters

* Use an `isNoCentsCurrency` logic for `CLP` `JPY` `KRW` `VND`

And remove custom `CLP` logic and locale

* Add `locale` param to `formatPrice`

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Update scripts/plan-prices/plans.js to generate numbers instead of localized amounts

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Remove generation of `plans.json`

As /services/web/frontend/js/main/plans.js was removed in https://github.com/overleaf/internal/pull/12593

* Sort currencies in alphabetical order in scripts/plan-prices/plans.js

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Use `formatCurrency` in price-summary.tsx

* Use `formatCurrency` in Subscription Pug files

* Fix unit tests SubscriptionHelperTests.js

* Remove unused `currencySymbol`

* Change to `formatCurrency` in other React components

* Add `CurrencyCode` JSDoc types

* Duplicate `formatCurrency` into services/web/app/src/util

* Wrap tests in a top-level describe block

* Use `narrowSymbol`

* Fix tests with `narrowSymbol` expects

* Revert deletion of old `formatPrice` in SubscriptionFormatters.js

* Rename `formatCurrency` -> `formatCurrencyLocalized`

* Revert deletion of `CurrencySymbol`

* Add split-test in SubscriptionController.js

* Add split-test in SubscriptionViewModelBuilder.js

* Add split-test in plans

* Add split-test in subscription-dashboard-context.tsx

* Add split-test in 4 more components

* Update tests

* Show currency and payment methods in interstitial page

* Fix `&ndash;` being printed. Use `–` instead

* Fix test with NOK

* Storybook: Fix missing `SplitTestProvider`

* Storybook: Revert "Remove unused `currencySymbol`"

This reverts commit e55387d4753f97bbf8e39e0fdc3ad17312122aaa.

* Replace `getSplitTestVariant` by `useSplitTestContext`

* Use parameterize currencyFormat in `generateInitialLocalizedGroupPrice`

* Fixup import paths of `formatCurrencyLocalized`

* Replace `% 1 === 0` by `Number.isInteger`

* Add comment explaining that any combinations of languages/currencies could happen

* Fixup after rebase: import `useSplitTestContext`

* Revert "Remove SplitTestProvider from subscription root"

This reverts commit be9f378fda715b86589ab0759737581c72321d87.

* Revert "Remove split test provider from some tests"

This reverts commit 985522932b550cfd38fa6a4f4c3d2ebaee6ff7df.

GitOrigin-RevId: 59a83cbbe0f7cc7e45f189c654e23fcf9bfa37af
2024-04-19 08:03:54 +00:00
Antoine Clausse
76955c814a Remove subscription-cancel-button (#17976)
I believe this was already removed since https://github.com/overleaf/internal/pull/13311

GitOrigin-RevId: e486f2fce794fc9d587da331547834c3b6158ceb
2024-04-19 08:03:49 +00:00
Thomas
52e6ceef67 Merge pull request #17898 from overleaf/tm-remove-twitter-login
Remove twitter login code and uninstall passport-twitter

GitOrigin-RevId: 928c877ef2a42d5881652cad7f9d563c7766fd36
2024-04-18 08:04:16 +00:00
roo hutton
d53a3e315e Merge pull request #17879 from overleaf/rh-refresh-collab
Refresh websocket on collaborator change

GitOrigin-RevId: b05444d592f5952a08bad51c9f529ed9183d042f
2024-04-17 08:05:18 +00:00
Alf Eaton
4a68a5f8bc Discontinue the bonus program (#17919)
GitOrigin-RevId: d30ace08a340dd17a68c3cfe82e589bb37b5959f
2024-04-17 08:04:58 +00:00
Antoine Clausse
616bd0df16 Merge pull request #17925 from overleaf/jpa-ac-20s-timeout-migration-logging-tweaks
[web] timeout 20s split-test teardown cleanups (remove override, remove tests, ...)

GitOrigin-RevId: 8d8c44539cf45d0f5142f84cf8372cecda3bf77a
2024-04-17 08:04:30 +00:00
Jakob Ackermann
ac2ea9f34d Merge pull request #17865 from overleaf/jpa-open-in-overleaf-session-storage
[web] open-in-overleaf: cleanup redis and browser session storage

GitOrigin-RevId: af79bb49ff474545fc0d206d2a6f5a0ffa1416bc
2024-04-17 08:04:04 +00:00
Antoine Clausse
d35204033f Merge pull request #17909 from overleaf/ac-tear-down-compile-timeout-tests-2
[web]  Remove split-tests `compile-backend-class*` and `compile-timeout-20s*` (attempt 2)

GitOrigin-RevId: 5658f2977d3e7089eec5bbe7a33eee81c153e41d
2024-04-16 08:04:08 +00:00
Torben
78bd986d0e Since the creation of the user happens asynchronously, the node process dies before it has created the user or sent the mail. 2024-04-15 14:45:40 +02:00
Alexandre Bourdin
5f8db6ee23 Merge pull request #17799 from overleaf/ab-account-deletion-audit-log
[web] Add audit log when user account is deleted or recovered

GitOrigin-RevId: 3d5f99705fbd6192ccae430e040be4b7fcb3f740
2024-04-15 08:04:42 +00:00
Antoine Clausse
491bc2628d Merge pull request #17899 from overleaf/revert-17700-ac-tear-down-compile-timeout-tests
Revert "[web] Remove split-tests `compile-backend-class*` and `compile-timeout-20s*`"

GitOrigin-RevId: d5070ced06adbd435e782a44b7ef767e395bd6a0
2024-04-15 08:04:37 +00:00
Antoine Clausse
2dd10c7fee [web] Remove split-tests compile-backend-class* and compile-timeout-20s* (#17700)
* Remove split-tests of `compile-timeout-20s` and `compile-timeout-20s-existing-users`

* Remove `NEW_COMPILE_TIMEOUT_ENFORCED_CUTOFF` variables

* Revert timeout override `60` -> `20`

* Update settings.overrides.saas.js: `compileTimeout: 20`

* Remove `compile-backend-class-n2d`

* Remove `force_new_compile_timeout`

* Remove `showNewCompileTimeoutUI`

* Remove `compileTimeChanging`

* Simplify code by removing segmentation object

* Remove `CompileTimeoutChangingSoon`

* Remove `user.features.compileTimeout = '20 (with 10s prompt)'`

* Remove `CompileTimeWarning`

* Remove `TimeoutUpgradePrompt` (old)

* Remove `compile-backend-class`

* Remove unused translations

* Update tests

* Fix: Show `CompileTimeout` even if `!window.ExposedSettings.enableSubscriptions`

* Create script to migrate users to 20s compileTimeout

* migration script: exclude `compileTimeout: 20` from the match

* migration script: use `batchedUpdate`

* Remove `showFasterCompilesFeedbackUI` and `FasterCompilesFeedback`

Helped-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Remove `_getCompileBackendClassDetails`, simplify definition of `limits` object

* Remove `Settings.apis.clsi.defaultBackendClass`

* Remove unnecessary second scan of the whole user collection in dry mode

* Override `timeout` to 20 for users having `compileGroup === 'standard' && compileTimeout <= 60`

* Remove second `logCount`: re-run the script in dry-mode if you want to see that count

* Use secondary readPreference when counting users

* Fix script setup and exit 0

* Fix: Remove `user.` from query path!

* Add acceptance test on script migration_compile_timeout_60s_to_20s.js

GitOrigin-RevId: 3cb65130e6d7fbd9c54005f4c213066d0473e9d8
2024-04-15 08:04:24 +00:00
roo hutton
03fb015f8f Merge pull request #17856 from overleaf/rh-deletion-email-update
[web] Use securityAlert template for user deletion email

GitOrigin-RevId: 60dfef18946710f5d5df17daca1a0bdc9800519b
2024-04-12 08:06:40 +00:00
roo hutton
754609f379 Merge pull request #17830 from overleaf/rh-reduce-staff-access-session
[web] Reduce size of staffAccess field in session

GitOrigin-RevId: 7745dc595e8096caef04fd140b47532f0775f165
2024-04-12 08:06:35 +00:00
Jessica Lawshe
955c860b64 Merge pull request #17841 from overleaf/jel-lint-populate
[web] Add linting rule for mongoose `populate`

GitOrigin-RevId: 625b2b5f9db4e88ce0d629752f083b8be71c7766
2024-04-12 08:06:18 +00:00
Jessica Lawshe
0cfcdf5e4d Merge pull request #17822 from overleaf/jel-dash-usersBestSubscription
[web] Limit data sent to dash for best subscription when group

GitOrigin-RevId: d52101bec69cbb7931e9702e085b4aeb65d9d603
2024-04-12 08:06:09 +00:00
Jessica Lawshe
751e079105 Merge pull request #17817 from overleaf/jel-group-subscription-page
[web] Only send necesssary group subscription data to frontened

GitOrigin-RevId: bf49245e573bb9a1ec4bafc85cc6d0b7fd5f3e6f
2024-04-12 08:06:04 +00:00
Jakob Ackermann
ea0a99253c Merge pull request #17864 from overleaf/jpa-fix-redirect
[web] fix navigation flow after try premium page when using skip button

GitOrigin-RevId: 1ae7ccdb14f7125919bc97746761a21c6896938f
2024-04-12 08:05:15 +00:00
Tim Down
a345eb42c2 Merge pull request #17712 from overleaf/td-bs5-feature-flag
Add feature flag check and per-page opt-in for Bootstrap 5

GitOrigin-RevId: 111474c19f0202efc4e701eef597c7653f8e8b61
2024-04-12 08:05:10 +00:00
David
ce5d190c4a Merge pull request #17833 from overleaf/dp-add-secondary-prompt
Update primary email check form to match new designs

GitOrigin-RevId: b740255e3615bd7807845c533472aabb263d69ea
2024-04-11 08:04:20 +00:00
roo hutton
bf7a18db8b Merge pull request #17730 from overleaf/rh-acct-delete-email
[web] Send email notification on account deletion

GitOrigin-RevId: 03c0effba0ee3b829f5b4fe377fe67d05776ba3f
2024-04-10 08:04:12 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540)
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
2024-04-10 08:04:08 +00:00
Davinder Singh
2ba92141ee Merge pull request #17719 from overleaf/ds-latam-pricing-web-config
Latam Geo Pricing V2 - Updating Web configurations file for new prices

GitOrigin-RevId: 0cd7abc565e971dd68f0860f00ea2ed8c1e713f8
2024-04-09 08:04:10 +00:00
Davinder Singh
998d55d159 Merge pull request #17559 from overleaf/ds-latam-v2
LATAM Geo Pricing - Introducing split test in LATAM countries Round 2

GitOrigin-RevId: 76ab880262f126f8db7f8e577154d78b5e9abf7a
2024-04-09 08:04:06 +00:00
M Fahru
9e318f24ff Merge pull request #17594 from overleaf/mf-website-redesign-register
[web] Website redesign for register page

GitOrigin-RevId: a8ae7327b1d662cb442e44992c5e2676a23cca3e
2024-04-08 08:04:33 +00:00
roo hutton
8644e239c6 Merge pull request #17596 from overleaf/rh-permissions-policy
[web] Add Permissions-Policy header

GitOrigin-RevId: 8934bbbda411102580d9ef8af135dcdc147627f9
2024-04-08 08:04:29 +00:00
roo hutton
67e9a40e87 Merge pull request #17680 from overleaf/rh-promisify-templates-man
[web] Promisify TemplatesManager and TemplatesManagerTests

GitOrigin-RevId: 69ff0a5f34ceb7b4c23452bb00963eda35621f3f
2024-04-08 08:04:25 +00:00
David
bedc54e632 Merge pull request #17734 from overleaf/dp-privacy-policy-link
Add privacy notice link to registration smallprint

GitOrigin-RevId: 893363b86753b7464f36620cde1952e2b6644a5f
2024-04-08 08:04:08 +00:00
David
b1928cecef Merge pull request #17530 from overleaf/dp-teardown-onboarding-flow-split-test
Teardown onboarding flow split test

GitOrigin-RevId: 48e95e4e736772074cb68d195fc950a9da3aebcf
2024-04-08 08:04:04 +00:00
M Fahru
eaea8a4979 [web] Implement new notification style for homepage registration form (#17695)
The new notification style is implemented as a separate function (pug mixin), so in order to update all of our forms, we need to explicitly change the function call in the other pug templates. This way, we can update all the other forms with the new notification style gradually.

GitOrigin-RevId: 78b755468e3e70f08500bdfb6280fa79853c3ed1
2024-04-05 08:04:18 +00:00
Domagoj Kriskovic
b3d2d73136 Add externalUserId in ThirdPartyIdentityExistsError info (#17709)
* Add externalUserId in ThirdPartyIdentityExistsError info

* format fix

GitOrigin-RevId: 85370987ff7a9caa54102bf9013ebc655a2d383b
2024-04-04 08:03:54 +00:00
Antoine Clausse
92a58c8f3b [web] Paywall CTA split-test (#17555)
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
2024-04-03 08:04:16 +00:00
Brian Gough
cdf31ed91c Merge pull request #17675 from overleaf/bg-session-mitigation-redis-store-metrics
add CustomSessionStore class to handle session metrics and logging

GitOrigin-RevId: 49d4cda9fd94a8801adb33e894be239dc38ad544
2024-04-03 08:03:55 +00:00
M Fahru
d836631902 Merge pull request #17548 from overleaf/mf-promisify-render-set-password-form
[web] promisify renderSetPasswordForm

GitOrigin-RevId: 3a79a7fd23de2d7ff87a833204298aed6cc303a5
2024-03-29 09:04:26 +00:00
Mathias Jakobsen
192c497508 Merge pull request #17671 from overleaf/mj-project-projection
[web] Use projection when fetching project

GitOrigin-RevId: 4c7eb6582dba9ffa81f8d34c4e353faf1dc15c83
2024-03-29 09:04:13 +00:00
Mathias Jakobsen
48f8fe9dd6 [web] Add current history tab to admin panel (#17482)
* [web] Add current history tab to admin panel

GitOrigin-RevId: 95a479d01bdf2ca65cd9b18077823d895cc12501
2024-03-29 09:04:02 +00:00
Jessica Lawshe
3437ddb203 Merge pull request #17592 from overleaf/jel-sso-enrollment-page
[web] Return 403 on group SSO enrollment page if group does not have feature

GitOrigin-RevId: ce6bbf69da2ff332ffa541f8febf8fb298ea743a
2024-03-28 09:04:49 +00:00
Rebeka Dekany
8dd5b2574e Merge pull request #16261 from overleaf/rd-rate-limiter
[web] Add rate limits for subscription requests

GitOrigin-RevId: 3cfdb80713c96d32f7d297f38ec306e2bf6ec9a6
2024-03-28 09:04:06 +00:00
Mathias Jakobsen
44d0b947ce Merge pull request #17553 from overleaf/mj-admin-history-ranges-enable
[web] Add button for adding history ranges support in admin panel

GitOrigin-RevId: fa85b25719fff753f0d0806ccb02ad2f9db2ee82
2024-03-28 09:03:51 +00:00
M Fahru
b874d932c2 Merge pull request #17258 from overleaf/mf-fix-active-state-persisted-navbar-toggle
[web] Fix navbar toggle persisted active state on mobile

GitOrigin-RevId: 46e6962bc5ff003fd131419b94d7a04df3b619c6
2024-03-26 09:04:44 +00:00
David
6fef715316 Merge pull request #17611 from overleaf/dp-unlink-sso-script
Add script to unlink a third party identifier

GitOrigin-RevId: ded0672121fdf8c6cf30f94580f4491af9321dd7
2024-03-26 09:04:40 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
Brian Gough
f2a1b49d48 Merge pull request #17593 from overleaf/bg-account-security-update-hibp-links
Update haveibeenpwnd links to use the password check form

GitOrigin-RevId: f67b1ed689c851ad3684becc38cd5eb82b0018a2
2024-03-22 09:03:13 +00:00
Thomas
8a04ec9b75 Merge pull request #17572 from overleaf/tm-email-confirmation-require-login
Prevent email confirmation unless logged in to the requesting account

GitOrigin-RevId: 28af875b2887b8bbef8327097635aa01345c682c
2024-03-22 09:03:10 +00:00
Thomas
811173d32d Merge pull request #17569 from overleaf/tm-account-suspension
Add the ability to suspend user accounts

GitOrigin-RevId: 5e57f29941434c78a47354baca83527213f9b9b5
2024-03-22 09:03:06 +00:00
David
3ca09c07a1 Merge pull request #17508 from overleaf/dp-ac-ieee-deprecation-notifications
Update notifications for IEEE Retirement

GitOrigin-RevId: f4e02e5fd838c2b1a6227c86f48bb12dd6bdb9a3
2024-03-18 09:04:32 +00:00
Jessica Lawshe
408e1dccd7 Merge pull request #17436 from overleaf/ab-split-test-export-cleanup
[web] Fix the split test export format and prune unwanted info

GitOrigin-RevId: 2a8ecbd738338c16fee4bf1d286e724cc25c0008
2024-03-14 09:04:59 +00:00
Jessica Lawshe
310cbe10ba Merge pull request #17434 from overleaf/ab-allow-analytics-inactive-test
[web] Allow analytics to be enabled for inactive tests

GitOrigin-RevId: f854fd6532357c4291f2785b950eac2478cfbae0
2024-03-14 09:04:54 +00:00
Jessica Lawshe
8d4766f5fa Merge pull request #17234 from overleaf/jel-clear-saml-data
[web] Clear linking data for all linked users in group

GitOrigin-RevId: 1b7b3642a37a33c8b1499aee9c98300551bccea0
2024-03-14 09:04:42 +00:00
Brian Gough
8484ae75c7 Merge pull request #17537 from overleaf/bg-session-mitigation-log-session-size
Add custom session store to track largest session sizes for anonymous users

GitOrigin-RevId: 23312689d7adb8196e66bb925afcfef78c4c558d
2024-03-13 09:03:44 +00:00
Jimmy Domagala-Tang
5701a1cccd Merge pull request #17369 from overleaf/jdt-rm-old-wf-prj-list-ad
removing old writefull ad from project list and removing uneeded spli…

GitOrigin-RevId: 84722949c4972ba0b7c8e0bf6d2884608e26a613
2024-03-13 09:03:26 +00:00
Domagoj Kriskovic
3e701f1388 Send operations to project-history when deleting comments (#17198) (#17494)
* Make Operation.fromRaw parse AddComment operations

* Send operations to project-history when deleting comments

* remove RedisManager.updateDocument call

* format fix

* Revert "remove RedisManager.updateDocument call"

This reverts commit 5d45f34b5919bf5a85e8475e5a450bcb213d3f82.

* remove versions from deleteComment op

* pass userId to deleteComment operation

* revert userId from chat service

* revert userid from chat tests

* format:fix

* document updater fix tests

* format:fix

* fix web unit test

* deleteThread test fix

* send only if historyRangesSupport is true

* use headers to pass userId

* set historyRangesSupport in tests

* optional headers

* Revert "use headers to pass userId"

This reverts commit e916c469f95b1ac166e30e12e735171eb814af01.

---------

Co-authored-by: Eric Mc Sween <5454374+emcsween@users.noreply.github.com>
GitOrigin-RevId: 14c10669e43d76883dbaaa8ab55e102b5ebadd38
2024-03-12 09:03:55 +00:00
Jessica Lawshe
d65bba566c Merge pull request #17315 from overleaf/ab-accounts-settings-sso-status
[web] Show Group SSO linking status on the account settings page

GitOrigin-RevId: ae45e1bd7a90a672c5fb023e7f3e603a00e364e5
2024-03-12 09:03:43 +00:00
Jessica Lawshe
814ee0ac62 Merge pull request #17351 from overleaf/jel-async-getUserForPasswordResetToken
[web] Promisify getUserForPasswordResetToken

GitOrigin-RevId: 4b0363b390af155f1bae4332fba7cf10c130e1c6
2024-03-12 09:03:35 +00:00
Jessica Lawshe
7a9c2fd644 Merge pull request #17329 from overleaf/jel-async-peekValueFromToken
[web] Promisify peekValueFromToken

GitOrigin-RevId: 4a7f6ae793ff0a1bd22c89c963881ef0957e29e8
2024-03-12 09:03:32 +00:00
Jessica Lawshe
b2b100d485 Merge pull request #17090 from overleaf/jel-block-password-reset
[web] Block password reset request for managed users linked to SSO

GitOrigin-RevId: 9c990d9fcb7a3286fee733e0fd61c06c09d79367
2024-03-12 09:03:29 +00:00
Miguel Serrano
02d890ef18 Merge pull request #17426 from overleaf/msm-expressify-controllers
[web] Expressify controller methods

GitOrigin-RevId: 9784176b53a89beed09f9b38915872a6e7fae465
2024-03-12 09:03:26 +00:00
Miguel Serrano
d2cfa26807 Merge pull request #17418 from overleaf/msm-expressify-usermembershipctlr
[web] expressify UserMembershipController

GitOrigin-RevId: 54f8d718bffb52609f055490f2a996f6c007f472
2024-03-12 09:03:20 +00:00
David
1ba5b27e57 Merge pull request #17408 from overleaf/dp-mongoose-callback-autherntication-manager
Promisify AuthenticationManager and AuthenticationManagerTests

GitOrigin-RevId: 8120bf55d19380a6ecf5241ffab8722eff2d4fe3
2024-03-12 09:03:14 +00:00
Domagoj Kriskovic
f5b894bc2e Revert "Send operations to project-history when deleting comments (#17198)" (#17476)
This reverts commit 34ab7e4ea6dd1b5fd749f9accaf4a6e16ae1d840.

GitOrigin-RevId: 005de52bcacbacf62d22cd8617d7a765f56bd72e
2024-03-11 09:04:29 +00:00
Domagoj Kriskovic
4a3a0752a4 Send operations to project-history when deleting comments (#17198)
* Make Operation.fromRaw parse AddComment operations

* Send operations to project-history when deleting comments

* remove RedisManager.updateDocument call

* format fix

* Revert "remove RedisManager.updateDocument call"

This reverts commit 5d45f34b5919bf5a85e8475e5a450bcb213d3f82.

* remove versions from deleteComment op

* pass userId to deleteComment operation

* revert userId from chat service

* revert userid from chat tests

* format:fix

* document updater fix tests

* format:fix

* fix web unit test

* deleteThread test fix

* send only if historyRangesSupport is true

* use headers to pass userId

* set historyRangesSupport in tests

* optional headers

* Revert "use headers to pass userId"

This reverts commit e916c469f95b1ac166e30e12e735171eb814af01.

---------

Co-authored-by: Eric Mc Sween <5454374+emcsween@users.noreply.github.com>
GitOrigin-RevId: 34ab7e4ea6dd1b5fd749f9accaf4a6e16ae1d840
2024-03-11 09:04:24 +00:00
Miguel Serrano
cf227e2d08 Merge pull request #17450 from overleaf/msm-fix-sp-welcome-page
[web] Make wiki and template links configurable in welcome page

GitOrigin-RevId: fab1b8a11f518c5907a5bfa9365ff8e8a130b7c6
2024-03-07 16:30:42 +00:00
Jakob Ackermann
1a6ac06bed Merge pull request #17432 from overleaf/jpa-wf-switch-split-test
[web] fully adopt writefull-oauth-promotion split-test

GitOrigin-RevId: b37491bc18e7cc65ec2fc8e8ced140df9f8a6048
2024-03-06 17:27:52 +00:00
Jakob Ackermann
5415aafaf8 Merge pull request #17353 from overleaf/jdt-wf-oauth-tutorial
Writefull Oauth banner

GitOrigin-RevId: cdd8d27b70c9c0f5be326f6861a7c997ca81616e
2024-03-06 17:27:46 +00:00
David
43007539a0 Merge pull request #17380 from overleaf/dp-mongoose-callback-toke-access-handler
Promisify TokenAccessHandler and TokenAccessHandlerTests

GitOrigin-RevId: 835081e78977456a59b7e16043fd6dcbdbce3ade
2024-03-06 17:27:40 +00:00
Davinder Singh
511ad1b68f Adding BRL geo pricing (#17164)
* BRL geo pricing banners and modals

* format:fix

GitOrigin-RevId: 478435764230e7fea3c8f26e5747562698f78228
2024-03-06 17:27:18 +00:00
Jakob Ackermann
9daacea6cb Merge pull request #17409 from overleaf/jpa-check-before-hibp
[web] check user password before HIBP check

GitOrigin-RevId: 7c1bdc220fb9369733a1ff3bf26bed8cacc8e8d4
2024-03-05 09:03:46 +00:00
Jakob Ackermann
84a2b25a3c Merge pull request #17401 from overleaf/jpa-skip-hibp-known-device
[web] skip HIBP check from known devices

GitOrigin-RevId: 897df02492aafeac010753c7c306e02bde5b1fd8
2024-03-05 09:03:37 +00:00
Jakob Ackermann
001af76f15 Merge pull request #17399 from overleaf/jpa-hibp-login
[web] check HIBP on login

GitOrigin-RevId: e052926e4d970f9a15821f1ea9c8af46bdab90cb
2024-03-05 09:03:34 +00:00
David
857a45edeb Merge pull request #17171 from overleaf/dp-mongoose-callback-project-collabratec
Promisify ProjectCollabratecDetailsHandler and ProjectCollabratecDetailsHandlerTest

GitOrigin-RevId: efd911dcbba58f706adfd3b7a5c043280f6cc1af
2024-03-05 09:03:22 +00:00
David
db1508be69 Merge pull request #17075 from overleaf/dp-mongoose-callback-subscription-group-handler
Promisify SubscriptionGroupHandler and SubscriptionGroupHandlerTests

GitOrigin-RevId: 998ebb56f9cffe59f7cb490220bccbeedb133a7b
2024-03-05 09:03:19 +00:00
David
6551aba1a5 Merge pull request #17005 from overleaf/dp-mongoose-callback-subscription-handler
Promisify SubscriptionHandler and SubscriptionHandlerTests

GitOrigin-RevId: b34328ee2cca4449a02723a587a1bfb887ed847a
2024-03-05 09:03:15 +00:00
M Fahru
920e86e4d0 Merge pull request #17303 from overleaf/mf-fix-plans-page-mobile
[web] Fix plans page table styling on both desktop and mobile

GitOrigin-RevId: 252bbaf7245751b1cfe07286a0fe19069219bb5b
2024-03-04 09:04:08 +00:00
M Fahru
5a8a0fb268 Tear down annual-trials split test:
- Use the `default` variant as the winner
- Remove all `annual-trials`-related code

GitOrigin-RevId: 3956f256157f3e86c99e41eec54ef6fd0da39bc3
2024-03-01 09:03:24 +00:00
Jessica Lawshe
cb3f70f7ab Merge pull request #17289 from overleaf/jel-permissions-controller
[web] Move user permissions check to manager

GitOrigin-RevId: 8c59d053da3d8d452cd424b04baa05f5d7d9057a
2024-02-29 09:04:37 +00:00
David
84c3dc1fff Merge pull request #17268 from overleaf/dp-remove-old-mongo-metrics
Remove timeAsyncMethod mongo metrics

GitOrigin-RevId: 1ba3a1fd51b9d0766355c31791ae9836d832afe8
2024-02-29 09:04:19 +00:00
David
6d99f6dfae Merge pull request #17201 from overleaf/dp-ip-rate-limit
Add subnet rate limiter for login rate limit

GitOrigin-RevId: c9f68829887dbc1778eff3b465dbde40bc2073d8
2024-02-29 09:04:15 +00:00
David
3c98e028f5 Merge pull request #17206 from overleaf/dp-mongoose-callback-institutions-manager
Promisify InsitutionsManager and InstitutionsManagerTests

GitOrigin-RevId: 0872aabb646ee143f51a92608f91d7901723ec0c
2024-02-29 09:04:11 +00:00
David
6a96e160d9 Merge pull request #17079 from overleaf/dp-mongoose-callback-subscription-locator
Promisify SubscriptionLocator and SubscriptionLocatorTests

GitOrigin-RevId: 9956a72d0cd94cb0b89da0fc1ec9c0e06fdcfeea
2024-02-29 09:04:07 +00:00
David
0827139e48 Merge pull request #17155 from overleaf/dp-mongoose-callback-user-registration-handler
Promisify UserRegistrationHandler and UserRegistrationHandlerTests

GitOrigin-RevId: b561f5574883b016824077e971aa4613b44a42dd
2024-02-29 09:04:03 +00:00
Jakob Ackermann
642eea2de6 Merge pull request #17318 from overleaf/jpa-create-tokens-first
[web] create link-sharing tokens before enabling link-sharing

GitOrigin-RevId: 19a72d57623421681f0de3193572b916a5adeaa9
2024-02-27 17:02:37 +00:00
ilkin-overleaf
b04247dd5a Merge pull request #17023 from overleaf/ii-token-access-null-values
[web] Fix projects token access values

GitOrigin-RevId: f0c6a4993e42320c06753cb65198138afe55b71a
2024-02-26 09:03:13 +00:00
Miguel Serrano
f4454cfe7e [web] Make SamlLogHandler.log() calls asynchronous (#17207)
* [web] Refactor exports in ErrorController

* [web] Make SamlLogHandler.log() async

* [web] await for SamlLogHandler.log() in ErrorController

* [web] await for SamlLogHandler.log() in SAMLMiddleware

* [web] await for SamlLogHandler.log() async controllers

* [web] await for SamlLogHandler.log() in SAMLManager

* [web] Remove explicit wait when testing SAML logs

After making the logs asynchronouse the wait
is no longer needed

* [web] Avoid using async with SamlLogHandler.log on callbacks

* Add expressifyErrorHandler to promise-utils

* Tighten assertion in SAMLMiddlewareTests

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Updated SamlLogHandler.log to await for promise

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 3645923fae8096a9ba25dc9087f1a36231528569
2024-02-23 09:03:14 +00:00
Brian Gough
c8cc34377f Merge pull request #17004 from overleaf/bg-mongoose-mongo-compatibility
Ensure Mongoose and mongodb modules use the same mongodb instance

GitOrigin-RevId: fb55f3dfcff73919a4c5d26a354ba7c55b1e63c1
2024-02-23 09:03:00 +00:00
Miguel Serrano
992cb49802 Merge pull request #17241 from overleaf/msm-fix-sp-git-settings
[web] Prevent render of Sync section in SP when git is disabled

GitOrigin-RevId: 5bfd1baadaff21db72d84a11d3f926431739dae4
2024-02-22 09:05:06 +00:00
M Fahru
dc9b0aa8a5 Merge pull request #17230 from overleaf/mf-tear-down-inr-2
[web] Tear down INR split test

GitOrigin-RevId: 90c6ab4666d9281e804b279d697d6c14ffd682d2
2024-02-22 09:05:02 +00:00
Alf Eaton
6212f340d3 Allow individual docs to be downloaded from the file tree (#17137)
GitOrigin-RevId: d0b2ce9f3a252e34f452155ed83c3c04e7916ef0
2024-02-22 09:04:48 +00:00
Thomas
1019142457 Use winning website redesign variant (#17200)
* Implement redesign on the default urls and redirect variants to defaults

* Fix Features & Benefits inconsistent case, cleanup temp translation

* Replace header_extras with the website redesign header extras

* Delete old home page

* Remove real time edits javascript (old home page)

* Cleanup unused locales

* Temporarily disable test that checked about/features-overview page

* Fix business/universities links in customer stories

GitOrigin-RevId: 9d2ee64c2622ffea7a2c2f7448a5e5beae3187e9
2024-02-21 09:03:18 +00:00
Jessica Lawshe
f8094bbdb6 Merge pull request #17060 from overleaf/jel-password-linked-group-sso
[web] Prevent updating password for managed users linked to group SSO

GitOrigin-RevId: f40bba47575cfac1b1e42d3138112c0db4f7865c
2024-02-20 09:06:06 +00:00
Jessica Lawshe
d5639794c2 Merge pull request #17166 from overleaf/ab-fix-group-settings-label
[web] Cleanup managed users env var and fix group settings label

GitOrigin-RevId: 817ed86a6c94c03adb41e8c10115d6404180142e
2024-02-20 09:05:54 +00:00
David
0f05623e16 Merge pull request #17084 from overleaf/dp-mongoose-callback-system-message-manager
Promisify SystemMessageManager and SystemMessageManagerTests

GitOrigin-RevId: b8fafdfdba817160c1b18cf7eb0270a27adf114c
2024-02-20 09:04:38 +00:00
David
148f6d6f96 Merge pull request #17065 from overleaf/dp-mongoose-callback-inactive-project-manager
Promisify InactiveProjectManager and InactiveProjectManagerTests

GitOrigin-RevId: 985d0d4c80bfd1e46fa3c85c98203432459bdc84
2024-02-20 09:04:33 +00:00
David
62b4a19788 Merge pull request #17069 from overleaf/dp-mongoose-callback-linked-files-handler
Promisify LinkedFilesHandler

GitOrigin-RevId: 9c996dfd721b0a5dced989c9403ac3a5d9cbfc87
2024-02-20 09:04:29 +00:00
David
aea6264700 Merge pull request #16692 from overleaf/dp-mongoose-callback-project-getter
Promisify ProjectGetter and ProjectGetterTests

GitOrigin-RevId: 373492da963912f2de923f65c53df284c919279d
2024-02-20 09:04:24 +00:00
Jessica Lawshe
4ad6d3cb5f Merge pull request #17091 from overleaf/jel-promisify-password-reset
[web] Promisify password reset

GitOrigin-RevId: bc8399727a86276b1d5baa380369d988772c268a
2024-02-19 09:04:29 +00:00
Jakob Ackermann
881abf6e5f Merge pull request #17109 from overleaf/jpa-tpds-remove-sl-prefix-2
[misc] remove ShareLaTeX branding from tpds job headers 2/2

GitOrigin-RevId: da42dacbfe7f14f8f7e4da0534b13ef9b8c046cd
2024-02-19 09:04:12 +00:00
Jakob Ackermann
b2dd70e0b4 Merge pull request #17107 from overleaf/jpa-x-update-source-2
[misc] remove ShareLaTeX branding from X-Update-Source header 2/2

GitOrigin-RevId: bebe0212a1f7b4c965cd55a22357e52dfce6dd30
2024-02-19 09:04:09 +00:00
Jakob Ackermann
4118775a49 Merge pull request #17167 from overleaf/jpa-hide-writefull-anon
[web] hide Writefull promotion for non-logged-in users

GitOrigin-RevId: 945b0f3da4b3bbd64e71e10f40ab6f8320efb1cd
2024-02-19 09:04:06 +00:00
Jakob Ackermann
8c339045b3 Merge pull request #17108 from overleaf/jpa-tpds-remove-sl-prefix-1
[misc] remove ShareLaTeX branding from tpds job headers 1/2

GitOrigin-RevId: c4b028f037be6d4a312d8c62ea7ec603ec192bb0
2024-02-19 09:03:52 +00:00
Jakob Ackermann
5889aa1c1b Merge pull request #17106 from overleaf/jpa-x-update-source-1
[misc] remove ShareLaTeX branding from X-Update-Source header 1/2

GitOrigin-RevId: 435924b8f0f50016fe5bb1df7b960707babbb286
2024-02-19 09:03:44 +00:00
Jakob Ackermann
4804cd68a5 Merge pull request #17105 from overleaf/jpa-tpds-cleanup
[misc] cleanup for tpds queues

GitOrigin-RevId: 8a501a692fa20d8956ad9dc4fccc0447c9f6fbe5
2024-02-19 09:03:41 +00:00
Alexandre Bourdin
42b5f91b9f Merge pull request #17153 from overleaf/ab-send-group-sso-invite-self
[web] Send the SSO linking invite when the group admin is adding self to the group

GitOrigin-RevId: f87ce6cfb006a0e353394e4102881e6220e5e6d9
2024-02-19 09:03:22 +00:00
Alexandre Bourdin
0ed6e0be17 Merge pull request #17088 from overleaf/ab-skip-deleting-group-sub-if-sso-enabled
[web] Skip deleting expired group subscription if group SSO is enabled

GitOrigin-RevId: 2e4f2105e9f024b6f421d8e50dffa3367ee68964
2024-02-19 09:03:15 +00:00
Alf Eaton
f4b176c93d Preserve folder structure when uploading folders (#16502)
GitOrigin-RevId: 791233ce1e68920a4f2d7042ed4c60ca3f4be8fb
2024-02-16 09:05:07 +00:00
Alf Eaton
5650b38069 Only validate segmentation values for Mixpanel (#16889)
GitOrigin-RevId: 3cb9de7648d1ba1f9faa8720eb57370e224c0c8c
2024-02-16 09:04:50 +00:00
Tim Down
07e16838b8 Merge pull request #16971 from overleaf/td-bootstrap-5-base
Bootstrap 5 base

GitOrigin-RevId: 2ac614298d31a9cf65430a46d726648a742044f9
2024-02-15 09:04:05 +00:00
Davinder Singh
c1f8647339 tearing down split test (#17000)
GitOrigin-RevId: cdcca8635a81c697e9f91f31fb711ee420cc6f7d
2024-02-14 09:04:43 +00:00
David
32d2603adb Merge pull request #16731 from overleaf/dp-ip-rate-metrics
Add tracking of rate limit method to metrics

GitOrigin-RevId: 3996c2a0ccb747018571ce402120be46fc52eace
2024-02-13 09:04:09 +00:00
Tim Down
07a46545bb Merge pull request #17003 from overleaf/msm-remove-env-confirmation-emails
[web] Remove env to skip sending confirmation emails

GitOrigin-RevId: 70f67f4920e9e2b40cd1219a40704885ce6956a4
2024-02-13 09:03:48 +00:00
Jakob Ackermann
385d3f9c1b Merge pull request #16980 from overleaf/jpa-join-project-remove-sl-2
[misc] joinProject: pass userId and anonymous access token in body 2/2

GitOrigin-RevId: b1a11941a6d9c7cc779769d1e97d3a0f03bed610
2024-02-13 09:03:39 +00:00
Jakob Ackermann
8523c21158 Merge pull request #16948 from overleaf/jpa-rails-sharelatex-rebranding-step-2
[web] migrate v1 api calls away from ShareLaTeX branded endpoints

GitOrigin-RevId: af08ee029d0cee8f0f171d21b4f2b0b76222b3f8
2024-02-13 09:03:35 +00:00
Jakob Ackermann
959fa06148 Merge pull request #17009 from overleaf/ae-file-tree-classname
Remove duplicate className from Angular file tree

GitOrigin-RevId: 238b1ad8631b5a861361113679a9f1f8a66da6ea
2024-02-12 09:03:24 +00:00
Jakob Ackermann
974069bf1c Merge pull request #16979 from overleaf/jpa-join-project-remove-sl-1
[misc] joinProject: pass userId and anonymous access token in body 1/2

GitOrigin-RevId: 5d7832246c7262c004c2cd465d62488384b35ee3
2024-02-12 09:03:16 +00:00
David
03bb99aeaa Merge pull request #16657 from overleaf/dp-mongoose-callback-project-update-handler
Promisify ProjectUpdateHandler and ProjectUpdateHandlerTests

GitOrigin-RevId: 312cbe71d431cf50932ab7d5501529d87f7827f2
2024-02-09 09:07:27 +00:00
David
68f011378d Merge pull request #16911 from overleaf/dp-mongoose-callback-referal-allocator
Promisify ReferalAllocator and ReferalAllocatorTests

GitOrigin-RevId: 0c68ec6176ac440504fc6501e0fad161d83d3541
2024-02-09 09:07:22 +00:00
David
d4e9d1bd89 Merge pull request #16912 from overleaf/dp-mongoose-callback-referal-features
Promisify ReferalFeatures and ReferalFeaturesTests

GitOrigin-RevId: 25c1d80c5aea2883f62b95b8646a5670340c5cf2
2024-02-09 09:07:18 +00:00
David
144e22c209 Merge pull request #16918 from overleaf/dp-mongoose-callback-referal-handler
Promisify ReferalHandler and ReferalHandlerTests

GitOrigin-RevId: b73eda0063b04227a0d58d8e9bd0dea1ff6f0af1
2024-02-09 09:07:14 +00:00
Alf Eaton
c997d1dc2b Remove MathJax v2 (#16961)
GitOrigin-RevId: 32a43361cfc883aa1a5ed85f6be5432b6e838b9d
2024-02-09 09:06:42 +00:00
Alf Eaton
2566dff9d8 Ensure that a "create linked file" request includes a name (#16673)
GitOrigin-RevId: 6b4ffac59f299e297f0a9a14a72ad7cea2508c3c
2024-02-09 09:06:38 +00:00
Jessica Lawshe
03aaee84a3 Merge pull request #16945 from overleaf/ab-fix-sso-managed-users-enrollment
[web] Fix managed users enrollment clearing out SSO linking status

GitOrigin-RevId: b2083b48df1782c426794f16e2cdd767b217256c
2024-02-09 09:06:03 +00:00
Miguel Serrano
abe33de010 [web] upgrade @node-oauth/oauth2-server to ^5.1.0, (#16705)
* [web] upgrade @node-oauth/oauth2-server to ^5.1.0,

* Added `expressify` to middleware returned by Authentication.requireOauth()

* Extracted OAuth2 scope transformation to utilities

* Throw an error with undefined SAML scopes

GitOrigin-RevId: 00dfe81c707e9a3fcf9bb10e007c1fc646f7b9dd
2024-02-09 09:05:20 +00:00
Jakob Ackermann
4e689233a5 Merge pull request #16956 from overleaf/jpa-anon-access-token
[web] read anonymous access token header from joinProject endpoint only

GitOrigin-RevId: 4f8f60c23dc93cc2b02a429bd5492d8a931ae284
2024-02-09 09:05:15 +00:00
Jakob Ackermann
c73f1f3693 Merge pull request #16944 from overleaf/jpa-fix-entity-creation
[web] fix creation of missing user membership entities

GitOrigin-RevId: 203d5e2bb5733479c53068543a04b58a6fa7d1a3
2024-02-09 09:04:54 +00:00
Jakob Ackermann
63520c7076 Merge pull request #16859 from overleaf/jpa-sharelatex-cleanup
[misc] ShareLaTeX cleanup - high impact

GitOrigin-RevId: 6dcce9b0f15e30f7afcf6d69c3df36a369f38120
2024-02-09 09:04:11 +00:00
Jimmy Domagala-Tang
537c822789 Merge pull request #16874 from overleaf/jdt-me-learn-links-new-tab
Learn wiki links should open in new tab

GitOrigin-RevId: 7e87feff971bc2c28d0e0bac85e0e20ef139e321
2024-02-06 09:03:57 +00:00
Jakob Ackermann
621301618f Merge pull request #16893 from overleaf/jpa-download-pdf-dashboard-for-all
[web] enable button for downloading PDFs from dashboard for all users

GitOrigin-RevId: bd46675bc75a7772824081e3e5e3043f282594a1
2024-02-06 09:03:16 +00:00
David
8bd917242b Merge pull request #16744 from overleaf/dp-mongoose-callback-user-feature-updater
Convert UserFeaturesUpdater and UserFeaturesUpdaterTests to async/await

GitOrigin-RevId: 65cbb57d463dd9557e7e8e7643a1be160f17eebc
2024-02-06 09:03:13 +00:00
David
0e9ceb1ffd Merge pull request #16788 from overleaf/dp-mongoose-callback-user-membership-handler
Promisify UserMembershipHandler and UserMembershipHandlerTests

GitOrigin-RevId: bb33110ee750364754db53fb075a5700be003ecc
2024-02-06 09:03:08 +00:00
Tim Down
473e74ecf1 Merge pull request #16749 from overleaf/td-upgrade-joi-celebrate
Upgrade Joi and Celebrate to latest

GitOrigin-RevId: 287130f6e476c04f9eb4efdf202729452b081c40
2024-02-05 09:04:16 +00:00
Jakob Ackermann
0596e8d25c Merge pull request #16813 from overleaf/jpa-remove-legacy-registration
[web] remove legacy registration aka the public-registration module

GitOrigin-RevId: 5cbb7ecbc7da5cd0617bd1abd1f5c6eef4c05b3f
2024-02-05 09:04:09 +00:00
Jakob Ackermann
880087945e Merge pull request #16854 from overleaf/jpa-overleaf-integration-core-tests
[web] enable overleaf-integration module when running SaaS tests

GitOrigin-RevId: 36eda6ef448604a55f8dc8daac5ce29af23b6b0b
2024-02-05 09:04:05 +00:00
Alexandre Bourdin
3437b2c678 Merge pull request #16824 from overleaf/jel-clear-sso
[web] Clear group SSO via Overleaf admin "Clear all SAML data" button

GitOrigin-RevId: e5db107da533679d51d4f05db4e65c3ab51ed1ad
2024-02-05 09:03:53 +00:00
Jessica Lawshe
3748621bcd Merge pull request #16791 from overleaf/jel-saml-audience
[web] Handle the SAML error of a SP entity ID mismatch in the response

GitOrigin-RevId: d8168d4ce77f4e810df193dae98046da07e6c0ae
2024-02-02 09:03:51 +00:00
Jakob Ackermann
82cde31619 Merge pull request #16808 from overleaf/jpa-wsUrl
[web] move wsUrl into meta tag

GitOrigin-RevId: c94638759b79b8090b8b3cfa81baa718a69839e1
2024-02-02 09:03:35 +00:00
Alf Eaton
efe44f08b8 Only log unknown file upload errors (#16739)
GitOrigin-RevId: a6129e622ce32ea227f575b6d93616a7411391ed
2024-02-02 09:03:17 +00:00
Eric Mc Sween
d0a9f8c2cb Merge pull request #15748 from overleaf/em-drop-docops-collection
Drop the docOps collection

GitOrigin-RevId: 8ffa0570ae58b6a00412d8953d3ea0fbb1869b69
2024-02-01 09:03:46 +00:00
Thomas
2a7e06ea07 Merge pull request #16839 from overleaf/tm-website-redesign-suppress-alternate
Suppress rel=alternate hreflang links on website redesign variant pages

GitOrigin-RevId: ff53adbaf9aadd261427157a8b60bafe55d6ce36
2024-02-01 09:03:37 +00:00
Jakob Ackermann
783008b05f Merge pull request #16804 from overleaf/jpa-code-cleanup
[misc] ShareLaTeX code cleanup - low impact

GitOrigin-RevId: 4b4a958af133efdb81196967adb66c97420c4861
2024-02-01 09:03:34 +00:00
Brian Gough
f9db088d57 Merge pull request #16835 from overleaf/bg-google-spam-temporarily-disable-emails
Temporarily disable onboarding emails

GitOrigin-RevId: a1967bc793fcd7b3b90f812fb8c9b9d83f704093
2024-02-01 09:03:30 +00:00
Brian Gough
9702b36c64 Merge pull request #16833 from overleaf/bg-google-spam-add-email-metrics
Include email type and rate-limit status in metrics

GitOrigin-RevId: eb5645e68d9ee3571d04b87b2c0fc09f9caa126a
2024-02-01 09:03:27 +00:00
M Fahru
f0247a3311 Merge pull request #15302 from overleaf/mf-fix-unlink-github-sync-behaviour
[web] Unlink github from collaborators when project owner unsubcribes and github feature was lost

GitOrigin-RevId: 81b81cfb75e3a3684e185ef13d8c0aca19d5699d
2024-01-30 09:04:39 +00:00
Thomas
17e4c776c1 Place redesign pages on seperate urls with redirects (#16724)
* Place redesign pages on seperate urls with redirects, refactor into StaticPageController

* Add page titles to variant pages (#16710)

* Add features-page-view event (#14911)

* Add canonical URLs to variant marketing pages

GitOrigin-RevId: 3f65f53d856a063dde1e9d60fd3cc327437294f6
2024-01-29 09:03:54 +00:00
Alf Eaton
b38d6a85c9 Warn when project or file is not found (#16740)
GitOrigin-RevId: ab71000492c3b2f2ba02ad6fd768b7c2e4563ed7
2024-01-29 09:03:26 +00:00
Alf Eaton
fefec2c1bf Improve handling of upload to deleted folder (#16738)
GitOrigin-RevId: 2ad2890f8fe51f3c7c7a8ac0834059ea9cb0557b
2024-01-29 09:03:23 +00:00
Alf Eaton
b9db589f33 Add compile-log-events assignment (#16655)
GitOrigin-RevId: 11a7986796e6970783c391c18101b0bfdd82a67d
2024-01-29 09:03:16 +00:00
Jakob Ackermann
bc7201e337 Merge pull request #16723 from overleaf/jpa-bump-copyright-years
[web] bump hard-coded copyright years

GitOrigin-RevId: a4896456713e00a68986228504218bf645565d47
2024-01-29 09:03:10 +00:00
Rebeka Dekany
140b312eca Merge pull request #14799 from overleaf/rd-report-tablist-plan
Accessibility - help the user to navigate through the tabs on the plans page

GitOrigin-RevId: 93822277edd3a44eaf8e1219a4902e28d31e198a
2024-01-26 09:03:36 +00:00
Alexandre Bourdin
e264b1ac8b Merge pull request #16690 from overleaf/jpa-sessions-fix
[web] remove unexpected angular success message from de-ng sessions page

GitOrigin-RevId: f320607a4efc098757d78edb8ab0248e3726ab15
2024-01-26 09:03:31 +00:00
Jessica Lawshe
c5a902656d Merge pull request #16491 from overleaf/rd-plans-table
[web] Accessibility - improve the navigation on the plans page

GitOrigin-RevId: 8fccdfe5c60ad908f028608b79be74ca964fb65a
2024-01-24 09:04:34 +00:00
Jessica Lawshe
d812a73d93 Merge pull request #16656 from overleaf/mf-fix-recaptcha-reconfirm-password-reset
[web] Fix recaptcha flow on reconfirm page and password reset page

GitOrigin-RevId: 45e07a283d6f978c808a7785cf21487b8a7f6ada
2024-01-24 09:04:31 +00:00
Jessica Lawshe
ecd2bf96a9 Merge pull request #16633 from overleaf/jel-translation
[web] Fix typo in translation

GitOrigin-RevId: 32226ed769313e4379758dd4c65d20e69e74a08a
2024-01-24 09:04:28 +00:00
Jessica Lawshe
45d44d2fe6 Merge pull request #16444 from overleaf/jel-v1-api
[web] Begin promisifying InstitutionsAPI

GitOrigin-RevId: aa615e22d3fc8aa77255a26dcdab0e2ce28d93c0
2024-01-24 09:04:21 +00:00
ilkin-overleaf
784ebcbd57 Merge pull request #16610 from overleaf/ii-generate-unique-name-for-project
[web] Fix unique project name generator

GitOrigin-RevId: 9b30041ab532b4ad87ee647fb7d5b280b069ce12
2024-01-24 09:03:55 +00:00
David
b3f6f3861c Merge pull request #16629 from overleaf/dp-mongoose-callback--project-options
Convert ProjectOptionsHandler and ProjectOptionsHandlerTests to use async/await

GitOrigin-RevId: 3f2902ee7c2f093b9350748824a58f00a88d02c7
2024-01-24 09:03:44 +00:00
David
4c973755fa Merge pull request #16617 from overleaf/dp-mongoose-callback
Convert ProjectHistoryHandler from callbacks to promises

GitOrigin-RevId: 6b1841269f6976deb4da663f614c423de7b962b7
2024-01-24 09:03:40 +00:00
David
7f113250aa Remove deprecated usages of mongodb and mongoose remove, update, and insert methods (#16573)
* Remove usage of mongo .insert in favour of .insertOne

* Replace usages of update with updateOne

* Replace remove with deleteOne/deleteMany

* Update one more usage of `remove`

* Update a few missed usages of remove/update/insert

GitOrigin-RevId: 49d08eca1ce80831c375c343fb8b5b3846b71460
2024-01-24 09:03:34 +00:00
David
e3513a9d50 Merge pull request #16545 from overleaf/dp-project-owner-delete-labels
Allow project owners to delete history labels

GitOrigin-RevId: 16111337681ac4085db2cf48e9d4c2fa87993b77
2024-01-23 09:03:08 +00:00
Eric Mc Sween
af06de4e8f Merge pull request #16621 from overleaf/jpa-writefull-integration-user-property
[web] add user property for writefull-integration

GitOrigin-RevId: b3b0ec8290db318d17b426be050266522d420bf4
2024-01-22 09:04:14 +00:00
Alexandre Bourdin
73349a1b1d Merge pull request #16550 from overleaf/ab-unlink-sso-user-leaves-group
[web] Unlink group SSO when user leaves/is removed from group

GitOrigin-RevId: a4515f8b6f0f0012fc4d9f47b11e6f711743c2ec
2024-01-19 09:05:23 +00:00
Alexandre Bourdin
3b9eb4e8aa Merge pull request #16307 from overleaf/ab-split-tests-never-throw
[web] Guarantee split test assignments can never throw and cleanup boilterplate error handling

GitOrigin-RevId: ab50abde6e0632c5a9625b5c3d3e98f3383cc56c
2024-01-19 09:05:14 +00:00
Tim Down
56a72690d5 Merge pull request #16521 from overleaf/td-ieee-collabratec-notification
Add notification and script for IEEE Collabratec users

GitOrigin-RevId: 7f463baa172514d9f1d37f99a02b311b8f925cd8
2024-01-18 09:04:44 +00:00
Jakob Ackermann
797f2c518d Merge pull request #16514 from overleaf/jpa-enforce-oauth-scope
[web] restrict access to oauth endpoints to their respective clients

GitOrigin-RevId: 6ffa6008130588e44d336e2af32584ee20ad3ffc
2024-01-18 09:04:28 +00:00
Alexandre Bourdin
061839d610 Merge pull request #16532 from overleaf/ab-enable-typechecking-backend-modules
[web] Enable type checking on some backend modules with types

GitOrigin-RevId: 74728bf65de34ee3c2f4601a5add8bbb948ce765
2024-01-17 09:03:23 +00:00
Alexandre Bourdin
ddd9334bd6 Merge pull request #14951 from overleaf/ab-split-test-calculator
[web] Split test calculator

GitOrigin-RevId: 53a84a64d69c47d692f215dee351af635a5dcceb
2024-01-15 09:04:22 +00:00
Alf Eaton
384633e41e Preload the translations for the current language (#16430)
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: c5500d0b7e8d0c99ed09751a35140a0b62182318
2024-01-15 09:04:17 +00:00
M Fahru
ded18dd09b Merge pull request #16244 from overleaf/mf-website-redesign-analytics
[web] Implement analytics that will be used for the website-redesign split test analysis

GitOrigin-RevId: 49bc0fe2049a5bf2ff676dfde93c1396002735c2
2024-01-12 09:03:37 +00:00
Rebeka Dekany
64c512250d Merge pull request #16179 from overleaf/rd-remove-survey
[web] Tear down onboarding survey 2022

GitOrigin-RevId: ae2e7bf833424fe2bff9f82e4c3f264f42a1b27d
2024-01-09 09:04:09 +00:00
Miguel Serrano
51de84664d Merge pull request #16346 from overleaf/msm-remove-underscore
Remove `underscore` in monorepo

GitOrigin-RevId: fd3b92e3e8a940a7a086669232102320c34a89e2
2024-01-09 09:03:58 +00:00
Jimmy Domagala-Tang
5f38a930a5 Merge pull request #16319 from overleaf/jdt-grammarly-ad-redesign
Grammarly Ad redesign

GitOrigin-RevId: 28d0ae871b6303b31aadb59abc80b625d529cc9b
2024-01-08 09:05:40 +00:00
Davinder Singh
5c5a01777c Making getAnalyticsIdFromMongoUser private to UserAnalyticsIdCache (#16125)
* Making getAnalyticsIdFromMongoUser private to UserAnalyticsIdCache

* renaming userAnalyticsIdCache to UserAnalyticsIdCache

* deleting function _getAnalyticsIdFromMongoUser

* renaming userAnalyticsIdCache to UserAnalyticsIdCache part 2

* format:fix

* adding upperCamelCase

* capital case first letter

GitOrigin-RevId: 2e9c18c544b8cffb53838aed56e1ef16979606a5
2024-01-08 09:05:31 +00:00
Rebeka Dekany
61c380c89d Merge pull request #16371 from overleaf/rd-skip-link-dashboard
[web] Accessibility - Add 'main-content' ID to main element for skip link destination

GitOrigin-RevId: f6a7bf4cc12ab2428478562a9edda245dce7c2fb
2024-01-05 09:03:49 +00:00
Rebeka Dekany
34debffd20 Merge pull request #16358 from overleaf/rd-tear-down-welcome-page
[web] Tear down welcome-page-redesign split test

GitOrigin-RevId: 769aeae75eac6ac0b5880dca4ec1d36fbc39cea2
2024-01-05 09:03:45 +00:00
Eric Mc Sween
ad53583e3a Merge pull request #16294 from overleaf/em-premium-routes-super-props
Add super properties to support premium routes determination on events

GitOrigin-RevId: d85733f25b7bf12ca59591fece8f3cbd604be04f
2024-01-05 09:03:37 +00:00
Jakob Ackermann
d1f1530b77 Merge pull request #16383 from overleaf/jpa-normalize-token-prefix
[web] normalize token hash prefix ahead of comparison

GitOrigin-RevId: 44afda865df5d3517f23335509ee0e46ba74335f
2024-01-05 09:03:30 +00:00
Jakob Ackermann
2207000a0f Merge pull request #16379 from overleaf/jpa-pw-reset-hint
[web] add username hint for password managers on password (re)set form

GitOrigin-RevId: f691c0368494bc550ee10581f2a8ddf5addadf9b
2024-01-05 09:03:27 +00:00
Eric Mc Sween
92d36962bd Merge pull request #16367 from overleaf/em-remove-util-promises
Remove util/promises stub

GitOrigin-RevId: 8bde9a924d09905f24e8072ae3f7552eb3391862
2024-01-05 09:03:24 +00:00
Eric Mc Sween
b0f3f00c43 Merge pull request #16368 from overleaf/em-remove-project-archiver-code
Remove project-archiver related code

GitOrigin-RevId: b3331033658c14a7c4d8745fd7085cd7c65c94bc
2024-01-05 09:03:21 +00:00
Jimmy Domagala-Tang
ebd2a2f5fe Merge pull request #16353 from overleaf/em-typescript-in-web-backend
Enable type checking in the web backend

GitOrigin-RevId: cc8e34777c89704765fcd9b973aed806c3ae9016
2024-01-04 09:03:43 +00:00
Jimmy Domagala-Tang
d94ca9679f Merge pull request #16322 from overleaf/dk-ignore-clsi-warning
[web] ignore noisy CLSI 404 warning

GitOrigin-RevId: d821496e2fb91ba184a32449986c128b9b079f3f
2024-01-04 09:03:37 +00:00
Rebeka Dekany
5342d95efc Merge pull request #16277 from overleaf/tm-plans-compile-servers
Update plans and interstitial pages with updated compile timeout info

GitOrigin-RevId: a92ccd4a2f381e6456459a3ad4d2840b3b49f3c8
2023-12-19 09:04:36 +00:00
Mathias Jakobsen
c371732e6e Merge pull request #16186 from overleaf/mj-mongo-object-id
[web] Use constructor for ObjectId

GitOrigin-RevId: 9eb8b377ea599605b72af237d1ab12f4d8287162
2023-12-19 09:04:02 +00:00
Thomas
abd2974469 Merge pull request #16254 from overleaf/tm-website-redesign-navbar-footer-base
Implement navbar and footer changes for website redesign, and for existing pages for treatment users

GitOrigin-RevId: d91328e3928bc0e249e19eff34c6f9423784ccbf
2023-12-18 09:05:08 +00:00
Thomas
ede42bb016 Merge pull request #15990 from overleaf/tm-analytics-debug-log-consistency
Add message with analytics event debug log (and log for all events)

GitOrigin-RevId: 7ece70cc8ddafd806885d5012b1fdf7fdf6a003b
2023-12-18 09:05:03 +00:00
Alexandre Bourdin
77de72f43f Merge pull request #16071 from overleaf/ab-group-sso-test-flow-2
[web] Group SSO test flow - Error handling (part 1)

GitOrigin-RevId: bf41ef2a0f1a33331fc9d122e6004c10e8094881
2023-12-18 09:04:50 +00:00
Alf Eaton
c2b553e915 [ide-react] Improve file tree and outline components in the editor sidebar (#16225)
* Upgrade react-resizable-panels
* Add FileTreeOpenProvider
* Add OutlineProvider and OutlineContainer
* Convert Outline tests to Cypress

GitOrigin-RevId: afd9ae8190edf37642e36a4ffb331f1182c8982d
2023-12-18 09:03:53 +00:00
Brian Gough
114149ddf6 Merge pull request #16175 from overleaf/bg-group-sso-restrict-login
restrict login methods to group SSO for managed users with group SSO linked

GitOrigin-RevId: d0a92f9dc16cc08a3afacb4ad4b9ce19b1fd1330
2023-12-15 09:03:42 +00:00
Miguel Serrano
771f07d7ad Merge pull request #16202 from overleaf/msm-passport-upgrade-2
[web] passport + passport-saml updates (post revert)

GitOrigin-RevId: e1fa5757e15b3ac733511570637d39297247e050
2023-12-14 09:03:24 +00:00
Brian Gough
ec923c2144 Merge pull request #16194 from overleaf/bg-group-sso-fix-default-permission-check
fix default permission check for group sso

GitOrigin-RevId: b78c3dd26d852822f06c44c2aef79daea36fc2bd
2023-12-14 09:03:16 +00:00
Eric Mc Sween
ee0dbcf331 Merge pull request #16167 from overleaf/em-writefull-promo
Writefull integration 10% promo

GitOrigin-RevId: 27ef5e51d7d9c56d85ccc44692444bff46fbeeec
2023-12-13 09:02:48 +00:00
Miguel Serrano
369d5cb406 Merge pull request #16190 from overleaf/revert-15519-em-upgrade-passport
Revert "Upgrade passport"

GitOrigin-RevId: 34a5442d6dae9623463908f92ab103bdc16f1b67
2023-12-12 09:04:23 +00:00
Miguel Serrano
d96283e593 Merge pull request #15519 from overleaf/em-upgrade-passport
Upgrade passport

GitOrigin-RevId: b93bfcab39ba3d2ab4efb4814371defec8ca95c4
2023-12-12 09:04:08 +00:00
M Fahru
2b15cb8e9b Merge pull request #16051 from overleaf/mf-website-redesign-home-checkbox
Add newsletter checkbox to new homepage

GitOrigin-RevId: 6e056194633a9bf2349d0ebcb599dee0d0d50870
2023-12-08 09:05:06 +00:00
Jimmy Domagala-Tang
5c84ea8895 Merge pull request #16062 from overleaf/jdt-ieee-eslint-fix
fix: missing setting on test causing eslint failure
GitOrigin-RevId: fff96acd389cfe30a1e89404a08a87543f503089
2023-12-08 09:04:50 +00:00
Jimmy Domagala-Tang
24261ac617 Merge pull request #16007 from overleaf/jdt-writeful-user-settings
Add Writeful to user settings

GitOrigin-RevId: 15b3dd47b96cdc8bf8002afe3ddc570b03a6065f
2023-12-08 09:04:45 +00:00
Jessica Lawshe
c2f8099793 Merge pull request #16146 from overleaf/jel-sso-login-invalid-email-error
[web] Show error message for invalid emails on SSO log in page

GitOrigin-RevId: 511cd05754f9019bf755ff4909b4579c6dcd7fbb
2023-12-08 09:04:33 +00:00
Jessica Lawshe
3499ebe939 Merge pull request #15992 from overleaf/ab-group-sso-test-flow-1
[web] Group SSO multi-step modal and test flow

GitOrigin-RevId: 343a20ef494276e65b35d1ee070c28d94617ea61
2023-12-07 09:04:31 +00:00
Jessica Lawshe
22aa7a17b2 Merge pull request #16053 from overleaf/jel-project-dash-sso-linked-alert
[web] Show group SSO linked notification

GitOrigin-RevId: f66f68dd647963f53b3978931088ba23bab78273
2023-12-07 09:04:23 +00:00
Brian Gough
29871caf2b Merge pull request #16035 from overleaf/bg-group-sso-login-errors
add an error for unrecognised email on saml login

GitOrigin-RevId: 7102cde8b2b9ccb510f913394c555efc39dd9016
2023-12-06 09:05:16 +00:00
Brian Gough
d9e86e2dba Merge pull request #16034 from overleaf/bg-group-sso-login-copy-ii
update copy for group sso login - revised version

GitOrigin-RevId: 0c72d3a3e06ab7e427c4e728e63c60f0f1526f8e
2023-12-06 09:05:11 +00:00
Eric Mc Sween
94b9d1fa48 Merge pull request #16073 from overleaf/em-postpone-tutorials
Support postponing tutorials

GitOrigin-RevId: fe662086c87cc1909d6d9eeac07f85e306d64418
2023-12-06 09:04:58 +00:00
Alf Eaton
17ac0eb16b Remove unused Angular code from "main" and "ide" endpoints (#15868)
GitOrigin-RevId: dc7ed968c60ae6c64d3cd6d2ec47c93e8d32d7db
2023-12-06 09:04:45 +00:00
M Fahru
77227087e9 [web] Implement homepage redesign (#15905)
* Implement homepage redesign for large screen width

* Implement the UI of `new-design-registration` variant of the homepage redesign

* Add quick placeholder/template for the website-redesign header/footer

Co-authored-by: Thomas Mees <thomas.mees@overleaf.com>
GitOrigin-RevId: 8cff6def8aa560f2e11230dae264cb19feede054
2023-12-05 09:04:40 +00:00
Jessica Lawshe
8a741b89f2 Merge pull request #16082 from overleaf/jel-group-sso-already-linked
[web] Fix projection when checking if user is already enrolled in SSO

GitOrigin-RevId: eebe645cba2f911783f1b2a636a4fc51a8f6107b
2023-12-05 09:04:29 +00:00
Jimmy Domagala-Tang
e57806b204 Merge pull request #15046 from overleaf/jdt-gramr-ad
creating notification for grammarly collab ad

GitOrigin-RevId: 984869bb561a2b2d3210f1018b93b24aedef9783
2023-12-05 09:04:25 +00:00
Jessica Lawshe
a439f8b490 Merge pull request #16040 from overleaf/jel-require-group-access
[web] Add access check for group membership

GitOrigin-RevId: c7605ebb956556d9d9480cd5f3d1d6b60d99bc7c
2023-12-05 09:04:17 +00:00
Jimmy Domagala-Tang
7341c18e0f Merge pull request #16069 from overleaf/jdt-add-staging-trusted-writefull
Add writeful to trusted users, and fix trusted logic

GitOrigin-RevId: 526d8a77e8d5c56e94a6d671e811bfdbb74e2ac6
2023-12-04 09:03:01 +00:00
Jimmy Domagala-Tang
8e194d5ff9 Merge pull request #16066 from overleaf/jdt-revert-ieee-fix
Revert #15976 (hiding theme picker on IEEE branded pages)

GitOrigin-RevId: 435a866a7e5ac105786f28dce0588d05cf504cd4
2023-12-01 09:03:21 +00:00
Jimmy Domagala-Tang
cea7846795 Merge pull request #15976 from overleaf/jdt-jpa-ieee-theme-picker
Hiding the overall theme for IEEE branded projects

GitOrigin-RevId: 5f07a7b316aea29ab72183fe4014c1b3e5c94bb8
2023-12-01 09:03:18 +00:00
Domagoj Kriskovic
b9834b0cbd Added category support for sendgrid (#15970)
* Added category support for sendgrid

* use category only for confirmation code

GitOrigin-RevId: 1b93d8d0ac3699b9ad9f633f62b6471d163a2fba
2023-12-01 09:03:09 +00:00
Jakob Ackermann
0f793975d2 Merge pull request #16044 from overleaf/jpa-cleanup-user-model
[web] remove unused field "sharelatexHashedPassword" from user model

GitOrigin-RevId: 69ff744b8f40adbdeb0e0092ab8435d693f97113
2023-11-30 09:04:07 +00:00
Jakob Ackermann
6b19cae812 Merge pull request #16001 from overleaf/jpa-web-real-time-auto-join-only
[web] drop support for legacy real-time connection

GitOrigin-RevId: d03aae6392a8d920239647ab198d66d6c75f61a0
2023-11-30 09:03:49 +00:00
Jakob Ackermann
a523283559 Merge pull request #16000 from overleaf/jpa-web-join-project-rate-limit-per-user-id
[web] apply rate limit for joinProject per user-id and project-id

GitOrigin-RevId: d03a81f4ff55d9a8f6d4ea4ca3633e3682e6dacb
2023-11-30 09:03:46 +00:00
Eric Mc Sween
75df01683b Merge pull request #15958 from overleaf/em-writefull-script-local
Load the Writefull script when given a query param

GitOrigin-RevId: 57ce26b8692b43b7754ee77de67e9734d4a196dc
2023-11-30 09:03:29 +00:00
Jimmy Domagala-Tang
0a484bb325 Merge pull request #16015 from overleaf/jdt-trust-captcha-on-login
Add trusted case for captchaRequiredForLogin

GitOrigin-RevId: 45cd93b46515ced034f1514f5454767383f3a17a
2023-11-29 09:04:56 +00:00
Davinder Singh
638c964fe2 Removing "Load' Event from event tracking (#15967)
* removing load event from event tracking

* adding segmentation

GitOrigin-RevId: 2d008a1fb1a8bf2183a91659cb0351f9beb484ef
2023-11-29 09:04:52 +00:00
Davinder Singh
abba46978d adding a filter condition for adding an email (#15914)
* adding a filter condition for adding an email

* fixing failing tests

GitOrigin-RevId: 5276ad69229ab16b776da29150a103513e23d15a
2023-11-29 09:04:43 +00:00
Jimmy Domagala-Tang
53708fb03e Merge pull request #15906 from overleaf/jdt-disable-staging-captchas-if-trusted
allow for list of trusted users to skip captchas

GitOrigin-RevId: d398e98f63e4dc800a5b4ac59c8c9b672a200a15
2023-11-29 09:04:39 +00:00
Alf Eaton
d40de2018c Remove Angular/Pug review panel code (#15935)
GitOrigin-RevId: de782d4b47d987f6434a34bea487568b269e8d85
2023-11-29 09:04:13 +00:00
Alf Eaton
9875e55a27 Remove Ace (#14299)
GitOrigin-RevId: ec8788fdbc8aea73ca33ec2810f4e588fe9476b5
2023-11-29 09:04:08 +00:00
Jakob Ackermann
4636f40f03 Merge pull request #12448 from overleaf/jpa-compile-and-download-pdf
[web] add button to project dashboard for compiling and downloading PDF

GitOrigin-RevId: c243b4a30e4720116d82d9c25bdc8be8825d6d74
2023-11-29 09:03:59 +00:00
Brian Gough
011609b345 Merge pull request #15913 from overleaf/bg-group-sso-fix-signature-error
fix the error message for an invalid saml signature

GitOrigin-RevId: 2987f84f6ff2bea168887ff3e6ad621fb257aeed
2023-11-28 09:04:58 +00:00
Alexandre Bourdin
661c9f685c Merge pull request #15963 from overleaf/ab-reminder-invite-non-managed
[web] Reminder emails for non-managed groups

GitOrigin-RevId: 93b7c0afb0b0b2057ad38a5628edc9526a0a48a5
2023-11-28 09:04:36 +00:00
Alf Eaton
345f51bedb [ide-react] Improve initial loading behaviour (#15916)
* Defer script loading
* Only mount IdePage once everything has connected

GitOrigin-RevId: 32f16214f26ac6a6d71a9dd332b3c35b8b82deae
2023-11-28 09:04:11 +00:00
Thomas
24023dd267 Merge pull request #15901 from overleaf/tm-design-system-updates-teardown
Design system updates test tear down and clean up

GitOrigin-RevId: 743423f7c31c0ba89093bba0107d7e6799e1c309
2023-11-28 09:04:06 +00:00
Davinder Singh
310c938f80 adding correct events on plans page (#15951)
GitOrigin-RevId: d86b9cff07b9179a80b19ecdca1542ff8f9c9cd1
2023-11-27 09:04:32 +00:00
Rebeka Dekany
fbf02b4856 [web] Track if the email is confirmed/verified (#15818)
* Added email-verifed event

* added email provider

* check if the email is primary

* rename confirm email segmentation

* remove the segmentation because it duplicates verification-type

* move the response

* remove duplicate definition

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 2956467b46a883fc0ee00c26dd446ba82fa5be26
2023-11-27 09:03:56 +00:00
Rebeka Dekany
441cf1bb5b Add institution name field to the database (#15862)
GitOrigin-RevId: 5527692bb476a8504e3540e827d62e41d8813d60
2023-11-27 09:03:48 +00:00
Alexandre Bourdin
202196dde2 Merge pull request #15808 from overleaf/ab-split-test-dev-toolbar
[web] Split Test Dev Toolbar

GitOrigin-RevId: 630116049a94aceb39d5afc9425b8ec6ee95b944
2023-11-24 09:04:40 +00:00
Mathias Jakobsen
21c61be543 Merge pull request #15781 from overleaf/ds-react-history-split-test-tear-down
History View React - Split test tear down

GitOrigin-RevId: 6095ea94a74fc96c7031a4d1bbefdc6211cc934c
2023-11-24 09:04:14 +00:00
Miguel Serrano
b1978d9362 [web] new notification style for dashboard (#15878)
* Create `new-notification-style` split test

GitOrigin-RevId: 3b6d8894da049939c424459ddb7d0afe967dab4c
2023-11-23 09:03:05 +00:00
Alf Eaton
aed5c911f2 Throw error if project name has leading or trailing whitespace (#15842)
GitOrigin-RevId: 65dc375535dbab66b7446642c6b2d14c978d3c38
2023-11-23 09:02:57 +00:00
M Fahru
8aed8f7dd7 Merge pull request #15857 from overleaf/mf-split-test-website-redesign
[web] Configure `website-redesign` split test

GitOrigin-RevId: 8b1b3c6ab1ba9c674517ebdb87e89bd3a44aade7
2023-11-22 09:04:53 +00:00
Tim Down
2807a35e24 Merge pull request #15728 from overleaf/td-lg-expire-password-tokens
Expire user password reset tokens when user changes their password

GitOrigin-RevId: 2d303eba947c224e71ebe60083abc7a8ff5207a5
2023-11-22 09:04:30 +00:00
Brian Gough
3e5273144e Merge pull request #15656 from overleaf/bg-group-sso-login-acceptance-tests
add acceptance tests for group sso login

GitOrigin-RevId: 046d142ab478e45619b3a76d88eac73a808dfa08
2023-11-22 09:04:07 +00:00
Jessica Lawshe
f76563787b Merge pull request #15838 from overleaf/jel-link-sharing-redirect-hash
[web] Save link sharing URL hash as part of redirect

GitOrigin-RevId: 7d067852863b93e3246e5132511031005e333810
2023-11-21 09:04:23 +00:00
Mathias Jakobsen
6e74a65758 Merge pull request #15672 from overleaf/mj-group-subscription-audit-revival
[web] Add audit logs when user joins or leaves group subscription

GitOrigin-RevId: d64425f5a2434c60c89c297c9a51acae3b96c31e
2023-11-21 09:04:08 +00:00
Mathias Jakobsen
7c8014d791 Merge pull request #15798 from overleaf/mj-features-page-teardown
[web] Tear down features-page split test

GitOrigin-RevId: 346064bea8775033d226f4405843717b380085fd
2023-11-21 09:04:03 +00:00
Mathias Jakobsen
9ca43ebc4e Merge pull request #15822 from overleaf/mj-audit-log-tokens
[web] Add audit logs for token expiration operations

GitOrigin-RevId: 220fe017cf508ead986a4cd2bd9009035418ce43
2023-11-21 09:03:59 +00:00
Brian Gough
1ff830027f Merge pull request #15726 from overleaf/ab-managed-users-module-cleanup
[web] Managed users / Group SSO module cleanup

GitOrigin-RevId: a24d3278667059248d9563afe44cafca5f87a7c0
2023-11-21 09:03:54 +00:00
Jessica Lawshe
11ce29197b Merge pull request #15687 from overleaf/jel-token-v1-mismatch
[web] Test for v1 project URL fragment in link sharing hash check

GitOrigin-RevId: 10cb2efe60f4613e3a39a5199bd653376c06ad3b
2023-11-17 09:03:05 +00:00
Jakob Ackermann
453edbfe0a Merge pull request #15793 from overleaf/jpa-compile-domain-cleanup
[web] tear down split test for new compile domain

GitOrigin-RevId: 7ab417d67e508cd95bd4e78ce7ce2a993c789dca
2023-11-17 09:02:56 +00:00
Alf Eaton
d2d2a0ff65 Upgrade PDF.js (#15157)
GitOrigin-RevId: a0a241da08c06a7e345a710559cb47fb59685e5a
2023-11-15 09:03:09 +00:00
M Fahru
6a7f230fa2 Fix "Done" button after accepting group invite button does not work as intended because of href value is not set correctly
the `doneLink` variable on the pug file is expanded in the backend, so this commit will move the href building in the pug file instead of the frontend angular controller to make sure the value exists

GitOrigin-RevId: 74029a03293324955120bca630925a743ee60c22
2023-11-14 09:05:03 +00:00
Rebeka Dekany
1c834cbfaf Merge pull request #15740 from overleaf/dk-odc-newprops
Store ODC form step 3 data in mongo

GitOrigin-RevId: 91311efaddb5ccb9a456ea359140235235530536
2023-11-14 09:04:56 +00:00
Domagoj Kriskovic
9ce9b2c937 Add onboarding-flow in "register" and "user-registered" events (#15651)
* onboarding-flow in register event

* onboarding-flow in user-registered event

* fix typos

GitOrigin-RevId: aff8a7157062db0ec1c99499353a7c08eaa7b8b6
2023-11-13 09:03:57 +00:00
M Fahru
0639f266d8 Merge pull request #14756 from overleaf/mf-group-invite-new-user-redirection
[web] Redirect to invite screen if new user register with a pending group invitations

GitOrigin-RevId: 39aeffd65b9d793c87e53398a700ad140794594e
2023-11-10 09:04:23 +00:00
Alexandre Bourdin
c4bea21ee2 Merge pull request #15669 from overleaf/ab-fix-sso-linking-status
[web] Fix SSO status in group members table

GitOrigin-RevId: e54e7b0c9640f0b96d9692c0208357e3bac2de91
2023-11-10 09:04:15 +00:00
Alf Eaton
b0effa7e4a Trim the project name again after fixing (#15682)
GitOrigin-RevId: 74c87ee1689668a058a162a1f456815e0748b049
2023-11-10 09:04:00 +00:00
Miguel Serrano
7f347be7f3 Merge pull request #15658 from overleaf/msm-team-invite-acceptance
[web] Team invite acceptance tests

GitOrigin-RevId: 755a4c483c93cee1ce4403c04db85fcbf4da06c3
2023-11-10 09:03:38 +00:00
Rebeka Dekany
4dd2635c40 Merge pull request #15685 from overleaf/rd-newsletter-homepage
[web] Hide newsletter checkbox on the homepage when token-confirmation-odc variant is active

GitOrigin-RevId: b5c0c1fdf205c99584ae7b6b461b13a73745fef3
2023-11-09 09:03:26 +00:00
Jessica Lawshe
efc66bb276 Merge pull request #15664 from overleaf/jel-token-hash-prefix
[web] Include more data when logging link sharing token hash mismatches

GitOrigin-RevId: 8f939cf3dd49497d5b21779e354ce5deff07edad
2023-11-09 09:03:13 +00:00
Domagoj Kriskovic
330a9c8e3a Store ODC form results in onboardingDataCollection (#15609)
* registration/onboarding page

* show only if in split test group

* rate limiter, skip errors

* fix storybook logo

* remove skip payload

* fix typos

* prettier

* store ODC form results in onboardingDataCollection

* add userId

* prettier

* pick what properties should be stored

* remove unused props

* remove userId index

* update user profile

* update user profile

* use setOp

* added test

* remove userId from schema

* clean after user delete

* mock unit test

* limit to 255 chars

* updatedAt field

* prettier

* firstName, lastName as separate vars

* move subscribe at the end

* check if user exists

GitOrigin-RevId: 6d76927e97b5f4ed664ffb9b8806b3516c77eb9b
2023-11-09 09:03:04 +00:00
Miguel Serrano
42fe453096 [SP] Prevent rendering of sync section in SP when git disabled (#15647)
GitOrigin-RevId: 0f4c43eeb0182e7288566eff1ceed861bb9c4338
2023-11-07 12:35:08 +00:00
Alf Eaton
e0c8eb98c1 Show the git sync modal to read-only users (#15301)
GitOrigin-RevId: e002815fa7c18d497260e6344a4e8de95d7bacef
2023-11-07 12:35:04 +00:00
Alf Eaton
3912de589f Merge pull request #15629 from overleaf/ae-web-target
Use production `web` dependencies for development

GitOrigin-RevId: e89942d1a24c32bf60b319932c6d74905db74a19
2023-11-07 12:35:00 +00:00
Alexandre Bourdin
8abf8ba956 Merge pull request #15639 from overleaf/ab-fix-group-settings-visibility
[web] Various fixes for Group SSO

GitOrigin-RevId: 0a98d7eed14b2878a6be5e28e54ab1f7ceb9be5f
2023-11-07 12:34:45 +00:00
Jessica Lawshe
780673ed31 Merge pull request #15558 from overleaf/jel-log-token-hash-mismatch
[web] Log the project ID on link sharing token hash prefix mismatches

GitOrigin-RevId: 37d15206f49920f49d61f22479b98dd4d448f6bd
2023-11-07 09:05:12 +00:00
Alexandre Bourdin
d45ca7d401 Merge pull request #15582 from overleaf/msm-sso-linking-reminders
[web] SSO Linking redirects and interstitial info

GitOrigin-RevId: fdad0290ebf2b8b8a77f12b75736c030a4c7b642
2023-11-07 09:05:00 +00:00
Alexandre Bourdin
6852ad2be7 Merge pull request #15569 from overleaf/msm-group-sso-link-errors
[web] Error handling during SSO linking

GitOrigin-RevId: 232ef0672e93dc7c68cd45396306e8b4328a35d9
2023-11-07 09:04:55 +00:00
Alexandre Bourdin
2783e89bc3 Merge pull request #15539 from overleaf/ab-schedule-sso-reminder
[web] Schedule Group SSO account linking reminder after joining the group

GitOrigin-RevId: 5586787fbd268446e441762fd7b4846821f849f6
2023-11-07 09:04:51 +00:00
Brian Gough
ee4e1f5429 Trim project name and validate whitespace (#14976)
* add whitespace check to fixProjectname
* add whitespace check to validateProjectName
* Log a warning if the project name starts or ends with whitespace

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: ba81e0f795e52dbba92c9fbb48cebfd8e547af08
2023-11-06 09:03:55 +00:00
Alexandre Bourdin
e322f4a31f Merge pull request #15418 from overleaf/ds-managedUsersEnabled
Managed users - Adding a managedUsersEnabled flag on subscription model

GitOrigin-RevId: a03dd169ba71255dd1bec5f7bee8ce9609d95a2f
2023-11-03 09:00:26 +00:00
Eric Mc Sween
75c7a58100 Merge pull request #15515 from overleaf/em-promisify-user-controller
Promisify UserController

GitOrigin-RevId: d56ddb32abff2c33f45efa58285c7bf02b578cd2
2023-11-03 09:00:13 +00:00
Brian Gough
d3adcff0f1 Merge pull request #15544 from overleaf/bg-misc-use-literal-paths
Replace APP_ROOT and other variables with literal paths in web imports

GitOrigin-RevId: 138f03ad9355c8c6c92a206b0e54573234a6f65d
2023-11-02 08:53:03 +00:00
Jimmy Domagala-Tang
37817f89f4 Merge pull request #15295 from overleaf/jdt-subs-tbl-tab-access
Add subscription table icons to the tab index

GitOrigin-RevId: 1585cf2c7a114a9cae78c5d4bfbd888756aacf43
2023-11-02 08:52:59 +00:00
Domagoj Kriskovic
af4b22fab5 Confirm email new routes (#15377)
* confirm email routes

* Style the email confirmation template (#15196)

* error handling

* prettier

* error message

* rename variables

* message codes change

* v1 redirect

* fix assigning to session

* rename rate limitter

* rate limitter per email

* add try/catch

* added stub

* prettier

* confirm email acceptance test

* confirm when created

* tests

* added rate limit tests

* new email text

* subscribe to newsletter

* beforeEach/afterEach test both variants

* move tests to OverleafAuthenticationTests

* Revert "move tests to OverleafAuthenticationTests"

This reverts commit 3c745382815da1594044a811882ba3daa24a7a3a.

* cacheflow reset after each

* remove test archive request

* use crypto for random code

* rate limit in userEmailsConfirmationHandler

* ratelimiter per type

* req.session.pendingUserRegistration

* spy in before/after each

* without deleteMany

* delete staffUser in afterEach

* stub response, format

* rate limiter outside userEmailConfirmationHandler

* mock ratelimitter

* fix subscribe promise

* add email to logger

* logger calls

* using tsscmp

* fix lint

* resendConfirmationCode rate limiter in router

* remove redirect

---------

Co-authored-by: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>
GitOrigin-RevId: 786c477966cf2c5f6e28417fe486146ee5c10884
2023-11-02 08:52:48 +00:00
Miguel Serrano
220998839b Merge pull request #15504 from overleaf/msm-fix-import-sp
[web] Replace module import breaking Server Pro

GitOrigin-RevId: 23f65b06d14019d1878c61abdf71b6b556192dc4
2023-11-01 09:03:25 +00:00
Miguel Serrano
e22e8ff7a8 [web] SSO linking for existing group members (#15471)
* [web] SSO linking for existing group users

GitOrigin-RevId: 22a5a5a28a213860f88ae0284c1ef51a31bb268f
2023-11-01 09:03:19 +00:00
Miguel Serrano
1f56441184 Merge pull request #15514 from overleaf/jpa-single-webpack-runtime
[web] enable webpack option runtimeChunk=single in dev-env

GitOrigin-RevId: 905b362496fc5df896632db920c91aee75c30b46
2023-11-01 09:03:16 +00:00
Miguel Serrano
d62f2c6a40 Merge pull request #15509 from overleaf/jpa-ide-react-pug-tweaks
[web] editor: use CSS/JavaScript loading primitives from base template

GitOrigin-RevId: fb570f62e37517f2a4444d469435e854fd890db6
2023-11-01 09:03:14 +00:00
Miguel Serrano
93b7e65f6c Merge pull request #15405 from overleaf/msm-remove-redundant-check
[web] Remove redundant check

GitOrigin-RevId: 035adf436c0d694fcb7817cd27e743683eb1252d
2023-11-01 09:03:08 +00:00
Jakob Ackermann
6906c6a28c Merge pull request #15513 from overleaf/jpa-consistent-return-type
[web] ExpressLocals: avoid returning undefined from getCssThemeModifier

GitOrigin-RevId: f5256719c2b4f06e2957f6bc971d3c895bdff5d2
2023-11-01 09:02:51 +00:00
Brian Gough
a12699133d Merge pull request #15420 from overleaf/bg-group-sso-handle-errors
handle errors in group sso login

GitOrigin-RevId: dcfba6bc4f7aec8aa9d27945b297154594368d92
2023-10-31 09:04:48 +00:00
Jessica Lawshe
8a0f2dbe1d Merge pull request #15419 from overleaf/em-error-request-logging
Use the request logger for errors in web

GitOrigin-RevId: f654fc69e0bbdab8b16d23b007aefbad08925358
2023-10-31 09:04:36 +00:00
Jessica Lawshe
1054b2d6fa Merge pull request #15491 from overleaf/jel-token-hash-log-user-id
[web] Log the user ID on token hash prefix mismatches

GitOrigin-RevId: 78d298051a9c1794ed38422bef24c852dcee3bb2
2023-10-31 09:04:26 +00:00
Jessica Lawshe
a3251394e1 Merge pull request #15473 from overleaf/jel-remove-encoded-hash
[web] Remove encoded hashtag when checking token hash prefix

GitOrigin-RevId: 2b9c369beceb7897d0f6f165b4c3a70b79c14469
2023-10-31 09:04:22 +00:00
Thomas
3cd0cefd30 Gradual rollout of new compile timeout to existing users (#15478)
* Rollout compile timeout to existing users

* Update copy for compile timeout messages

GitOrigin-RevId: bada02efb3fc506ae6e35bdb7871a58ef4295cbe
2023-10-31 09:04:11 +00:00
Alf Eaton
1314f9082c Improve detection of folder move into subfolder (#15422)
GitOrigin-RevId: 200d6e10a6e92ca85de24cae6d20f50c697ca584
2023-10-31 09:04:00 +00:00
Alexandre Bourdin
cd27ee3c8f Merge pull request #15446 from overleaf/ab-tie-user-enrollment
[web] Prevent a user from becoming managed by another group after linking group SSO

GitOrigin-RevId: d8cb763a68ca38b4aaf1518a5f93ac5a61cec28c
2023-10-30 09:04:47 +00:00
Alexandre Bourdin
c71301ac9a Merge pull request #15223 from overleaf/ab-sso-multiple-certificates-ui
[web] Support multiple certificates in group SSO settings

GitOrigin-RevId: 5f014eb82b7e0820040941fdd2bded8d33958316
2023-10-30 09:04:38 +00:00
Jessica Lawshe
16e859e40a Merge pull request #15429 from overleaf/jel-token-hash-metrics
[web] Log mismatched link sharing token hash prefixes

GitOrigin-RevId: 5ba690f4209987fccef859c858686c465e972f62
2023-10-27 08:03:27 +00:00
Davinder Singh
f97689aa87 Group SSO - Adding the SSO invite link reminder button in the dropdown (#15289)
GitOrigin-RevId: 9641946e65ede2d52645caf8876d7587a24e7dfc
2023-10-26 08:03:21 +00:00
Jessica Lawshe
21514418e5 Merge pull request #14881 from overleaf/ab-beta-program-async-await
[web] Convert BetaProgramController to async/await

GitOrigin-RevId: 2423cb00b78b2f3fddb7bcd317d34ed4dbc12b95
2023-10-25 08:05:03 +00:00
Jessica Lawshe
8da063d640 Merge pull request #15326 from overleaf/jel-link-sharing
[web] Add prefix of token hash to link sharing URLs

GitOrigin-RevId: 4b764c076a335768ab261dd1e181d90ce00fd1a2
2023-10-25 08:04:59 +00:00