github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
20418 commits 3 branches 7 tags 206 MiB
Commit graph

17803 commits

Author SHA1 Message Date
CloudBuild
2db96f5c66 auto update translation 
GitOrigin-RevId: b1846e4d997a1238e7e1e33c9196d42771d91e70
 2023-05-05 08:05:35 +00:00
Jessica Lawshe
44c2b6d2b2 Merge pull request #12958 from overleaf/jel-payment-change-currency 
[web] Add currency as a dependency of effect and query price with current currency

GitOrigin-RevId: 1bbb2c5cd71a0dc23642e9af1eddc4a8a129b7ae
 2023-05-05 08:05:27 +00:00
Rebeka
e3a0d236ae fix: color should be persisted on the disabled menu item when hovering over it 
GitOrigin-RevId: e594388b36de986c02114aa652f6fe9c9d705c5d
 2023-05-05 08:05:10 +00:00
Eric Mc Sween
e323a22666 Merge pull request #12932 from overleaf/em-history-chunks-project-deletion 
Use index when deleting project history chunks

GitOrigin-RevId: 804b8fe8da8bab04a4c0e9fe0008c5554b51817e
 2023-05-05 08:05:02 +00:00
Tim Down
a0e3379c86 Merge pull request #12939 from overleaf/td-history-more-update-scroll-amount 
History migration: More update button scrolls next change to the centre

GitOrigin-RevId: 29d41a046f7110c246a0b9c784dedf6b148ea298
 2023-05-05 08:04:53 +00:00
Tim Down
27457133e4 Merge pull request #12873 from overleaf/td-history-loading-improvements 
History migration: Improve loading logic and display for loading file diffs

GitOrigin-RevId: 9d20c4632e6a804cb21e6fffd52faa88bc03f01a
 2023-05-05 08:04:45 +00:00
Tim Down
95646a1bd5 Merge pull request #12936 from overleaf/td-history-diff-viewer-fixed-font 
History migration: Use fixed font, text size, line height and theme in document diff viewer

GitOrigin-RevId: 9f86be609e0fe72ca41429bae9db03e047952c08
 2023-05-05 08:04:37 +00:00
Jakob Ackermann
856e1e4025 Merge pull request #12935 from overleaf/jpa-include-patches 
[misc] make npm package patches available to all the services

GitOrigin-RevId: 4e53f8af15f009d5e7c44d00b87b7592b6175541
 2023-05-05 08:04:13 +00:00
June Kelly
7d1d34726e Merge pull request #12914 from overleaf/mf-sort-file-tree-history-react 
Sort react history file tree items with the same rule as the angular history file tree

GitOrigin-RevId: da3d3195fff1f5b05b232b329fc3cf38a65743f6
 2023-05-05 08:04:04 +00:00
Eric Mc Sween
8a0a67e2bb Merge pull request #12880 from overleaf/em-hash-oauth-secrets-4 
Hash secrets when creating OAuth clients

GitOrigin-RevId: 5fb05bd825ceaabda635fe554a95879773aa3396
 2023-05-04 08:06:12 +00:00
Jakob Ackermann
b0633b3a47 Merge pull request #12842 from overleaf/jpa-logout 
[web] remove GET /logout endpoints

GitOrigin-RevId: 93f9498fdb66ece5028d90941aac50cda2737604
 2023-05-04 08:05:57 +00:00
Eric Mc Sween
d5242379f2 Merge pull request #12912 from overleaf/em-server-pro-oauth-indexes 
Add missing OAuth indexes in ServerPro

GitOrigin-RevId: 6cd37c1d884d30d5ec040f7d60961c8854e51273
 2023-05-04 08:05:48 +00:00
Rebeka
0c54e6605b Remove deprecated uses of badge style 
GitOrigin-RevId: 47234e95acd42d7e5d23de8e3b67edca2bdd98d1
 2023-05-04 08:05:40 +00:00
Alf Eaton
680a02892c Duplicate the cloneSelectionVertically key mapping to re-allow Ctrl on macOS (#12918) 
GitOrigin-RevId: 747e8889b5e3b34dd9ffef888f4a1d42fea1af74
 2023-05-04 08:05:31 +00:00
Alf Eaton
2093d85a5f Exclude CtrlSym commands from completion (#12905) 
GitOrigin-RevId: f6d1813eba6c17444d2371b024f538137c244963
 2023-05-04 08:05:23 +00:00
Alf Eaton
b010d6a5d3 Handle unset editor theme (#12892) 
GitOrigin-RevId: 0e3413c08c6fd0752cd90ee868fec9b0f9f77437
 2023-05-04 08:05:14 +00:00
Alf Eaton
2796f750ee Rename TrackChangesToggleButton prop to match onMouseDown attribute (#12862) 
GitOrigin-RevId: bf2a83c58298ee809f181d95beddec695d223922
 2023-05-04 08:05:05 +00:00
Alf Eaton
09c5bf72d2 [cm6] Use Cmd on macOS for cloneSelectionVertically (#12855) 
GitOrigin-RevId: ea72da47f2ebb377cf22af061ab616a021950502
 2023-05-04 08:04:57 +00:00
Alf Eaton
8a12c34fce [cm6] Emacs: close search form when Enter is pressed in "Find" input (#12841) 
GitOrigin-RevId: a4c974f45e0dbb13d96b9b424f056768449791fb
 2023-05-04 08:04:49 +00:00
Alf Eaton
6c21f0821c [cm6] Handle multiple selection ranges when applying snippets (#12830) 
* Use fork of @codemirror/autocomplete
* Handle multiple selection ranges when applying snippets

GitOrigin-RevId: 04afc087ac127206463ea3d4950284a50308364a
 2023-05-04 08:04:39 +00:00
Alf Eaton
05582567b4 Improve performance of search match counting (#12808) 
GitOrigin-RevId: 70cd1aaf5b079cbd540c4a9f92a04fcb2786b308
 2023-05-04 08:04:30 +00:00
Eric Mc Sween
05f963d17d Merge pull request #12878 from overleaf/em-hash-oauth-secrets-2 
Script for hashing OAuth secrets

GitOrigin-RevId: 7e2198ff9b41a24b1ca84768c24f3f653243c030
 2023-05-02 19:46:13 +00:00
Eric Mc Sween
66d29940c3 Merge pull request #12861 from overleaf/em-ds-delete-chunk-migration 
Better indexes for history chunks deletion

GitOrigin-RevId: 1404f5a0535bc94cb1e9d7fc2ea66fd90f584fea
 2023-05-02 19:45:57 +00:00
Eric Mc Sween
cc604376c5 Merge pull request #12882 from overleaf/em-git-bridge-swap-job-config 
Disable swap job when swap store is unsafe

GitOrigin-RevId: 104b03e378e7802f9ba6ff96b5a626a2fa7960fb
 2023-05-02 19:45:48 +00:00
Tim Down
da916c9c13 Merge pull request #12906 from overleaf/td-history-fix-labels-test 
Expect correct number of labels in history version list test

GitOrigin-RevId: 2a56b21c7359aad5111a2a7879f31fb5e7c6b73d
 2023-05-02 19:45:40 +00:00
Tim Down
7f17992cbc Merge pull request #12870 from overleaf/td-history-prevent-diff-render-on-label-change 
History migration: prevent unnecessary render when adding or deleting a label

GitOrigin-RevId: acabd581403f17f863e3bd0c06d1fbd77fe22228
 2023-05-02 19:45:31 +00:00
Tim Down
76103eb77f Merge pull request #12874 from overleaf/td-history-binary-file 
History migration: Show alert for binary file preview

GitOrigin-RevId: f30e4946ce9f873661055b8a096c6aba7ab08e2d
 2023-05-02 19:45:22 +00:00
Tim Down
a19dffeac2 Merge pull request #12877 from overleaf/td-history-file-tree-keyboard 
History migration: Only activate document in file tree for space and enter keys

GitOrigin-RevId: 166a9ba36b1f19cd4e50d0e6f63ce04b164512cf
 2023-05-02 19:45:14 +00:00
Tim Down
91db36bc01 Merge pull request #12883 from overleaf/td-history-deletion-marker-fix 
History migration: Fix deletion marker class in theme

GitOrigin-RevId: d84c97632f467b116024ffc0992970b9aa586294
 2023-05-02 19:45:05 +00:00
M Fahru
9e5aabea33 Implement auto retry mechanism for deleted file restore in history react (#12866) 
GitOrigin-RevId: b30895061ee6fdfb6488d27ce2f91d4e410735aa
 2023-05-02 19:44:57 +00:00
Tim Down
1fb921de99 History migration: Add error handling for all history requests (#12872) 
* Add error handling for all history requests

* Remove comment

GitOrigin-RevId: 528dc98a0fc4ab523f8536274996c4166be45064
 2023-05-02 19:44:48 +00:00
Tim Down
70bae34bd8 Add paywall to React history view (#12849) 
* Implement history view paywall

* Add tests and some CSS fallbacks

* Make additional faded version above paywall non-clickable

* Change isFaded to faded for consistency

* Remove unused import

* Add missing attribute

* SHow all labels in free tier

* Address review comments

* Change Boolean conversion

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* Make adding or deleting a label show up in version list again

* Refactor to use visibleUpdateCount rather than maintaining two separate update arrays

* Removed unused import

* Use data-testid instead on class

* Round gradient values

* Correct test selector

---------

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
GitOrigin-RevId: a2b021f3f4d3b9eb1358edb2ee4aa7db1bc7240e
 2023-05-02 19:44:39 +00:00
June Kelly
e89b4b4214 Merge pull request #12811 from overleaf/jk-plans-event-currency-segmentation 
[web] Add currency/id segmentation to Recurly analytics events

GitOrigin-RevId: 56998f403358d5f6b3cece6835e16e65e06635b1
 2023-05-02 19:44:24 +00:00
ilkin-overleaf
5480e1b371 Merge pull request #12850 from overleaf/ii-history-react-fix-disappeared-pseudo-labels 
[web] Fix disappeared pseudo labels

GitOrigin-RevId: 4d33eb8888cadbccba29ac001e205db8fa717c49
 2023-05-02 19:44:15 +00:00
Miguel Serrano
0564532f92 [git-bridge] Add support for Oauth2 Personal Access Tokens (#12795) 
* [git-bridge] Add support for Oauth2 Personal Access Tokens

Adds support for Personal Access Tokens by sending a Bearer
token authentication when the username is `git`.
The feature is controlled by `GIT_BRIDGE_ACCESS_TOKEN_ENABLED`

---------

Co-authored-by: Eric Mc Sween <5454374+emcsween@users.noreply.github.com>
GitOrigin-RevId: 5553b0b68574158ede86ceec6c618cf4c4b09c92
 2023-05-02 19:43:59 +00:00
Brian Gough
1da76f0a8d Merge pull request #12848 from overleaf/bg-fix-path-exception 
add exception handling for  path.join in ProjectEntityHandler

GitOrigin-RevId: dad305057fd6b2821525ca5b6d1933824989e241
 2023-05-02 19:43:50 +00:00
Jakob Ackermann
6ef9be0d0c Merge pull request #12858 from overleaf/jpa-server-ce-script-change-compile-timeout 
[web] server-ce-script: add script for changing compile timeout for user

GitOrigin-RevId: 3718b970661e1ede04402889c240ecdabdcc7eff
 2023-05-01 08:05:20 +00:00
Jakob Ackermann
cb16efdc53 Merge pull request #12853 from overleaf/jpa-tweak-filestore-test-output 
[filestore] add ss header to error output when sockets are leaking

GitOrigin-RevId: 9aa61c99eaf74a061ea0b524c236abbc6f1c9846
 2023-05-01 08:05:11 +00:00
Alf Eaton
e0d9069131 [cm6] Add "within selection" option to the search form (#12798) 
* Use forked @codemirror/search
* Use getPanel to get the search panel
* Remove layer-based highlightSelectionMatches
* Add "within selection" option to the search form
* Add test for "replace all within selection"
* Fix tests

GitOrigin-RevId: 95ce76fd017f96278b04c16a1fd34f785f7504a3
 2023-05-01 08:05:02 +00:00
Alf Eaton
7f7443356c Merge pull request #12738 from overleaf/mj-disable-ace-beta-users 
[web] Hide Ace editor for beta users

GitOrigin-RevId: 7e359823429656862c4701e55686ebfd3f1f7a36
 2023-05-01 08:04:53 +00:00
Alf Eaton
2606c76aec Merge pull request #12805 from overleaf/ae-markdown-types 
[cm6] Fix type for Markdown language loader

GitOrigin-RevId: 725e1b28dd73e9090638f5d682e48e658c957a04
 2023-05-01 08:04:45 +00:00
Alf Eaton
1da94f029c [cm6] Avoid selecting a search match when re-opening the search panel (#12797) 
GitOrigin-RevId: 32bb03b71ce56cc0dbe6f7c92cc6d85151ef1971
 2023-05-01 08:04:36 +00:00
Alf Eaton
40cbfc451a [cm6] Improve search match scrolling into view (#12787) 
GitOrigin-RevId: 6ce9b86253a9c3a2c6ff44c10f78204ff16bd6e2
 2023-05-01 08:04:27 +00:00
Alf Eaton
c53411ff1d Merge pull request #12776 from overleaf/ae-search-close-tooltip 
[cm6] Add tooltip to search panel close button

GitOrigin-RevId: ba7f4ca5d672580054cb6214be94497fd5141730
 2023-05-01 08:04:17 +00:00
Alf Eaton
f3205c1d06 Merge pull request #12768 from overleaf/ae-upgrade-codemirror-3 
[cm6] Upgrade CodeMirror dependencies

GitOrigin-RevId: aa2d3473deee940fc86ac18261c0e0c35af53711
 2023-05-01 08:04:07 +00:00
M Fahru
0648b8aa6c Implement deleted file restore for history react (#12753) 
* Add strikethrough to deleted file tree item in history file tree

* Add "restore file" button on toolbar if the selected file have a `removed` operation.

* Implement "restore file" functionality on removed file:

- Refactor the `Selection` object in history context value since we need the `deletedAtV` data which currently is not passed through the state.
- Refactor and clean up file tree type system to support passing through the whole `FileDiff` object for getting the `deletedAtV` data which only appear on `removed` operation
- Implement `postJSON` with file restoration API and pass it on restore file onClick handler at toolbar

* Implement loading behaviour while restoring file is inflight:

- Add `loadingRestoreFile` to `LoadingState`
- Change restore file button to `Restoring...` when in loading state.

* Refactor:

- Rename `DiffOperation` to `FileOperation`
- Extract `isFileRemoved` and `isFileRenamed` to its own file
- Extract `Toolbar` components into small files

GitOrigin-RevId: 2e32ebd2165f73fc6533ff282a9c084162efd682
 2023-04-28 08:04:59 +00:00
Jessica Lawshe
0de648eecd Merge pull request #12774 from overleaf/ds-em-mongo-secondary-db-fix 
Bug fix - Mongo DB secondary preference

GitOrigin-RevId: d9adc0a7e1ee5085b34c5c1ddfdc715967607fc3
 2023-04-28 08:04:51 +00:00
Jessica Lawshe
afb810c2a1 Merge pull request #12772 from overleaf/td-history-infinite-scroll-fix 
Fix bug in infinite scrolling in history view

GitOrigin-RevId: ae71e96a17197451ae583e5614adbbd9dda93ee0
 2023-04-28 08:04:42 +00:00
Jessica Lawshe
8be17cdb37 Merge pull request #12819 from overleaf/jpa-institutions-lookup 
[web] migrate /institutions/ proxies to explicit V1 requests

GitOrigin-RevId: 535da280a6350dacbe2c957d2f2cedaeee02a48a
 2023-04-28 08:04:34 +00:00
Domagoj Kriskovic
3d5e8c9877 add 'Ace removal' notification (#12800) 
* add 'Ace removal' notification

* prettier

* add memo, window.clearTimeout

* remove warning for server pro

* added tracking events

* useCallback for onClick

* fix: event rename

GitOrigin-RevId: 70bce8b93bae233e7183a941abaf2ec7a70ddfb6
 2023-04-28 08:04:19 +00:00
Miguel Serrano
d2172e5179 [web] Issue Oauth2 access tokens (#12788) 
* [web] Issue Oauth2 access tokens

* [web] Add partial index for `oauthAccessTokens.user_id` for Personal Access Tokens

* [web] script to create personal access tokens

GitOrigin-RevId: 796e8d23a6799a87ac6096c686139c6290668b83
 2023-04-28 08:04:10 +00:00
Jakob Ackermann
77da9fd0cd Merge pull request #12824 from overleaf/jpa-clsi-pipe 
[clsi] rewrite UrlFetcher in async/await and fetch/pipeline

GitOrigin-RevId: a2a90fd886252f06c818f807e85e566f3fc1f841
 2023-04-28 08:04:01 +00:00
Jakob Ackermann
efa68fce61 Merge pull request #12731 from overleaf/jpa-clsi-log-err 
[clsi] log error when writing to log file fails

GitOrigin-RevId: 3f698fd0ecad26fe9782aae6ba9a49c03b8f9923
 2023-04-28 08:03:51 +00:00
Brian Gough
426128554d Merge pull request #12813 from overleaf/bg-add-inr-currency 
add Indian Rupee (INR) prices to plan and group settings

GitOrigin-RevId: 6c058ed034d1566cfda17e73a8ba23d8bd7b7ab0
 2023-04-27 08:07:45 +00:00
Miguel Serrano
fe1dad8c0b [web/scripts] Clean legacy history data (#12812) 
* [web/scripts] Clean legacy history data

GitOrigin-RevId: ce91ca69a9f4e8b340e659d0b468852abe01e6fd
 2023-04-27 08:07:07 +00:00
Jakob Ackermann
a437dcf537 Merge pull request #12823 from overleaf/jpa-clsi-download-tests 
[clsi] modernise tests for file downloads

GitOrigin-RevId: b33749b9100812de8ae2a26bd84e933f0282457b
 2023-04-27 08:06:54 +00:00
Jakob Ackermann
5380999459 Merge pull request #12815 from overleaf/jpa-pipe-tests 
[misc] tests: migrate to stream.pipeline or request({ body: stream })

GitOrigin-RevId: 5de077c9ba9c7951d6fec7b1d6da6fb694394610
 2023-04-27 08:06:20 +00:00
Brian Gough
80fdef796c Merge pull request #12817 from overleaf/bg-plan-scripts 
refactor plan-prices scripts and add new currency (INR)

GitOrigin-RevId: 12b515143e0426f19b2d224569bf9c5490b7d72a
 2023-04-27 08:06:06 +00:00
Brian Gough
c3ad6645fe Merge pull request #12816 from overleaf/bg-recurly-scripts-cleanup 
sort recurly script JSON outputs for consistency

GitOrigin-RevId: e5dc789fd834e9864912e3ef14ac3e6bf8eb7d99
 2023-04-27 08:05:52 +00:00
Jakob Ackermann
46fb6f7c83 Merge pull request #12814 from overleaf/jpa-modules-rs-init 
[web] initialize mongo replicaset for individual modules

GitOrigin-RevId: 9f8934ae58b21a99f466093617449f5e792d39cd
 2023-04-27 08:05:40 +00:00
Domagoj Kriskovic
cd689e4e1f [cm6] Show Regex errors in find & replace (#12720) 
* [cm6] Show Regex errors in find & replace

* cleanup, isInvalidRegExp function

* no state variable, less color var

* use @brand-dager

* using var(--ol-cm-search-form-focus-shadow)

* using state-danger-border

GitOrigin-RevId: 844c9dfee5a56d2a7494cd86c266acbe9eacd033
 2023-04-27 08:05:14 +00:00
Domagoj Kriskovic
e311a22686 Merge pull request #12765 from overleaf/dk-fix-create-folder-name 
fix: Clear new folder input after closing modal
GitOrigin-RevId: cde804212ef966f211804afc6bec1b207befeedc
 2023-04-27 08:05:00 +00:00
ilkin-overleaf
0895e33235 Merge pull request #12773 from overleaf/ii-history-react-changes-list-dropdown 
[web] Actions dropdown history migration

GitOrigin-RevId: 6b7055501c5eb1529b1794db92bb9f5f3faa6648
 2023-04-26 08:05:24 +00:00
CloudBuild
28f90c8a87 auto update translation 
GitOrigin-RevId: e0d9d3c22c4ce093c3ad7393ef2b91f9a3cada16
 2023-04-26 08:05:16 +00:00
June Kelly
724a8d6113 Merge pull request #12698 from overleaf/jk-full-stops 
[web] Add full-stops after 'Please use a different password'

GitOrigin-RevId: 9cac7c70358db11a74858252001a2dee211c0325
 2023-04-26 08:04:30 +00:00
June Kelly
f5740e6b17 Merge pull request #12593 from overleaf/jk-remove-plans-split-test 
[web] Remove 'plans-page-layout-v3' split test

GitOrigin-RevId: 91e0d3d8bc40632df630131b2e872fa824015da5
 2023-04-26 08:04:21 +00:00
Brian Gough
70072481f4 Merge pull request #12783 from overleaf/ae-dev-tools-localstorage 
[cm6] Use customLocalStorage in CM6 dev tools

GitOrigin-RevId: df4c40868b5a7b24b30483d55d1fbe75b5703776
 2023-04-26 08:04:12 +00:00
Davinder Singh
10f879eab8 Merge pull request #12365 from overleaf/ds-deleted-project-page 
Admin panel- Deleted project info page migration to react

GitOrigin-RevId: a964d80b3a2ef25340452fccdab6bdc51c01c59e
 2023-04-26 08:04:03 +00:00
Miguel Serrano
a8885b1720 OAuth server: generate GitHub-style tokens (#12617) 
* Add `base-x` and `crc-32` dependencies

* OAuth server: generate GitHub-style tokens

GitOrigin-RevId: c128742a37d53f1902ccfaf75fa1c5ca5adfdbf2
 2023-04-25 08:07:18 +00:00
Jimmy Domagala-Tang
45797f8bb6 Merge pull request #12764 from overleaf/jpa-remove-unused-http-proxy 
[web] remove unused http-proxy dependency

GitOrigin-RevId: bc1e30d1ce175e1f5c88614ab6f2fbbeb5d863a5
 2023-04-25 08:07:09 +00:00
Eric Mc Sween
c539e960e7 Merge pull request #12671 from overleaf/em-git-bridge-delete-project 
Add endpoint to delete project data in git bridge

GitOrigin-RevId: bdc9701284255166bf4a122dad5fd89ced0c0ca2
 2023-04-25 08:06:30 +00:00
Tim Down
afd1195902 Add infinite scrolling to history versions list (#12752) 
* Add infinite scrolling to change list, add spinner while doing initial updates load, refactor updates state

* Update type in tests

* Update types

* Using LoadingSpinner component

* Remove redundant imports

GitOrigin-RevId: 98c7eae8edbc4d10d7107d825045edfc4159494f
 2023-04-25 08:06:22 +00:00
Tim Down
bf076a8c97 Merge pull request #12721 from overleaf/td-history-improve-diff-highlight 
Add markers for addition and deletion on empty lines in history diff

GitOrigin-RevId: 62e329da8bc055ee922854b837fe9465d724402e
 2023-04-25 08:06:14 +00:00
Brian Gough
72abda9f29 Merge pull request #12757 from overleaf/bg-clean-up-recurly-prices-script 
clean up recurly prices script

GitOrigin-RevId: b9afa05a0931bb11fd9be2d9a92a6d4beaab2f7d
 2023-04-25 08:06:05 +00:00
Brian Gough
253f44894a Merge pull request #12748 from overleaf/bg-recurly-add-currency 
add script for generating recurly prices

GitOrigin-RevId: c7a624af35eba9882798fbaf750e4328604f47fa
 2023-04-25 08:05:57 +00:00
Mathias Jakobsen
17ca11fae0 [cm6] Add save command to emacs (recompiles doc) (#12742) 
GitOrigin-RevId: 10cda3f14411147d0d900f688d9b5017f49d2db2
 2023-04-25 08:05:35 +00:00
Alf Eaton
f409b96f00 Fix padding in emptyLineFiller and lineWrappingIndentation extensions (#12736) 
GitOrigin-RevId: 8b6a2ad0beb802d917f3e998c378792c6156836a
 2023-04-25 08:05:27 +00:00
Alf Eaton
8537a7a5d0 Handle mode: 'none' in keybindings (#12717) 
GitOrigin-RevId: 77d040352b1de2311f663a8b33bd0d20d79a30ae
 2023-04-25 08:05:18 +00:00
Alf Eaton
4bb582bdd8 [cm6] Improve Tab behaviour in read-only mode (#12715) 
* Improve Tab behaviour in read-only mode
* Remove Tab shortcuts from Markdown configuration

GitOrigin-RevId: 9eb804fcf820b37b371b1c351cfbdf7bff1ced89
 2023-04-25 08:05:10 +00:00
Alf Eaton
08ccdb79d3 [cm6] Improve alignment of review panel elements (#12710) 
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
 2023-04-25 08:05:02 +00:00
Alf Eaton
acf6abb0fb [cm6] Use a block widget for padding at the top of the editor (#12705) 
GitOrigin-RevId: 000ce9c90ea6b2ca72ab969704354a19fcea7a87
 2023-04-25 08:04:53 +00:00
Rebeka
b063495200 fix: fit text inside the circle shape 
GitOrigin-RevId: 81167ee6ebc281a7a403ff2fdc3b19f4cc91d6be
 2023-04-24 08:02:42 +00:00
M Fahru
4dec157e08 Implement history react toolbar UI (#12530) 
There are two different UI in this PR: `comparing` and `viewing` mode.

- For `comparing`, the user would be shown two separate date. It uses the `UpdateRange` object and this PR adds a timestamp to both `fromV` and `toV` of the object type.
- For `viewing`, the user would only be shown one date since `viewing` mode means viewing a specific update version.

Some other notable changes:

- Move `diff` state to `diff-view.tsx`, which contains `main.tsx` (main editor history view) and `toolbar.tsx` as its children
- refactor `autoSelectFile` by passing `updateRange.toV` directly
- refactor `updateIsSelected` by passing an object that contains `fromV` and `toV` instead of passing `update

There's also a cypress test for both the `viewing` mode and `comparing` mode in this PR.

GitOrigin-RevId: ba54f073f3479c55a39eb6b2932ea7faff78dddc
 2023-04-21 08:03:39 +00:00
M Fahru
08d2eea47a Decouple history-file-tree styling out of editor file tree: 
- Extract/duplicate the style from editor file tree (only extract styling that's being used in history file tree)
- Change some of the class name to avoid duplicated class name from the editor file tree
- Revert change to editor file tree since it has been moved to history file tree

GitOrigin-RevId: 6c3b20080c9b428363024db622f60e3540d919e6
 2023-04-21 08:03:36 +00:00
Ilkin Ismailov
dd5509b16f add sm size to badge 
GitOrigin-RevId: 4e69d582ce770abcff10f3a6b34662f4873fc224
 2023-04-21 08:03:33 +00:00
M Fahru
8212b686c6 Implement new style for history file tree badge 
GitOrigin-RevId: 6221bc00e5aecf49fd3f2657128d1e9a2d4e648b
 2023-04-21 08:03:30 +00:00
Jakob Ackermann
0b985c7a0b Merge pull request #12723 from overleaf/jpa-revert-node-18-upgrade 
[misc] revert node 18 upgrade

GitOrigin-RevId: 752d45b015e2e8802b875b5de8ee044ba1170345
 2023-04-21 08:03:22 +00:00
Alf Eaton
98961d9465 Merge pull request #12719 from overleaf/ae-navbar 
Restore z-index of .navbar-main

GitOrigin-RevId: f25b462227beaee483199043a97206ccdedfe1c0
 2023-04-21 08:03:19 +00:00
Mathias Jakobsen
81a8fa2ce3 Merge pull request #12672 from overleaf/ae-emacs-compile-keydown 
[cm6] Stop propagation of Ctrl-s when Emacs keybindings are enabled

GitOrigin-RevId: 32bebefb583ad813931af221cce7498d40fdbaf1
 2023-04-21 08:03:11 +00:00
Mathias Jakobsen
462837b44d Merge pull request #12701 from overleaf/dk-cm6-autocomplete-item-space 
[cm6] Add space after item autocomplete

GitOrigin-RevId: 6fff77c0c0563530af981bbac73b1d88e02bb759
 2023-04-21 08:03:08 +00:00
Mathias Jakobsen
4341abcf64 Merge pull request #12678 from overleaf/mj-cm6-vim-upgrade 
[cm6] Upgrade codemirror-vim

GitOrigin-RevId: 2f57c338a69c19bf6bd6525debd10e5e6eb1269f
 2023-04-21 08:03:05 +00:00
Mathias Jakobsen
29b056d5a3 Merge pull request #12682 from overleaf/mj-def-whitespace 
[lezer] Allow whitespace before macro parameter

GitOrigin-RevId: 14bd8428f0a78fb71184bf300dac0b2b1e3abd3c
 2023-04-21 08:03:02 +00:00
Mathias Jakobsen
3bd174631a Merge pull request #12696 from overleaf/mj-rt-skip-more-preamble 
[cm6+rt] Update skip-preamble-cursor to skip \maketitle and abstract

GitOrigin-RevId: 3c54d8159bfdb431763872790a2b82ac4cffc09f
 2023-04-21 08:02:59 +00:00
Mathias Jakobsen
59b3b9b933 Merge pull request #12631 from overleaf/ae-readonly-focus 
[cm6] Prevent the editor being focused when read-only

GitOrigin-RevId: 7de9f2df2421b57b3315d59d640f7c8b46caf178
 2023-04-21 08:02:56 +00:00
Mathias Jakobsen
c2292a8567 Merge pull request #12677 from overleaf/ae-codemirror-view-upgrade 
[cm6] Upgrade CodeMirror dependencies

GitOrigin-RevId: cc973b1c5b23eca0fc93a9b3a970c832212e47af
 2023-04-21 08:02:53 +00:00
Rebeka
5ff575e3e5 fix: when collapsing the navbar, do not overlap it with other elements, for example with the tooltip 
GitOrigin-RevId: 2db133ce8399c46b620a3a594fc415244c7d9788
 2023-04-21 08:02:49 +00:00
Rebeka
4adf965180 fix: make the navbar dropdown list to take the full viewport 
GitOrigin-RevId: c6c6c447c14fa25ad27d73cf3c39d6650fa5e744
 2023-04-21 08:02:46 +00:00
Brian Gough
cb8992e912 Merge pull request #12709 from overleaf/bg-rollback-additional-services 
rollback additional services from node 18 to 16

GitOrigin-RevId: 60428768eb4c895b89e9a5dace429ea70af3b9bf
 2023-04-20 08:04:02 +00:00
Brian Gough
8d55ebc662 Merge pull request #12706 from overleaf/bg-rollback-broken-node-18-services 
rollback broken node 18 services

GitOrigin-RevId: 7aa84d0cc864474d00fe881db100a4c6ec7d798c
 2023-04-20 08:03:54 +00:00
Brian Gough
ed0acd8e58 Merge pull request #12658 from overleaf/bg-node-18-upgrade 
Upgrade to node 18

GitOrigin-RevId: 1b25d20a8987950a72a7bf966a825794de4ad960
 2023-04-20 08:03:37 +00:00
Rebeka Dekany
df300b5f24 Fix: Chat messages deduplication (#12667) 
* Prevent the duplicated message IDs by filtering them out

* fix: Prevent the duplicated message IDs by filtering them out

GitOrigin-RevId: 6d6c2821e6e29c9949fd323fa3a507016b51aff4
 2023-04-19 08:03:31 +00:00
Tim Down
5f5e07a334 Merge pull request #12668 from overleaf/td-history-scroll-to-first-change 
Scroll to first change in history document diff viewer

GitOrigin-RevId: e135877ca440c5eb2732890e8723d9098444727f
 2023-04-19 08:03:28 +00:00
Tim Down
99e1ff0804 Merge pull request #12644 from overleaf/td-history-compare 
Initial implementation of comparing history versions

GitOrigin-RevId: 890e270d6e41856a79689ab41ccfbde25c4703ba
 2023-04-19 08:03:25 +00:00
Jessica Lawshe
df58f6720e Merge pull request #12609 from overleaf/jel-request-for-service-pdf 
[web] Update Request for Service PDF

GitOrigin-RevId: 0a0598ba3549148a0314b65248f00d167ac62d0c
 2023-04-19 08:03:22 +00:00
Jessica Lawshe
6fc5385ca6 Merge pull request #12249 from overleaf/tm-gallery-top-picks 
Implement top picks in template gallery for CVs

GitOrigin-RevId: 22f720582e27fac2b9e454ce4e28bd124de094b7
 2023-04-19 08:03:19 +00:00
Eric Mc Sween
5b804ceefd Merge pull request #12654 from overleaf/em-td-upload-filename-encoding 
Fix filename encoding of project and file uploads

GitOrigin-RevId: e718c8f8f376772ee13c50c82d26848977e16eef
 2023-04-19 08:03:13 +00:00
Eric Mc Sween
cff54eae78 Merge pull request #12575 from overleaf/em-fix-chunk-replace-transaction 
Fix history chunk replacement transaction

GitOrigin-RevId: fc0fa8f4a55ae5f402ba87db5e4ac2856fe6627b
 2023-04-19 08:03:10 +00:00
Alf Eaton
924012e21f [cm6] Avoid overwriting themed syntax highlighting colours when editing Markdown (#12648) 
GitOrigin-RevId: ed5d558544839978862004a8b7feb80806a2100d
 2023-04-19 08:03:04 +00:00
Alf Eaton
5717f51042 Merge pull request #12643 from overleaf/ae-initial-active-line-highlight 
[cm6] Fix initial active line highlight

GitOrigin-RevId: 54de6a176e826ed7d7f1016ba6cee7a8803f0be4
 2023-04-19 08:02:53 +00:00
Alf Eaton
f205d1f31d Merge pull request #12621 from overleaf/ii-history-react-delete-labels 
[web] Delete history tags

GitOrigin-RevId: 0a2846bbb3e99ef632b9192a9f8c04f702645506
 2023-04-19 08:02:47 +00:00
Jimmy Domagala-Tang
fd61e9b2b5 Merge pull request #12554 from overleaf/jdt-dev-google-sso-env-variable 
local env variable for google sso contains trailing slash

GitOrigin-RevId: 3840cd794cda4870a10755a1d272221b314a6586
 2023-04-18 08:05:23 +00:00
Jakob Ackermann
66d91dfd61 Merge pull request #12632 from overleaf/jdt-jpa-sso-notification-logging 
[web] fallback to providerName when displaying SSO-linked notification

GitOrigin-RevId: 0da4a570f8a704cdbd47b5905a21273c6ab85d6d
 2023-04-18 08:05:07 +00:00
Mathias Jakobsen
c8f7bc54bc [web] Add split test for testing editor switch naming (#12596) 
Co-authored-by: Ieva Vaiginyte <95856891+ievaoverleaf@users.noreply.github.com>
GitOrigin-RevId: dafe07bda841dad962ebf2894718750fafe86373
 2023-04-18 08:04:59 +00:00
Jimmy Domagala-Tang
77c2db38fc Merge pull request #12566 from overleaf/jdt-ghost-danger-buttons 
feat: adding danger ghost buttons
GitOrigin-RevId: 2ee6ea1c395ba4a73fbe09b36acde3145c590a6b
 2023-04-18 08:04:51 +00:00
Tim Down
b07535f15b Merge pull request #12641 from overleaf/td-source-editor-import-fix 
Fix for incorrect import

GitOrigin-RevId: 5814fbf888446f7cbc9464565ab13f3b1db8b54f
 2023-04-17 08:05:57 +00:00
Tim Down
23b9c078b8 Merge pull request #12636 from overleaf/td-history-autoselect-file 
Simplify file autoselect in React history view

GitOrigin-RevId: 43f070b26ab0a75af13063712b5cf05778da4064
 2023-04-17 08:05:49 +00:00
Tim Down
38998afa8e Implement history diff viewer buttons (#12439) 
GitOrigin-RevId: 0ed8eb8568783b4938188a86c4ee75c767e6d713
 2023-04-17 08:05:41 +00:00
Alf Eaton
63b2064420 [cm6] Add scrollIntoView when commands are dispatched (#11678) 
GitOrigin-RevId: be005885330b9b29c7ddbfeacaec0a41d96e5e25
 2023-04-17 08:05:33 +00:00
Mathias Jakobsen
7d237d0103 [cm6] Only swallow text in autocomplete insertion if node is well-formed (#12562) 
* [cm6] Only swallow text in autocomplete insertion if node is well-formed

* [cm6] Use longest common prefix heuristic for autocompletion in ill-formed nodes

GitOrigin-RevId: 5adf3dc0314d86b267e2142a1250dece3ab29ef8
 2023-04-17 08:05:24 +00:00
Mathias Jakobsen
73191f56e1 [cm6+rt] Make formatting commands work after UnknownCommands without arguments (#12625) 
GitOrigin-RevId: 0eb59e6580d6f217c46424ede0fa6f79c8786940
 2023-04-17 08:05:16 +00:00
Mathias Jakobsen
4b2cc907e2 [cm6] Change Emacs commands to visual-line-mode (#12523) 
* [cm6] Change Emacs commands to visual-line-mode
* [cm6] Change line deletion commands to visual line mode

GitOrigin-RevId: 7a4f3d66bec611de410b6c1fbafbfe33b974e37b
 2023-04-17 08:05:08 +00:00
Alf Eaton
e09a5f3adf Assert that the Rich Text document is ready before continuing with Cypress tests (#12612) 
GitOrigin-RevId: fb0755200366e1129ee86ba9a439210ffe64e205
 2023-04-17 08:04:59 +00:00
Alf Eaton
6ca565fa90 Fix autocomplete hotkeys description (#12607) 
GitOrigin-RevId: f7f80fdf56f97ee70accec0162e6b395cfd16584
 2023-04-17 08:04:51 +00:00
Alf Eaton
359255b820 [cm6] Use a modified fork of the closeBrackets extension (#12573) 
GitOrigin-RevId: a24020ed216cb10defff989f5876666c29889de2
 2023-04-17 08:04:43 +00:00
Alf Eaton
dda9230c6c [rich text] Add "Insert Citation" and "Insert Cross-reference" buttons (#12529) 
GitOrigin-RevId: fde2f1a281318afede138ccae12f73ade3fa9f65
 2023-04-17 08:04:34 +00:00
Alf Eaton
39df55787c Improve handling of doc:saved events (#12522) 
GitOrigin-RevId: 0ebf198548f6aeecb356405b0c582d3fd64db391
 2023-04-17 08:04:26 +00:00
Alf Eaton
a8ed6b65e1 [cm6] Improve "vertical overflow" handling (#12405) 
* Avoid setting style on the editor view whenever overflowPaddingState changes
* Round values in recalculateScreenPositions
* Refactor ignoreGeometryChangesUntil slightly
* Restore the original value

GitOrigin-RevId: 75c57be21dd16a748c0d9b14058386849a80b831
 2023-04-17 08:04:18 +00:00
Alf Eaton
ab10fd99f5 Add CodeMirror dev tools extension (#12142) 
GitOrigin-RevId: 148a0fba5faf6dc8f638fcb4666e2fda6c5c6c40
 2023-04-17 08:04:09 +00:00
Alf Eaton
161decd67d Upgrade @codemirror/view (#12574) 
* Upgrade @codemirror/view
* Disable emptyLineFiller extension

GitOrigin-RevId: 57ce4194ece0ea448e24184f0b3a3e13352cb014
 2023-04-17 08:04:00 +00:00
Jakob Ackermann
01f4df08ee Merge pull request #12620 from overleaf/jpa-align-compile-size-limit 
[web] align size limit for editable content between SAAS and Server Pro

GitOrigin-RevId: 84da372ac5e3716f7987cc2d195834a5180d2978
 2023-04-14 08:03:33 +00:00
Jakob Ackermann
3841177931 Merge pull request #12504 from overleaf/jel-cms-card-padding 
[web] Option to set padding on CMS rows

GitOrigin-RevId: 297344c9bf6c04eae630f1ddbed59f9519d4e4c7
 2023-04-14 08:03:19 +00:00
Jakob Ackermann
bc91aebf1c Merge pull request #12410 from overleaf/bg-fix-restore-deleted-docs-script 
fix async call usage of restoreDeletedDoc

GitOrigin-RevId: 693c3d1e2e1d7757815d310eacd148a107b44395
 2023-04-14 08:03:15 +00:00
Jakob Ackermann
1096c81f4a Merge pull request #12528 from overleaf/jpa-switch-dashboard-events-to-bq 
[web] switch events on project dashboard to BQ

GitOrigin-RevId: 9326c19cc5663c4dc2919877eb8df91e312bb902
 2023-04-14 08:03:12 +00:00
Jakob Ackermann
c35da85ad8 Merge pull request #12526 from overleaf/jpa-delete-redundant-assignment 
[web] delete redundant variable assignment in tests

GitOrigin-RevId: 2876e217eb21a886dc2c8b251b7208de1b5ea349
 2023-04-14 08:03:09 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457) 
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
 2023-04-13 08:40:56 +00:00
M Fahru
3f992f9453 Ensure new data are fetched properly whenever history is opened (#12577) 
GitOrigin-RevId: e0ae14cdc90c95dbd44b12bd8332bc982ea34a10
 2023-04-13 08:04:45 +00:00
Alexandre Bourdin
f03b75e55f [web] Tags/color picker tweaks (#12595) 
* Change wording of tags header and hide uncategorized when tags list is empty

* Add a tooltip on the colour picker more button

* Fix linting

GitOrigin-RevId: 07e1c411c2c9f6f66e0a00c1610af662b829c4e4
 2023-04-13 08:04:37 +00:00
Jakob Ackermann
08673c9c1c Merge pull request #12594 from overleaf/jpa-fix-cleanup-unused 
[web] scripts/translations: fix searching for unused translations

GitOrigin-RevId: 2cfefc6ffde7aaab0ef2d00888059ddafda3bb1d
 2023-04-13 08:04:29 +00:00
Alexandre Bourdin
376d9c43a3 Merge pull request #12374 from overleaf/ab-rename-folders-tags 
[web] Rename folders to tags

GitOrigin-RevId: 05c34c515aeeb9230ed512c267f97bcb679767a8
 2023-04-13 08:04:20 +00:00
Alexandre Bourdin
481cd14cb1 Merge pull request #12557 from overleaf/ii-history-react-labels-only 
[web] History labels only list

GitOrigin-RevId: 58b8e5a5af0754e32841223f9c478c25900df526
 2023-04-13 08:04:12 +00:00
Alexandre Bourdin
04c204f989 [web] Colour picker for tags (#12255) 
* Base for color picker

* React color picker and updated modals

* Add tag color picker to mobile dashboard

* Update existing tests and fix disable save button condition

* CSS adaptations for desktop modal streched into mobile display

* Update TagsController tests

* Add aria-hidden label on color pickers

* Fix linting

* Fix project list test

* Select random color when creating tag

* Cleanup leftovers in project list context

* Test cleanup

* Pre-select custom color and store local color while picking

* Add type to preset colors

* Add css fix to override disabled button opacity

* Skip redundant check

* Fix linting

* Add back btn-secondary on manage tag modal after rebase

GitOrigin-RevId: a4cf24e85cc0ca01466f4bf9c77482be8360e68e
 2023-04-13 08:04:03 +00:00
M Fahru
fb6746a887 Add default pathname logic on history react file tree (#12505) 
On history react, when the initial screen has been loaded, no default pathname is selected. This PR adds logic for selecting default pathname and getting the diff for that pathname.

Also, add some other small changes, the notable ones are:

- Refactor some type naming and file structure related to the history file tree
- Refactor file tree selectable hooks (merge selectable context provider into the main provider)
- prevent clicking on the same file tree item by checking the current pathname before invoking the handler function

GitOrigin-RevId: 73c36e9ed918ae3d92dd47108fbe8542a7571bdd
 2023-04-12 08:04:58 +00:00
June Kelly
e780a09a15 Merge pull request #12473 from overleaf/ab-server-pro-split-test-overrides 
[web] Add split test overrides through settings for non-SaaS env

GitOrigin-RevId: 82cb6a573a992e730107f6287e7804cfe0f04aa5
 2023-04-12 08:04:37 +00:00
June Kelly
17109393c5 Merge pull request #12387 from overleaf/jk-split-button-tweaks 
[web] Split-menu style tweaks

GitOrigin-RevId: a04121981c4fe240c247cf03da5be7052c26f541
 2023-04-12 08:04:28 +00:00
June Kelly
841df71a1d Merge pull request #12342 from overleaf/jk-password-ux-please-use-another-password 
[web] Password UX: 'Please use another password'

GitOrigin-RevId: ca9b26cbcf2dabb27c716da314764ee40ffc83dd
 2023-04-12 08:04:13 +00:00
Jakob Ackermann
9362d286b7 Merge pull request #12560 from overleaf/jpa-faster-migration 
[web] migrations: cut delay in auditLog migration from 10s to 10ms

GitOrigin-RevId: 2a6525212149c5e0f1ebfec4023f4e0fe91ecc5f
 2023-04-12 08:04:05 +00:00
Miguel Serrano
7aa68ebcec Merge pull request #12551 from overleaf/msm-git-bridge-vulnerabilites 
[git-bridge] Update `httpclient` and `commons-compress`

GitOrigin-RevId: cb4f6cca09d991114bd784af6d2a79d887de256d
 2023-04-12 08:03:57 +00:00
ilkin-overleaf
8e0aa685ce Merge pull request #12549 from overleaf/ii-history-react-list-of-all-versions 
[web] All versions of history entries

GitOrigin-RevId: 7365ac4913c115b3b2872a3713d893463719c15e
 2023-04-12 08:03:47 +00:00
Eric Mc Sween
fb1f61434a Merge pull request #12545 from overleaf/em-oauth-tokens-ttl 
Delete expired OAuth tokens and authorization codes

GitOrigin-RevId: 2743ed12a11101a383c46de93deabc5cdeeddc5b
 2023-04-11 08:04:23 +00:00
Eric Mc Sween
1f9cfd877a Merge pull request #12536 from overleaf/em-oauth-refresh-tokens-index 
Allow OAuth access tokens without refresh tokens

GitOrigin-RevId: 5f95985b3a2e9b1c9a391b73476ce6b55875af87
 2023-04-11 08:04:06 +00:00