Commit graph

139 commits

Author SHA1 Message Date
Tim Down
de7eb43f51 Merge pull request #9792 from overleaf/ds-jpa-remove-stoponfirsterror-split-test
Split Test removal - removed stop-on-first-error split test code

GitOrigin-RevId: 4a5663397d0a967e0fa957453b36d466aa530630
2022-10-04 08:03:24 +00:00
Alf Eaton
c6f198b3a2 Merge pull request #9605 from overleaf/ae-9585-remove-rich-text-survey
Remove Rich Text survey

GitOrigin-RevId: 97003dfb70b8f9cc9118be3f291c7d56d2508f63
2022-09-15 08:04:10 +00:00
Alf Eaton
25725bd79f Add Rich Text survey message in PDF preview pane (#9423)
GitOrigin-RevId: e190ae569d5e2390e8bcf52672757cc7f269ea56
2022-09-02 08:04:41 +00:00
Alf Eaton
c2b4a2d3ea Merge pull request #9375 from overleaf/mj-timeout-link
[web] Add missing link to compile timeout message

GitOrigin-RevId: 46af17a4fe0620ccf6dc29a27edfbf3ac79e856d
2022-08-25 08:03:40 +00:00
Alf Eaton
4843288b50 Merge pull request #9312 from overleaf/ds-remove-keyShortCut
Remove keyShortCut from compile function options

GitOrigin-RevId: 31b13be5fd6742419d4147b89ef281b1b30227fb
2022-08-22 08:03:49 +00:00
Alf Eaton
d905863002 Merge pull request #8747 from overleaf/ae-error-boundary-fallback
Create a generic ErrorBoundaryFallback component

GitOrigin-RevId: 0c9200ddef2be3b90030a32eb8c36a59047cf2b4
2022-08-10 08:03:51 +00:00
ilkin-overleaf
73f2811a7b Merge pull request #9095 from overleaf/ii-pdf-set-zoom-fix
[web] Pdf zoom throws an error

GitOrigin-RevId: bcb3cde05ca9c65c1cca554b26ea9c7d0fe8d995
2022-08-05 08:04:02 +00:00
ilkin-overleaf
bec4827c3f Merge pull request #9085 from overleaf/ii-pdf-click-position-fix
[web] PDF preview click position error fix

GitOrigin-RevId: f2ac73f2a4050b707402c373193ae7a0ecd8ac53
2022-08-05 08:03:49 +00:00
Jakob Ackermann
f1487714b4 Merge pull request #9058 from overleaf/jpa-error-handling-2nd-page
[web] improve error handling for pdf-caching

GitOrigin-RevId: ddd65f2813fb08eb4493967071ee62d9742930cc
2022-08-02 08:04:07 +00:00
Jakob Ackermann
315414de1b Merge pull request #9011 from overleaf/jpa-better-render-error-message
[web] provide helpful error message when pdf rendering fails

GitOrigin-RevId: abbe6f362fa362fadee197527463ee675760e581
2022-07-29 08:04:48 +00:00
Alexandre Bourdin
4f340b0ed7 Merge pull request #8894 from overleaf/ab-cleanup-start-free-trial-button
[web] Cleanup StartFreeTrialButton component

GitOrigin-RevId: 67538882ff5a3389d2134ec6e4833431aa43f8e6
2022-07-26 08:04:21 +00:00
Timothée Alby
7b8d277437 Merge pull request #8898 from overleaf/ta-change-redundant-controls
Change Redundant Layout Controls

GitOrigin-RevId: b50d71b1f75d202334442b3f6cb5037ed0d8a411
2022-07-21 08:04:25 +00:00
Jakob Ackermann
0409676c41 Merge pull request #8911 from overleaf/jpa-pdf-detach-pdf-caching-metrics
[web] fix forwarding of pdf caching metrics in pdf-detach mode

GitOrigin-RevId: c4a65190102ca4abfb7970186bc5ee785bff14c6
2022-07-21 08:03:03 +00:00
Jakob Ackermann
985ad8ff5b Merge pull request #8879 from overleaf/jpa-fix-pdf-detach-delivery-latency
[web] collect fetch and render latency in the scope of the viewer

GitOrigin-RevId: 3bf6c5ffc01df705605c873a130f0a645fdc66c4
2022-07-19 08:03:34 +00:00
Jakob Ackermann
3c8a9d9863 Merge pull request #8853 from overleaf/jpa-no-pdf-download-in-editor-only-mode
[web] do not download the pdf in editor only view mode

GitOrigin-RevId: 4d8936964540c0820f72abb8c858e86e2e7196e2
2022-07-19 08:03:28 +00:00
Alexandre Bourdin
a62fb305c9 Merge pull request #8851 from overleaf/ab-fix-compile-time-warning-redisplay
Fix the compile time warning being displayed again after dismiss

GitOrigin-RevId: 4b3d80cfa7664e13154418aa510cb9265e282525
2022-07-14 08:04:52 +00:00
Alexandre Bourdin
6a6b6a0c88 Merge pull request #8846 from overleaf/ab-compile-time-tracking
[web] Add event and time since display segmentation for compile time warning

GitOrigin-RevId: 5a1ca75231e4ffd7a0812674b8600b62c4cddf11
2022-07-14 08:04:25 +00:00
Alexandre Bourdin
d501bc4820 [web] Compile time warning split test (#8813)
* Implement compile time warning split test

* Add i18n for compile time warning

* Memoize CompileTimeWarning component

* Reuse startFreeTrial() function from account-upgrade

* Improve usage of react bootstrap native properties

* Cleanup compile-time-warning

* Move all logic into CompileTimeWarning component

* Only show compile time warning to project owners

* Handle compile time warning in detached mode and while switching layout

GitOrigin-RevId: 4fc40acfc113f91c81a6744c14c0f8b3ef766e39
2022-07-14 08:03:50 +00:00
Jakob Ackermann
db83832485 Merge pull request #8774 from overleaf/jpa-fix-pdf-metrics
[web] fix collection of pdf.js timing metrics

GitOrigin-RevId: ee4cd29cc737a740e367e8be1a00e688aa684462
2022-07-11 08:03:50 +00:00
Timothée Alby
c92278a8e5 Merge pull request #8609 from overleaf/ta-preview-error-message-copy
Update Preview Errors Copy

GitOrigin-RevId: 0e7f7a4237a80c3fa2efc8ae87fc2011f4bc879d
2022-07-07 08:03:48 +00:00
Jakob Ackermann
64184a7f56 Merge pull request #8730 from overleaf/jpa-refactor-pdf-caching
[web] refactor pdf caching

GitOrigin-RevId: af6b871fad652f757d8c465085b33a79b955cd6b
2022-07-07 08:03:28 +00:00
Eric Mc Sween
7837af0afd Merge pull request #8511 from overleaf/em-stop-on-first-error-info-badge
Replace stop-on-first-error beta badge with info badge

GitOrigin-RevId: d0f8d1c6e960646bd257aeaf5efc21b23615242b
2022-06-22 08:05:27 +00:00
Jakob Ackermann
bfad0841a4 Merge pull request #8483 from overleaf/jpa-faster-compiles-feedback-ui
[web] faster compiles feedback UI

GitOrigin-RevId: 9feea47503aa6bddf51adb73b8c9fbef394fda14
2022-06-22 08:05:14 +00:00
Eric Mc Sween
aa60c0846d Merge pull request #8405 from overleaf/em-halt-on-error-beta-survey
Stop on first error beta badges

GitOrigin-RevId: 1f5609518a81d12eb81fd4d1ca51ef432e039548
2022-06-15 08:05:30 +00:00
Eric Mc Sween
a2532ef968 Merge pull request #8354 from overleaf/em-halt-on-error-animation
Animation when setting "Stop on first error"

GitOrigin-RevId: 9639e2c815d1eaf57f3392131f9a484a6a1a0a9e
2022-06-14 08:02:32 +00:00
Eric Mc Sween
3d0f464637 Merge pull request #8361 from overleaf/em-halt-on-error-events
Analytics events for "Stop on first error"

GitOrigin-RevId: cbdb054cdf031f0364390c36cc1c1865169f2cd4
2022-06-14 08:02:30 +00:00
Eric Mc Sween
e365a6cbaf Merge pull request #8346 from overleaf/em-halt-on-error-logs-2
Stop on first error: logs pane prompts

GitOrigin-RevId: a246a7e5d302ad3104e15f7fd78344992b4e011b
2022-06-10 08:03:55 +00:00
Timothée Alby
ae207f7559 Merge pull request #8326 from overleaf/ta-pdf-detach-redundant-controls
Bring Back Redundant Layout Controls

GitOrigin-RevId: a725e8742ab41612b285bcab23054ba9da15b60f
2022-06-09 08:02:34 +00:00
Eric Mc Sween
cb657d1f1c Merge pull request #8297 from overleaf/em-halt-on-error-logs
Stop on first error info box in logs pane

GitOrigin-RevId: cf11f65d582d98bea93c6506393940d9a6144c0d
2022-06-08 08:03:12 +00:00
Eric Mc Sween
2ab5189771 Merge pull request #8237 from overleaf/em-halt-on-error
Stop on first error dropdown UI

GitOrigin-RevId: 5191a37f6c227ff5a91c10ce965832e1702c3931
2022-06-03 08:03:39 +00:00
Thomas
d9753dcb22 Merge pull request #8246 from overleaf/tm-remove-logs-pane-info-notice
Remove PdfLogsPaneInfoNotice

GitOrigin-RevId: 0b4e611c081fe5fed8842c2967b47fc6f6556264
2022-06-02 08:02:47 +00:00
Timothée Alby
af5543f119 Merge pull request #8224 from overleaf/ta-pdf-detach-wait-i18n
PDF Detach: Wait for i18n

GitOrigin-RevId: d1774c917ba903eab9980c90dc8b1e41eaf5e935
2022-06-01 08:03:59 +00:00
Timothée Alby
32741c07e0 Merge pull request #8218 from overleaf/ta-pdf-detach-safari-warnings
PDF Detach Safari Warning

GitOrigin-RevId: e6f8942d8c8c141d887c44921a09716c4e4c85ae
2022-05-31 08:04:36 +00:00
Alf Eaton
9253dac12f Merge pull request #8010 from overleaf/ta-synctex-unmount
Unmount Default Synctex Controls in Detacher Mode

GitOrigin-RevId: bc754fb172aba7430003f7a61eddb4450b175025
2022-05-24 08:04:11 +00:00
Alf Eaton
1770cdc8fc Handle pdf.js loading errors (#7824)
GitOrigin-RevId: a4893dd66ceb9e9f8266cf720ab2b3507bf6aef1
2022-05-24 08:04:05 +00:00
ilkin-overleaf
1e22d17520 Merge pull request #8066 from overleaf/ii-refactor-tooltip-usage-fix-2
Fix expand button tooltip text

GitOrigin-RevId: db19ce6c21bf1a83f38a60014bd0aa92e220ce40
2022-05-23 08:04:13 +00:00
Alf Eaton
bce320f4bc Merge pull request #8037 from overleaf/ii-refactor-tooltip-usage-fix
Place the download PDF tooltip to the bottom

GitOrigin-RevId: e2171c4417de66f2143be66dc76ca7c450c43234
2022-05-20 08:04:20 +00:00
Timothée Alby
5731463d32 Merge pull request #7956 from overleaf/ii-refactor-toolitp-usage
Tooltip usage refactoring

GitOrigin-RevId: f4b2d4d57722172141a081dd60e4394ff7fff332
2022-05-19 08:04:07 +00:00
Alf Eaton
e14363246d Handle compile shortcuts in all layouts (#7969)
GitOrigin-RevId: cbfb24a7328d499ca96caa8683b8e4b1e6858372
2022-05-19 08:03:14 +00:00
Alf Eaton
37218bce59 Attach PDF highlights to the viewer element (#7728)
GitOrigin-RevId: 918dfd8c43dfea4e64fbb5a1437ea8532cbac7ec
2022-04-28 08:03:35 +00:00
Alf Eaton
ff44afb74c Only show compile shortcut when editor is visible (#7773)
GitOrigin-RevId: 0b6d25d7012e82a676e3a782730fb6ca481cd1e8
2022-04-28 08:03:19 +00:00
Timothée Alby
a110c4d7bd Merge pull request #7323 from overleaf/ta-synctex-disable-multi-one-way
Don't Disable Synctex PDF-to-Code Button

GitOrigin-RevId: 90328e0fea8cb5358217ce866839f5e1a4a73b94
2022-04-13 08:03:36 +00:00
Alf Eaton
aca889a3e0 Sync cursor position to PDF when double-clicking on a heading in the file outline (#7314)
GitOrigin-RevId: ef98f5d20e99bfc03c91cbf4027d277e738ab176
2022-04-11 08:03:14 +00:00
June Kelly
dc6f480843 Merge pull request #7275 from overleaf/ds-shared-loading-spinner-2
Changed LoadingSpinner default delay

GitOrigin-RevId: 2bf499585e3394e5c6b8ed9583add7ef6f678fc1
2022-04-07 09:56:57 +00:00
Timothée Alby
3c01402bbd Merge pull request #7034 from overleaf/ta-pdf-detach-full
PDF Detach v2

GitOrigin-RevId: 3deb76474185f9176cde23ab32ef51b90df6e8e9
2022-04-05 12:19:23 +00:00
Alf Eaton
935dc9be7c Remove unused code and translation keys (#7140)
GitOrigin-RevId: 15ce5d22a40ebe56cae76c78703c1547f2ab0552
2022-03-28 08:04:07 +00:00
Timothée Alby
ac3eb878d6 Merge pull request #7172 from overleaf/ta-pdf-viewer-backdrop-hide
Fix Logo Backdrop in PDF Viewer

GitOrigin-RevId: ae9eb98dc8a51a882354b6ddea095df2bed51346
2022-03-24 09:03:44 +00:00
ilkin-overleaf
57e60c05ca Merge pull request #7066 from overleaf/ta-synctex-disable-multi
Disable Synctex Controls for Docs and Multiselections

GitOrigin-RevId: 9f14e68228f9aa13a4188918930fc8cdb5eefabf
2022-03-22 09:03:21 +00:00
Alf Eaton
65e71714b8 Upgrade pdf.js via split test framework (#7053)
GitOrigin-RevId: dffe1f5bec07cba0914e3bd18ff5332dfe204f33
2022-03-21 09:03:16 +00:00
June Kelly
1fc13e6549 Merge pull request #7036 from overleaf/ta-go-to-pdf-hide-logs
Hide Logs When Highlighting PDF Location

GitOrigin-RevId: cdf22393b1dde5eb842cf0f8b2d7d8c408bc8eca
2022-03-16 09:03:11 +00:00
Timothée Alby
9ba3f04491 Merge pull request #7002 from overleaf/ta-compile-dropdown-button-not-disabled
Don't Disable Dropdown Button When Compiling

GitOrigin-RevId: 099ddae07c7601016103514168eef80712ccc57f
2022-03-07 09:03:01 +00:00
Timothée Alby
5ba970b81e Merge pull request #6986 from overleaf/ta-compile-button-disabled
Disable Compile Button when Compiling

GitOrigin-RevId: c25cbaab3547695919ba62385cffef2a44665fec
2022-03-04 09:03:37 +00:00
Miguel Serrano
a3b01659a4 Fix isRequired error in GoToCodeButton.propTypes (#6646)
Skip `PdfSynctexControls` rendering until `position` is set

GitOrigin-RevId: ea40c7f98ea3bbdf3d8689175658d2c014b68436
2022-02-16 11:38:02 +00:00
Alf Eaton
f065a7a909 Improve the Icon component (#6245)
GitOrigin-RevId: fbb23b32c47edbe5a22badc627318accbd09e82a
2022-01-20 09:03:58 +00:00
Jakob Ackermann
5a7698ddef [web] refactor updating of scroll position in pdf view
Co-Authored-By: Timothée Alby <tim.alby@overleaf.com>
GitOrigin-RevId: 932c880bcd41e68d231928bdcbbaeb06c60f6fd5
2022-01-14 09:03:28 +00:00
Thomas
3f05f7f283 Merge pull request #6294 from overleaf/ta-synctex-detach-icon
Remove Arrows from Synctex Button in Detach Mode

GitOrigin-RevId: 0b96ed29fd43308383c1db658f1d8d5143e3dd23
2022-01-12 09:03:28 +00:00
Timothée Alby
55829a3382 Merge pull request #6199 from overleaf/ta-pdf-detach-sync-to-entry
Make syncToEntry a Detach Action

GitOrigin-RevId: 92e92b770c4e2be5b001c083d2d490231a7fddfb
2022-01-11 09:04:33 +00:00
Alf Eaton
5b560ad8ab Only store/restore PDF scroll position when visible (#6218)
GitOrigin-RevId: c2023b5173fe4668f52da3e096c3dfc0124a7248
2022-01-11 09:03:55 +00:00
Alf Eaton
50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Timothée Alby
44eca312ff Merge pull request #6053 from overleaf/ta-pdf-detach-tests
PDF Detach Misc Tests

GitOrigin-RevId: 9615c8fdfd8964a9c63d7c91e4596d397a1d35dc
2021-12-15 09:04:46 +00:00
Timothée Alby
c1c0f1fe4a Merge pull request #6039 from overleaf/ta-synctex-cursor-position-init
Fix Cursor Position Tracking for Synctex

GitOrigin-RevId: 6df703812f3efa2163b953aab82f32e174919179
2021-12-15 09:04:33 +00:00
Miguel Serrano
48233cd593 Merge pull request #6027 from overleaf/ae-disabled-download-pdf-tooltip
Fix tooltip on disabled download PDF button

GitOrigin-RevId: d1814e75886d8a530331c3ded01499dcad8a4289
2021-12-08 09:03:16 +00:00
Jessica Lawshe
994b34bb2d Merge pull request #5981 from overleaf/jel-synctex-bug
Fix postMessage error for PDF detach SyncTeX

GitOrigin-RevId: 701e92ca3d6bc20a6069d5290ee52d9d2d8f63b4
2021-12-03 09:04:15 +00:00
Timothée Alby
f6fc3d468c Merge pull request #5854 from overleaf/ta-pdf-detach-v2
PDF Detach Updates

GitOrigin-RevId: c09c4fe37a922b041cfa1376e110a264a88177c8
2021-12-01 09:03:41 +00:00
Alf Eaton
2e3f56c0d4 Check for the presence of window.ResizeObserver (#5924)
GitOrigin-RevId: d072c9313967b52370a870fc2d30b50c498d8d1d
2021-11-30 09:03:05 +00:00
Miguel Serrano
7de1e6f979 Update log error ordering and wording on tips (#5873)
* Show bibtex errors with compile errors
* Update wording on error log tips

GitOrigin-RevId: 0e25a05418b241526958016f1b525334d33ad741
2021-11-26 09:03:07 +00:00
Timothée Alby
8ca159b4b9 Merge pull request #5797 from overleaf/ta-pdf-detach
PDF Detach

GitOrigin-RevId: f69d8a87d1ba2115ad496a719106dfc7707a6ed5
2021-11-16 09:02:57 +00:00
Alf Eaton
3feca1ffc6 Move symbol palette to module and add overlay (#5396)
GitOrigin-RevId: 649dd56aaecd60662bd2bf534bda323ee541874f
2021-11-11 09:03:05 +00:00
Miguel Serrano
83e0a0c29b Fix scrollIntoView for PDF highlights (#5723)
GitOrigin-RevId: c2196ca3e3eed14a48b827a27a13f13232bb4c00
2021-11-09 09:03:55 +00:00
Alf Eaton
913a62fbc8 Migrate synctex controls to React (#5503)
GitOrigin-RevId: 80362a00ae6b73616a6fa9b3193b9b9974b5fd35
2021-10-22 08:03:43 +00:00
Alf Eaton
dd5bcd6098 Merge pull request #5521 from overleaf/ae-remove-stop-compile-button
Remove "Stop compiling" action from Recompile button in new PDF preview toolbar

GitOrigin-RevId: a4c90ec7d6213c49e11f13f045354ce66f2e9a8b
2021-10-22 08:03:28 +00:00
Alf Eaton
bd3d0d124d Merge pull request #5520 from overleaf/ae-log-entry-height
Fix log entry height in new PDF preview

GitOrigin-RevId: a9b7cae352da87f391c66720b109e3d9fd00fe52
2021-10-22 08:03:24 +00:00
June Kelly
4f29ca5cbd Merge pull request #5395 from overleaf/msm-pdf-metrics
Added PdfJsMetrics to React PDF Viewer

GitOrigin-RevId: ff749d67baec243ca2c8e51409754716f4cef62c
2021-10-21 08:03:07 +00:00
Alf Eaton
89dfcaf528 Finish migrating to PdfLogEntry component (#5483)
GitOrigin-RevId: 93f1da35dbc80b317964133e0437373dd0af7933
2021-10-18 08:04:12 +00:00
Alf Eaton
9ffe28649c Improve rendering of errors from pdf.js (#5448)
GitOrigin-RevId: 69836ba213b124e2442b2d0083531dd95be2bf4e
2021-10-18 08:04:06 +00:00
Alf Eaton
4c25dcfb2b Disable overflow: scroll on the outer pdf.js element (#5446)
GitOrigin-RevId: 77485d0dd2af3e4dc6f86f322816e00beee9dfa9
2021-10-18 08:03:52 +00:00
Alf Eaton
61f466afc0 Ignore invalid synctex highlights (#5476)
GitOrigin-RevId: 9123a09502f17c1251995b2e7133b345db885107
2021-10-18 08:03:41 +00:00
Alf Eaton
09f3962ded Ensure that the TimeoutUpgradePrompt component returns null (#5482)
GitOrigin-RevId: 95e58537c82d9bedd055839cfb916a06c1ef96df
2021-10-18 08:03:34 +00:00
Alf Eaton
12eab99990 Migrate log entry component to new PDF preview (#5478)
* Migrate log entry component to new PDF preview
* Add a test for expandable log content

GitOrigin-RevId: 3e2154983c1ea03b5db44c87822e7043c4aa2cfe
2021-10-18 08:03:30 +00:00
Alf Eaton
f7ef2532e0 Handle PDF preview on toggle between split and full-width views (#5470)
* Only hide the compile logs pane when toggled off
* Handle PDF preview on toggle between split and full-width views

GitOrigin-RevId: 9ceca8a06a22abfa78f245e1ae5d24af98215906
2021-10-18 08:03:26 +00:00
Alf Eaton
e26d47cb41 Add hybrid toolbar to migrated PDF preview (#5414)
GitOrigin-RevId: 6266028091229c819aee3c8d4bd3bff2e2417125
2021-10-13 08:03:01 +00:00
Alf Eaton
845b2fbc04 Move useScopeValue hook to shared hooks folder and wrap setValue in a function (#5386)
GitOrigin-RevId: b1a6a4e871af3b52fb3d100a83b479c834cb75ca
2021-10-11 08:03:29 +00:00
Miguel Serrano
8766c45362 Add log limit and info notice to PDF Preview log view (#5390)
GitOrigin-RevId: 14764d109dbe13d7e4fb4f79f098c74d4b57d59d
2021-10-11 08:03:13 +00:00
Miguel Serrano
07ca18cdbb Added keyboard shortcuts for zoom (#5334)
GitOrigin-RevId: b284f923e9b4aba7837430239b09e05bb0308d09
2021-10-11 08:03:07 +00:00
Alf Eaton
b902bd9265 Refactor compile-related code from PDF preview context provider into a separate class (#5341)
GitOrigin-RevId: 96b8bb527fa3d60a5fb84eee2b8f4fabc1726875
2021-10-11 08:02:56 +00:00
June Kelly
03e1daa038 Merge pull request #5201 from overleaf/msm-pdf-viewer-error-boundaries
Error boundaries for React PDF viewer

GitOrigin-RevId: 90052fc183f7ece8125ecfb0410a529cf905c13b
2021-10-07 08:03:43 +00:00
June Kelly
1e7dbeeb94 Merge pull request #5180 from overleaf/msm-pdf-js-viewer-tests
Unit Tests for `pdf-js-viewer.js`

GitOrigin-RevId: 4bd38cf98c598e2ea30791052b9c24568d92c6b8
2021-10-07 08:03:30 +00:00
Alf Eaton
73bc3418a2 Add React version of the PDF preview pane (#5135)
GitOrigin-RevId: fcc88a362c3e97c9fddf85d47c3a83a0a0b89432
2021-10-01 08:03:12 +00:00
Alf Eaton
deafe456b4 Merge pull request #4913 from overleaf/ae-pdf-preview-feature-flag
Add feature flag for React PDF preview pane

GitOrigin-RevId: ac1e7329d13117e72de6f6cf060cd16be81cbbaa
2021-09-06 08:02:52 +00:00