github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-01-31 12:52:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #8774 from overleaf/jpa-fix-pdf-metrics

Browse source 
[web] fix collection of pdf.js timing metrics

GitOrigin-RevId: ee4cd29cc737a740e367e8be1a00e688aa684462
This commit is contained in:
Jakob Ackermann 2022-07-08 09:15:05 +01:00 committed by Copybot
parent 361570f0ab
commit db83832485
1 changed files with 34 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

52
services/web/frontend/js/features/pdf-preview/components/pdf-js-viewer.js
View file

@ -22,7 +22,6 @@ function PdfJsViewer({ url, pdfFile }) {
setPosition,
startCompile,
} = useCompileContext()
const [timePDFFetched, setTimePDFFetched] = useState()
// state values persisted in localStorage to restore on load
const [scale, setScale] = usePersistedState(
@ -58,37 +57,54 @@ function PdfJsViewer({ url, pdfFile }) {
[setError]
)
// fetch and render times
const times = useRef({})
// listen for initialize event
useEffect(() => {
if (pdfJsWrapper) {
if (pdfJsWrapper && firstRenderDone) {
const handlePagesinit = () => {
setInitialised(true)
if (firstRenderDone) {
const visible = !document.hidden
if (!visible) {
firstRenderDone({
timePDFFetched,
})
} else {
const timePDFRendered = performance.now()
firstRenderDone({
timePDFFetched,
timePDFRendered,
})
}
times.current.timePDFFetched = performance.now()
const visible = !document.hidden
if (!visible) {
// Rendering does not start in case we are hidden.
firstRenderDone(times.current)
}
}
// `pagesinit` fires when the data for rendering the first page is ready.
pdfJsWrapper.eventBus.on('pagesinit', handlePagesinit)
return () => pdfJsWrapper.eventBus.off('pagesinit', handlePagesinit)
}
}, [pdfJsWrapper, firstRenderDone, timePDFFetched])
}, [pdfJsWrapper, firstRenderDone, times])
// list for page rendered event
useEffect(() => {
if (pdfJsWrapper && firstRenderDone) {
const handleRendered = () => {
const visible = !document.hidden
if (!visible) {
// The render time is not accurate in case we are hidden.
firstRenderDone(times.current)
} else {
times.current.timePDFRendered = performance.now()
firstRenderDone(times.current)
}
// Only get the times for the first page.
pdfJsWrapper.eventBus.off('pagerendered', handleRendered)
}
// `pagerendered` fires when a page was actually rendered.
pdfJsWrapper.eventBus.on('pagerendered', handleRendered)
return () => pdfJsWrapper.eventBus.off('pagerendered', handleRendered)
}
}, [pdfJsWrapper, firstRenderDone, times])
// load the PDF document from the URL
useEffect(() => {
if (pdfJsWrapper && url) {
setTimePDFFetched(performance.now())
setInitialised(false)
setError(undefined)
times.current = {}
pdfJsWrapper.loadDocument(url, pdfFile).catch(error => {
console.error(error)
@ -96,7 +112,7 @@ function PdfJsViewer({ url, pdfFile }) {
})
return () => pdfJsWrapper.abortDocumentLoading()
}
}, [pdfJsWrapper, url, pdfFile, setError])
}, [pdfJsWrapper, url, pdfFile, setError, times])
// listen for scroll events
useEffect(() => {