Commit graph

1153 commits

Author SHA1 Message Date
Timothée Alby
c0fae79ad7 Merge pull request #6693 from overleaf/jpa-error-is-manager
[web] refactor error handling for rejected manager removal

GitOrigin-RevId: 48be3bf254de74c2799d1368aee329fd9038dfa6
2022-02-16 11:34:25 +00:00
Jakob Ackermann
ae0c347f27 Merge pull request #6542 from overleaf/jpa-em-code-sharing-workspaces
[misc] npm workspaces

GitOrigin-RevId: 87aa72db6637fb238d7cd35b0a48ac3ed58ab3eb
2022-02-16 11:31:07 +00:00
Jakob Ackermann
42d78528ae Merge pull request #6572 from overleaf/jpa-web-unit-tests-npm-workspaces
[web] adjust unit test setup for npm workspaces

GitOrigin-RevId: 4c6f6debbc082301570173345cc366984a9c59f1
2022-02-16 11:31:03 +00:00
Miguel Serrano
176ead8983 Primary Email Check (#6471)
* added primary-email-check page, route and controllers
* add `#add-email` internal link in settings to display new email form
* added primary-email-check redirection with split test
* update `lastPrimaryEmailCheck` when the default email address is set
* added `lastPrimaryCheck` to admin panel
* translations for primary-email-check
* acceptance tests for primary-email-check
* [web] multi-submit for primary email check
* Using `confirmedAt` to prevent from displaying primary-email-check page

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
Co-Authored-By: Miguel Serrano <mserranom@gmail.com>
GitOrigin-RevId: d8e3a280439da08038a4487d8bfd7b3b0596e3b5
2022-02-04 09:03:34 +00:00
Alexandre Bourdin
215725e0a7 Merge pull request #6569 from overleaf/ab-recurly-webhook-filter
Add a failfast for invalid userId on recurly webhook

GitOrigin-RevId: 94e7c5fd756f5fbc592a9c346fca157883625396
2022-02-03 09:03:23 +00:00
Eric Mc Sween
57228c5589 Merge pull request #6442 from overleaf/em-split-tests-user-admin
Show split test assignments in user admin

GitOrigin-RevId: 4563a4899d5278a0ef84188ae25cb5dfd3d5cb57
2022-01-27 09:04:06 +00:00
Jakob Ackermann
d812b88e76 Merge pull request #6457 from overleaf/jpa-harden-login
[web] harden login process

GitOrigin-RevId: 5c0b7cc725efd5e3e879067ad8a42fe46a47b60d
2022-01-27 09:03:38 +00:00
Jessica Lawshe
6a0da3d204 Merge pull request #6375 from overleaf/jel-reconfirm-check
[web] Use v1 date for reconfirm notification check

GitOrigin-RevId: e14f1b6a1a6ab629628858d962a3757a6078cf79
2022-01-26 09:03:50 +00:00
Jessica Lawshe
7653b46719 Merge pull request #6356 from overleaf/jel-user-admin-panel
[web] v2 admin affiliations tab shows data used for licenses

GitOrigin-RevId: 1038b042a0728b118d3204515ed9f69e35746b18
2022-01-26 09:03:43 +00:00
Jakob Ackermann
cfaec97a3d Merge pull request #6393 from overleaf/ta-backfill-user-properties
Backfill User Properties

GitOrigin-RevId: ea2ffeaaf71d5ce41c76a1bfb2f0014006ef0d08
2022-01-26 09:03:06 +00:00
Jakob Ackermann
b2e18c92a6 Merge pull request #6418 from overleaf/ta-ga-optimize-remove
Cleanup Google Optimize

GitOrigin-RevId: d8cf8008179ad2c355c09f06d947fb2b89cf5a3c
2022-01-26 09:03:02 +00:00
Alexandre Bourdin
4c49edd89b Assignment by id for recurly webhook (#6465)
* Allow split test assignment by ID for recurly webhook

* Small refactoring of assignment logic

* Add tests for getAssignmentForUser

* Cleanup following review comments

* Provide default value for sync option in split test handler

GitOrigin-RevId: 828cad3a1f3a0f3efd25f427d00a3c530ae2f087
2022-01-25 09:04:05 +00:00
Alexandre Bourdin
1b954fa720 Merge pull request #6332 from overleaf/ab-split-test-param-overrides
Split tests query param overrides

GitOrigin-RevId: 8112710d057ddc22cebf37a619dfc969be57b6cc
2022-01-25 09:03:04 +00:00
Tim Alby
bbac46156b convert price_in_unit to price_in_cents
GitOrigin-RevId: bae030e9c90f8286d6e6550744849984fe81f63d
2022-01-21 09:03:29 +00:00
Tim Alby
3e70546e18 rename price attributes to price_in_cents or price_in_unit
GitOrigin-RevId: 8045472c96862078583fcb522099ad78926281dc
2022-01-21 09:03:23 +00:00
Jakob Ackermann
1fc0b3e4aa Merge pull request #6349 from overleaf/jpa-password-strength-checking
[web] data collection for password strength using HaveIBeenPwned api

GitOrigin-RevId: 7e4d57a979c29027fb7ca5294f3935500a0b4cf3
2022-01-20 09:03:07 +00:00
Jakob Ackermann
220daff655 Merge pull request #6384 from overleaf/jpa-fix-proxying-of-json
[web] fix proxying of responses from other services

GitOrigin-RevId: ac1ecc02c06e353f8379fadb47824a46672610e5
2022-01-18 09:03:30 +00:00
Jakob Ackermann
d720d6affa Merge pull request #6317 from overleaf/jpa-send-explicit-content-type
[web] send explicit content type in responses

GitOrigin-RevId: d5aeaba57a7d2fc053fbf5adc2299fb46e435341
2022-01-18 09:03:18 +00:00
Jakob Ackermann
c97e95aeba [web] confirmDomain: skip fetching affiliations per user
Nothing is looking at either
 - `user.emails[i].affiliation` or
 - `user.emails[i].emailHasInstitutionLicence`
So we might as well skip fetching the data.

This eliminates N v1 calls and N mongo calls from the endpoint.

GitOrigin-RevId: bb1d077df19910b9dfb7ef06562cf35ce5302290
2022-01-14 09:03:33 +00:00
June Kelly
c72ec548bb Merge pull request #5976 from overleaf/jk-login-audit-log-type
[web] Add 'method' info to login audit log

GitOrigin-RevId: 093fe885bc1b688aebd640d6762f031c752191d4
2022-01-14 09:02:28 +00:00
Jessica Lawshe
d7365e2929 Merge pull request #6338 from overleaf/jel-prettier-test
Run prettier on file

GitOrigin-RevId: bcd3a355d5ffa9271dd7b9a0f4ff0efa0d61a7ee
2022-01-13 09:04:41 +00:00
Jessica Lawshe
e8a4a88e87 Merge pull request #6238 from overleaf/jel-script-remove-email
[web] Script to remove email

GitOrigin-RevId: c8f1a69259904b08ef39181b8b7e9c3150ea59f0
2022-01-13 09:04:22 +00:00
Jessica Lawshe
bbc5e2d34c Merge pull request #6255 from overleaf/jel-tidy-saml-tests
[web] Tidy SAML tests

GitOrigin-RevId: 3b13fa847d935235bafe61c4118b046eb972f922
2022-01-13 09:04:09 +00:00
June Kelly
b5625fe3df Merge pull request #6227 from overleaf/jpa-de-dupe-feature-refresh
[web] when confirming institution domain, refresh features once per user

GitOrigin-RevId: 3855441848cf0b140a6cf0264b887d8eca7db5ad
2022-01-13 09:03:33 +00:00
June Kelly
02bb2f1c5a Merge pull request #6181 from overleaf/jk-fix-sub-handler-xml-exception
[web] Catch XML errors in RecurlyWrapper

GitOrigin-RevId: bc20146b67e0ceac76f21b5d28ea2b36e2e97f0d
2022-01-13 09:03:23 +00:00
Alf Eaton
50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Jakob Ackermann
2465a32451 Merge pull request #6234 from overleaf/jpa-web-owns-spelling-preferences
[misc] move ownership of spellingPreferences collection to web

GitOrigin-RevId: f2584a1119a578c3df15371c6798923a4f2d15ae
2022-01-07 09:03:11 +00:00
Jakob Ackermann
17eb841b31 Merge pull request #6151 from overleaf/jpa-jel-ta-spelling-client-cache
[misc] filter out saved words from users dict client side

GitOrigin-RevId: 01b496c60d25954c8e65a71c06fd90a6c428a698
2022-01-05 09:02:59 +00:00
Brian Gough
108c99cf53 Merge pull request #6141 from overleaf/bg-update-basic-auth
[web] remove deprecated basic-auth-connect module

GitOrigin-RevId: b18435c98696858da70f3a715258c3c7a86c3b54
2021-12-20 09:03:06 +00:00
Timothée Alby
00e792b022 Merge pull request #6093 from overleaf/jpa-last-user-activity
[web] add a last active date for denoting account activity in groups mgt

GitOrigin-RevId: 32a9e5c1e8f63e794bf6d379685b6dda7e6d4d22
2021-12-15 09:05:34 +00:00
Eric Mc Sween
b22df1dcba Merge pull request #5984 from overleaf/em-unnecessarily-async-functions
Clean up unnecessarily async functions

GitOrigin-RevId: 59f0f0a76b4436f3b99a09b747670d443bac4582
2021-12-07 09:03:33 +00:00
Miguel Serrano
d48dbed536 Override split test locals (#5960)
GitOrigin-RevId: 9a5372f2c4c6d79e6d77a2f72f6dc6a86437f577
2021-12-03 09:03:24 +00:00
Miguel Serrano
d5bf5b0614 Merge pull request #5881 from overleaf/ab-split-test-middleware
New global split test middleware for locals

GitOrigin-RevId: b530572f709572663fc3d051f544064bd8804f76
2021-12-03 09:03:20 +00:00
Eric Mc Sween
b8ab8fbdbd Merge pull request #5853 from overleaf/em-fix-file-tree
More filename fixes when resyncing

GitOrigin-RevId: 15e2e71fa8d16a1c708449eb607918b36f2fb3ee
2021-11-23 09:03:11 +00:00
Alexandre Bourdin
f9873619ad Merge pull request #5769 from overleaf/ab-null-split-tests
Setup null split tests

GitOrigin-RevId: 4cba55e123d0a4add19cdace7434506e9d20c7a9
2021-11-23 09:02:46 +00:00
Alexandre Bourdin
fa6bc3fc7b Merge pull request #5777 from overleaf/ab-utm-term-content
Track utm_content param and replace utm_term in utm-tags property

GitOrigin-RevId: 868274a3dc4f44705f1e8340592ee05acc471b19
2021-11-23 09:02:43 +00:00
Jessica Lawshe
8060b5e781 Merge pull request #5802 from overleaf/jel-reconfirm-notification
[web] Extend reconfirmation notification check

GitOrigin-RevId: da3785a25b4fa1152a862214af3c17a67f57f10b
2021-11-18 09:03:18 +00:00
Alf Eaton
a15e1bdc07 Merge pull request #5734 from overleaf/ab-handle-project-zip-not-existing
Handle case of not existing project ID when zipping projects for download

GitOrigin-RevId: 601b14ef0217c27dc50ef0442f7e81db35642b6d
2021-11-17 09:03:29 +00:00
Eric Mc Sween
642764fccf Merge pull request #5770 from overleaf/em-resync-clean-filename
Clean filenames before resync

GitOrigin-RevId: 46a408a8b7eb067b431db04951d92c029b833054
2021-11-16 09:02:51 +00:00
Brian Gough
aeb2ce7435 Fix up duplicate filenames during resync (#5742)
* Fix up duplicate filenames during resync

* Unit test for project history resync with duplicate paths

* Decaf cleanup: unnecessary returns

* Decaf cleanup: remove initClass()

* Decaf cleanup: unused variables

* Decaf cleanup: camel case variables

* Support duplicate folder names when traversing project folders

We have some broken projects that contain duplicate folder names. In
order to fix them, we need to be able to find them in the project. The
use of an object to store folders by path meant that only one of the
duplicate folders would be found.

* Keep docupdater up to date when renaming during a resync

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: bf3dcdc4c1d4f5418ff9f5e68b255438620349ca
2021-11-12 09:02:56 +00:00
Miguel Serrano
b7e9f0b67f Prepare React Pdf Preview Rollout with Split Test (#5746)
Prepare React Pdf Preview Rollout with Split Test and disabled new Logs UI

GitOrigin-RevId: 995b7ca3ed542e58596b9f9715adc93a64da597e
2021-11-12 09:02:42 +00:00
Eric Mc Sween
5fc6d7dcb3 Merge pull request #5740 from overleaf/em-gcp-logging-web
Improve GCP logging for web

GitOrigin-RevId: b304c87a3fe46c29189f665eb3daf22c23d6eb8f
2021-11-11 09:03:09 +00:00
Miguel Serrano
739ac96195 Revert "Prepare new Pdf Preview rollout (#5664)" (#5745)
This reverts commit 047a3c636e09e9786c2a9b93514fef5bc46b0da9.

GitOrigin-RevId: 91b3c024cd364c1fd55d5e4fc6a2c592b784bc2a
2021-11-11 09:03:01 +00:00
Miguel Serrano
19eef0acca Prepare new Pdf Preview rollout (#5664)
* Prepare new pdf preview rollout
* skip new_logs_ui variant tests

GitOrigin-RevId: 047a3c636e09e9786c2a9b93514fef5bc46b0da9
2021-11-11 09:02:57 +00:00
Hugh O'Brien
3b95ac6d88 Merge pull request #5688 from overleaf/jpa-invalid-password-message
[web] password reset: validate user password ahead of invalidating token

GitOrigin-RevId: ba3e6549f53675a2216e2fc24293276c1968d416
2021-11-10 09:02:38 +00:00
Alexandre Bourdin
05c1ecdde0 Merge pull request #5679 from overleaf/ab-utm-tracking-fix
UTM Tracking

GitOrigin-RevId: 8e9f8372affce72b35f47786de40def77c08a514
2021-11-09 09:05:05 +00:00
Alexandre Bourdin
7836743754 Merge pull request #5717 from overleaf/ab-sub-controller-uncaught-ex
Prevent uncaught error in SubscriptionController

GitOrigin-RevId: af8e986ce4c83c48d4af2a4af092c63eea092335
2021-11-09 09:04:58 +00:00
Alexandre Bourdin
c881909258 Merge pull request #5716 from overleaf/ab-tear-down-de-ng-plans-page-test
Tear down de-ng split test and cleanup old version

GitOrigin-RevId: 02438bbb2e530dfe72f046dd91c547d97c39c96e
2021-11-09 09:04:51 +00:00
Jessica Lawshe
b90b7c92ac Merge pull request #5655 from overleaf/jel-detach-feature-flag
Make showNewPdfPreview a dependency of showPdfDetach

GitOrigin-RevId: 2bb2f5cd8b2cf68a28e8979713c08c0ceef33fa5
2021-11-04 09:03:51 +00:00
Alexandre Bourdin
115436925c Merge pull request #5668 from overleaf/revert-5595-ab-utm-tracking
Revert "UTM Tracking"

GitOrigin-RevId: dbed61448496ff8e990eb9a3712831ef1a3376fe
2021-11-03 09:04:26 +00:00