github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #5777 from overleaf/ab-utm-term-content

Browse source 
Track utm_content param and replace utm_term in utm-tags property

GitOrigin-RevId: 868274a3dc4f44705f1e8340592ee05acc471b19
This commit is contained in:
Alexandre Bourdin 2021-11-22 11:34:23 +01:00 committed by Copybot
parent 033b9bd982
commit fa6bc3fc7b
3 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
services/web/app/src/Features/Analytics/AnalyticsUTMTrackingMiddleware.js
View file

@ -22,14 +22,11 @@ function recordUTMTags() {
...utmValues,
})
const propertyValue = [
'utm_source',
'utm_medium',
'utm_campaign',
'utm_term',
]
.map(tag => utmValues[tag] || 'N/A')
.join(';')
const propertyValue = `${utmValues.utm_source || 'N/A'};${
utmValues.utm_medium || 'N/A'
};${utmValues.utm_campaign || 'N/A'};${
utmValues.utm_content || utmValues.utm_term || 'N/A'
}`
AnalyticsManager.setUserPropertyForSession(
req.session,
'utm-tags',

1
services/web/app/src/Features/Analytics/RequestHelper.js
View file

@ -5,6 +5,7 @@ const UTM_KEYS = [
'utm_campaign',
'utm_source',
'utm_term',
'utm_content',
'utm_medium',
'utm_count',
]

15
services/web/test/unit/src/Analytics/AnalyticsUTMTrackingMiddlewareTests.js
View file

@ -63,12 +63,13 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
describe('with all UTM tags in query', function () {
beforeEach(function () {
this.req.url =
'/project?utm_source=Organic&utm_medium=Facebook&utm_campaign=Some%20Campaign&utm_term=foo-bar'
'/project?utm_source=Organic&utm_medium=Facebook&utm_campaign=Some%20Campaign&utm_content=foo-bar&utm_term=overridden'
this.req.query = {
utm_source: 'Organic',
utm_medium: 'Facebook',
utm_campaign: 'Some Campaign',
utm_term: 'foo-bar',
utm_content: 'foo-bar',
utm_term: 'overridden',
}
this.middleware(this.req, this.res, this.next)
})
@ -92,7 +93,8 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
utm_source: 'Organic',
utm_medium: 'Facebook',
utm_campaign: 'Some Campaign',
utm_term: 'foo-bar',
utm_content: 'foo-bar',
utm_term: 'overridden',
}
)
})
@ -109,10 +111,12 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
describe('with some UTM tags in query', function () {
beforeEach(function () {
this.req.url = '/project?utm_medium=Facebook&utm_campaign=Some%20Campaign'
this.req.url =
'/project?utm_medium=Facebook&utm_campaign=Some%20Campaign&utm_term=foo'
this.req.query = {
utm_medium: 'Facebook',
utm_campaign: 'Some Campaign',
utm_term: 'foo',
}
this.middleware(this.req, this.res, this.next)
})
@ -135,6 +139,7 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
path: '/project',
utm_medium: 'Facebook',
utm_campaign: 'Some Campaign',
utm_term: 'foo',
}
)
})
@ -144,7 +149,7 @@ describe('AnalyticsUTMTrackingMiddleware', function () {
this.AnalyticsManager.setUserPropertyForSession,
this.req.session,
'utm-tags',
'N/A;Facebook;Some Campaign;N/A'
'N/A;Facebook;Some Campaign;foo'
)
})
})