github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
22602 commits 3 branches 7 tags 206 MiB
Commit graph

22602 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jakob Ackermann
06607b5c51 Merge pull request #18732 from overleaf/jpa-server-pro-csp 
[server-ce] enable CSP by default in Server CE/Pro

GitOrigin-RevId: 8c7664a39f688a748f33e3158b594b9368457661
 2024-06-06 08:04:35 +00:00
ilkin-overleaf
dd7970c11d Merge pull request #18644 from overleaf/ii-delete-with-body-teardown-old-routes 
[web] Tear down deprecated routes

GitOrigin-RevId: b86e1d9283a30d36f77148eeb782a7f37987854a
 2024-06-06 08:04:31 +00:00
Antoine Clausse
e452f1df5b [web] Promisify LdapController (#18500) 
* Promisify LdapController

* Update tests LdapControllerTests.js

* Promisify `AuthenticationController.finishLogin`

* Simplify null checks in LdapController

* Fix: don't use spread operator in module.exports

* Make `AuthenticationController.promises.finishLogin` a promise that resolves

* Fixup: `finishLogin` does not call `next` then the promise finishes, it calls it only on errors

* Use `Modules.promises.hooks.fire`

* Revert `processPassportLogin` callback style

* Update error handling: Use `OError.tag` instead of `logger.err`

* Fix unit tests: Rely on callbacks rather than promises

* Fix: Actually call `passport.authenticate` (!!)

* Update test: fixup `passport.authenticate` mocks

This would have caught the bugs that the previous commit is solving

* Remove `.then(() => next())` in `processPassportLogin`

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>

---------

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: a7eab5f5289956aeb8f2418408958daef3511ab7
 2024-06-06 08:04:23 +00:00
Antoine Clausse
258289e65a [web] Promisify LaunchpadController (#18497) 
* Remove unused exports and decaffeinate comment

* Update export format

* Make `launchpadPage` async

* Make `_atLeastOneAdminExists` async

* Make `sendTestEmail` async

* Make `registerExternalAuthAdmin` async

* Make `registerAdmin` async

* Update tests LaunchpadControllerTests.js

* Use `expressify(...)`

* Fix unit tests: export `LaunchpadController`

* Fix unit tests by awaiting expressified functions (could include breaking changes!)

* Call `.exec()` after `User.updateOne(...)`

* Revert promisification of `expressify`

* Revert some `return` removal in tests

GitOrigin-RevId: c73a38bf1cf798830df046fe96d3516178655ea6
 2024-06-06 08:04:18 +00:00
Alf Eaton
c24ace801b Remove Angular (#17534) 
GitOrigin-RevId: 7a0d45e17d9905fa75569e2d19ca59caa4a41565
 2024-06-06 08:04:09 +00:00
Tim Down
b3d33fe813 Merge pull request #18688 from overleaf/td-bs5-dropdown-min-width 
Apply min-width rather than width to Bootstrap 5 drop-downs

GitOrigin-RevId: 369b5028fa5c53e7e39986474c27f8b848e70b20
 2024-06-05 08:04:05 +00:00
Jakob Ackermann
3b5cfd83f3 Merge pull request #18704 from overleaf/jpa-fix-local-sandboxed-compiles 
[server-pro] fix TeXLive versions for running tests locally

GitOrigin-RevId: 08bc769fd97558323011dedae378982d8cefee66
 2024-06-05 08:04:01 +00:00
Liangjun Song
432fbd3c40 Revert "[web]implement in-house sha1 hash function (#18651)" (#18703) 
This reverts commit aa3f5ab3ff412696c715521381eebf176f503197.

GitOrigin-RevId: b2be3907439525f3ed49baec0b438ba35ea1663c
 2024-06-05 08:03:57 +00:00
Eric Mc Sween
55c342134c Merge pull request #18659 from overleaf/em-crop-comments-tracked-deletes 
Crop comments when processing tracked deletes

GitOrigin-RevId: 662c9ed86a8ed4959d1671ce466548487f334f45
 2024-06-05 08:03:53 +00:00
Liangjun Song
4101f4efeb [web]implement in-house sha1 hash function (#18651) 
* implement in-house sha1 hash function

* add comment

* add test description

Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>

* add more tests

* dedupe test strings and remove unneeded toString calls

---------

Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>
GitOrigin-RevId: aa3f5ab3ff412696c715521381eebf176f503197
 2024-06-05 08:03:42 +00:00
CloudBuild
a9cc32e6ed auto update translation 
GitOrigin-RevId: 12802865aecee6957eb6b36eafc4500c32512aeb
 2024-06-04 08:05:12 +00:00
Tim Down
9f1272d46d Merge pull request #18536 from overleaf/td-bs5-remove-bookmarkable-tab 
Move bookmarkable tabs to Bootstrap 3 only

GitOrigin-RevId: 456599e96f6b0ee3862004f74e4b19c5d4d94c93
 2024-06-04 08:05:04 +00:00
Jessica Lawshe
22be3928e3 Merge pull request #18614 from overleaf/mf-create-plans-redesign-split-test-config 
[web] Create split test configuration for `website-redesign-plans` split test

GitOrigin-RevId: dea88256830897d1ab1f1de64eb21413c823e6ff
 2024-06-04 08:04:59 +00:00
Jessica Lawshe
9e99683915 Merge pull request #18568 from overleaf/jel-cms-cards 
[web] Add 2 new card style options for CMS

GitOrigin-RevId: d784d3f4860abf9553f1ab68e3edd29b93355a52
 2024-06-04 08:04:55 +00:00
Liangjun Song
c22802eac9 implement in-house md5 hash function (#18647) 
* implement in-house md5 hash function

* format

* add lisence information

GitOrigin-RevId: 1416654e8c27ec7a0d6ca632e6ece59c830ef561
 2024-06-04 08:04:50 +00:00
Tim Down
c0d920f305 Merge pull request #18660 from overleaf/td-rd-bs5-contact-us-modal 
Bootstrap 5 contact us modal

GitOrigin-RevId: a4607fab50152109fbe83bc29246b7b4a82539a1
 2024-06-04 08:04:46 +00:00
Tim Down
e533bee8a3 Merge pull request #18664 from overleaf/td-bs5-integrations-premium-badge 
Position "premium feature" badge correctly on account settings page

GitOrigin-RevId: 82d8a1db739a9836bcfa2c6a56a2bc6198da7f54
 2024-06-04 08:04:38 +00:00
Tim Down
7825bb8dd8 Merge pull request #18662 from overleaf/td-bs5-increase-settings-button-sizes 
Bootstrap 5: increase size of "Add new email" and institution/role change submit buttons

GitOrigin-RevId: 28756bdfe723a57da9c73f0ab3d852d2f9c3ea5e
 2024-06-04 08:04:34 +00:00
Mathias Jakobsen
2180ea0578 Merge pull request #18657 from overleaf/mj-mastersthesis-typo 
[web] Fix typo in mastersthesis autocompletion

GitOrigin-RevId: 38c3473c310da071b5293739dc6e74d0263259b9
 2024-06-04 08:04:08 +00:00
David
656130b2ed Merge pull request #18655 from overleaf/dp-pdf-viewer-typescript 
Convert PdfJsViewer component to typescript

GitOrigin-RevId: 1019b947f3e6869a99495d3de7cd14ebd5007587
 2024-06-04 08:04:03 +00:00
David
d652717c5a Merge pull request #18601 from overleaf/dp-pdf 
Only set initial pdf page number on first page render

GitOrigin-RevId: f272acb2bce704037079e01dde89e475414e9fea
 2024-06-04 08:03:59 +00:00
Jakob Ackermann
167bb66939 Merge pull request #18656 from overleaf/jpa-fix-double-lint 
[web] eslint with multiple --ignore-pattern is broken

GitOrigin-RevId: eef4bdd2e43c6f576ee5997f8e9a2bd9f385ab48
 2024-06-04 08:03:54 +00:00
CloudBuild
9bed2dc73e auto update translation 
GitOrigin-RevId: eb89cf81de994aff77bd8a88748656700dbad86c
 2024-06-03 08:04:22 +00:00
Andrew Rumble
d1a58e6b77 Merge pull request #18538 from overleaf/ar-add-download-all-link-in-web 
[web] add download all link for output files

GitOrigin-RevId: 3d574d75d53e577cb0f8fd3caa4f757d9e1b7889
 2024-06-03 08:04:07 +00:00
David
a70a3fc77e Merge pull request #18514 from overleaf/dp-pdf-toolbar-hover 
Add hover state to pdf toolbar buttons

GitOrigin-RevId: d58ad739e6454b9e0cdbdbb93c55e58785a9d672
 2024-06-03 08:04:02 +00:00
CloudBuild
f89ee54fdc auto update translation 
GitOrigin-RevId: ab2ee1e69de70b797f33fe7d9757444f8fc2f527
 2024-05-31 08:05:00 +00:00
Jimmy Domagala-Tang
17074473a7 Merge pull request #18525 from overleaf/jdt-disable-indenttaion-safari 
[Web] Disable indentation markers on Safari

GitOrigin-RevId: 7a62382e6d4a4ecf0bd144ab937f6e197d173bdb
 2024-05-31 08:04:56 +00:00
Rebeka Dekany
9120afffa5 Merge pull request #18567 from overleaf/rd-bs5-settings-modal 
[web] Migrate the Git Integration settings on the Account Settings page to Bootstrap 5

GitOrigin-RevId: bafac941d3afaadaa046de07e18968d8e3692b1c
 2024-05-31 08:04:49 +00:00
Tim Down
1b247347e7 Merge pull request #18590 from overleaf/td-ieee-editor-remove-blue 
Disable IEEE stylesheet in IEEE editor based on feature flag

GitOrigin-RevId: 09b203e3220a868d5f0a0e413bdc4d3ff7a1792e
 2024-05-31 08:04:41 +00:00
Jessica Lawshe
d209c107c5 Merge pull request #18613 from overleaf/dp-pdf-keyboard-scroll 
Fix keyboard arrow scrolling on pdf viewer

GitOrigin-RevId: 7c338049f0e5368ee11fdda11198a1f4df2bd49f
 2024-05-31 08:04:34 +00:00
Jessica Lawshe
3a59883e7a Merge pull request #18297 from overleaf/jel-remove-angular-group-invite 
[web] Remove Angular version of group invite

GitOrigin-RevId: bd31cd2ed3c105c9042ae9c42894cfe960459a46
 2024-05-31 08:04:27 +00:00
Jessica Lawshe
cbe5cefb9a Merge pull request #18161 from overleaf/jel-subscription-dash-admin 
[web] Subscription dash message when viewing as admin

GitOrigin-RevId: 699a523d7ac8d1a71e9ba14c7b8a66b39142958a
 2024-05-31 08:04:23 +00:00
Eric Mc Sween
c85f4ab5e5 Merge pull request #18491 from overleaf/em-filter-summarized-updates 
Filter out comment ops from summarized updates

GitOrigin-RevId: 97a44821b6dc001cd1ea84115cf69c8d712e9946
 2024-05-31 08:04:18 +00:00
Miguel Serrano
266d3d2a2e [CE/SP] Add e2e tests for tutorial links in welcome page (#18471) 
* [CE/SP] Add e2e tests for tutorial links in welcome page

The Welcome page should only display a tutorial link
in Server Pro when wiki is enabled

GitOrigin-RevId: 26f8b60a34bb86c0f9edc3b479e8304cc48842b7
 2024-05-31 08:04:11 +00:00
Jakob Ackermann
2f5bcebcdd Merge pull request #18570 from overleaf/jpa-lean-npm-install 
[server-ce] omit devDependencies from final image

GitOrigin-RevId: e35d7010ee33345121fb175e0400be122cb468c1
 2024-05-31 08:04:00 +00:00
Jakob Ackermann
f5701b67eb Merge pull request #18559 from overleaf/jpa-server-ce-caching 
[server-ce] docker image caching

GitOrigin-RevId: 161d775485d6b8f994d1a6e53440a586fb9a5058
 2024-05-30 08:05:34 +00:00
Jakob Ackermann
5a1cff55bc Merge pull request #18543 from overleaf/jpa-server-pro-test-templates 
[server-pro] tests: add tests for templates feature

GitOrigin-RevId: b36482af924e306207cbdedc1a8d1d548272ee77
 2024-05-30 08:05:30 +00:00
Jakob Ackermann
2754c90ea6 Merge pull request #18465 from overleaf/jpa-more-server-pro-e2e-tests 
[server-pro] add more e2e tests for Server Pro

GitOrigin-RevId: 003a92ae6c12b58d1d31679f9d9e54d83cfc4a1e
 2024-05-30 08:05:26 +00:00
Jakob Ackermann
8eb8b233c0 Merge pull request #18316 from overleaf/jpa-host-admin 
[server-ce] e2e tests: add capability for reconfiguring the instance

GitOrigin-RevId: 44ec800b5b37497b3122310a94f637c24ff2667a
 2024-05-30 08:05:22 +00:00
Eric Mc Sween
22257cf037 Merge pull request #18583 from overleaf/em-multi-hash-key 
Ensure that MULTI commands always go to a single node

GitOrigin-RevId: 223d29986766577df89c82983126dabca5d16eed
 2024-05-30 08:05:17 +00:00
David
55e54ce875 Merge pull request #18435 from overleaf/dp-ae-pdf-viewer-controls 
Update PDF viewer controls

GitOrigin-RevId: 4e15b7cbd34e878d0175be635369b8d620188203
 2024-05-30 08:05:06 +00:00
Eric Mc Sween
e0f6622519 Merge pull request #18579 from overleaf/em-verbose-multi-error 
More verbose error on MULTI

GitOrigin-RevId: c1e194063bfd4b4cc88bfb5775af13e1533100d4
 2024-05-30 08:04:52 +00:00
Tim Down
134232a1a6 Merge pull request #18577 from overleaf/td-bs5-nav-dropdown-item-missing-href 
Add missing href on Bootstrap 5 nav dropdown items

GitOrigin-RevId: 211a6dbd559ad74a9e49edbace61a51c2cc2f2da
 2024-05-30 08:04:48 +00:00
ilkin-overleaf
920bbe4bac Merge pull request #18527 from overleaf/ii-bs5-projects-structure 
[web] Create the sidebar and projects columns in dashboard page (BS5)

GitOrigin-RevId: 9096d6932980c10816411fc18570ad88df68a6d6
 2024-05-30 08:04:44 +00:00
Mathias Jakobsen
80044b53b4 Merge pull request #18571 from overleaf/mj-error-reporting-more-info 
[web] Add frontend release and load time to error reporting

GitOrigin-RevId: f362569d0012131d4538016573d1488b30b5c790
 2024-05-30 08:04:40 +00:00
Antoine Clausse
36f0a3e01a [web] Promisify ProjectController (#18477) 
* Create `promiseAuto` util to replace `async.auto`

* Promisify `BrandVariationsHandler.getBrandVariationById`

* Promisify `updateProjectSettings`

* Promisify `updateProjectAdminSettings`

* Promisify `newProject`

* Promisify `deleteProject`

* Promisify `loadEditor`

* Fix brandVariation loading in promise auto

* Promisify `_refreshFeatures`

* Promisify `_injectProjectUsers`

* Fix `no-inner-declarations`

* Promisify `cloneProject`

* Promisify `userProjectsJson`

* Promisify `projectEntitiesJson`

* Promisify `restoreProject`

* Promisify `renameProject`

* Additional warning fix

* Update unit tests

* Fixup `updateProjectSettings`: call jobs inside the Promise.all

* Use `expressify(...)` instead of manually call `next(err)`

https://github.com/overleaf/internal/pull/18477#discussion_r1613611987
https://github.com/overleaf/internal/pull/18477#discussion_r1613621146
https://github.com/overleaf/internal/pull/18477#discussion_r1613634000
...

* Replace Promise.all by sequencial awaits

https://github.com/overleaf/internal/pull/18477#discussion_r1613852746
https://github.com/overleaf/internal/pull/18477#discussion_r1613611987

* Remove manual throws of 500. Let the generic error handler catch them.

https://github.com/overleaf/internal/pull/18477#discussion_r1613623446
https://github.com/overleaf/internal/pull/18477#discussion_r1613628955

* Promisify `untrashProject`

https://github.com/overleaf/internal/pull/18477#discussion_r1613627783

* Promisify `expireDeletedProjectsAfterDuration`

* Promisify `archiveProject`

* Promisify `unarchiveProject`

* Promisify `trashProject`

* Promisify `expireDeletedProject`

* Use async `setTimeout` from `timers/promise`

https://github.com/overleaf/internal/pull/18477#discussion_r1613843085

* Remove unused `_injectProjectUsers`

https://github.com/overleaf/internal/pull/18477#discussion_r1613855766

* Add missing exec in queries (?)

Not sure if that makes a real difference but it's more consistent with the rest of the code

* Catch floating promises

https://github.com/overleaf/internal/pull/18477#discussion_r1613868876

* Replace custom `promiseAuto` by `p-props` from NPM

https://github.com/overleaf/internal/pull/18477#discussion_r1613393294

* Downgrade `p-props` to v4. Later versions require ESM

* Simplify code around `splitTestAssignments`

GitOrigin-RevId: 84d37f7aa9227b5b9acf9eeb5db1b78afc01b6ee
 2024-05-30 08:04:36 +00:00
Antoine Clausse
01e1286a8b In PayPal collect invoices script: Update throw unsuccessful invoices collections (#18572) 
* Remove throw on `INVOICES_COLLECTED_SUCCESS.length === 0`

Effectively reverts 038377b511

See: https://digital-science.slack.com/archives/C20TZCMMF/p1716973110408049

* Update tests so they don't expect rejections

* Reject when some invoice collection failed

GitOrigin-RevId: aa37f7fa37c96b8624e87d94be675d115e3250a9
 2024-05-30 08:04:31 +00:00
M Fahru
69871fccbe Fix plans page hash does not get updated if no hash is on the URL 
Example case: visit plans page via other pages, the hash will be empty initially, this commit will make sure hash is updated even though no initial hash exists.

GitOrigin-RevId: 411585111e8cf1b3eb803059ad4cf98ae4e69b19
 2024-05-30 08:04:27 +00:00
Domagoj Kriskovic
218a4538c1 [web] support for reverting binary files (#18033) 
* [web] revert binary file

* use addEntityWithName if file was deleted

* todo comments

* only show Revert file in ui even if deleted

* use _revertBinaryFile function

* emit new ids when reverting

* format:fix

* await emitToRoom calls

* use EditorController.upsertFile

* remove _revertBinaryFile function

* binary file check

* mock importFile method in tests

* move findElementByPath stub

* debug ci error

* resolve with empty object as file

* fix tests

* remove await before expect()

* format:fix

* test when binary file exists and when it does not

* use "file-revert" for source

* [web] revert existing file without ranges support (#18107)

* [web] revert existing file without ranges support

* ignore document_updated_externally if file-revert

* fix test

GitOrigin-RevId: a5e0c83a7635bc7d934dec9debe916bdd4beb51e
 2024-05-30 08:04:20 +00:00
Tim Down
3b2e60ece7 Merge pull request #18558 from overleaf/td-bs5-query-string-override 
Add a mechanism to hide incomplete Bootstrap 5 pages by default

GitOrigin-RevId: 07cc998bf3a0bed9df2f43d1c04c62d167c9b893
 2024-05-30 08:04:15 +00:00