github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity
20857 commits 3 branches 7 tags 221 MiB
Commit graph

3199 commits

Author SHA1 Message Date
Miguel Serrano
db70128d03 Merge pull request #13244 from overleaf/msm-fix-split-test-client 
[web] Fix split test assignments not sent via LocalsHelper in Server Pro

GitOrigin-RevId: 3a69fda3a4a0e66ecde3772d918d9c6d46e89ecf
 2023-06-01 08:04:39 +00:00
Domagoj Kriskovic
a05c201652 [cm6] indent figure modal generated code (#13213) 
* [cm6] indent figure modal generated code

* fix: prettier

* fix indenting issues

* add licence on top

* fix cypress tests

GitOrigin-RevId: 8f74be537f19c2a29de3c742a9bbabe43b1ce40d
 2023-06-01 08:03:49 +00:00
June Kelly
d68ed0efdf Merge pull request #13140 from overleaf/jk-real-time-disconnect-link-sharing 
[real-time] Disconnect relevant users when link-sharing is turned off

GitOrigin-RevId: cf44a30a235717b658a759e8a74ae4d0e5abae47
 2023-05-31 08:05:07 +00:00
ilkin-overleaf
bb815268f2 Merge pull request #13146 from overleaf/ii-history-react-save-last-selected-file-in-local-storage 
[web] Save lastly selected file in the file tree

GitOrigin-RevId: 4b4dcdcb1340e253d4cd2003280f67385975d664
 2023-05-31 08:04:59 +00:00
Miguel Serrano
51223315e4 Merge pull request #13164 from overleaf/msm-email-limit 
[web] limit user email addresses to 10

GitOrigin-RevId: 038214cc921d86a407391e6c82fa9cd16a7f9646
 2023-05-29 08:04:04 +00:00
M Fahru
c1211bef8f Remove node controller and dead backend code of the old project list (#12222) 
GitOrigin-RevId: 31f92b1df484db9e44ea17cd258fdc5fe467a379
 2023-05-26 08:05:10 +00:00
Tim Down
9ca81a72af Merge pull request #13218 from overleaf/td-history-update-change-list-tests 
History migration: Update change list fixtures to ensure file diff request happens

GitOrigin-RevId: 5ec7b4389bc4d7f1343f9e3d26c0bcb7e4585ab5
 2023-05-26 08:04:38 +00:00
Tim Down
66dc566752 Merge pull request #13039 from overleaf/td-history-auto-select-file-ignore-binary 
History migration: Ignore binary files when auto-selecting file to display in history view

GitOrigin-RevId: 7d2a314cdb3d54e4e2292a95e7633e3829ea931f
 2023-05-26 08:04:29 +00:00
Jimmy Domagala-Tang
76d0d82e74 Merge pull request #13027 from overleaf/jdt-personal-plan-split-test 
Personal plan split test

GitOrigin-RevId: 067973398c57be7466f6529f28fbfd896c86b10b
 2023-05-25 08:05:52 +00:00
Alf Eaton
5827c6f05c Merge pull request #13208 from overleaf/td-history-fix-change-list-test 
History migration: Skip change list tests temporarily

GitOrigin-RevId: 38cdc3c42c8eafbada75c83503afb523b5d93199
 2023-05-25 08:05:43 +00:00
Alf Eaton
510e686b7b Upgrade ESLint plugins (#13153) 
GitOrigin-RevId: 9cd0b4429a9c2b3df9c18957aef21ef021e5fdfd
 2023-05-25 08:05:34 +00:00
Alf Eaton
929e383ed5 Merge pull request #13151 from overleaf/ae-testing-library-upgrades 
Upgrade @testing-library dependencies

GitOrigin-RevId: d1be1cf58eccb5acdbac68ab48a31ab960ad72bc
 2023-05-25 08:05:15 +00:00
Alf Eaton
e0d327a3e8 Skip/improve flaky pdf tests (#13150) 
GitOrigin-RevId: a98b145e86f325d1df79bdbcd1825ee5a3ca6def
 2023-05-25 08:04:49 +00:00
Alf Eaton
6bae8fcdde Merge pull request #13149 from overleaf/ae-flaky-projects-test 
Skip flaky ProjectListRoot unit test

GitOrigin-RevId: f888555cbba2a27c493ce66a33bba3f0c6c9b814
 2023-05-25 08:04:40 +00:00
Tim Down
ccacd4cab7 History migration: Abort previous GET requests (#12893) 
GitOrigin-RevId: ad72d526bf7cdfa91b00025b58205d9a5b4cc62f
 2023-05-25 08:04:15 +00:00
Alf Eaton
a5378ebd49 Merge pull request #13175 from overleaf/msm-flaky-tests 
[web] replace clock.runAll() with clock.next() in flaky tests

GitOrigin-RevId: 62ea59315597d9ecd0e143418f65382644ed8345
 2023-05-25 08:04:07 +00:00
ilkin-overleaf
454f8f80c2 Merge pull request #13117 from overleaf/ii-history-react-changes-list-tests 
[web] Add changes list tests

GitOrigin-RevId: 5a4e1ea647d737dc761e4258002e6507c76e95a9
 2023-05-23 08:05:27 +00:00
Tim Down
fd8557ef39 Merge pull request #13159 from overleaf/td-history-comparison-text-icon-tweaks 
History migration: Icon and text changes to version comparison, switch order of from and to

GitOrigin-RevId: e31db255c55caf15481ed0237875e637c0ac0861
 2023-05-23 08:04:15 +00:00
Alf Eaton
4670c698ee Allow digits in PDF filenames (#13122) 
GitOrigin-RevId: 58c93d299c3bfe79dd4c223b8b060411bad078c7
 2023-05-18 08:03:55 +00:00
June Kelly
9d86affec4 Merge pull request #13124 from overleaf/jk-disable-flaky-test-again 
[web] disable flaky test with `fake-timers`, again

GitOrigin-RevId: e53afd52058666b14c55fbe91bc1ea7b55a87c1a
 2023-05-18 08:03:45 +00:00
Miguel Serrano
b2a0fd13e6 [web] Git Bridge modal with Personal Access Token (#13058) 
* [web] Git Bridge modal with Personal Access Token

* [web] Added `git-bridge-modal-tokens` unit tests

GitOrigin-RevId: 854ce83bba91b9d97afa950d49ce18f62970fb5b
 2023-05-17 09:28:10 +00:00
Miguel Serrano
27c2d1c16e [web] Personal Access Token Settings UI (#13040) 
* [web] Personal Access Token Settings UI

* [web] Add Personal Access Token Settings UI to settings page

* [web] Added `personal-access-token-settings` unit tests

GitOrigin-RevId: 353b2f1a2b57c3292554f129be6cbb4f8f8382f8
 2023-05-17 09:28:01 +00:00
June Kelly
db9e17bd47 Merge pull request #13110 from overleaf/jk-investigate-fake-timers-problem 
[web] Fix failing unit test involving `fake-timers`

GitOrigin-RevId: d166cc10079b9c4fa6d07525a9e6140e86b05fc9
 2023-05-17 09:27:53 +00:00
Mathias Jakobsen
988fc57574 Merge pull request #13077 from overleaf/mj-figure-modal-tests 
[web] Add cypress tests for figure modal

GitOrigin-RevId: 4debae1c665a68fd7bfa9f0dcfc150bec38a7c64
 2023-05-17 08:06:33 +00:00
Alf Eaton
c8a72e96d4 [cm6] Improve keyboard shortcuts for toggling line comments (#13067) 
GitOrigin-RevId: dd08778ea3621eefa75f306b2dada3f2c484f76c
 2023-05-17 08:05:28 +00:00
Alf Eaton
c8c17bca38 Allow all Unicode "letter" characters in PDF filename (#13071) 
GitOrigin-RevId: 030d7326b33525a34bccff26e12103e9a8e1a3f3
 2023-05-17 08:05:19 +00:00
Alf Eaton
7f795e4c8b Use content-disposition for setting the Content-Disposition header (#13072) 
GitOrigin-RevId: f84100beb5e00485be4732c954b5ee553fe18558
 2023-05-17 08:05:10 +00:00
June Kelly
4d69861daf Merge pull request #13102 from overleaf/jk-temporary-skip-tpds-unit-test 
[web] Temporarily skip failing test in web/tpds

GitOrigin-RevId: 9a5f2b9ff43d18eff43bc3f5123f99aff07863e3
 2023-05-17 08:04:15 +00:00
June Kelly
6c2bc2fe8b Merge pull request #13068 from overleaf/td-history-renamed-file-auto-select 
History migration: Fix bug that prevents renamed files being automatically selected

GitOrigin-RevId: ce127b218d1eb472fe7b35467a17549f3db4bfb7
 2023-05-17 08:03:58 +00:00
June Kelly
ff4ac0a803 Merge pull request #12851 from overleaf/jk-dashboard-filter-visibility 
[web] Improve filter visibility on project dashboard

GitOrigin-RevId: de7a9f999d6d0164ab3c18c58e305c7c628f946c
 2023-05-17 08:03:39 +00:00
Jakob Ackermann
21950fdb30 Merge pull request #13091 from overleaf/jpa-metric-blg 
[web] add metric for blg file usage

GitOrigin-RevId: 5a6bd4185d5f236a56994331cfe3b25c1998d0db
 2023-05-16 08:05:38 +00:00
Jakob Ackermann
915914840a Merge pull request #13083 from overleaf/ds-jpa-project-ownership-change 
[web] let invited admins transfer ownership of projects

GitOrigin-RevId: 49da7d42bec089f2278bde8942a63e5538fb5401
 2023-05-16 08:05:22 +00:00
Eric Mc Sween
1117bfae20 Merge pull request #13023 from overleaf/em-delete-git-bridge-data 
Delete git bridge data when a project is expired

GitOrigin-RevId: a600941831af31ff7712d44e437936cd416fc644
 2023-05-16 08:05:07 +00:00
Mathias Jakobsen
31190b967b [cm6] Add figure modal (#12751) 
GitOrigin-RevId: 3043d1369ed85b38b1fec7479385b123a304c05b
 2023-05-16 08:04:02 +00:00
Brian Gough
e46567b696 Merge pull request #12195 from overleaf/bg-use-glob-ignore 
Change ignored file matching to use standard `minimatch` module

GitOrigin-RevId: ef8f13c039015e7bb9894441fb6170703941653c
 2023-05-16 08:03:53 +00:00
Alf Eaton
ea996582bf [cm6] Improve begin environment autocompletion (#12982) 
GitOrigin-RevId: 42731e6f2261f7ed9b85523a550c636968698fc3
 2023-05-11 08:05:37 +00:00
Alf Eaton
466011df86 [cm6] Account for line shifts when updating the spelling line tracker (#13015) 
* Use lineShift

* Use fromA instead of fromB

* Only check the update doc

* Always use oldDoc

* Copy tests

GitOrigin-RevId: 05e5516b09ee4a25d8ac2b5f2994a034f35c9e82
 2023-05-11 08:04:48 +00:00
Tim Down
f8a2d85126 Merge pull request #12917 from overleaf/td-history-highlight-tooltip-improvements 
History migration: Rework change marker tooltips to match Angular version behaviour

GitOrigin-RevId: c34e42db6c310521d04690de41f3bb81c219bfbc
 2023-05-10 08:04:18 +00:00
Eric Mc Sween
9528eab43e Merge pull request #13000 from overleaf/em-revert-delete-git-bridge-data 
Revert "Delete git bridge data when a project is expired"

GitOrigin-RevId: a8674e040c9ccce3937b6ce244a82cd190c32c97
 2023-05-09 08:05:17 +00:00
Eric Mc Sween
264bacab10 Merge pull request #12840 from overleaf/em-expire-project-git-bridge 
Delete git bridge data when a project is expired

GitOrigin-RevId: 2f26af2f946ffd8c09f530a7eaadb37522d24a50
 2023-05-09 08:05:00 +00:00
Miguel Serrano
c2dce961b9 Merge pull request #12901 from overleaf/msm-oauth-token-flags 
[web] Feature flags for Personal Access Tokens

GitOrigin-RevId: cb359b7c41d8875ebae7d78a8839528bc4adc04c
 2023-05-08 08:04:55 +00:00
Tim Down
a0e3379c86 Merge pull request #12939 from overleaf/td-history-more-update-scroll-amount 
History migration: More update button scrolls next change to the centre

GitOrigin-RevId: 29d41a046f7110c246a0b9c784dedf6b148ea298
 2023-05-05 08:04:53 +00:00
Jakob Ackermann
b0633b3a47 Merge pull request #12842 from overleaf/jpa-logout 
[web] remove GET /logout endpoints

GitOrigin-RevId: 93f9498fdb66ece5028d90941aac50cda2737604
 2023-05-04 08:05:57 +00:00
Alf Eaton
6c21f0821c [cm6] Handle multiple selection ranges when applying snippets (#12830) 
* Use fork of @codemirror/autocomplete
* Handle multiple selection ranges when applying snippets

GitOrigin-RevId: 04afc087ac127206463ea3d4950284a50308364a
 2023-05-04 08:04:39 +00:00
Tim Down
da916c9c13 Merge pull request #12906 from overleaf/td-history-fix-labels-test 
Expect correct number of labels in history version list test

GitOrigin-RevId: 2a56b21c7359aad5111a2a7879f31fb5e7c6b73d
 2023-05-02 19:45:40 +00:00
Tim Down
70bae34bd8 Add paywall to React history view (#12849) 
* Implement history view paywall

* Add tests and some CSS fallbacks

* Make additional faded version above paywall non-clickable

* Change isFaded to faded for consistency

* Remove unused import

* Add missing attribute

* SHow all labels in free tier

* Address review comments

* Change Boolean conversion

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* Make adding or deleting a label show up in version list again

* Refactor to use visibleUpdateCount rather than maintaining two separate update arrays

* Removed unused import

* Use data-testid instead on class

* Round gradient values

* Correct test selector

---------

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
GitOrigin-RevId: a2b021f3f4d3b9eb1358edb2ee4aa7db1bc7240e
 2023-05-02 19:44:39 +00:00
June Kelly
e89b4b4214 Merge pull request #12811 from overleaf/jk-plans-event-currency-segmentation 
[web] Add currency/id segmentation to Recurly analytics events

GitOrigin-RevId: 56998f403358d5f6b3cece6835e16e65e06635b1
 2023-05-02 19:44:24 +00:00
Brian Gough
1da76f0a8d Merge pull request #12848 from overleaf/bg-fix-path-exception 
add exception handling for  path.join in ProjectEntityHandler

GitOrigin-RevId: dad305057fd6b2821525ca5b6d1933824989e241
 2023-05-02 19:43:50 +00:00
Alf Eaton
e0d9069131 [cm6] Add "within selection" option to the search form (#12798) 
* Use forked @codemirror/search
* Use getPanel to get the search panel
* Remove layer-based highlightSelectionMatches
* Add "within selection" option to the search form
* Add test for "replace all within selection"
* Fix tests

GitOrigin-RevId: 95ce76fd017f96278b04c16a1fd34f785f7504a3
 2023-05-01 08:05:02 +00:00
Alf Eaton
1da94f029c [cm6] Avoid selecting a search match when re-opening the search panel (#12797) 
GitOrigin-RevId: 32bb03b71ce56cc0dbe6f7c92cc6d85151ef1971
 2023-05-01 08:04:36 +00:00
M Fahru
0648b8aa6c Implement deleted file restore for history react (#12753) 
* Add strikethrough to deleted file tree item in history file tree

* Add "restore file" button on toolbar if the selected file have a `removed` operation.

* Implement "restore file" functionality on removed file:

- Refactor the `Selection` object in history context value since we need the `deletedAtV` data which currently is not passed through the state.
- Refactor and clean up file tree type system to support passing through the whole `FileDiff` object for getting the `deletedAtV` data which only appear on `removed` operation
- Implement `postJSON` with file restoration API and pass it on restore file onClick handler at toolbar

* Implement loading behaviour while restoring file is inflight:

- Add `loadingRestoreFile` to `LoadingState`
- Change restore file button to `Restoring...` when in loading state.

* Refactor:

- Rename `DiffOperation` to `FileOperation`
- Extract `isFileRemoved` and `isFileRenamed` to its own file
- Extract `Toolbar` components into small files

GitOrigin-RevId: 2e32ebd2165f73fc6533ff282a9c084162efd682
 2023-04-28 08:04:59 +00:00
Jessica Lawshe
0de648eecd Merge pull request #12774 from overleaf/ds-em-mongo-secondary-db-fix 
Bug fix - Mongo DB secondary preference

GitOrigin-RevId: d9adc0a7e1ee5085b34c5c1ddfdc715967607fc3
 2023-04-28 08:04:51 +00:00
Jessica Lawshe
8be17cdb37 Merge pull request #12819 from overleaf/jpa-institutions-lookup 
[web] migrate /institutions/ proxies to explicit V1 requests

GitOrigin-RevId: 535da280a6350dacbe2c957d2f2cedaeee02a48a
 2023-04-28 08:04:34 +00:00
ilkin-overleaf
0895e33235 Merge pull request #12773 from overleaf/ii-history-react-changes-list-dropdown 
[web] Actions dropdown history migration

GitOrigin-RevId: 6b7055501c5eb1529b1794db92bb9f5f3faa6648
 2023-04-26 08:05:24 +00:00
June Kelly
f5740e6b17 Merge pull request #12593 from overleaf/jk-remove-plans-split-test 
[web] Remove 'plans-page-layout-v3' split test

GitOrigin-RevId: 91e0d3d8bc40632df630131b2e872fa824015da5
 2023-04-26 08:04:21 +00:00
Tim Down
afd1195902 Add infinite scrolling to history versions list (#12752) 
* Add infinite scrolling to change list, add spinner while doing initial updates load, refactor updates state

* Update type in tests

* Update types

* Using LoadingSpinner component

* Remove redundant imports

GitOrigin-RevId: 98c7eae8edbc4d10d7107d825045edfc4159494f
 2023-04-25 08:06:22 +00:00
Tim Down
bf076a8c97 Merge pull request #12721 from overleaf/td-history-improve-diff-highlight 
Add markers for addition and deletion on empty lines in history diff

GitOrigin-RevId: 62e329da8bc055ee922854b837fe9465d724402e
 2023-04-25 08:06:14 +00:00
Alf Eaton
acf6abb0fb [cm6] Use a block widget for padding at the top of the editor (#12705) 
GitOrigin-RevId: 000ce9c90ea6b2ca72ab969704354a19fcea7a87
 2023-04-25 08:04:53 +00:00
M Fahru
4dec157e08 Implement history react toolbar UI (#12530) 
There are two different UI in this PR: `comparing` and `viewing` mode.

- For `comparing`, the user would be shown two separate date. It uses the `UpdateRange` object and this PR adds a timestamp to both `fromV` and `toV` of the object type.
- For `viewing`, the user would only be shown one date since `viewing` mode means viewing a specific update version.

Some other notable changes:

- Move `diff` state to `diff-view.tsx`, which contains `main.tsx` (main editor history view) and `toolbar.tsx` as its children
- refactor `autoSelectFile` by passing `updateRange.toV` directly
- refactor `updateIsSelected` by passing an object that contains `fromV` and `toV` instead of passing `update

There's also a cypress test for both the `viewing` mode and `comparing` mode in this PR.

GitOrigin-RevId: ba54f073f3479c55a39eb6b2932ea7faff78dddc
 2023-04-21 08:03:39 +00:00
Mathias Jakobsen
462837b44d Merge pull request #12701 from overleaf/dk-cm6-autocomplete-item-space 
[cm6] Add space after item autocomplete

GitOrigin-RevId: 6fff77c0c0563530af981bbac73b1d88e02bb759
 2023-04-21 08:03:08 +00:00
Rebeka Dekany
df300b5f24 Fix: Chat messages deduplication (#12667) 
* Prevent the duplicated message IDs by filtering them out

* fix: Prevent the duplicated message IDs by filtering them out

GitOrigin-RevId: 6d6c2821e6e29c9949fd323fa3a507016b51aff4
 2023-04-19 08:03:31 +00:00
Tim Down
5f5e07a334 Merge pull request #12668 from overleaf/td-history-scroll-to-first-change 
Scroll to first change in history document diff viewer

GitOrigin-RevId: e135877ca440c5eb2732890e8723d9098444727f
 2023-04-19 08:03:28 +00:00
Tim Down
99e1ff0804 Merge pull request #12644 from overleaf/td-history-compare 
Initial implementation of comparing history versions

GitOrigin-RevId: 890e270d6e41856a79689ab41ccfbde25c4703ba
 2023-04-19 08:03:25 +00:00
Eric Mc Sween
5b804ceefd Merge pull request #12654 from overleaf/em-td-upload-filename-encoding 
Fix filename encoding of project and file uploads

GitOrigin-RevId: e718c8f8f376772ee13c50c82d26848977e16eef
 2023-04-19 08:03:13 +00:00
Alf Eaton
f205d1f31d Merge pull request #12621 from overleaf/ii-history-react-delete-labels 
[web] Delete history tags

GitOrigin-RevId: 0a2846bbb3e99ef632b9192a9f8c04f702645506
 2023-04-19 08:02:47 +00:00
Tim Down
23b9c078b8 Merge pull request #12636 from overleaf/td-history-autoselect-file 
Simplify file autoselect in React history view

GitOrigin-RevId: 43f070b26ab0a75af13063712b5cf05778da4064
 2023-04-17 08:05:49 +00:00
Tim Down
38998afa8e Implement history diff viewer buttons (#12439) 
GitOrigin-RevId: 0ed8eb8568783b4938188a86c4ee75c767e6d713
 2023-04-17 08:05:41 +00:00
Mathias Jakobsen
73191f56e1 [cm6+rt] Make formatting commands work after UnknownCommands without arguments (#12625) 
GitOrigin-RevId: 0eb59e6580d6f217c46424ede0fa6f79c8786940
 2023-04-17 08:05:16 +00:00
Alf Eaton
e09a5f3adf Assert that the Rich Text document is ready before continuing with Cypress tests (#12612) 
GitOrigin-RevId: fb0755200366e1129ee86ba9a439210ffe64e205
 2023-04-17 08:04:59 +00:00
Alf Eaton
359255b820 [cm6] Use a modified fork of the closeBrackets extension (#12573) 
GitOrigin-RevId: a24020ed216cb10defff989f5876666c29889de2
 2023-04-17 08:04:43 +00:00
Jakob Ackermann
1096c81f4a Merge pull request #12528 from overleaf/jpa-switch-dashboard-events-to-bq 
[web] switch events on project dashboard to BQ

GitOrigin-RevId: 9326c19cc5663c4dc2919877eb8df91e312bb902
 2023-04-14 08:03:12 +00:00
Jakob Ackermann
c35da85ad8 Merge pull request #12526 from overleaf/jpa-delete-redundant-assignment 
[web] delete redundant variable assignment in tests

GitOrigin-RevId: 2876e217eb21a886dc2c8b251b7208de1b5ea349
 2023-04-14 08:03:09 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457) 
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
 2023-04-13 08:40:56 +00:00
Alexandre Bourdin
f03b75e55f [web] Tags/color picker tweaks (#12595) 
* Change wording of tags header and hide uncategorized when tags list is empty

* Add a tooltip on the colour picker more button

* Fix linting

GitOrigin-RevId: 07e1c411c2c9f6f66e0a00c1610af662b829c4e4
 2023-04-13 08:04:37 +00:00
Alexandre Bourdin
376d9c43a3 Merge pull request #12374 from overleaf/ab-rename-folders-tags 
[web] Rename folders to tags

GitOrigin-RevId: 05c34c515aeeb9230ed512c267f97bcb679767a8
 2023-04-13 08:04:20 +00:00
Alexandre Bourdin
04c204f989 [web] Colour picker for tags (#12255) 
* Base for color picker

* React color picker and updated modals

* Add tag color picker to mobile dashboard

* Update existing tests and fix disable save button condition

* CSS adaptations for desktop modal streched into mobile display

* Update TagsController tests

* Add aria-hidden label on color pickers

* Fix linting

* Fix project list test

* Select random color when creating tag

* Cleanup leftovers in project list context

* Test cleanup

* Pre-select custom color and store local color while picking

* Add type to preset colors

* Add css fix to override disabled button opacity

* Skip redundant check

* Fix linting

* Add back btn-secondary on manage tag modal after rebase

GitOrigin-RevId: a4cf24e85cc0ca01466f4bf9c77482be8360e68e
 2023-04-13 08:04:03 +00:00
M Fahru
fb6746a887 Add default pathname logic on history react file tree (#12505) 
On history react, when the initial screen has been loaded, no default pathname is selected. This PR adds logic for selecting default pathname and getting the diff for that pathname.

Also, add some other small changes, the notable ones are:

- Refactor some type naming and file structure related to the history file tree
- Refactor file tree selectable hooks (merge selectable context provider into the main provider)
- prevent clicking on the same file tree item by checking the current pathname before invoking the handler function

GitOrigin-RevId: 73c36e9ed918ae3d92dd47108fbe8542a7571bdd
 2023-04-12 08:04:58 +00:00
June Kelly
e780a09a15 Merge pull request #12473 from overleaf/ab-server-pro-split-test-overrides 
[web] Add split test overrides through settings for non-SaaS env

GitOrigin-RevId: 82cb6a573a992e730107f6287e7804cfe0f04aa5
 2023-04-12 08:04:37 +00:00
June Kelly
841df71a1d Merge pull request #12342 from overleaf/jk-password-ux-please-use-another-password 
[web] Password UX: 'Please use another password'

GitOrigin-RevId: ca9b26cbcf2dabb27c716da314764ee40ffc83dd
 2023-04-12 08:04:13 +00:00
ilkin-overleaf
867b37b76f Merge pull request #12417 from overleaf/ii-history-react-toggle-switch 
[web] Toggle switch history migration

GitOrigin-RevId: c0812d03d576bc66dd8878fa80d4ac18dd8576d0
 2023-03-30 08:04:22 +00:00
Alf Eaton
4c9c0641b2 Avoid reading some variables directly from window (#12280) 
GitOrigin-RevId: 93af19498470fd7903db9d55d7468f0298097cc4
 2023-03-30 08:03:32 +00:00
Tim Down
e76bcbec8d Merge pull request #12316 from overleaf/td-history-view-shell-and-split-test 
Add empty shell for React history view, viewable based on split test

GitOrigin-RevId: 97241d56a052648c7a0d293d323dad4b00ad4159
 2023-03-23 09:04:38 +00:00
June Kelly
a140e3dc8c Merge pull request #12269 from overleaf/jk-enable-password-similarity-check 
[web] Enforce password similarity check

GitOrigin-RevId: 1bc4efebba401663c1db9d209dc560560f160ce0
 2023-03-23 09:04:12 +00:00
Eric Mc Sween
21971956b7 Merge pull request #12219 from overleaf/em-camel-case-web 
Camel case variables in web

GitOrigin-RevId: 28e61b759b27f71265f33ab64f588374dba610e0
 2023-03-22 09:05:04 +00:00
Jakob Ackermann
03f45c02c3 Merge pull request #12276 from overleaf/jpa-batched-update-window 
[web] add time based window queries to batchedUpdate

GitOrigin-RevId: e56c01b888cd9749f39d42b77de09bc3fe2d0ec1
 2023-03-22 09:04:09 +00:00
Jakob Ackermann
e6a8f3d04f Merge pull request #12297 from overleaf/jpa-primary-email-check-saas 
[web] disable primary email check in Server CE/Pro

GitOrigin-RevId: be40160aecae7f19780a67e5cdd9356be232ee22
 2023-03-21 09:05:45 +00:00
ilkin-overleaf
122d2310e6 Merge pull request #12278 from overleaf/ii-change-email-confirmation 
[web] Show confirmation modal when making an email primary

GitOrigin-RevId: eb67fc37c18a5ecd59973baa27ee9ef8e4b67423
 2023-03-21 09:04:23 +00:00
Jakob Ackermann
ccb0841a50 Merge pull request #12281 from overleaf/jpa-tweak-event-segmentation-filter 
[web] tweak analytics event segmentation filter

GitOrigin-RevId: e00fef0ac74edfd7fbace33bf9289f1c6f905b57
 2023-03-20 09:03:16 +00:00
June Kelly
556a557a04 Merge pull request #12261 from overleaf/jk-alter-password-similarity 
[web] Alter password-similarity check/metric

GitOrigin-RevId: e9a55b4a86d2b69d6f34c1e2339d32321e08341d
 2023-03-20 09:03:10 +00:00
Alf Eaton
f375362894 Always use mockable location methods (#11929) 
* Always use mockable location methods
* Add eslint rules for window.location calls/assignment
* Add useLocation hook
* Update tests

GitOrigin-RevId: eafb846db89f884a7a9a8570cce7745be605152c
 2023-03-17 09:05:21 +00:00
Jakob Ackermann
df3c7e48ab Merge pull request #12198 from overleaf/jpa-force-new-compile-domain 
[web] changes for force-new-compile-domain test

GitOrigin-RevId: a4ceaf46fdcebed156d155385cbbc2f06405d31f
 2023-03-17 09:04:49 +00:00
Jakob Ackermann
223b8aa9d8 Merge pull request #12250 from overleaf/ii-add-new-email-blocklist 
[web] Prevent Blocklisted domains from appearing as suggestion

GitOrigin-RevId: b02bebe3e043cb264fbdbffce3f783b3af483e95
 2023-03-17 09:04:33 +00:00
Jakob Ackermann
fa5804a3cf Merge pull request #12254 from overleaf/jpa-back-fill-doc-rev 
[web] add script for back filling rev=1 for old (deleted) docs

GitOrigin-RevId: 62f5b773fb83ddbf9bb202a592ce2e8f33b5e6b2
 2023-03-17 09:03:58 +00:00
Alf Eaton
390d7ed005 Merge pull request #12176 from overleaf/ae-syntex-tests 
Improve synctex Cypress tests

GitOrigin-RevId: 282d26d344d8ae08f52b18ef4c12a4c311a6b7ff
 2023-03-14 09:04:14 +00:00
Mathias Jakobsen
89ce4757fa [web] Update commons notifications (#12149) 
GitOrigin-RevId: 0a39ce64c34467cd3a2c3304c2aba5e8bea64956
 2023-03-14 09:03:57 +00:00
Thomas
5dc15a19de Merge pull request #12083 from overleaf/tm-teardown-refreshed-payment-page 
Tear down refreshed payment page test, keeping refreshed page

GitOrigin-RevId: 4f0d9a1f4bcd3b018b12372fbe86aad3c8e41fbd
 2023-03-10 09:04:18 +00:00
Jessica Lawshe
b10b7b1f91 Merge pull request #12042 from overleaf/jel-change-plan 
[web] Change plan UI now in a modal and update the style

GitOrigin-RevId: 1b501b4a972ca676cff32f531862c15c0c8f9e61
 2023-03-09 09:05:05 +00:00
M Fahru
8bd1026abd Rename projectListReactPage to projectListPage in project list controller. (#12130) 
This is because the controller's function was already renamed in another commit but the tests were not renamed.

GitOrigin-RevId: fb2e016999417aeb95a68f7cd37f0c55035f2a53
 2023-03-07 09:06:11 +00:00
M Fahru
27723b7878 Migrate node controller unit test to the react version of the project dashboard controller (#11993) 
* Migrate node controller unit test to the react version of the project dashboard controller

* change `promise.race` behaviour when fetching initial project list data to use setTimeout with 0ms delay (fake delay)

* rename `this.collabertions` to `this.readAndWrite`

* Change IP matcher to use `await` and `try` + `catch` block to be able to correctly write the test for

GitOrigin-RevId: 72ad9263c099b7ba44dede8304dba1c5ba879b56
 2023-03-07 09:05:56 +00:00
M Fahru
01c504109b Make project list react as the default in main router (#12047) 
* Make project list react as the default in the main router

* Remove angular controller check-in project list smoke test

GitOrigin-RevId: 586a14afd9888d6f18e3cfa64aeebc5975bb43d5
 2023-03-07 09:05:39 +00:00
Alf Eaton
488c6ff919 Improve compile request mocking in Cypress tests (#12095) 
GitOrigin-RevId: fdbc53148e5437e451dab4889232923c823d649e
 2023-03-07 09:05:25 +00:00
Jakob Ackermann
e0c84f08fb Merge pull request #11940 from overleaf/jpa-fix-assignment-of-initial-clsi-vm 
[web] fix assignment of initial compile server

GitOrigin-RevId: 84aea918946a106a5826d7cf39cc0bf47047cb35
 2023-03-07 09:04:33 +00:00
ilkin-overleaf
8616c53839 Merge pull request #12031 from overleaf/ii-payment-page-migration-three-d-secure-currency-change 
[web] 3DS currency change fix

GitOrigin-RevId: e88c773c6576e55803df3b2ec6a6acb1df80e8f2
 2023-03-02 09:04:13 +00:00
ilkin-overleaf
48587a7a62 Merge pull request #12007 from overleaf/ii-react-subscription-dash-thank-you 
[web] Successful subscription react migration

GitOrigin-RevId: 1d7d849415f4b7a7f60ddf8a4e18570ff5142196
 2023-03-02 09:04:04 +00:00
Eric Mc Sween
65976cb363 Merge pull request #11869 from overleaf/em-upgrade-mongoose-web 
Upgrade Mongoose and the Mongo driver in web

GitOrigin-RevId: 2cad1aabe57eae424a9e4c68b2e0062f0e78ffaf
 2023-03-01 09:03:27 +00:00
ilkin-overleaf
076bc9b39c Merge pull request #11872 from overleaf/ii-payment-page-tests 
[web] Payment page tests

GitOrigin-RevId: 0ab9a75c13f1833cbdf7aa71ffe3ab66174ca773
 2023-03-01 09:03:22 +00:00
ilkin-overleaf
612728d300 Merge pull request #11963 from overleaf/ii-react-subscription-dash-reactivate-subscription 
[web] Subscription dash reactivate button react migration

GitOrigin-RevId: dde8dd1abb8979bdf90d71ea07e1336e9af491b3
 2023-03-01 09:03:17 +00:00
ilkin-overleaf
fed5ad87a1 Merge pull request #11965 from overleaf/lg-deleteFeedback 
[web] Delete user data from feedbacks collection when user is deleted

GitOrigin-RevId: 39a98cffb2e42c261c7095d8937fb6cdaf0977f9
 2023-03-01 09:03:05 +00:00
ilkin-overleaf
38cdd77890 Merge pull request #11943 from overleaf/jk-another-password-similarity-metric 
[web] Add another metric for password similarity

GitOrigin-RevId: 6d44796a63f3be85bfee86056e03cfd3bb47066c
 2023-03-01 09:03:02 +00:00
ilkin-overleaf
eb32081585 Merge pull request #11974 from overleaf/jk-catch-errors-in-rename-file 
[web] add logging to catch an error in renameEntity

GitOrigin-RevId: 74a942e87150a4fa94f7b1b46732de3df8b36389
 2023-03-01 09:02:56 +00:00
ilkin-overleaf
41a706108c Merge pull request #11941 from overleaf/ii-recompile-tooltip 
[web] Recompile tooltip fix

GitOrigin-RevId: da3282b9da0133f5b6ec84c4453bd6ab19b739af
 2023-03-01 09:02:53 +00:00
ilkin-overleaf
9f95c7c2ab Merge pull request #11919 from overleaf/ii-react-subscription-dash-user-email-not-matching-recurly-email 
[web] Subscription dash user email not matching recurly email section - react migration

GitOrigin-RevId: 8d89dbc804694afffea2a92cebdeb5d4e9389810
 2023-03-01 09:02:47 +00:00
Thomas
16b2d27fde Update B2B Groups and Enterprise banners (#11989) 
* Tear down B2B banner ad split test and implement updated ads

GitOrigin-RevId: 7d09d54bef7cb4e2b2b597d3834e0f58551b179e
 2023-02-28 09:04:31 +00:00
Jessica Lawshe
7469f01acd Merge pull request #11981 from overleaf/jel-downgrade-when-cancel 
[web] Migrate downgrade plan option when cancelling in React subscription dash

GitOrigin-RevId: 11a4b39deb58493f3f56e65e8760d71527a8e8fc
 2023-02-28 09:03:54 +00:00
Jessica Lawshe
68e61d7bb7 Merge pull request #11973 from overleaf/ii-react-canceled-subscription 
[web] Subscription page canceled subscription react migration

GitOrigin-RevId: dd127d753e72c194cd6bbb90b1ca1557742896d9
 2023-02-24 09:05:28 +00:00
Jessica Lawshe
0037e45740 Merge pull request #11970 from overleaf/ab-sub-dash-already-have-warning 
[web] Display a warning on subscription dash when coming from plans page

GitOrigin-RevId: 6c6294fbf634a5dcd1a09b94538add6586ebd15b
 2023-02-24 09:05:20 +00:00
Jessica Lawshe
ebc04e4a9d Merge pull request #11888 from overleaf/jel-subscription-dash-cancel-plan 
[web] Migrate cancel subscription to React

GitOrigin-RevId: 8482fd61894c8011b4c980263ae1d41f396233c6
 2023-02-24 09:05:12 +00:00
Alexandre Bourdin
d2fb800174 Merge pull request #11885 from overleaf/ab-personal-sub-custom-react 
[web] Display a message for custom personal subscriptions in React dash

GitOrigin-RevId: c70986ffacfdfdeccd3675385e2e5dba1a2ad61f
 2023-02-23 09:05:13 +00:00
Alexandre Bourdin
8b00a496e7 Merge pull request #11881 from overleaf/ab-custom-subscription-react-dash 
[web] Add a contact support message for custom subsbcriptions on React dash

GitOrigin-RevId: e2a2bb27b4f1e70cbbe62f4c837fe63d81a820c2
 2023-02-23 09:05:05 +00:00
Alexandre Bourdin
f86eeac522 Merge pull request #11862 from overleaf/ab-group-subscription-memberships-dash-react 
[web] Migrate group subscription memberships to React dash

GitOrigin-RevId: d5ff3ae4e5d8c422530502af22edda6c24c9a593
 2023-02-23 09:04:49 +00:00
Alexandre Bourdin
a928fd20e6 Merge pull request #11906 from overleaf/ii-react-subscription-dash-active-coupons 
[web] Subscription dash show active coupons react migration

GitOrigin-RevId: 7a63505b31d828491b6ea812482376882354b4ee
 2023-02-23 09:04:13 +00:00
Alexandre Bourdin
d6e9508aed [web] Migrate managed publishers to React dash (#11749) 
* Migrate managed publishers to React dash

* Decaf cleanup + async/await PublishersGetter

* Continue migration of managed publishers to react dash

* Fix linting

* Add tests

* Decaf cleanup PublishersGetterTests

* Update PublishersGetter tests

* Rename component files to kebab-case

GitOrigin-RevId: cb1fe14d120457c965a9d23a8ddb2c2c92e1d5da
 2023-02-23 09:04:03 +00:00
Jessica Lawshe
89ef1681e8 Merge pull request #11844 from overleaf/jel-subscription-dash-change-to-group-submit 
[web] Submit group plan change on subscription dash

GitOrigin-RevId: 5bc2644351c80189774ad3ac4cdcd622d354770f
 2023-02-22 09:05:21 +00:00
Jessica Lawshe
124306d7ac Merge pull request #11819 from overleaf/jel-subscription-dash-change-to-group-prices 
[web] Show price in change to group plan modal on React subscription dash

GitOrigin-RevId: 6a1a4be3a7d008cd9e26186c2d97bc0bdc2f82ed
 2023-02-22 09:05:13 +00:00
Jessica Lawshe
cad3660f0b Merge pull request #11839 from overleaf/jel-subscription-dash-change-to-group-pt2 
[web] Continue change to group plan via React subscription dash

GitOrigin-RevId: b7e743f18e40383ecc1dbf02914f663ff0bc1846
 2023-02-22 09:05:05 +00:00
Jessica Lawshe
b2a10260be Merge pull request #11773 from overleaf/jel-subscription-dash-change-to-group 
[web] Begin change to group plan via React subscription dash

GitOrigin-RevId: 3f0f2820ab18ecc8337746282295302d7951c56f
 2023-02-22 09:04:56 +00:00
M Fahru
b62cb86bf8 Create new SplitMenu component and implement it for the pdf compile button (detached & non-detached) (#11772) 
* Create a new shared `SplitMenu` component.

* Refactor the pdf compile button & detached compile button:
    - Rename `detach-compile-button` to `detach-compile-button-wrapper`
    - Rename `pdf-compile-button-inner` to `detach-compile-button`
    - Move some of the logic from `detach-compile-button-wrapper` to `detach-compile-button`
    - Create a new `compile-button.less` to centralize all of the compile button (detached/non-detached) custom styles rule.
    - Extract the animated striped CSS definition to the dedicated CSS file, change the class from `btn-recompile-group-has-changes` to `btn-striped-animated`
    - Refactor other className(s) appropriately according to the new component name
    - Delete the unused `changes-to-autocompile` css rule since it has not been used anywhere

* Implement the new pdf compile button with the new `SplitMenu` component.

GitOrigin-RevId: d1d055bffd311923fc47b4681605ce8ba8e26f25
 2023-02-22 09:04:42 +00:00
Jessica Lawshe
d539aaf226 Merge pull request #11681 from overleaf/jel-confirm-subscription-change 
[web] Plan change request in subscription dash

GitOrigin-RevId: 9afe22b2da035f887c6fa9abe8129711d492108c
 2023-02-17 09:05:51 +00:00
Alf Eaton
6175df9f95 Show preview for PDF image (#11793) 
GitOrigin-RevId: 5c7dde42cdfcf9952e47487358f7e2b52658cc59
 2023-02-17 09:04:35 +00:00
Jakob Ackermann
3c9ace481d Merge pull request #11855 from overleaf/jpa-fix-config 
[web] fix access-token-encryptor config

GitOrigin-RevId: b16002159a3f0004e83ddb4b0cde3b33211184b3
 2023-02-17 09:04:00 +00:00
Jakob Ackermann
b6d5b97326 Merge pull request #11817 from overleaf/jk-password-too-similar-metric-refinement 
[web] Refine metrics on password-too-similar validation

GitOrigin-RevId: f644e50e4815b34ad9af5215ebc3c9a082572681
 2023-02-17 09:03:52 +00:00
Jakob Ackermann
dd906df7b7 Merge pull request #11360 from overleaf/jpa-encrypt-2fa-secret 
[web] two-factor-authentication: encrypt the secret in the db

GitOrigin-RevId: 86642e13d917b239012229f685ad0210039a6706
 2023-02-17 09:03:44 +00:00
Davinder Singh
c524fee690 Merge pull request #11694 from overleaf/ab-managed-institutions-react 
[web] Migrate managed institutions to React dash

GitOrigin-RevId: 535dfafe42d88189bb20e7bb3beac233221ee6ba
 2023-02-15 09:04:55 +00:00
June Kelly
53b78ad68b Merge pull request #11590 from overleaf/jk-password-reset-ux-improvements 
[web] Password Reset UX Improvements

GitOrigin-RevId: d62575ff965e045823bfb7268db892188cf709ed
 2023-02-10 16:33:14 +00:00
M Fahru
5f3ef71e43 Implement 'Add Affiliation' UI on the mobile version of the new react dashboard (#11606) 
* Refactor & change `add-affiliation.tsx` file:
    * Change class from `user-profile` to `add-affiliation`
    * Add new optional `className` props for custom styling

* Show affiliation widget on mobile screen:

* Fix bug on use add affiliation hooks: return type should be `boolean`, not `boolean | 0`

GitOrigin-RevId: 800b951e2a012797266b1780993b4ed9a918d565
 2023-02-08 09:07:23 +00:00
Jessica Lawshe
f3d055af86 Merge pull request #11619 from overleaf/jel-react-personal-subscription-dash-change-plan 
[web] Query display price data for change plan UI in React subscription dash

GitOrigin-RevId: e05779d1f289ee55a1b8be17b182905fca66e44f
 2023-02-08 09:06:44 +00:00
Jessica Lawshe
d4057a7bcc Merge pull request #11602 from overleaf/jel-react-personal-subscription-dash-pt-6 
[web] Continue migration of change plan UI to React

GitOrigin-RevId: 4f6176ac101ba3c57134cf5c86329e205f17ab23
 2023-02-08 09:06:37 +00:00
Jessica Lawshe
c7d8e4867d Merge pull request #11560 from overleaf/jel-react-personal-subscription-dash-pt-5 
[web] Continue migration of personal subscription dash to React

GitOrigin-RevId: fb327592ad5031bff20b2a95a83edee4735112e8
 2023-02-08 09:06:29 +00:00
Jessica Lawshe
c36b872ae3 Merge pull request #11509 from overleaf/jel-react-personal-subscription-dash-pt-4 
[web] Continue migration of personal subscription dash to React

GitOrigin-RevId: f2d913099d727725f04697003516c90616faf014
 2023-02-08 09:06:21 +00:00
Alexandre Bourdin
ed40a87cdc [web] Migrate group management to React (#11293) 
* Rename manage group entry point

* Migrate group management root page to React

* Add cypress tests for the group management react page

* Fix linting

* Add checkbox labels for screen-readers + remove unused classes

* Await on add/remove members calls

* Display the export CSV link for a full group

* Display error message when group is full

* Sort locales

* Handle the managers management page in React version

* Fix missing type in GroupMemberRow

* Split members and managers React pages

* Build API paths on frontend side + add cypress tests for each page

* Fix linting

* Update unit tests

* Review improvements

* Type API errors

GitOrigin-RevId: d124a9d24cbf33de8aacc5d69e9d46e7bcda93c5
 2023-02-07 09:04:18 +00:00
June Kelly
c4ecded316 Merge pull request #11508 from overleaf/jk-password-disallow-substring 
[web] Metric for passwords too similar to email

GitOrigin-RevId: cf8320fc3c9561b4dc6d54a3e97db96400ece2a9
 2023-02-02 18:22:17 +00:00
ilkin-overleaf
db54475bd0 Merge pull request #11525 from overleaf/ii-payment-page-migration-init 
[web] Payment page migration initialisation

GitOrigin-RevId: f33b73a13b96fad3cddf0c0205d05df678ce5300
 2023-02-02 18:21:52 +00:00
June Kelly
ac83dd9bb3 Merge pull request #11353 from overleaf/jk-remove-deprecated-public-access-levels 
[web] Disallow deprecated access levels from being set

GitOrigin-RevId: cf276e849692be210a2dc7d896820579efc46952
 2023-02-02 09:02:59 +00:00
June Kelly
be7b424a63 Merge pull request #11436 from overleaf/jk-increase-password-min-length-to-8 
[web] Increase the minimum password length to 8 characters

GitOrigin-RevId: 94eb3c5605183b5e189babd3342dc308f403ebbd
 2023-02-02 09:02:56 +00:00
Jessica Lawshe
df532c9737 Merge pull request #11494 from overleaf/jel-react-personal-subscription-dash-pt-3 
[web] Continue migration of personal subscription dash to React

GitOrigin-RevId: 412301dad0a04fa6e7b8712ad919c4f67d0bbfe2
 2023-02-01 09:05:35 +00:00
Jessica Lawshe
b7108f7874 Merge pull request #11515 from overleaf/ab-group-membership-dash-react 
[web] Managed groups in React subscription dash

GitOrigin-RevId: 4811d8dd2b42fa9ad83b5c4f12582e7bc04bad40
 2023-02-01 09:05:27 +00:00
M Fahru
78304e7c94 Add is-screen-width-less-than-768px to the upgrade-button-click event (#11506) 
GitOrigin-RevId: 33ae53d7959863017607d3e1ea237602aed626dc
 2023-01-31 09:04:09 +00:00
Eric Mc Sween
75abea72b0 Merge pull request #11492 from overleaf/em-rate-limiter 
Move all remaining rate limiters to rate-limiter-flexible

GitOrigin-RevId: 163ab2aebecb281057e552dc75591dd02028990c
 2023-01-31 09:03:44 +00:00
Mathias Jakobsen
a87d44ffdd [cm6+rt] Add cypress tests for atomic decorations (#11486) 
GitOrigin-RevId: c8bd264603dbb8eb5354d07f8d277010aeb9a2c0
 2023-01-27 12:03:53 +00:00
Eric Mc Sween
2dbc0e3b3d Merge pull request #11489 from overleaf/em-fix-paypal 
Set COOP header to same-origin-allow-popups

GitOrigin-RevId: c8c3751386addb307ee2caf59c228484e8e593c0
 2023-01-27 09:05:43 +00:00