github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #13558 from overleaf/ab-group-sync-check-user-id-format

Browse source 
[web/cron] Check that the userId is a valid mongo ID

GitOrigin-RevId: 0c5fce5c0e474ae9d8ad8683bccade2e0b74b0c7
This commit is contained in:
Alexandre Bourdin 2023-06-26 18:27:27 +03:00 committed by Copybot
parent 2ef48be496
commit ded4de3349
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/scripts/analytics/sync_group_subscription_memberships.js
View file

@ -7,6 +7,7 @@ const {
} = require('../../app/src/models/DeletedSubscription')
const minimist = require('minimist')
const _ = require('lodash')
const { ObjectId } = require('mongodb')
let FETCH_LIMIT, COMMIT, VERBOSE
@ -195,6 +196,10 @@ async function checkDeletedSubscriptionMemberships(
}
async function sendCorrectiveEvent(userId, event, subscription) {
if (!ObjectId.isValid(userId)) {
console.warn(`Skipping '${event}' for user ${userId}: invalid user ID`)
return
}
const segmentation = {
groupId: subscription._id.toString(),
subscriptionId: subscription.recurlySubscription_id,