From ded4de3349e59cfa4c223ae56e7348ee148c16f0 Mon Sep 17 00:00:00 2001
From: Alexandre Bourdin <abourdin@users.noreply.github.com>
Date: Mon, 26 Jun 2023 18:27:27 +0300
Subject: [PATCH] Merge pull request #13558 from
 overleaf/ab-group-sync-check-user-id-format

[web/cron] Check that the userId is a valid mongo ID

GitOrigin-RevId: 0c5fce5c0e474ae9d8ad8683bccade2e0b74b0c7
---
 .../scripts/analytics/sync_group_subscription_memberships.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/services/web/scripts/analytics/sync_group_subscription_memberships.js b/services/web/scripts/analytics/sync_group_subscription_memberships.js
index a7cf7eadc4..8249177dbb 100644
--- a/services/web/scripts/analytics/sync_group_subscription_memberships.js
+++ b/services/web/scripts/analytics/sync_group_subscription_memberships.js
@@ -7,6 +7,7 @@ const {
 } = require('../../app/src/models/DeletedSubscription')
 const minimist = require('minimist')
 const _ = require('lodash')
+const { ObjectId } = require('mongodb')
 
 let FETCH_LIMIT, COMMIT, VERBOSE
 
@@ -195,6 +196,10 @@ async function checkDeletedSubscriptionMemberships(
 }
 
 async function sendCorrectiveEvent(userId, event, subscription) {
+  if (!ObjectId.isValid(userId)) {
+    console.warn(`Skipping '${event}' for user ${userId}: invalid user ID`)
+    return
+  }
   const segmentation = {
     groupId: subscription._id.toString(),
     subscriptionId: subscription.recurlySubscription_id,