github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

added test to check compile should continue on error downloading http

Browse source 
resource

also improved logging
This commit is contained in:
Henry Oswald 2015-09-09 09:44:38 +01:00
parent 4b3aa933a3
commit d44cfb8614
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/clsi/app/coffee/ResourceWriter.coffee
View file

@ -58,7 +58,7 @@ module.exports = ResourceWriter =
if resource.url?
UrlCache.downloadUrlToFile project_id, resource.url, path, resource.modified, (err)->
if err?
logger.err err:err, "error downloading file for resources"
logger.err err:err, project_id:project_id, path:path, resource_url:resource.url, modified:resource.modified, "error downloading file for resources"
callback() #try and continue compiling even if http resource can not be downloaded at this time
else
fs.writeFile path, resource.content, callback

7
services/clsi/test/unit/coffee/ResourceWriterTests.coffee
View file

@ -1,6 +1,6 @@
SandboxedModule = require('sandboxed-module')
sinon = require('sinon')
require('chai').should()
should = require('chai').should()
modulePath = require('path').join __dirname, '../../../app/js/ResourceWriter'
path = require "path"
@ -94,7 +94,7 @@ describe "ResourceWriter", ->
path: "main.tex"
url: "http://www.example.com/main.tex"
modified: Date.now()
@UrlCache.downloadUrlToFile = sinon.stub().callsArg(4)
@UrlCache.downloadUrlToFile = sinon.stub().callsArgWith(4, "fake error downloading file")
@ResourceWriter._writeResourceToDisk(@project_id, @resource, @basePath, @callback)
it "should ensure the directory exists", ->
@ -110,6 +110,9 @@ describe "ResourceWriter", ->
it "should call the callback", ->
@callback.called.should.equal true
it "should not return an error if the resource writer errored", ->
should.not.exist @callback.args[0][0]
describe "with a content based resource", ->
beforeEach ->
@resource =