github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

don't error if a http resource can not be download

Browse source 
try and continue, log the error but you might still be able to
compile. prevents issue with badly uploaded images in filstore
This commit is contained in:
Henry Oswald 2015-09-08 21:58:27 +01:00
parent b3c030b3ed
commit 4b3aa933a3
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
services/clsi/app/coffee/ResourceWriter.coffee
View file

@ -5,6 +5,7 @@ async = require "async"
mkdirp = require "mkdirp"
OutputFileFinder = require "./OutputFileFinder"
Metrics = require "./Metrics"
logger = require "logger-sharelatex"
module.exports = ResourceWriter =
syncResourcesToDisk: (project_id, resources, basePath, callback = (error) ->) ->
@ -55,13 +56,10 @@ module.exports = ResourceWriter =
return callback(error) if error?
# TODO: Don't overwrite file if it hasn't been modified
if resource.url?
UrlCache.downloadUrlToFile(
project_id,
resource.url,
path,
resource.modified,
callback
)
UrlCache.downloadUrlToFile project_id, resource.url, path, resource.modified, (err)->
if err?
logger.err err:err, "error downloading file for resources"
callback() #try and continue compiling even if http resource can not be downloaded at this time
else
fs.writeFile path, resource.content, callback