github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-03-04 16:03:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #57 from sharelatex/bg-handle-undefined-project-name-with-error

Browse source 
avoid exception in validateProjectName
This commit is contained in:
Brian Gough 2017-10-18 13:10:45 +01:00 committed by GitHub
commit d0f0268783
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/app/coffee/Features/Project/ProjectDetailsHandler.coffee
View file

@ -57,7 +57,7 @@ module.exports = ProjectDetailsHandler =
MAX_PROJECT_NAME_LENGTH: 150
validateProjectName: (name, callback = (error) ->) ->
if name.length == 0
if !name? or name.length == 0
return callback(new Errors.InvalidNameError("Project name cannot be blank"))
else if name.length > @MAX_PROJECT_NAME_LENGTH
return callback(new Errors.InvalidNameError("Project name is too long"))

6
services/web/test/UnitTests/coffee/Project/ProjectDetailsHandlerTests.coffee
View file

@ -126,6 +126,12 @@ describe 'ProjectDetailsHandler', ->
done()
describe "validateProjectName", ->
it "should reject undefined names", (done) ->
@handler.validateProjectName undefined, (error) ->
expect(error).to.exist
done()
it "should reject empty names", (done) ->
@handler.validateProjectName "", (error) ->
expect(error).to.exist