From 8cf328818715ba7963eb6c121ef82c559b2e2aa0 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Thu, 12 Oct 2017 16:03:12 +0100 Subject: [PATCH] avoid exception in validateProjectName --- .../coffee/Features/Project/ProjectDetailsHandler.coffee | 2 +- .../coffee/Project/ProjectDetailsHandlerTests.coffee | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/services/web/app/coffee/Features/Project/ProjectDetailsHandler.coffee b/services/web/app/coffee/Features/Project/ProjectDetailsHandler.coffee index 5819e03472..09783c58c7 100644 --- a/services/web/app/coffee/Features/Project/ProjectDetailsHandler.coffee +++ b/services/web/app/coffee/Features/Project/ProjectDetailsHandler.coffee @@ -57,7 +57,7 @@ module.exports = ProjectDetailsHandler = MAX_PROJECT_NAME_LENGTH: 150 validateProjectName: (name, callback = (error) ->) -> - if name.length == 0 + if !name? or name.length == 0 return callback(new Errors.InvalidNameError("Project name cannot be blank")) else if name.length > @MAX_PROJECT_NAME_LENGTH return callback(new Errors.InvalidNameError("Project name is too long")) diff --git a/services/web/test/UnitTests/coffee/Project/ProjectDetailsHandlerTests.coffee b/services/web/test/UnitTests/coffee/Project/ProjectDetailsHandlerTests.coffee index abb0b505d0..8d2973e235 100644 --- a/services/web/test/UnitTests/coffee/Project/ProjectDetailsHandlerTests.coffee +++ b/services/web/test/UnitTests/coffee/Project/ProjectDetailsHandlerTests.coffee @@ -126,6 +126,12 @@ describe 'ProjectDetailsHandler', -> done() describe "validateProjectName", -> + + it "should reject undefined names", (done) -> + @handler.validateProjectName undefined, (error) -> + expect(error).to.exist + done() + it "should reject empty names", (done) -> @handler.validateProjectName "", (error) -> expect(error).to.exist