github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Tear down recompile button text split test (#11637)

Browse source 
GitOrigin-RevId: 574ebeda9517cc54e04362395a90584703198d9f
This commit is contained in:
M Fahru 2023-02-09 10:03:29 -07:00 committed by Copybot
parent 6da0a8ddf7
commit 9719b0439c
2 changed files with 3 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
services/web/app/src/Features/Project/ProjectController.js
View file

@ -48,10 +48,6 @@ const ProjectListController = require('./ProjectListController')
const ProjectAuditLogHandler = require('./ProjectAuditLogHandler')
const PublicAccessLevels = require('../Authorization/PublicAccessLevels')
// We want the recompile-button-text split test to only target users who have
// signed up recently.
const RECOMPILE_BUTTON_SPLIT_TEST_MIN_SIGNUP_DATE = new Date('2023-01-16')
/**
* @typedef {import("./types").GetProjectsRequest} GetProjectsRequest
* @typedef {import("./types").GetProjectsResponse} GetProjectsResponse
@ -1114,27 +1110,6 @@ const ProjectController = {
}
)
},
recompileButtonTextAssignment: [
'user',
(results, cb) => {
if (
results.user.signUpDate <
RECOMPILE_BUTTON_SPLIT_TEST_MIN_SIGNUP_DATE
) {
return cb()
}
SplitTestHandler.getAssignment(
req,
res,
'recompile-button-text',
{},
() => {
// do not fail editor load if assignment fails
cb()
}
)
},
],
},
(
err,

30
services/web/frontend/js/features/pdf-preview/components/pdf-compile-button-inner.tsx
View file

@ -1,11 +1,8 @@
import { Button } from 'react-bootstrap'
import PropTypes from 'prop-types'
import Tooltip from '../../../shared/components/tooltip'
import Icon from '../../../shared/components/icon'
import { useTranslation } from 'react-i18next'
import { memo, useCallback } from 'react'
import { useSplitTestContext } from '../../../shared/context/split-test-context'
import * as eventTracking from '../../../infrastructure/event-tracking'
import { memo } from 'react'
const modifierKey = /Mac/i.test(navigator.platform) ? 'Cmd' : 'Ctrl'
@ -20,28 +17,7 @@ function PdfCompileButtonInner({
}: PdfCompileButtonInnerProps) {
const { t } = useTranslation()
const { splitTestVariants } = useSplitTestContext({
splitTestVariants: PropTypes.object,
})
const recompileButtonTextVariant = splitTestVariants['recompile-button-text']
let compileButtonLabel
if (compiling) {
compileButtonLabel = t('compiling') + '…'
} else if (splitTestVariants['recompile-button-text'] === 'recompile-pdf') {
compileButtonLabel = t('recompile') + ' PDF'
} else {
compileButtonLabel = t('recompile')
}
const handleRecompileButtonClick = useCallback(() => {
if (recompileButtonTextVariant != null) {
// Only send the event when the user is targeted by the
// recompile-button-text split test
eventTracking.sendMB('recompile-pdf-clicked')
}
startCompile()
}, [recompileButtonTextVariant, startCompile])
const compileButtonLabel = compiling ? `${t('compiling')}…` : t('recompile')
return (
<Tooltip
@ -58,7 +34,7 @@ function PdfCompileButtonInner({
<Button
className="btn-recompile"
bsStyle="primary"
onClick={handleRecompileButtonClick}
onClick={() => startCompile()}
aria-label={compileButtonLabel}
disabled={compiling}
data-ol-loading={compiling}