From 9719b0439c304beca42322150393dadec9095960 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Thu, 9 Feb 2023 10:03:29 -0700 Subject: [PATCH] Tear down recompile button text split test (#11637) GitOrigin-RevId: 574ebeda9517cc54e04362395a90584703198d9f --- .../src/Features/Project/ProjectController.js | 25 ---------------- .../components/pdf-compile-button-inner.tsx | 30 ++----------------- 2 files changed, 3 insertions(+), 52 deletions(-) diff --git a/services/web/app/src/Features/Project/ProjectController.js b/services/web/app/src/Features/Project/ProjectController.js index 380f2782f9..4227e8bc44 100644 --- a/services/web/app/src/Features/Project/ProjectController.js +++ b/services/web/app/src/Features/Project/ProjectController.js @@ -48,10 +48,6 @@ const ProjectListController = require('./ProjectListController') const ProjectAuditLogHandler = require('./ProjectAuditLogHandler') const PublicAccessLevels = require('../Authorization/PublicAccessLevels') -// We want the recompile-button-text split test to only target users who have -// signed up recently. -const RECOMPILE_BUTTON_SPLIT_TEST_MIN_SIGNUP_DATE = new Date('2023-01-16') - /** * @typedef {import("./types").GetProjectsRequest} GetProjectsRequest * @typedef {import("./types").GetProjectsResponse} GetProjectsResponse @@ -1114,27 +1110,6 @@ const ProjectController = { } ) }, - recompileButtonTextAssignment: [ - 'user', - (results, cb) => { - if ( - results.user.signUpDate < - RECOMPILE_BUTTON_SPLIT_TEST_MIN_SIGNUP_DATE - ) { - return cb() - } - SplitTestHandler.getAssignment( - req, - res, - 'recompile-button-text', - {}, - () => { - // do not fail editor load if assignment fails - cb() - } - ) - }, - ], }, ( err, diff --git a/services/web/frontend/js/features/pdf-preview/components/pdf-compile-button-inner.tsx b/services/web/frontend/js/features/pdf-preview/components/pdf-compile-button-inner.tsx index 7cfb0e8c3f..cf4b47762e 100644 --- a/services/web/frontend/js/features/pdf-preview/components/pdf-compile-button-inner.tsx +++ b/services/web/frontend/js/features/pdf-preview/components/pdf-compile-button-inner.tsx @@ -1,11 +1,8 @@ import { Button } from 'react-bootstrap' -import PropTypes from 'prop-types' import Tooltip from '../../../shared/components/tooltip' import Icon from '../../../shared/components/icon' import { useTranslation } from 'react-i18next' -import { memo, useCallback } from 'react' -import { useSplitTestContext } from '../../../shared/context/split-test-context' -import * as eventTracking from '../../../infrastructure/event-tracking' +import { memo } from 'react' const modifierKey = /Mac/i.test(navigator.platform) ? 'Cmd' : 'Ctrl' @@ -20,28 +17,7 @@ function PdfCompileButtonInner({ }: PdfCompileButtonInnerProps) { const { t } = useTranslation() - const { splitTestVariants } = useSplitTestContext({ - splitTestVariants: PropTypes.object, - }) - const recompileButtonTextVariant = splitTestVariants['recompile-button-text'] - - let compileButtonLabel - if (compiling) { - compileButtonLabel = t('compiling') + '…' - } else if (splitTestVariants['recompile-button-text'] === 'recompile-pdf') { - compileButtonLabel = t('recompile') + ' PDF' - } else { - compileButtonLabel = t('recompile') - } - - const handleRecompileButtonClick = useCallback(() => { - if (recompileButtonTextVariant != null) { - // Only send the event when the user is targeted by the - // recompile-button-text split test - eventTracking.sendMB('recompile-pdf-clicked') - } - startCompile() - }, [recompileButtonTextVariant, startCompile]) + const compileButtonLabel = compiling ? `${t('compiling')}…` : t('recompile') return ( startCompile()} aria-label={compileButtonLabel} disabled={compiling} data-ol-loading={compiling}