github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

avoid possible exception if selection is undefined

Browse source 
defensive programming only
This commit is contained in:
Brian Gough 2017-06-15 14:32:00 +01:00
parent b9804823f3
commit 503822deb0
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee
View file

@ -441,11 +441,11 @@ define [
return true return true
_hasSelection = () -> _hasSelection = () ->
selection = window.getSelection() selection = window.getSelection?()
# check the selection type in preference to using # check the selection type in preference to using
# selection.toString() as the latter is "" when the # selection.toString() as the latter is "" when the
# selection is hidden (e.g. while viewing logs) # selection is hidden (e.g. while viewing logs)
return _isSelectionWithinPDF(selection) and selection.type is 'Range' return selection? and _isSelectionWithinPDF(selection) and selection.type is 'Range'
_isSelectionWithinPDF = (selection) -> _isSelectionWithinPDF = (selection) ->
if selection.rangeCount == 0 if selection.rangeCount == 0