github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-06 17:12:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2354 from overleaf/em-disallow-console

Browse source 
Disallow console.log in backend code

GitOrigin-RevId: 53ff1f2f2585d05a0f2380336227c50524aee08c
This commit is contained in:
Jessica Lawshe 2019-11-13 08:23:20 -06:00 • committed by sharelatex
parent 41d4fabc78
commit 41d77889da
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/.eslintrc
View file

@ -87,7 +87,7 @@
},
{
// Backend specific rules
"files": ["**/app/*/src/**/*.js"],
"files": ["**/app/src/**/*.js"],
"rules": {
// don't allow console.log in backend code
"no-console": "error"

1
services/web/app/src/Features/Analytics/AnalyticsManager.js
View file

@ -152,7 +152,6 @@ module.exports = {
}
makeAnalyticsRequest(userId, opts, function(err, response, body) {
if (err != null) {
console.log(response, opts)
logger.warn({ userId, err }, 'error getting last occurance of event')
callback(err)
} else {