From 41d77889daefff38f8bd4703862f715882d0a29c Mon Sep 17 00:00:00 2001 From: Jessica Lawshe Date: Wed, 13 Nov 2019 08:23:20 -0600 Subject: [PATCH] Merge pull request #2354 from overleaf/em-disallow-console Disallow console.log in backend code GitOrigin-RevId: 53ff1f2f2585d05a0f2380336227c50524aee08c --- services/web/.eslintrc | 2 +- services/web/app/src/Features/Analytics/AnalyticsManager.js | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/services/web/.eslintrc b/services/web/.eslintrc index 53896582cc..59afbe94e8 100644 --- a/services/web/.eslintrc +++ b/services/web/.eslintrc @@ -87,7 +87,7 @@ }, { // Backend specific rules - "files": ["**/app/*/src/**/*.js"], + "files": ["**/app/src/**/*.js"], "rules": { // don't allow console.log in backend code "no-console": "error" diff --git a/services/web/app/src/Features/Analytics/AnalyticsManager.js b/services/web/app/src/Features/Analytics/AnalyticsManager.js index 9e3393aebd..228e491b7b 100644 --- a/services/web/app/src/Features/Analytics/AnalyticsManager.js +++ b/services/web/app/src/Features/Analytics/AnalyticsManager.js @@ -152,7 +152,6 @@ module.exports = { } makeAnalyticsRequest(userId, opts, function(err, response, body) { if (err != null) { - console.log(response, opts) logger.warn({ userId, err }, 'error getting last occurance of event') callback(err) } else {