github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-08 07:52:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

simplify comments

Browse source
This commit is contained in:
Hayden Faulds 2018-02-22 10:16:29 +00:00
parent ea0dd9700b
commit 0f87ae1f74
3 changed files with 6 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/document-updater/app/coffee/DocumentManager.coffee
View file

@ -89,11 +89,8 @@ module.exports = DocumentManager =
callback null
else
DocumentManager.flushAndDeleteDoc project_id, doc_id, (error) ->
# Flush in the background since it requires a http request. We
# want to flush project history if the previous call only failed
# to delete the doc from Redis. There is no harm in flushing
# project history if the previous call failed to flush at all. So
# do this before checking errors.
# There is no harm in flushing project history if the previous
# call failed and sometimes it is required
HistoryManager.flushProjectChangesAsync project_id
return callback(error) if error?

7
services/document-updater/app/coffee/HttpController.coffee
View file

@ -107,11 +107,8 @@ module.exports = HttpController =
timer = new Metrics.Timer("http.deleteDoc")
DocumentManager.flushAndDeleteDocWithLock project_id, doc_id, (error) ->
timer.done()
# Flush in the background since it requires a http request. We
# want to flush project history if the previous call only failed
# to delete the doc from Redis. There is no harm in flushing
# project history if the previous call failed to flush at all. So
# do this before checking errors.
# There is no harm in flushing project history if the previous call
# failed and sometimes it is required
HistoryManager.flushProjectChangesAsync project_id
return next(error) if error?

6
services/document-updater/app/coffee/ProjectManager.coffee
View file

@ -59,10 +59,8 @@ module.exports = ProjectManager =
logger.log project_id: project_id, doc_ids: doc_ids, "deleting docs"
async.series jobs, () ->
# Flush in the background since it requires a htpt request. If we
# flushed and deleted only some docs successfully then we should still
# flush project history. If no docs succeeded then there is still no
# harm flushing project history. So do this before checking errors.
# There is no harm in flushing project history if the previous call
# failed and sometimes it is required
HistoryManager.flushProjectChangesAsync project_id
if errors.length > 0