diff --git a/services/document-updater/app/coffee/DocumentManager.coffee b/services/document-updater/app/coffee/DocumentManager.coffee index 6574c4c4b1..3d3f690b5c 100644 --- a/services/document-updater/app/coffee/DocumentManager.coffee +++ b/services/document-updater/app/coffee/DocumentManager.coffee @@ -89,11 +89,8 @@ module.exports = DocumentManager = callback null else DocumentManager.flushAndDeleteDoc project_id, doc_id, (error) -> - # Flush in the background since it requires a http request. We - # want to flush project history if the previous call only failed - # to delete the doc from Redis. There is no harm in flushing - # project history if the previous call failed to flush at all. So - # do this before checking errors. + # There is no harm in flushing project history if the previous + # call failed and sometimes it is required HistoryManager.flushProjectChangesAsync project_id return callback(error) if error? diff --git a/services/document-updater/app/coffee/HttpController.coffee b/services/document-updater/app/coffee/HttpController.coffee index 069cfc889e..650ee07ae2 100644 --- a/services/document-updater/app/coffee/HttpController.coffee +++ b/services/document-updater/app/coffee/HttpController.coffee @@ -107,11 +107,8 @@ module.exports = HttpController = timer = new Metrics.Timer("http.deleteDoc") DocumentManager.flushAndDeleteDocWithLock project_id, doc_id, (error) -> timer.done() - # Flush in the background since it requires a http request. We - # want to flush project history if the previous call only failed - # to delete the doc from Redis. There is no harm in flushing - # project history if the previous call failed to flush at all. So - # do this before checking errors. + # There is no harm in flushing project history if the previous call + # failed and sometimes it is required HistoryManager.flushProjectChangesAsync project_id return next(error) if error? diff --git a/services/document-updater/app/coffee/ProjectManager.coffee b/services/document-updater/app/coffee/ProjectManager.coffee index a82d88b4a6..64293e6985 100644 --- a/services/document-updater/app/coffee/ProjectManager.coffee +++ b/services/document-updater/app/coffee/ProjectManager.coffee @@ -59,10 +59,8 @@ module.exports = ProjectManager = logger.log project_id: project_id, doc_ids: doc_ids, "deleting docs" async.series jobs, () -> - # Flush in the background since it requires a htpt request. If we - # flushed and deleted only some docs successfully then we should still - # flush project history. If no docs succeeded then there is still no - # harm flushing project history. So do this before checking errors. + # There is no harm in flushing project history if the previous call + # failed and sometimes it is required HistoryManager.flushProjectChangesAsync project_id if errors.length > 0