github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-23 03:06:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #23900 from overleaf/em-read-only-permissions

Browse source 
Restrict viewer permissions for comments

GitOrigin-RevId: fb7189b8af9358603e29bbd33b0160dd862fe532
This commit is contained in:
Eric Mc Sween 2025-02-28 08:20:56 -05:00 • committed by Copybot
parent 1534731cdf
commit 0d9528932c
2 changed files with 17 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/frontend/js/features/review-panel-new/components/review-panel-message.tsx
View file

@ -41,7 +41,7 @@ export const ReviewPanelMessage: FC<{
const permissions = usePermissionsContext()
const isCommentAuthor = user.id === message.user.id
const canEdit = isCommentAuthor
const canEdit = isCommentAuthor && permissions.comment
const canResolve =
permissions.resolveAllComments ||
(permissions.resolveOwnComments && isCommentAuthor)

25
services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-thread.tsx
View file

@ -28,6 +28,7 @@ export const ReviewPanelResolvedThread: FC<{
const canDelete =
permissions.resolveAllComments ||
(permissions.resolveOwnComments && isCommentAuthor)
const canReopen = permissions.comment
const handleReopenThread = useCallback(async () => {
setProcessing(true)
@ -80,15 +81,21 @@ export const ReviewPanelResolvedThread: FC<{
/>
</div>
<div className="review-panel-resolved-comment-buttons">
<OLTooltip
id="reopen-thread"
overlayProps={{ placement: 'bottom' }}
description={t('reopen')}
>
<button type="button" className="btn" onClick={handleReopenThread}>
<MaterialIcon type="refresh" accessibilityLabel={t('reopen')} />
</button>
</OLTooltip>
{canReopen && (
<OLTooltip
id="reopen-thread"
overlayProps={{ placement: 'bottom' }}
description={t('reopen')}
>
<button
type="button"
className="btn"
onClick={handleReopenThread}
>
<MaterialIcon type="refresh" accessibilityLabel={t('reopen')} />
</button>
</OLTooltip>
)}
{canDelete && (
<OLTooltip
id="delete-thread"