From 0d9528932c84ac8e34b3ef6cb8f7225ab83f4c70 Mon Sep 17 00:00:00 2001 From: Eric Mc Sween <5454374+emcsween@users.noreply.github.com> Date: Fri, 28 Feb 2025 08:20:56 -0500 Subject: [PATCH] Merge pull request #23900 from overleaf/em-read-only-permissions Restrict viewer permissions for comments GitOrigin-RevId: fb7189b8af9358603e29bbd33b0160dd862fe532 --- .../components/review-panel-message.tsx | 2 +- .../review-panel-resolved-thread.tsx | 25 ++++++++++++------- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/services/web/frontend/js/features/review-panel-new/components/review-panel-message.tsx b/services/web/frontend/js/features/review-panel-new/components/review-panel-message.tsx index c01e895264..ae3a66f729 100644 --- a/services/web/frontend/js/features/review-panel-new/components/review-panel-message.tsx +++ b/services/web/frontend/js/features/review-panel-new/components/review-panel-message.tsx @@ -41,7 +41,7 @@ export const ReviewPanelMessage: FC<{ const permissions = usePermissionsContext() const isCommentAuthor = user.id === message.user.id - const canEdit = isCommentAuthor + const canEdit = isCommentAuthor && permissions.comment const canResolve = permissions.resolveAllComments || (permissions.resolveOwnComments && isCommentAuthor) diff --git a/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-thread.tsx b/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-thread.tsx index d949d79d61..53ac6d2192 100644 --- a/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-thread.tsx +++ b/services/web/frontend/js/features/review-panel-new/components/review-panel-resolved-thread.tsx @@ -28,6 +28,7 @@ export const ReviewPanelResolvedThread: FC<{ const canDelete = permissions.resolveAllComments || (permissions.resolveOwnComments && isCommentAuthor) + const canReopen = permissions.comment const handleReopenThread = useCallback(async () => { setProcessing(true) @@ -80,15 +81,21 @@ export const ReviewPanelResolvedThread: FC<{ />
- - - + {canReopen && ( + + + + )} {canDelete && (