github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #10193 from overleaf/ii-check-password-for-reuse-remove-samplerate

Browse source 
Remove sampleRate from metrics.inc when checking password

GitOrigin-RevId: 830383208039e239bb15a1172fea2ff9fb97373f
This commit is contained in:
ilkin-overleaf 2022-10-27 17:23:37 +03:00 committed by Copybot
parent c94043e2fe
commit 09c330caff
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/web/app/src/Features/Authentication/HaveIBeenPwned.js
View file

@ -96,7 +96,7 @@ function checkPasswordForReuseInBackground(password) {
isPasswordReused(password) isPasswordReused(password)
.then(isReused => { .then(isReused => {
Metrics.inc('password_re_use', 1, { Metrics.inc('password_re_use', {
status: isReused ? 're-used' : 'unique', status: isReused ? 're-used' : 'unique',
}) })
}) })
@ -108,7 +108,7 @@ function checkPasswordForReuseInBackground(password) {
err = new Error(err.message) err = new Error(err.message)
logger.err({ err }, 'cannot check password for re-use') logger.err({ err }, 'cannot check password for re-use')
Metrics.inc('password_re_use', 1, { status: 'failure' }) Metrics.inc('password_re_use', { status: 'failure' })
}) })
} }