From 09c330caff8e792dff7a529e16c2f930bee2267c Mon Sep 17 00:00:00 2001 From: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com> Date: Thu, 27 Oct 2022 17:23:37 +0300 Subject: [PATCH] Merge pull request #10193 from overleaf/ii-check-password-for-reuse-remove-samplerate Remove sampleRate from metrics.inc when checking password GitOrigin-RevId: 830383208039e239bb15a1172fea2ff9fb97373f --- .../web/app/src/Features/Authentication/HaveIBeenPwned.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/web/app/src/Features/Authentication/HaveIBeenPwned.js b/services/web/app/src/Features/Authentication/HaveIBeenPwned.js index eb9dbd902b..c459cd82a2 100644 --- a/services/web/app/src/Features/Authentication/HaveIBeenPwned.js +++ b/services/web/app/src/Features/Authentication/HaveIBeenPwned.js @@ -96,7 +96,7 @@ function checkPasswordForReuseInBackground(password) { isPasswordReused(password) .then(isReused => { - Metrics.inc('password_re_use', 1, { + Metrics.inc('password_re_use', { status: isReused ? 're-used' : 'unique', }) }) @@ -108,7 +108,7 @@ function checkPasswordForReuseInBackground(password) { err = new Error(err.message) logger.err({ err }, 'cannot check password for re-use') - Metrics.inc('password_re_use', 1, { status: 'failure' }) + Metrics.inc('password_re_use', { status: 'failure' }) }) }