github/hugo
1
0
Fork 0
mirror of https://github.com/gohugoio/hugo.git synced 2024-11-07 20:30:36 -05:00
Code Issues Projects Releases Packages Wiki Activity

hugolib: Use reflect.DeepEqual in tests

Browse source
This commit is contained in:
Cameron Moore 2016-12-26 19:42:43 -06:00 committed by Bjørn Erik Pedersen
parent 17f851780c
commit d1b89f5c7c
2 changed files with 4 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
hugolib/page_taxonomy_test.go
View file

@ -14,6 +14,7 @@
package hugolib package hugolib
import ( import (
"reflect"
"strings" "strings"
"testing" "testing"
) )
@ -73,7 +74,7 @@ func TestParseTaxonomies(t *testing.T) {
if params, ok := param.([]string); ok { if params, ok := param.([]string); ok {
expected := []string{"a", "b", "c"} expected := []string{"a", "b", "c"}
if !compareStringSlice(params, expected) { if !reflect.DeepEqual(params, expected) {
t.Errorf("Expected %s: got: %s", expected, params) t.Errorf("Expected %s: got: %s", expected, params)
} }
} else if params, ok := param.(string); ok { } else if params, ok := param.(string); ok {
@ -91,17 +92,3 @@ func TestParseTaxonomies(t *testing.T) {
} }
} }
} }
func compareStringSlice(a, b []string) bool {
if len(a) != len(b) {
return false
}
for i, v := range a {
if b[i] != v {
return false
}
}
return true
}

3
hugolib/taxonomy_test.go
View file

@ -15,6 +15,7 @@ package hugolib
import ( import (
"path/filepath" "path/filepath"
"reflect"
"testing" "testing"
"github.com/spf13/viper" "github.com/spf13/viper"
@ -43,7 +44,7 @@ func TestByCountOrderOfTaxonomies(t *testing.T) {
st = append(st, t.Name) st = append(st, t.Name)
} }
if !compareStringSlice(st, []string{"a", "b", "c"}) { if !reflect.DeepEqual(st, []string{"a", "b", "c"}) {
t.Fatalf("ordered taxonomies do not match [a, b, c]. Got: %s", st) t.Fatalf("ordered taxonomies do not match [a, b, c]. Got: %s", st)
} }
} }