From d1b89f5c7cb3d1031d74014b4b2150a434bf557e Mon Sep 17 00:00:00 2001 From: Cameron Moore Date: Mon, 26 Dec 2016 19:42:43 -0600 Subject: [PATCH] hugolib: Use reflect.DeepEqual in tests --- hugolib/page_taxonomy_test.go | 17 ++--------------- hugolib/taxonomy_test.go | 3 ++- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/hugolib/page_taxonomy_test.go b/hugolib/page_taxonomy_test.go index 30efd8c7f..acb6c28f1 100644 --- a/hugolib/page_taxonomy_test.go +++ b/hugolib/page_taxonomy_test.go @@ -14,6 +14,7 @@ package hugolib import ( + "reflect" "strings" "testing" ) @@ -73,7 +74,7 @@ func TestParseTaxonomies(t *testing.T) { if params, ok := param.([]string); ok { expected := []string{"a", "b", "c"} - if !compareStringSlice(params, expected) { + if !reflect.DeepEqual(params, expected) { t.Errorf("Expected %s: got: %s", expected, params) } } else if params, ok := param.(string); ok { @@ -91,17 +92,3 @@ func TestParseTaxonomies(t *testing.T) { } } } - -func compareStringSlice(a, b []string) bool { - if len(a) != len(b) { - return false - } - - for i, v := range a { - if b[i] != v { - return false - } - } - - return true -} diff --git a/hugolib/taxonomy_test.go b/hugolib/taxonomy_test.go index 4c6acf509..2d436c7dd 100644 --- a/hugolib/taxonomy_test.go +++ b/hugolib/taxonomy_test.go @@ -15,6 +15,7 @@ package hugolib import ( "path/filepath" + "reflect" "testing" "github.com/spf13/viper" @@ -43,7 +44,7 @@ func TestByCountOrderOfTaxonomies(t *testing.T) { st = append(st, t.Name) } - if !compareStringSlice(st, []string{"a", "b", "c"}) { + if !reflect.DeepEqual(st, []string{"a", "b", "c"}) { t.Fatalf("ordered taxonomies do not match [a, b, c]. Got: %s", st) } }