github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-12-25 18:31:35 +00:00
Code Issues Projects Releases Packages Wiki Activity
720 commits 39 branches 47 tags 112 MiB
Commit graph

720 commits

This branch
This branch
All branches
Author SHA1 Message Date
David Mehren
eaf1852fe5
Format with Prettier 2.3 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-15 21:13:44 +02:00
Renovate Bot
6658f0d5b4
Update dependency prettier to v2.3.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-15 19:06:39 +00:00
Renovate Bot
52d58f2d7e
Lock file maintenance 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-15 20:10:29 +00:00
Renovate Bot
b965d62dc6
Update linters 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-15 19:06:53 +00:00
Renovate Bot
d0d211e7ad
Update dependency rxjs to v7.0.1 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-13 21:31:38 +00:00
Renovate Bot
1b949fce99
Update dependency @types/node to v13.13.52 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-12 20:40:04 +00:00
Philip Molares
f739687b00
Refactor(note): Remove shortid from note 
This is a 1.x relict and isn't used anymore in 2.x. All 1.x shortids will be converted to aliases on migration of 1.x to 2.x.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-05-11 22:37:52 +02:00
Philip Molares
f5039791ed
Linting: Fixed wrong logger contexts 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-05-02 21:53:28 +02:00
Philip Molares
8cc9e12bc3
ESLint: Add custom rule 'correct-logger-context' 
This rule ensures, that the correct context is given in any logger statements.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-05-02 19:45:47 +02:00
David Mehren
375cb4eae9
AuthTokenEntity: Make validUntil not nullable 
As all tokens are valid for a maximum of 2 years, the
validUntil attribute is always populated.

This updates the database schema and the DTO to reflect that.

Fixes #1256

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 22:05:47 +02:00
David Mehren
6ddaa59e8c
Remove superfluous overrideProvider statements 
Fixes #1254

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 21:34:43 +02:00
Renovate Bot
6319b69aee
Update dependency @types/bcrypt to v5 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-09 19:42:04 +00:00
David Mehren
076c9c502d
Add error handling in seed.ts 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-02 18:35:38 +02:00
David Mehren
6471ba92ef
Fix nullable property types in Note DTOs 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-02 18:33:07 +02:00
David Mehren
73997d4693
MediaUploadDto: Make noteId optional 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:59:40 +02:00
David Mehren
2e5d40432e
E2E Tests: Fix ESLint errors 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 22:06:45 +02:00
David Mehren
d4495a0a62
GroupsService: Remove test obsoleted by strict mode 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 21:53:05 +02:00
David Mehren
8388edcd53
UsersService: Remove test obsoleted by strict mode 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 21:52:20 +02:00
David Mehren
0944f07834
Ensure optional properties of AuthTokenDto are initialized 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 21:14:09 +02:00
David Mehren
098ebd0445
Disable strict mode for tests 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 19:09:15 +02:00
David Mehren
246d053b68
Add explicit type annotations to nullable columns 
TypeORM can't correctly infer the data type on properties with a `| null` type.
This commit adds explicit type annotations.

See also https://github.com/typeorm/typeorm/issues/2567#issuecomment-408599335

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 19:08:59 +02:00
David Mehren
80d8ce901b
NotesService.toNoteMetadataDto: Handle undefined updateUser 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 18:30:48 +02:00
David Mehren
772263317d
NotesService: Fix type errors 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 18:30:17 +02:00
David Mehren
e217b30d26
Consistently type properties as optional 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 18:29:12 +02:00
David Mehren
bc08493f89
GroupsService: Remove null from toGroupDto return type 
toGroupDto won't return null, as TS's strict mode
prevents group from being nullish

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 18:28:32 +02:00
David Mehren
b962e8390a
NotesController: Double-check that req.user is defined 
TokenAuthGuard ensures that req.user is always
defined, but thanks to strict mode we have to check again.

In the future, we may add a custom Request type and
a custom param decorator to centralize the check.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 18:12:20 +02:00
David Mehren
0a8dd454ab
NoteEntity: Allow anonymous notes 
Notes created by anonymous users don't have an owner.
This commit updates the entity accordingly.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 18:09:22 +02:00
David Mehren
bd56d17663
MediaUploadDto: Make noteId optional 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:59:40 +02:00
David Mehren
3b0bbe8b00
MediaService: Handle unexpected backend type 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:59:18 +02:00
David Mehren
22702b3390
Correctly type nullable columns 
TypeORM columns with `nullable: true` can be `null` at runtime.
This commit ensures that the types of the corresponding properties reflect that.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:54:57 +02:00
David Mehren
d63f581a42
MediaController: Double-check that req.user is defined 
TokenAuthGuard ensures that req.user is always
defined, but thanks to strict mode we have to check again.

In the future, we may add a custom Request type and
a custom param decorator to centralize the check.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:44:27 +02:00
David Mehren
90038cf116
MeController: Double-check that req.user is defined 
TokenAuthGuard ensures that req.user is always
defined, but thanks to strict mode we have to check again.

In the future, we may add a custom Request type and
a custom param decorator to centralize the check.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:43:16 +02:00
David Mehren
87eb099d34
UsersService: Remove null from toUserDto return type 
toUserDto won't return null, as TS's strict mode
prevents user from being nullish

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:40:13 +02:00
David Mehren
a453344205
MarkdownBody: Handle error in getOwnPropertyDescriptor 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:27:15 +02:00
David Mehren
4959be739a
Handle config initialisation error on app bootstrap 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:22:01 +02:00
David Mehren
8357f3072c
HistoryService: Throw NotInDBError on empty DB result 
This adds error handling to getEntryByNote, so it throws a
NotInDBError instead of (illegally, according to the type) returning
null.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:16:30 +02:00
David Mehren
1a72e3c727
FrontendConfig DTOs: Make properties consistently optional 
Some properties already have a IsOptional decorator,
this makes the properties themselves also optional

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:13:54 +02:00
David Mehren
56ce66bc8b
ConsoleLoggerService: Fix type of context properties 
Nullish values of functionContext and classContext are handled correctly,
so the type can be adjusted

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:10:46 +02:00
David Mehren
52bb44a561
AuthService: Fix type of toAuthTokenWithSecretDto 
toAuthTokenDto does not return nor accept a nullish value anymore,
so the types can be adjusted.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:07:58 +02:00
David Mehren
327f36af94
AuthService.randomString: Throw Error instead of returning null 
A string with a negative length is invalid, so we should throw here
instead of complicating the type with a possible null return value.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 16:06:59 +02:00
David Mehren
5ee9b2a7e8
AuthTokenDto: Make properties consistently optional 
validUntil and lastUsed already have a IsOptional decorator,
this makes the properties themselves also optional

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 15:55:11 +02:00
David Mehren
ef8b8d985e
AuthService: Throw NotInDBError on empty DB result 
This adds error handling to various functions, so they throw a
NotInDBError instead of a TypeError

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 18:27:03 +02:00
David Mehren
52f6310e91
Safely parse numbers from environment vars 
This adds the function parseOptionalInt to help parse numbers
from environment variables

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 15:34:59 +02:00
David Mehren
36e721d4a9
Config Utils: Fix type of toArrayConfig 
configValue is checked for a nullish value,
the type should reflect that.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 15:26:15 +02:00
David Mehren
dcc09747d2
AuthService: Remove null from toAuthTokenDto return type 
toAuthTokenDto won't return null, as TS's strict mode
prevents authToken from being nullish

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 15:07:50 +02:00
David Mehren
d87980ae6d
RevisionsService: Throw NotInDBError on empty DB result 
This adds error handling to various getters, so they throw a
NotInDBError instead of (illegally, according to the type) returning
null.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 15:03:44 +02:00
David Mehren
6604a6e499
Enable TypeScript strict mode 
This enables strict mode, but sets strictPropertyInitialization to false,
as "the class-validator DTO pattern described in the documentation is
not compatible with strict property initialization" according to
https://github.com/nestjs/typescript-starter/pull/192

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-04-29 15:01:00 +02:00
Renovate Bot
b2f0bfa0bf
Update dependency eslint to v7.26.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-09 12:41:30 +00:00
Renovate Bot
618ab0dc9b
Update dependency ts-loader to v9.1.2 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-09 12:41:15 +00:00
Renovate Bot
0e698f6aad
Update dependency pymdown-extensions to v8.2 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-08 19:43:43 +00:00