Okay I'm just done. Firefox in our current CI is just the WORST. It is slower than chrome and crashes A LOT! Like really! The e2e workflows of some PRs have to run 4 or 5 times because firefox decides to just lose the connection.
This may also be caused by the performance of GHA, but right now it's easier to (temporally) remove firefox than switching to a whole new CI.
Just to be clear: I know that this step isn't optimal. I know that a huge part of our community uses firefox. But right now the flakiness of the firefox CI runs drives me crazy!
At the moment we need the e2e tests just for our development to make sure that we don't accidentally break something.
We can re-add firefox again when it's stable to use. Or when we have shifted enough of the e2e tests to jest. It would be nice to test other browsers (like safari or edge) as well.
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Use different environment per PR
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
* Fix main deployment by using CI-aware build script
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
* Use PR title and number in netlify deployment list
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
* Use exec
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
* Change cypress settings in CI job
* Catch error from highlight js chunk loading in auto completion
* Refactor code
* Show notification if highlightjs loading failed
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Use document base uri for react router
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Rename getAndSetUser to fetchAndSetUser
Getter should be reserved for simple get functions.
Everything that does a bit more logic should use a more meaningful verb.
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Rename getFrontPageContent to fetchFrontPageContent
Getter should be reserved for simple get functions.
Everything that does a bit more logic should use a more meaningful verb.
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Reformat code
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Use PUBLIC_URL env var in index.html
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Introduce new environment variables
For better testing (especially if you have multiple endpoints) this commit introduces
REACT_APP_BACKEND_BASE_URL, REACT_APP_FRONTEND_ASSETS_URL and REACT_APP_CUSTOMIZE_ASSETS_URL
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Remove redundant license information
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Remove redundant license information
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Fix rebase issues
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Remove unused file
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Correct parameter
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Fix run tasks
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Force use of bash
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Fix link to cypress picture
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* revert change
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* fix url
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Remove license info
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Revert rebase issues
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Add missing banner code
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Fix test url
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Useless change to trigger github
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
* Don't set backend base url because this break the mock mode detection
Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
Co-authored-by: Philip Molares <philip.molares@udo.edu>
* Change copyright year from 2020 to 2021
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
* Change copyright year in jetbrains copyright template
Signed-off-by: Tilman Vatteroth <tilman.vatteroth@tu-dortmund.de>
When the pipeline is cancelled by a preceding failing job, the screenshot upload job won't run. This change adds the flag that it will run even when preceding jobs failed.