deployments: Fix main branch deployment and overrides (#1801)

* Use different environment per PR

Signed-off-by: Erik Michelson <github@erik.michelson.eu>

* Fix main deployment by using CI-aware build script

Signed-off-by: Erik Michelson <github@erik.michelson.eu>

* Use PR title and number in netlify deployment list

Signed-off-by: Erik Michelson <github@erik.michelson.eu>

* Use exec

Signed-off-by: Erik Michelson <github@erik.michelson.eu>

.github/workflows/deploy.yml

@@ -49,14 +49,14 @@ jobs:
         with:
           step: start
           token: ${{ secrets.GITHUB_TOKEN }}
-          env: Preview
+          env: "PR #${{ github.event.number }}"
           no_override: false
           ref: ${{ github.head_ref }}
 
       - name: Run netlify CLI deployment
         env:
           NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
-        run: bash netlify/deploy.sh "${{ github.event.number }}" "${{ github.head_ref }}"
+        run: bash netlify/deploy.sh "${{ github.event.number }}" "${{ github.head_ref }}" "${{ github.event.pull_request.title }}"
         id: netlify-result
 
       - name: Mark GitHub deployment as finished

netlify.toml

@@ -1,6 +1,6 @@
 [build]
 publish = ".next"
-command = "echo 'Assuming already built and cleaned Next.js app at ./.next/'"
+command = "bash netlify/build.sh"
 
 [[plugins]]
 package = "@netlify/plugin-nextjs"

netlify/build.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+# SPDX-FileCopyrightText: 2021 The HedgeDoc developers (see AUTHORS file)
+#
+# SPDX-License-Identifier: AGPL-3.0-only
+
+if [[ -z "${GITHUB_ACTIONS}" ]]; then
+    echo "Running in netlify CI or manual"
+    exec yarn build:netlify
+else
+    echo "Running in GitHub actions CI"
+    echo "Build is not necessary as already done prior to this step."
+fi

netlify/deploy.sh

@@ -6,7 +6,7 @@
 
 deployid="$1-$2"
 
-json=$(yarn netlify deploy --build --context deploy-preview --alias "${deployid}" --json)
+json=$(yarn netlify deploy --build --context deploy-preview --alias "${deployid}" --json --message "[#$1] $3")
 
 url=$(echo "${json}" | jq -r .deploy_url)
 logs=$(echo "${json}" | jq -r .logs)