This repository has been archived on 2024-06-08. You can view files and clone it, but cannot push or open issues or pull requests.
tachiyomi/app
arkon 766f9e37b5
#3520 Searchable Settings (#3683)
* Adding class stubs for settings search, UI elements.

* -  implement searchable settings
- `SettingsController.setupPreferenceScreen` must return a PreferenceScreen

* Remove unneeded SettingsControllerFactory.

* Set query hint, clean up code smell.

* Add search button to MoreController, stop infinite recursion.

* - initialize SearchResultCollection once in Activity.onCreate

* - implement prefernce highlighting after settings search

* - Ensure all Preferences have a key set or else the highlighting effect will have no effect on it.
- remove ExtensionFilterController and SourceFilterController from settingControllersList in SettingsSearchHelper, since those are related to Extensions and not Settings

* Limiting search to settings menu only, localized breadcrumb string, and code cleanup after code review.

* - moved call to SettingsSearchHelper.initPreferenceSearchResultCollection() into SettingsSearchController

* Code review cleanup and refactoring.

* Inlined non-reused key strings.

* Adding more UI polish, add comments for future enhancements.

* - retain search query when navigating *away* from SettingsSearchController
- keep `searchItem` in `expandActionView` state until user goes back (fixes the empty view in `SettingsSearchSearchController` issue)

Co-authored-by: mpm11011 <markuscicero5@gmail.com>
Co-authored-by: lmj0011 <9396189+lmj0011@users.noreply.github.com>
2020-09-22 22:23:38 -04:00
..
src #3520 Searchable Settings (#3683) 2020-09-22 22:23:38 -04:00
.gitignore Move google-services.json 2020-04-29 17:56:05 -04:00
build.gradle #3520 Searchable Settings (#3683) 2020-09-22 22:23:38 -04:00
proguard-rules.pro Remove OkHttp Proguard rules 2020-08-22 10:44:52 -04:00
shortcuts.xml Merge sources and extensions into one view 2020-04-27 19:16:46 -04:00