From a3336368e5b1f35ee5dc0859ce272311bb88369d Mon Sep 17 00:00:00 2001
From: arkon <eugcheung94@gmail.com>
Date: Mon, 16 Mar 2020 17:53:17 -0400
Subject: [PATCH] Use solid/outline check icon for mark as read/unread (closes
#2719)
---
.../{ic_done_all_24dp.xml => ic_done_24dp.xml} | 2 +-
app/src/main/res/drawable/ic_done_all_grey_24dp.xml | 10 ----------
app/src/main/res/drawable/ic_done_outline_24dp.xml | 9 +++++++++
app/src/main/res/menu/chapter_selection.xml | 5 +++--
app/src/main/res/menu/updates_chapter_selection.xml | 5 +++--
5 files changed, 16 insertions(+), 15 deletions(-)
rename app/src/main/res/drawable/{ic_done_all_24dp.xml => ic_done_24dp.xml} (55%)
delete mode 100644 app/src/main/res/drawable/ic_done_all_grey_24dp.xml
create mode 100644 app/src/main/res/drawable/ic_done_outline_24dp.xml
diff --git a/app/src/main/res/drawable/ic_done_all_24dp.xml b/app/src/main/res/drawable/ic_done_24dp.xml
similarity index 55%
rename from app/src/main/res/drawable/ic_done_all_24dp.xml
rename to app/src/main/res/drawable/ic_done_24dp.xml
index 4c0a4544f5..ec56a77118 100644
--- a/app/src/main/res/drawable/ic_done_all_24dp.xml
+++ b/app/src/main/res/drawable/ic_done_24dp.xml
@@ -5,5 +5,5 @@
android:viewportHeight="24">
<path
android:fillColor="#FF000000"
- android:pathData="M18,7l-1.41,-1.41 -6.34,6.34 1.41,1.41L18,7zM22.24,5.59L11.66,16.17 7.48,12l-1.41,1.41L11.66,19l12,-12 -1.42,-1.41zM0.41,13.41L6,19l1.41,-1.41L1.83,12 0.41,13.41z"/>
+ android:pathData="M9,16.2L4.8,12l-1.4,1.4L9,19 21,7l-1.4,-1.4L9,16.2z"/>
</vector>
diff --git a/app/src/main/res/drawable/ic_done_all_grey_24dp.xml b/app/src/main/res/drawable/ic_done_all_grey_24dp.xml
deleted file mode 100644
index 9cbc7fdf95..0000000000
--- a/app/src/main/res/drawable/ic_done_all_grey_24dp.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
- android:width="24dp"
- android:height="24dp"
- android:alpha=".38"
- android:viewportHeight="24.0"
- android:viewportWidth="24.0">
- <path
- android:fillColor="#FFFFFFFF"
- android:pathData="M18,7l-1.41,-1.41 -6.34,6.34 1.41,1.41L18,7zM22.24,5.59L11.66,16.17 7.48,12l-1.41,1.41L11.66,19l12,-12 -1.42,-1.41zM0.41,13.41L6,19l1.41,-1.41L1.83,12 0.41,13.41z"/>
-</vector>
diff --git a/app/src/main/res/drawable/ic_done_outline_24dp.xml b/app/src/main/res/drawable/ic_done_outline_24dp.xml
new file mode 100644
index 0000000000..604980132a
--- /dev/null
+++ b/app/src/main/res/drawable/ic_done_outline_24dp.xml
@@ -0,0 +1,9 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+ android:width="24dp"
+ android:height="24dp"
+ android:viewportWidth="24"
+ android:viewportHeight="24">
+ <path
+ android:fillColor="#FF000000"
+ android:pathData="M19.77,5.03l1.4,1.4L8.43,19.17l-5.6,-5.6 1.4,-1.4 4.2,4.2L19.77,5.03m0,-2.83L8.43,13.54l-4.2,-4.2L0,13.57 8.43,22 24,6.43 19.77,2.2z"/>
+</vector>
diff --git a/app/src/main/res/menu/chapter_selection.xml b/app/src/main/res/menu/chapter_selection.xml
index 2c2c993c7d..eeda1d04df 100644
--- a/app/src/main/res/menu/chapter_selection.xml
+++ b/app/src/main/res/menu/chapter_selection.xml
@@ -32,15 +32,16 @@
<item
android:id="@+id/action_mark_as_read"
- android:icon="@drawable/ic_done_all_24dp"
+ android:icon="@drawable/ic_done_24dp"
android:title="@string/action_mark_as_read"
app:iconTint="?attr/colorOnPrimary"
app:showAsAction="always" />
<item
android:id="@+id/action_mark_as_unread"
- android:icon="@drawable/ic_done_all_grey_24dp"
+ android:icon="@drawable/ic_done_outline_24dp"
android:title="@string/action_mark_as_unread"
+ app:iconTint="?attr/colorOnPrimary"
app:showAsAction="always" />
<item
diff --git a/app/src/main/res/menu/updates_chapter_selection.xml b/app/src/main/res/menu/updates_chapter_selection.xml
index 317dff424b..013e5c435c 100644
--- a/app/src/main/res/menu/updates_chapter_selection.xml
+++ b/app/src/main/res/menu/updates_chapter_selection.xml
@@ -18,15 +18,16 @@
<item
android:id="@+id/action_mark_as_read"
- android:icon="@drawable/ic_done_all_24dp"
+ android:icon="@drawable/ic_done_24dp"
android:title="@string/action_mark_as_read"
app:iconTint="?attr/colorOnPrimary"
app:showAsAction="always" />
<item
android:id="@+id/action_mark_as_unread"
- android:icon="@drawable/ic_done_all_grey_24dp"
+ android:icon="@drawable/ic_done_outline_24dp"
android:title="@string/action_mark_as_unread"
+ app:iconTint="?attr/colorOnPrimary"
app:showAsAction="always" />
</menu>