github/tachiyomi
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Crash log no long shows cancelled jobs exceptions for updates

Browse source
This commit is contained in:
Jay 2020-05-11 16:31:47 -04:00
parent f0b0d3d197
commit 1d3763a34d
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateService.kt
View file

@ -40,6 +40,7 @@ import eu.kanade.tachiyomi.util.lang.chop
import eu.kanade.tachiyomi.util.system.executeOnIO
import eu.kanade.tachiyomi.util.system.notification
import eu.kanade.tachiyomi.util.system.notificationManager
import kotlinx.coroutines.CancellationException
import kotlinx.coroutines.CoroutineExceptionHandler
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.GlobalScope
@ -238,10 +239,14 @@ class LibraryUpdateService(
Timber.e(exception)
}
GlobalScope.launch(handler) {
val hasDLs = requestSemaphore.withPermit {
updateMangaInSource(
it.key, downloadNew, categoriesToDownload
)
val hasDLs = try {
requestSemaphore.withPermit {
updateMangaInSource(
it.key, downloadNew, categoriesToDownload
)
}
} catch (e: Exception) {
false
}
hasDownloads = hasDownloads || hasDLs
jobCount.andDecrement
@ -447,7 +452,7 @@ class LibraryUpdateService(
try {
var hasDownloads = false
if (job?.isCancelled == true) {
throw java.lang.Exception("Job was cancelled")
return false
}
showProgressNotification(manga, progress, mangaToUpdate.size)
val source = sourceManager.get(manga.source) as? HttpSource ?: return false
@ -478,7 +483,9 @@ class LibraryUpdateService(
}
return hasDownloads
} catch (e: Exception) {
Timber.e("Failed updating: ${manga.title}: $e")
if (e !is CancellationException) {
Timber.e("Failed updating: ${manga.title}: $e")
}
return false
}
}