From 806b9384a15dd1c36c2b64c0ee4dfc605fa8db56 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Tue, 20 Mar 2018 21:40:02 +0100 Subject: [PATCH] Update PULL_REQUEST_TEMPLATE.md revisited --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 02d796ae..1601979a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,11 +1,11 @@ Make sure you have checked all steps below. ### Prerequisite -* [ ] Please consider implementing the feature as hook script or plugin at first - * pyenv has some powerful support for plugins and hook scripts. Please refer [Authoring plugins](https://github.com/pyenv/pyenv/wiki/Authoring-plugins) for details and try to implement as some plugin if possible. -* [ ] Please consider contribute similar patch to [rbenv](https://github.com/rbenv/rbenv) since we have borrowed most of lines with the project - * We are occasionally importing the changes from the rbenv. In general, you can expect some changes made in rbenv will be imported to pyenv too, eventually. - * Generaly speaking, we sometime don't prefer to make some change in the core feature to keep compatibility with rbenv. +* [ ] Please consider implementing the feature as a hook script or plugin as a first step. + * pyenv has some powerful support for plugins and hook scripts. Please refer to [Authoring plugins](https://github.com/pyenv/pyenv/wiki/Authoring-plugins) for details and try to implement it as a plugin if possible. +* [ ] Please consider contributing the patch upstream to [rbenv](https://github.com/rbenv/rbenv), since we have borrowed most of the code from this project. + * We are occasionally importing the changes from rbenv. In general, you can expect some changes made in rbenv will be imported to pyenv too, eventually. + * Generaly speaking, we sometimes don't prefer to make some change in the core to keep compatibility with rbenv. * [ ] My PR addresses the following pyenv issue (if any) - https://github.com/pyenv/pyenv/issues/XXXX