github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-10-24 21:12:38 -04:00
Code Issues Projects Releases Packages Wiki Activity
overleaf/services/web/frontend/js
History
David a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891) 
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
..
features Implement a floating "Add comment" button for the redesigned review panel (#19891) 2024-09-17 08:04:58 +00:00
ide feat: making highlighting of errors more specific (#19963) 2024-09-04 08:04:48 +00:00
infrastructure Merge pull request #19842 from overleaf/jpa-ro-mirror-on-client 2024-08-22 08:05:13 +00:00
main Merge pull request #18898 from overleaf/jpa-no-window 2024-06-19 08:04:21 +00:00
pages Merge pull request #20071 from overleaf/mf-plans-page-click-currency 2024-09-05 08:06:26 +00:00
shared Implement a floating "Add comment" button for the redesigned review panel (#19891) 2024-09-17 08:04:58 +00:00
utils Merge pull request #20140 from overleaf/rd-footer-react 2024-08-30 08:04:29 +00:00
vendor/libs Merge pull request #19455 from overleaf/jpa-metrics 2024-07-19 08:04:34 +00:00
bootstrap-3.ts Upgrade jQuery to v3 (#18984) 2024-08-02 08:04:48 +00:00
bootstrap-5.ts Merge pull request #18276 from overleaf/td-bs5-load-js 2024-05-16 08:04:59 +00:00
dev-toolbar.js Merge pull request #15808 from overleaf/ab-split-test-dev-toolbar 2023-11-24 09:04:40 +00:00
i18n.js Merge pull request #18898 from overleaf/jpa-no-window 2024-06-19 08:04:21 +00:00
ide-detached.js
marketing.js Merge pull request #18996 from overleaf/td-bs5-nav-react 2024-08-22 08:05:03 +00:00
tracing.js